[INFO] cloning repository https://github.com/SamirTalwar/boo [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/SamirTalwar/boo" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSamirTalwar%2Fboo", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSamirTalwar%2Fboo'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ed5fba098ab85161f8df64aa9135bb4a5bdf3558 [INFO] checking SamirTalwar/boo/ed5fba098ab85161f8df64aa9135bb4a5bdf3558 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSamirTalwar%2Fboo" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/SamirTalwar/boo on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-4-tc2/source/rust-toolchain.toml [INFO] started tweaking git repo https://github.com/SamirTalwar/boo [INFO] finished tweaking git repo https://github.com/SamirTalwar/boo [INFO] tweaked toml for git repo https://github.com/SamirTalwar/boo written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/SamirTalwar/boo already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e3266208ff0323329b626c4ee46b24d1c15cdc7059741dcd933af3c00ca270a4 [INFO] running `Command { std: "docker" "start" "-a" "e3266208ff0323329b626c4ee46b24d1c15cdc7059741dcd933af3c00ca270a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e3266208ff0323329b626c4ee46b24d1c15cdc7059741dcd933af3c00ca270a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e3266208ff0323329b626c4ee46b24d1c15cdc7059741dcd933af3c00ca270a4", kill_on_drop: false }` [INFO] [stdout] e3266208ff0323329b626c4ee46b24d1c15cdc7059741dcd933af3c00ca270a4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7d53a7dfaaac43569476d2d7abfaf2523376a8806d9dc27aac1c18f1aa653080 [INFO] running `Command { std: "docker" "start" "-a" "7d53a7dfaaac43569476d2d7abfaf2523376a8806d9dc27aac1c18f1aa653080", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.196 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Compiling thiserror v1.0.56 [INFO] [stderr] Checking gimli v0.28.1 [INFO] [stderr] Checking unarray v0.1.4 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Compiling serde_derive v1.0.196 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Compiling num-bigint v0.4.4 [INFO] [stderr] Checking is_ci v1.1.1 [INFO] [stderr] Checking textwrap v0.15.2 [INFO] [stderr] Compiling miette-derive v5.10.0 [INFO] [stderr] Checking terminal_size v0.1.17 [INFO] [stderr] Checking owo-colors v3.5.0 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Compiling im v15.1.0 [INFO] [stderr] Checking bitmaps v2.1.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling regex-syntax v0.6.29 [INFO] [stderr] Compiling beef v0.5.2 [INFO] [stderr] Compiling peg-runtime v0.8.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand_xorshift v0.3.0 [INFO] [stderr] Checking rand_xoshiro v0.6.0 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking object v0.32.2 [INFO] [stderr] Compiling peg-macros v0.8.2 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking anstyle v1.0.5 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking anstream v0.6.11 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Compiling serde_json v1.0.113 [INFO] [stderr] Checking half v2.3.1 [INFO] [stderr] Checking sized-chunks v0.6.5 [INFO] [stderr] Checking clap_builder v4.4.18 [INFO] [stderr] Checking plotters-backend v0.3.5 [INFO] [stderr] Compiling anyhow v1.0.79 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking plotters-svg v0.3.5 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stderr] Compiling vte_generate_state_changes v0.1.1 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking similar v2.4.0 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking plotters v0.3.5 [INFO] [stderr] Checking regex-automata v0.4.5 [INFO] [stderr] Checking rayon v1.8.1 [INFO] [stderr] Checking vte v0.11.1 [INFO] [stderr] Checking iana-time-zone v0.1.59 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Compiling backtrace v0.3.69 [INFO] [stderr] Compiling logos-codegen v0.13.0 [INFO] [stderr] Checking peg v0.8.2 [INFO] [stderr] Compiling strum_macros v0.25.3 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking insta v1.34.0 [INFO] [stderr] Checking nu-ansi-term v0.49.0 [INFO] [stderr] Checking clap v4.4.18 [INFO] [stderr] Checking unicode-segmentation v1.10.1 [INFO] [stderr] Checking strip-ansi-escapes v0.2.0 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Compiling logos-derive v0.13.0 [INFO] [stderr] Checking logos v0.13.0 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Checking backtrace-ext v0.2.1 [INFO] [stderr] Compiling proptest-derive v0.4.0 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking chrono v0.4.33 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking is-terminal v0.4.10 [INFO] [stderr] Checking tempfile v3.9.0 [INFO] [stderr] Checking fd-lock v3.0.13 [INFO] [stderr] Checking supports-unicode v2.1.0 [INFO] [stderr] Checking supports-color v2.1.0 [INFO] [stderr] Checking supports-hyperlinks v2.1.0 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Checking reedline v0.28.0 [INFO] [stderr] Checking miette v5.10.0 [INFO] [stderr] Checking rusty-fork v0.3.0 [INFO] [stderr] Checking proptest v1.4.0 [INFO] [stderr] Checking boo-core v0.1.0 (/opt/rustwide/workdir/crates/core) [INFO] [stderr] Checking boo-test-helpers v0.1.0 (/opt/rustwide/workdir/crates/test-helpers) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/test-helpers/src/proptest.rs:9:11 [INFO] [stdout] | [INFO] [stdout] 7 | pub fn check(strategy: &S, test: impl Fn(S::Value) -> TestCaseResult) { [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 8 | let mut runner = TestRunner::default(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | match runner.run(strategy, test) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `boo-test-helpers` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/test-helpers/src/proptest.rs:9:11 [INFO] [stdout] | [INFO] [stdout] 7 | pub fn check(strategy: &S, test: impl Fn(S::Value) -> TestCaseResult) { [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 8 | let mut runner = TestRunner::default(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | match runner.run(strategy, test) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `boo-test-helpers` (lib test) due to 2 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/core/src/builtins.rs:135:9 [INFO] [stdout] | [INFO] [stdout] 127 | fn builtin_infix_math(name: &str, operate: Op) -> Expr [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 131 | let parameter_left = Identifier::name_from_str("left").unwrap(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | let parameter_right = Identifier::name_from_str("right").unwrap(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | / Expression::Function(Function { [INFO] [stdout] 136 | | parameter: parameter_left.clone(), [INFO] [stdout] 137 | | body: Expr::new( [INFO] [stdout] 138 | | None, [INFO] [stdout] ... | [INFO] [stdout] 157 | | ), [INFO] [stdout] 158 | | }), [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/core/src/builtins.rs:167:9 [INFO] [stdout] | [INFO] [stdout] 164 | let parameter = Identifier::name_from_str("param").unwrap(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 167 | / Expression::Function(Function { [INFO] [stdout] 168 | | parameter: parameter.clone(), [INFO] [stdout] 169 | | body: Expr::new( [INFO] [stdout] 170 | | None, [INFO] [stdout] ... | [INFO] [stdout] 179 | | ), [INFO] [stdout] 180 | | }), [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/core/src/evaluation.rs:75:13 [INFO] [stdout] | [INFO] [stdout] 65 | fn to_core(&self, expr: Self::Expr) -> Expr [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | value: expression, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | / match expression.as_ref() { [INFO] [stdout] 76 | | ast::Expression::Primitive(primitive) => { [INFO] [stdout] 77 | | ast::Expression::Primitive(primitive.clone()) [INFO] [stdout] 78 | | } [INFO] [stdout] ... | [INFO] [stdout] 119 | | } [INFO] [stdout] 120 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/core/src/evaluation.rs:109:41 [INFO] [stdout] | [INFO] [stdout] 109 | ... result: self.to_core(result.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/core/src/expr.rs:13:14 [INFO] [stdout] | [INFO] [stdout] 12 | pub fn new(span: Option, expression: Expression) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | Self(Spanned { [INFO] [stdout] | ______________^ [INFO] [stdout] 14 | | span, [INFO] [stdout] 15 | | value: expression.into(), [INFO] [stdout] 16 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/core/src/identifier.rs:140:23 [INFO] [stdout] | [INFO] [stdout] 140 | .prop_map(|x| Identifier::name_from_string(x).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/core/src/identifier.rs:157:23 [INFO] [stdout] | [INFO] [stdout] 157 | .prop_map(|x| Identifier::name_from_string(x).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/core/src/types.rs:24:14 [INFO] [stdout] | [INFO] [stdout] 23 | fn from(value: Type) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | Self(Arc::new(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `boo-core` (lib) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "7d53a7dfaaac43569476d2d7abfaf2523376a8806d9dc27aac1c18f1aa653080", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7d53a7dfaaac43569476d2d7abfaf2523376a8806d9dc27aac1c18f1aa653080", kill_on_drop: false }` [INFO] [stdout] 7d53a7dfaaac43569476d2d7abfaf2523376a8806d9dc27aac1c18f1aa653080