[INFO] cloning repository https://github.com/SalWolffs/spl-compile [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/SalWolffs/spl-compile" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSalWolffs%2Fspl-compile", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSalWolffs%2Fspl-compile'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] cfff496d0b532fb7c005e8212822d6b8b28cce7a [INFO] checking SalWolffs/spl-compile/cfff496d0b532fb7c005e8212822d6b8b28cce7a against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSalWolffs%2Fspl-compile" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/SalWolffs/spl-compile on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/SalWolffs/spl-compile [INFO] finished tweaking git repo https://github.com/SalWolffs/spl-compile [INFO] tweaked toml for git repo https://github.com/SalWolffs/spl-compile written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/SalWolffs/spl-compile already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 60c59cb2616bcb0c113844b1f128d3fd200b264626724cb4fecc99f456e55ebd [INFO] running `Command { std: "docker" "start" "-a" "60c59cb2616bcb0c113844b1f128d3fd200b264626724cb4fecc99f456e55ebd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "60c59cb2616bcb0c113844b1f128d3fd200b264626724cb4fecc99f456e55ebd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "60c59cb2616bcb0c113844b1f128d3fd200b264626724cb4fecc99f456e55ebd", kill_on_drop: false }` [INFO] [stdout] 60c59cb2616bcb0c113844b1f128d3fd200b264626724cb4fecc99f456e55ebd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 865f4c687620bf51c479c1cb2de67ab89bdf7f603db0af0b71f5a4f4c32099ac [INFO] running `Command { std: "docker" "start" "-a" "865f4c687620bf51c479c1cb2de67ab89bdf7f603db0af0b71f5a4f4c32099ac", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.3.0 [INFO] [stderr] Checking regex-syntax v0.6.14 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking itertools v0.10.3 [INFO] [stderr] Checking aho-corasick v0.7.8 [INFO] [stderr] Checking regex v1.3.4 [INFO] [stderr] Checking spl-compile v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: a method with this name may be added to the standard library in the future [INFO] [stdout] --> src/main.rs:83:61 [INFO] [stdout] | [INFO] [stdout] 83 | let parseresult: Result, _> = example_p.by_ref().try_collect(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: once this associated item is added to the standard library, the ambiguity may cause an error or change in behavior! [INFO] [stdout] = note: for more information, see issue #48919 [INFO] [stdout] = help: call with fully qualified syntax `itertools::Itertools::try_collect(...)` to keep using the current method [INFO] [stdout] = note: `#[warn(unstable_name_collisions)]` on by default [INFO] [stdout] help: add `#![feature(iterator_try_collect)]` to the crate attributes to enable `std::iter::Iterator::try_collect` [INFO] [stdout] | [INFO] [stdout] 3 + #![feature(iterator_try_collect)] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/mod.rs:265:12 [INFO] [stdout] | [INFO] [stdout] 263 | let exp = self.exp()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 264 | let (_, loc) = self.consume(Marker(Semicolon), "';'")?; [INFO] [stdout] 265 | Ok((id, exp, loc)) [INFO] [stdout] | ^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/mod.rs:277:12 [INFO] [stdout] | [INFO] [stdout] 270 | let ftype = if let Some(Marker(TypeColon)) = self.peektok()? { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 276 | let (body, bspan) = self.compound()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 277 | Ok((Fun(id, args, ftype, body), opthull(id.1, Some(bspan)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/mod.rs:289:12 [INFO] [stdout] | [INFO] [stdout] 281 | let intypes = self.many(Self::typ)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 288 | let outtype @ (_, endspan) = self.one(Self::typ, "type")?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 289 | Ok(((intypes, outtype), opthull(startspan, endspan))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/mod.rs:443:12 [INFO] [stdout] | [INFO] [stdout] 441 | let stmts = self.many(Self::stmt)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 442 | let endspan = self.discard(Marker(BraceClose))?.into(); [INFO] [stdout] 443 | Ok((stmts, hull(startspan, endspan))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `spl-compile` (bin "spl-compile") due to 5 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: a method with this name may be added to the standard library in the future [INFO] [stdout] --> src/main.rs:83:61 [INFO] [stdout] | [INFO] [stdout] 83 | let parseresult: Result, _> = example_p.by_ref().try_collect(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: once this associated item is added to the standard library, the ambiguity may cause an error or change in behavior! [INFO] [stdout] = note: for more information, see issue #48919 [INFO] [stdout] = help: call with fully qualified syntax `itertools::Itertools::try_collect(...)` to keep using the current method [INFO] [stdout] = note: `#[warn(unstable_name_collisions)]` on by default [INFO] [stdout] help: add `#![feature(iterator_try_collect)]` to the crate attributes to enable `std::iter::Iterator::try_collect` [INFO] [stdout] | [INFO] [stdout] 3 + #![feature(iterator_try_collect)] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/mod.rs:265:12 [INFO] [stdout] | [INFO] [stdout] 263 | let exp = self.exp()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 264 | let (_, loc) = self.consume(Marker(Semicolon), "';'")?; [INFO] [stdout] 265 | Ok((id, exp, loc)) [INFO] [stdout] | ^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/mod.rs:277:12 [INFO] [stdout] | [INFO] [stdout] 270 | let ftype = if let Some(Marker(TypeColon)) = self.peektok()? { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 276 | let (body, bspan) = self.compound()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 277 | Ok((Fun(id, args, ftype, body), opthull(id.1, Some(bspan)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/mod.rs:289:12 [INFO] [stdout] | [INFO] [stdout] 281 | let intypes = self.many(Self::typ)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 288 | let outtype @ (_, endspan) = self.one(Self::typ, "type")?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 289 | Ok(((intypes, outtype), opthull(startspan, endspan))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/mod.rs:443:12 [INFO] [stdout] | [INFO] [stdout] 441 | let stmts = self.many(Self::stmt)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 442 | let endspan = self.discard(Marker(BraceClose))?.into(); [INFO] [stdout] 443 | Ok((stmts, hull(startspan, endspan))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/mod.rs:638:15 [INFO] [stdout] | [INFO] [stdout] 625 | let leftplus = Parser::new("1+2*3").exp(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 626 | let rightplus = Parser::new("2*3+1").exp(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 638 | match rightplus.unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/mod.rs:669:15 [INFO] [stdout] | [INFO] [stdout] 656 | let rightplus = Parser::new("1*(2+3)").exp(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 657 | let leftplus = Parser::new("(2+3)*1").exp(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 669 | match leftplus.unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `spl-compile` (bin "spl-compile" test) due to 7 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "865f4c687620bf51c479c1cb2de67ab89bdf7f603db0af0b71f5a4f4c32099ac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "865f4c687620bf51c479c1cb2de67ab89bdf7f603db0af0b71f5a4f4c32099ac", kill_on_drop: false }` [INFO] [stdout] 865f4c687620bf51c479c1cb2de67ab89bdf7f603db0af0b71f5a4f4c32099ac