[INFO] cloning repository https://github.com/Sajjon/rust-factors [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Sajjon/rust-factors" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSajjon%2Frust-factors", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSajjon%2Frust-factors'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d9abbbdb3e87a1c535d57e32909b04347075c6eb [INFO] checking Sajjon/rust-factors/d9abbbdb3e87a1c535d57e32909b04347075c6eb against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSajjon%2Frust-factors" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Sajjon/rust-factors on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-5-tc2/source/rust-toolchain.toml [INFO] started tweaking git repo https://github.com/Sajjon/rust-factors [INFO] finished tweaking git repo https://github.com/Sajjon/rust-factors [INFO] tweaked toml for git repo https://github.com/Sajjon/rust-factors written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Sajjon/rust-factors already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e421be79841c33aa12926154bce67e067f943486639d4881658ef17e353569e8 [INFO] running `Command { std: "docker" "start" "-a" "e421be79841c33aa12926154bce67e067f943486639d4881658ef17e353569e8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e421be79841c33aa12926154bce67e067f943486639d4881658ef17e353569e8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e421be79841c33aa12926154bce67e067f943486639d4881658ef17e353569e8", kill_on_drop: false }` [INFO] [stdout] e421be79841c33aa12926154bce67e067f943486639d4881658ef17e353569e8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c32a15492e84d65653e62108030cbface728c01105f6c5d9558fcce9df47040c [INFO] running `Command { std: "docker" "start" "-a" "c32a15492e84d65653e62108030cbface728c01105f6c5d9558fcce9df47040c", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking either v1.12.0 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking tokio v1.38.0 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling actix-macros v0.2.4 [INFO] [stderr] Compiling async-trait v0.1.80 [INFO] [stderr] Checking actix-rt v2.10.0 [INFO] [stderr] Checking thiserror v1.0.61 [INFO] [stderr] Checking rust-factors v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signatures_builders/signatures_builder_level0.rs:130:31 [INFO] [stdout] | [INFO] [stdout] 130 | .map(|(k, v)| (k, v.into_iter().sorted().collect::>())) [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signatures_builders/signatures_builder_level2.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 138 | let threshold_factors = self.all_threshold_factor_source_ids(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | self.ids_of_skipped_factor_sources() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signatures_builders/signatures_builder_level2.rs:148:9 [INFO] [stdout] | [INFO] [stdout] 147 | let override_factors = self.all_override_factor_source_ids(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | self.ids_of_skipped_factor_sources() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/sargon.rs:250:31 [INFO] [stdout] | [INFO] [stdout] 241 | threshold_factors: impl IntoIterator, [INFO] [stdout] | ----------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 242 | threshold: u8, [INFO] [stdout] 243 | override_factors: impl IntoIterator, [INFO] [stdout] | ---------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 250 | override_factors: override_factors.into_iter().collect_vec(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/sargon.rs:326:38 [INFO] [stdout] | [INFO] [stdout] 323 | pub fn new(entities_requiring_auth: impl IntoIterator) -> Self { [INFO] [stdout] | --------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 326 | entities_requiring_auth: entities_requiring_auth.into_iter().collect_vec(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/user.rs:55:21 [INFO] [stdout] | [INFO] [stdout] 53 | act: impl Fn(&FactorSource, IndexSet) -> SigningUserInput + 'static, [INFO] [stdout] | ------------------------------------------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | ) -> Self { [INFO] [stdout] 55 | Self { act: Box::new(act) } [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/user.rs:78:27 [INFO] [stdout] | [INFO] [stdout] 77 | invalid_tx_if_skipped: IndexSet, [INFO] [stdout] | ------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | ) -> SigningUserInput { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 79 | | match self { [INFO] [stdout] 80 | | TestSigningUser::Prudent => SigningUserInput::Sign, [INFO] [stdout] 81 | | TestSigningUser::Lazy(laziness) => (laziness.act)(factor_source, invalid_tx_if_skipped), [INFO] [stdout] ... | [INFO] [stdout] 91 | | } [INFO] [stdout] 92 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/user.rs:107:27 [INFO] [stdout] | [INFO] [stdout] 106 | invalid_tx_if_skipped: IndexSet, [INFO] [stdout] | ------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | ) -> SigningUserInput { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 108 | | match self { [INFO] [stdout] 109 | | SigningUser::Test(test_user) => { [INFO] [stdout] 110 | | test_user [INFO] [stdout] ... | [INFO] [stdout] 114 | | } [INFO] [stdout] 115 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-factors` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 20 | user: TestSigningUser, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | all_factor_sources_in_profile: impl IntoIterator, [INFO] [stdout] | --------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | transactions: impl IntoIterator, [INFO] [stdout] | --------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | SigningUser::Test(user), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 20 | user: TestSigningUser, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | all_factor_sources_in_profile: impl IntoIterator, [INFO] [stdout] | --------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | transactions: impl IntoIterator, [INFO] [stdout] | --------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | all_factor_sources_in_profile.into_iter().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:27:13 [INFO] [stdout] | [INFO] [stdout] 20 | user: TestSigningUser, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | all_factor_sources_in_profile: impl IntoIterator, [INFO] [stdout] | --------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | transactions: impl IntoIterator, [INFO] [stdout] | --------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | transactions.into_iter().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 31 | all_factor_sources_in_profile: impl IntoIterator, [INFO] [stdout] | --------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | transactions: impl IntoIterator, [INFO] [stdout] | --------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | TestSigningUser::Prudent, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:42:41 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn test_prudent(transactions: impl IntoIterator) -> Self { [INFO] [stdout] | --------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | Self::test_prudent_with_factors(FactorSource::all(), transactions) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 46 | all_factor_sources_in_profile: impl IntoIterator, [INFO] [stdout] | --------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | transactions: impl IntoIterator, [INFO] [stdout] | --------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | TestSigningUser::lazy_sign_minimum(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:59:51 [INFO] [stdout] | [INFO] [stdout] 57 | transactions: impl IntoIterator, [INFO] [stdout] | --------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | ) -> Self { [INFO] [stdout] 59 | Self::test_lazy_sign_minimum_with_factors(FactorSource::all(), transactions) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:67:13 [INFO] [stdout] | [INFO] [stdout] 63 | all_factor_sources_in_profile: impl IntoIterator, [INFO] [stdout] | --------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | transactions: impl IntoIterator, [INFO] [stdout] | --------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | TestSigningUser::lazy_always_skip(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:76:50 [INFO] [stdout] | [INFO] [stdout] 74 | transactions: impl IntoIterator, [INFO] [stdout] | --------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | ) -> Self { [INFO] [stdout] 76 | Self::test_lazy_always_skip_with_factors(FactorSource::all(), transactions) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signatures_builders/signatures_builder_level0.rs:130:31 [INFO] [stdout] | [INFO] [stdout] 130 | .map(|(k, v)| (k, v.into_iter().sorted().collect::>())) [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signatures_builders/signatures_builder_level2.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 138 | let threshold_factors = self.all_threshold_factor_source_ids(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | self.ids_of_skipped_factor_sources() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signatures_builders/signatures_builder_level2.rs:148:9 [INFO] [stdout] | [INFO] [stdout] 147 | let override_factors = self.all_override_factor_source_ids(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | self.ids_of_skipped_factor_sources() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/sargon.rs:250:31 [INFO] [stdout] | [INFO] [stdout] 241 | threshold_factors: impl IntoIterator, [INFO] [stdout] | ----------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 242 | threshold: u8, [INFO] [stdout] 243 | override_factors: impl IntoIterator, [INFO] [stdout] | ---------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 250 | override_factors: override_factors.into_iter().collect_vec(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/sargon.rs:326:38 [INFO] [stdout] | [INFO] [stdout] 323 | pub fn new(entities_requiring_auth: impl IntoIterator) -> Self { [INFO] [stdout] | --------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 326 | entities_requiring_auth: entities_requiring_auth.into_iter().collect_vec(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/user.rs:55:21 [INFO] [stdout] | [INFO] [stdout] 53 | act: impl Fn(&FactorSource, IndexSet) -> SigningUserInput + 'static, [INFO] [stdout] | ------------------------------------------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | ) -> Self { [INFO] [stdout] 55 | Self { act: Box::new(act) } [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/user.rs:78:27 [INFO] [stdout] | [INFO] [stdout] 77 | invalid_tx_if_skipped: IndexSet, [INFO] [stdout] | ------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | ) -> SigningUserInput { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 79 | | match self { [INFO] [stdout] 80 | | TestSigningUser::Prudent => SigningUserInput::Sign, [INFO] [stdout] 81 | | TestSigningUser::Lazy(laziness) => (laziness.act)(factor_source, invalid_tx_if_skipped), [INFO] [stdout] ... | [INFO] [stdout] 91 | | } [INFO] [stdout] 92 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/user.rs:107:27 [INFO] [stdout] | [INFO] [stdout] 106 | invalid_tx_if_skipped: IndexSet, [INFO] [stdout] | ------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | ) -> SigningUserInput { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 108 | | match self { [INFO] [stdout] 109 | | SigningUser::Test(test_user) => { [INFO] [stdout] 110 | | test_user [INFO] [stdout] ... | [INFO] [stdout] 114 | | } [INFO] [stdout] 115 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 17 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-factors` (lib test) due to 18 previous errors [INFO] running `Command { std: "docker" "inspect" "c32a15492e84d65653e62108030cbface728c01105f6c5d9558fcce9df47040c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c32a15492e84d65653e62108030cbface728c01105f6c5d9558fcce9df47040c", kill_on_drop: false }` [INFO] [stdout] c32a15492e84d65653e62108030cbface728c01105f6c5d9558fcce9df47040c