[INFO] cloning repository https://github.com/Safarte/ray-tracing-one-weekend [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Safarte/ray-tracing-one-weekend" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSafarte%2Fray-tracing-one-weekend", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSafarte%2Fray-tracing-one-weekend'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b3966781eaae60cc08b793c120a6b1a41a2a45db [INFO] checking Safarte/ray-tracing-one-weekend/b3966781eaae60cc08b793c120a6b1a41a2a45db against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSafarte%2Fray-tracing-one-weekend" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Safarte/ray-tracing-one-weekend on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Safarte/ray-tracing-one-weekend [INFO] finished tweaking git repo https://github.com/Safarte/ray-tracing-one-weekend [INFO] tweaked toml for git repo https://github.com/Safarte/ray-tracing-one-weekend written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Safarte/ray-tracing-one-weekend already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b7a43b4a66f81bb6e7b65a6d6d11fcea5b8df770e627dba2aae95ac41c8a9b9e [INFO] running `Command { std: "docker" "start" "-a" "b7a43b4a66f81bb6e7b65a6d6d11fcea5b8df770e627dba2aae95ac41c8a9b9e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b7a43b4a66f81bb6e7b65a6d6d11fcea5b8df770e627dba2aae95ac41c8a9b9e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b7a43b4a66f81bb6e7b65a6d6d11fcea5b8df770e627dba2aae95ac41c8a9b9e", kill_on_drop: false }` [INFO] [stdout] b7a43b4a66f81bb6e7b65a6d6d11fcea5b8df770e627dba2aae95ac41c8a9b9e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 31f78d2d19eb3904a6917c9b69d85d84e080aa62dc1a452678662a1194859648 [INFO] running `Command { std: "docker" "start" "-a" "31f78d2d19eb3904a6917c9b69d85d84e080aa62dc1a452678662a1194859648", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling libc v0.2.91 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Compiling proc-macro2 v1.0.30 [INFO] [stderr] Compiling crossbeam-epoch v0.9.5 [INFO] [stderr] Compiling rayon-core v1.9.1 [INFO] [stderr] Compiling syn v1.0.80 [INFO] [stderr] Compiling serde_derive v1.0.130 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Compiling serde v1.0.130 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Compiling getrandom v0.2.2 [INFO] [stderr] Compiling crc32fast v1.2.1 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking weezl v0.1.5 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Compiling serde_json v1.0.68 [INFO] [stderr] Compiling memoffset v0.6.4 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Compiling rayon v1.5.1 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Compiling num-rational v0.3.2 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Compiling num-iter v0.1.42 [INFO] [stderr] Checking deflate v0.8.6 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking miniz_oxide v0.3.7 [INFO] [stderr] Compiling inflections v1.1.1 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Checking rand_core v0.6.2 [INFO] [stderr] Checking gif v0.11.2 [INFO] [stderr] Checking terminal_size v0.1.17 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking bytemuck v1.7.2 [INFO] [stderr] Checking png v0.16.8 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking console v0.14.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking base64 v0.12.3 [INFO] [stderr] Checking rand_chacha v0.3.0 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking yaml-rust v0.3.5 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking glam v0.20.2 [INFO] [stderr] Checking rand v0.8.3 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking indicatif v0.16.2 [INFO] [stderr] Compiling gltf-derive v0.16.0 [INFO] [stderr] Checking jpeg-decoder v0.1.22 [INFO] [stderr] Checking tiff v0.6.1 [INFO] [stderr] Checking image v0.23.14 [INFO] [stderr] Checking gltf-json v0.16.0 [INFO] [stderr] Checking gltf v0.16.0 [INFO] [stderr] Checking rust-ray-tracer v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable `closest_hit` is assigned to, but never used [INFO] [stdout] --> src/ray.rs:57:17 [INFO] [stdout] | [INFO] [stdout] 57 | let mut closest_hit: Option = None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_closest_hit` instead [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `closest_hit` is never read [INFO] [stdout] --> src/ray.rs:66:21 [INFO] [stdout] | [INFO] [stdout] 66 | closest_hit = hit; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `BVHNode` is never used [INFO] [stdout] --> src/bvh/mod.rs:14:10 [INFO] [stdout] | [INFO] [stdout] 14 | pub enum BVHNode { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `build_rec` and `traverse_rec` are never used [INFO] [stdout] --> src/bvh/mod.rs:29:8 [INFO] [stdout] | [INFO] [stdout] 28 | impl BVHNode { [INFO] [stdout] | ------------ associated functions in this implementation [INFO] [stdout] 29 | fn build_rec( [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 103 | fn traverse_rec( [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `BVH` is never constructed [INFO] [stdout] --> src/bvh/mod.rs:135:12 [INFO] [stdout] | [INFO] [stdout] 135 | pub struct BVH { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `traverse` are never used [INFO] [stdout] --> src/bvh/mod.rs:140:12 [INFO] [stdout] | [INFO] [stdout] 139 | impl BVH { [INFO] [stdout] | -------- associated items in this implementation [INFO] [stdout] 140 | pub fn new(primitives: &[P]) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 148 | pub fn traverse<'a, P: Bounded>( [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `surrounding_box_vec` is never used [INFO] [stdout] --> src/bvh/aabb.rs:58:8 [INFO] [stdout] | [INFO] [stdout] 58 | pub fn surrounding_box_vec(aabbs: &[AABB]) -> AABB { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `aabb_compare` is never used [INFO] [stdout] --> src/bvh/aabb.rs:70:8 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn aabb_compare(a: &AABB, b: &AABB, axis: usize) -> Ordering { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `vertical_fov`, `near_plane_dist`, and `far_plane_dist` are never read [INFO] [stdout] --> src/camera.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct Camera { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] ... [INFO] [stdout] 10 | pub vertical_fov: f32, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 11 | scale: f32, [INFO] [stdout] 12 | pub near_plane_dist: f32, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 13 | pub far_plane_dist: f32, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Triangle` and `Sphere` are never constructed [INFO] [stdout] --> src/geometry/mod.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 21 | pub enum Primitive { [INFO] [stdout] | --------- variants in this enum [INFO] [stdout] 22 | Triangle(Triangle), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 23 | Sphere(Sphere), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `hit` is never used [INFO] [stdout] --> src/geometry/mod.rs:36:12 [INFO] [stdout] | [INFO] [stdout] 35 | impl Primitive { [INFO] [stdout] | -------------- method in this implementation [INFO] [stdout] 36 | pub fn hit(&self, ray: &Ray, t_min: f32, t_max: f32) -> Option { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/gltf.rs:20:10 [INFO] [stdout] | [INFO] [stdout] 20 | Vec2(Vec2), [INFO] [stdout] | ---- ^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `DataType` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 20 | Vec2(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Hit` is never constructed [INFO] [stdout] --> src/material/pbr.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct Hit { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_color` is never used [INFO] [stdout] --> src/ray.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 20 | impl Ray { [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 45 | pub fn get_color( [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/geometry/constant_medium.rs:29:29 [INFO] [stdout] | [INFO] [stdout] 23 | boundary: Arc, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | density: f32, [INFO] [stdout] 25 | texture: Arc, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | phase_function: Arc::new(Isotropic { albedo: texture }), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/geometry/constant_medium.rs:37:29 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn from_color(boundary: Arc, density: f32, color: Color) -> ConstantMedium { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | phase_function: Arc::new(Isotropic::from_color(color)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gltf.rs:345:12 [INFO] [stdout] | [INFO] [stdout] 315 | pub fn from_gltf_file>(path: P) -> Result> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 316 | let gltf_old = read_gltf_from_file(path)?; [INFO] [stdout] 317 | let gltf = Gltf::open("assets/suzanne.gltf")?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 324 | let materials = gltf_materials_to_materials(&gltf_old.materials); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 325 | let mut objects = gltf_meshes_to_hittables(&gltf_old.meshes, &accessors, &materials); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 326 | let mut lights: Hittables = Vec::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 343 | let world = BVHNode::new(objects, 0., 1.); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 344 | [INFO] [stdout] 345 | Ok(Scene { [INFO] [stdout] | ____________^ [INFO] [stdout] 346 | | world, [INFO] [stdout] 347 | | camera, [INFO] [stdout] 348 | | background: Color::new(0.051, 0.051, 0.051), [INFO] [stdout] 349 | | lights, [INFO] [stdout] 350 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/material/mod.rs:54:21 [INFO] [stdout] | [INFO] [stdout] 52 | pub fn new(texture: Arc) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | Lambertian { [INFO] [stdout] 54 | albedo: texture.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 14 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-ray-tracer` (bin "rust-ray-tracer") due to 5 previous errors; 14 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable `closest_hit` is assigned to, but never used [INFO] [stdout] --> src/ray.rs:57:17 [INFO] [stdout] | [INFO] [stdout] 57 | let mut closest_hit: Option = None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_closest_hit` instead [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `closest_hit` is never read [INFO] [stdout] --> src/ray.rs:66:21 [INFO] [stdout] | [INFO] [stdout] 66 | closest_hit = hit; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `BVHNode` is never used [INFO] [stdout] --> src/bvh/mod.rs:14:10 [INFO] [stdout] | [INFO] [stdout] 14 | pub enum BVHNode { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `build_rec` and `traverse_rec` are never used [INFO] [stdout] --> src/bvh/mod.rs:29:8 [INFO] [stdout] | [INFO] [stdout] 28 | impl BVHNode { [INFO] [stdout] | ------------ associated functions in this implementation [INFO] [stdout] 29 | fn build_rec( [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 103 | fn traverse_rec( [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `BVH` is never constructed [INFO] [stdout] --> src/bvh/mod.rs:135:12 [INFO] [stdout] | [INFO] [stdout] 135 | pub struct BVH { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `traverse` are never used [INFO] [stdout] --> src/bvh/mod.rs:140:12 [INFO] [stdout] | [INFO] [stdout] 139 | impl BVH { [INFO] [stdout] | -------- associated items in this implementation [INFO] [stdout] 140 | pub fn new(primitives: &[P]) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 148 | pub fn traverse<'a, P: Bounded>( [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `surrounding_box_vec` is never used [INFO] [stdout] --> src/bvh/aabb.rs:58:8 [INFO] [stdout] | [INFO] [stdout] 58 | pub fn surrounding_box_vec(aabbs: &[AABB]) -> AABB { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `aabb_compare` is never used [INFO] [stdout] --> src/bvh/aabb.rs:70:8 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn aabb_compare(a: &AABB, b: &AABB, axis: usize) -> Ordering { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `vertical_fov`, `near_plane_dist`, and `far_plane_dist` are never read [INFO] [stdout] --> src/camera.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct Camera { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] ... [INFO] [stdout] 10 | pub vertical_fov: f32, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 11 | scale: f32, [INFO] [stdout] 12 | pub near_plane_dist: f32, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 13 | pub far_plane_dist: f32, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Triangle` and `Sphere` are never constructed [INFO] [stdout] --> src/geometry/mod.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 21 | pub enum Primitive { [INFO] [stdout] | --------- variants in this enum [INFO] [stdout] 22 | Triangle(Triangle), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 23 | Sphere(Sphere), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `hit` is never used [INFO] [stdout] --> src/geometry/mod.rs:36:12 [INFO] [stdout] | [INFO] [stdout] 35 | impl Primitive { [INFO] [stdout] | -------------- method in this implementation [INFO] [stdout] 36 | pub fn hit(&self, ray: &Ray, t_min: f32, t_max: f32) -> Option { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/gltf.rs:20:10 [INFO] [stdout] | [INFO] [stdout] 20 | Vec2(Vec2), [INFO] [stdout] | ---- ^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `DataType` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 20 | Vec2(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Hit` is never constructed [INFO] [stdout] --> src/material/pbr.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct Hit { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_color` is never used [INFO] [stdout] --> src/ray.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 20 | impl Ray { [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 45 | pub fn get_color( [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/geometry/constant_medium.rs:29:29 [INFO] [stdout] | [INFO] [stdout] 23 | boundary: Arc, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | density: f32, [INFO] [stdout] 25 | texture: Arc, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | phase_function: Arc::new(Isotropic { albedo: texture }), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/geometry/constant_medium.rs:37:29 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn from_color(boundary: Arc, density: f32, color: Color) -> ConstantMedium { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | phase_function: Arc::new(Isotropic::from_color(color)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gltf.rs:345:12 [INFO] [stdout] | [INFO] [stdout] 315 | pub fn from_gltf_file>(path: P) -> Result> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 316 | let gltf_old = read_gltf_from_file(path)?; [INFO] [stdout] 317 | let gltf = Gltf::open("assets/suzanne.gltf")?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 324 | let materials = gltf_materials_to_materials(&gltf_old.materials); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 325 | let mut objects = gltf_meshes_to_hittables(&gltf_old.meshes, &accessors, &materials); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 326 | let mut lights: Hittables = Vec::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 343 | let world = BVHNode::new(objects, 0., 1.); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 344 | [INFO] [stdout] 345 | Ok(Scene { [INFO] [stdout] | ____________^ [INFO] [stdout] 346 | | world, [INFO] [stdout] 347 | | camera, [INFO] [stdout] 348 | | background: Color::new(0.051, 0.051, 0.051), [INFO] [stdout] 349 | | lights, [INFO] [stdout] 350 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/material/mod.rs:54:21 [INFO] [stdout] | [INFO] [stdout] 52 | pub fn new(texture: Arc) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | Lambertian { [INFO] [stdout] 54 | albedo: texture.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 14 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-ray-tracer` (bin "rust-ray-tracer" test) due to 5 previous errors; 14 warnings emitted [INFO] running `Command { std: "docker" "inspect" "31f78d2d19eb3904a6917c9b69d85d84e080aa62dc1a452678662a1194859648", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "31f78d2d19eb3904a6917c9b69d85d84e080aa62dc1a452678662a1194859648", kill_on_drop: false }` [INFO] [stdout] 31f78d2d19eb3904a6917c9b69d85d84e080aa62dc1a452678662a1194859648