[INFO] cloning repository https://github.com/SabrinaJewson/spx [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/SabrinaJewson/spx" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSabrinaJewson%2Fspx", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSabrinaJewson%2Fspx'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7f0a3c8bbc5aceccdfa228480d86c0dda2520c45 [INFO] checking SabrinaJewson/spx/7f0a3c8bbc5aceccdfa228480d86c0dda2520c45 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSabrinaJewson%2Fspx" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/SabrinaJewson/spx on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/SabrinaJewson/spx [INFO] finished tweaking git repo https://github.com/SabrinaJewson/spx [INFO] tweaked toml for git repo https://github.com/SabrinaJewson/spx written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/SabrinaJewson/spx already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a7ba0f2da8b593314fd8d100f85b49bf0625af96a360505fa74e2305e395af6b [INFO] running `Command { std: "docker" "start" "-a" "a7ba0f2da8b593314fd8d100f85b49bf0625af96a360505fa74e2305e395af6b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a7ba0f2da8b593314fd8d100f85b49bf0625af96a360505fa74e2305e395af6b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a7ba0f2da8b593314fd8d100f85b49bf0625af96a360505fa74e2305e395af6b", kill_on_drop: false }` [INFO] [stdout] a7ba0f2da8b593314fd8d100f85b49bf0625af96a360505fa74e2305e395af6b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 432197e5c12b2921a3db94096c39f3799e68890bee5e21d24409b8360d2c0d38 [INFO] running `Command { std: "docker" "start" "-a" "432197e5c12b2921a3db94096c39f3799e68890bee5e21d24409b8360d2c0d38", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.121 [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling syn v1.0.89 [INFO] [stderr] Compiling log v0.4.16 [INFO] [stderr] Checking pin-project-lite v0.2.8 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Checking once_cell v1.10.0 [INFO] [stderr] Compiling indexmap v1.8.0 [INFO] [stderr] Checking slab v0.4.5 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Checking tinyvec v1.5.1 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling serde_derive v1.0.136 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking http v0.2.6 [INFO] [stderr] Compiling quote v1.0.16 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking mio v0.8.2 [INFO] [stderr] Checking getrandom v0.2.5 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking tracing-core v0.1.23 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Compiling httparse v1.6.0 [INFO] [stderr] Compiling async-trait v0.1.52 [INFO] [stderr] Compiling parking_lot_core v0.9.1 [INFO] [stderr] Compiling rustls v0.20.4 [INFO] [stderr] Checking unicode-bidi v0.3.7 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking tracing v0.1.32 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking try-lock v0.2.3 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking hostname v0.3.1 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking http-body v0.4.4 [INFO] [stderr] Checking lock_api v0.4.6 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rustls-pemfile v0.2.1 [INFO] [stderr] Checking tower-service v0.3.1 [INFO] [stderr] Checking httpdate v1.0.2 [INFO] [stderr] Checking data-encoding v2.3.2 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking ipnet v2.4.0 [INFO] [stderr] Compiling anyhow v1.0.56 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking rustls-native-certs v0.6.1 [INFO] [stderr] Checking parking_lot v0.12.0 [INFO] [stderr] Checking resolv-conf v0.7.0 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking rustls-pemfile v0.3.0 [INFO] [stderr] Checking pretty_env_logger v0.4.0 [INFO] [stderr] Checking webpki v0.22.0 [INFO] [stderr] Checking sct v0.7.0 [INFO] [stderr] Checking webpki-roots v0.22.2 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Compiling enum-as-inner v0.4.0 [INFO] [stderr] Compiling clap_derive v3.1.4 [INFO] [stderr] Checking tokio v1.17.0 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking clap v3.1.6 [INFO] [stderr] Checking tokio-util v0.6.9 [INFO] [stderr] Checking trust-dns-proto v0.21.1 [INFO] [stderr] Checking tokio-rustls v0.23.3 [INFO] [stderr] Checking h2 v0.3.12 [INFO] [stderr] Checking trust-dns-resolver v0.21.1 [INFO] [stderr] Checking serde_regex v1.1.0 [INFO] [stderr] Checking toml v0.5.8 [INFO] [stderr] Checking hyper v0.14.17 [INFO] [stderr] Checking hyper-rustls v0.23.0 [INFO] [stderr] Checking spx v0.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `inner` is never read [INFO] [stdout] --> src/proxy.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 26 | pub(crate) struct Proxy { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] 27 | inner: Arc, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Proxy` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `domain`, `deny_user_agents`, and `client` are never read [INFO] [stdout] --> src/proxy.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 30 | struct ProxyInner { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 31 | domain: String, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 32 | deny_user_agents: Regex, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 33 | client: hyper::Client>, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:23:8 [INFO] [stdout] | [INFO] [stdout] 20 | let config = toml::from_str::(file).context("config file is invalid")?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | Ok(server::Config { [INFO] [stdout] | ________^ [INFO] [stdout] 24 | | http_port: config.http_port, [INFO] [stdout] 25 | | https_port: config.https_port, [INFO] [stdout] 26 | | tls: server::TlsConfig { [INFO] [stdout] ... | [INFO] [stdout] 38 | | }, [INFO] [stdout] 39 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proxy.rs:57:12 [INFO] [stdout] | [INFO] [stdout] 37 | pub(crate) fn new(config: Config) -> anyhow::Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | let http_connector = Connector { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | let https_connector = hyper_rustls::HttpsConnectorBuilder::new() [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | let client = hyper::Client::builder().build(https_connector); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | [INFO] [stdout] 51 | let inner = Arc::new(ProxyInner { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | Ok(Proxy { inner }) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proxy.rs:91:18 [INFO] [stdout] | [INFO] [stdout] 89 | fn call(&mut self, uri: Uri) -> Self::Future { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | let this = self.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 92 | | let host = uri.host().ok_or(ConnectorError::NoHost(NoHostError))?; [INFO] [stdout] 93 | | let port = uri.port_u16().unwrap_or_else(|| match uri.scheme_str() { [INFO] [stdout] 94 | | Some("https") => 443, [INFO] [stdout] ... | [INFO] [stdout] 108 | | .map_err(ConnectorError::Tcp) [INFO] [stdout] 109 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proxy.rs:106:13 [INFO] [stdout] | [INFO] [stdout] 89 | fn call(&mut self, uri: Uri) -> Self::Future { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | let this = self.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | / TcpStream::connect(&*addresses) [INFO] [stdout] 107 | | .await [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 35 | pub(crate) fn run(config: Config) -> anyhow::Result<()> { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | / tokio::runtime::Builder::new_multi_thread() [INFO] [stdout] 37 | | .enable_all() [INFO] [stdout] 38 | | .build() [INFO] [stdout] 39 | | .context("failed to create Tokio runtime")? [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:40:19 [INFO] [stdout] | [INFO] [stdout] 35 | pub(crate) fn run(config: Config) -> anyhow::Result<()> { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | .block_on(run_async(config)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:50:29 [INFO] [stdout] | [INFO] [stdout] 47 | let http_task = tokio::task::spawn(serve_http(config.http_port, http.clone(), proxy.clone())); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | let http_task = async { http_task.await.unwrap() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:51:30 [INFO] [stdout] | [INFO] [stdout] 48 | let https_task = tokio::task::spawn(serve_https(config.https_port, config.tls, http, proxy)); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | let https_task = async { https_task.await.unwrap() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:105:19 [INFO] [stdout] | [INFO] [stdout] 102 | let tls_config = tls_config.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | match acceptor(&*tls.chain, &*tls.key).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `spx` (bin "spx") due to 10 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `inner` is never read [INFO] [stdout] --> src/proxy.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 26 | pub(crate) struct Proxy { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] 27 | inner: Arc, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Proxy` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `domain`, `deny_user_agents`, and `client` are never read [INFO] [stdout] --> src/proxy.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 30 | struct ProxyInner { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 31 | domain: String, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 32 | deny_user_agents: Regex, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 33 | client: hyper::Client>, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:23:8 [INFO] [stdout] | [INFO] [stdout] 20 | let config = toml::from_str::(file).context("config file is invalid")?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | Ok(server::Config { [INFO] [stdout] | ________^ [INFO] [stdout] 24 | | http_port: config.http_port, [INFO] [stdout] 25 | | https_port: config.https_port, [INFO] [stdout] 26 | | tls: server::TlsConfig { [INFO] [stdout] ... | [INFO] [stdout] 38 | | }, [INFO] [stdout] 39 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proxy.rs:57:12 [INFO] [stdout] | [INFO] [stdout] 37 | pub(crate) fn new(config: Config) -> anyhow::Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | let http_connector = Connector { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | let https_connector = hyper_rustls::HttpsConnectorBuilder::new() [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | let client = hyper::Client::builder().build(https_connector); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | [INFO] [stdout] 51 | let inner = Arc::new(ProxyInner { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | Ok(Proxy { inner }) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proxy.rs:91:18 [INFO] [stdout] | [INFO] [stdout] 89 | fn call(&mut self, uri: Uri) -> Self::Future { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | let this = self.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 92 | | let host = uri.host().ok_or(ConnectorError::NoHost(NoHostError))?; [INFO] [stdout] 93 | | let port = uri.port_u16().unwrap_or_else(|| match uri.scheme_str() { [INFO] [stdout] 94 | | Some("https") => 443, [INFO] [stdout] ... | [INFO] [stdout] 108 | | .map_err(ConnectorError::Tcp) [INFO] [stdout] 109 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proxy.rs:106:13 [INFO] [stdout] | [INFO] [stdout] 89 | fn call(&mut self, uri: Uri) -> Self::Future { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | let this = self.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | / TcpStream::connect(&*addresses) [INFO] [stdout] 107 | | .await [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 35 | pub(crate) fn run(config: Config) -> anyhow::Result<()> { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | / tokio::runtime::Builder::new_multi_thread() [INFO] [stdout] 37 | | .enable_all() [INFO] [stdout] 38 | | .build() [INFO] [stdout] 39 | | .context("failed to create Tokio runtime")? [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:40:19 [INFO] [stdout] | [INFO] [stdout] 35 | pub(crate) fn run(config: Config) -> anyhow::Result<()> { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | .block_on(run_async(config)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:50:29 [INFO] [stdout] | [INFO] [stdout] 47 | let http_task = tokio::task::spawn(serve_http(config.http_port, http.clone(), proxy.clone())); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | let http_task = async { http_task.await.unwrap() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:51:30 [INFO] [stdout] | [INFO] [stdout] 48 | let https_task = tokio::task::spawn(serve_https(config.https_port, config.tls, http, proxy)); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | let https_task = async { https_task.await.unwrap() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:105:19 [INFO] [stdout] | [INFO] [stdout] 102 | let tls_config = tls_config.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | match acceptor(&*tls.chain, &*tls.key).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `spx` (bin "spx" test) due to 10 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "432197e5c12b2921a3db94096c39f3799e68890bee5e21d24409b8360d2c0d38", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "432197e5c12b2921a3db94096c39f3799e68890bee5e21d24409b8360d2c0d38", kill_on_drop: false }` [INFO] [stdout] 432197e5c12b2921a3db94096c39f3799e68890bee5e21d24409b8360d2c0d38