[INFO] cloning repository https://github.com/SL-Lee/pfsense-auto-backup [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/SL-Lee/pfsense-auto-backup" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSL-Lee%2Fpfsense-auto-backup", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSL-Lee%2Fpfsense-auto-backup'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ee844efc42b478e2cc2a5db89bc19297f623bf2b [INFO] checking SL-Lee/pfsense-auto-backup/ee844efc42b478e2cc2a5db89bc19297f623bf2b against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSL-Lee%2Fpfsense-auto-backup" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/SL-Lee/pfsense-auto-backup on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/SL-Lee/pfsense-auto-backup [INFO] finished tweaking git repo https://github.com/SL-Lee/pfsense-auto-backup [INFO] tweaked toml for git repo https://github.com/SL-Lee/pfsense-auto-backup written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/SL-Lee/pfsense-auto-backup already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 66cf78fc292a4ab205eee6b373cd09a935d307c5e0a86423057f34daf46d004e [INFO] running `Command { std: "docker" "start" "-a" "66cf78fc292a4ab205eee6b373cd09a935d307c5e0a86423057f34daf46d004e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "66cf78fc292a4ab205eee6b373cd09a935d307c5e0a86423057f34daf46d004e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "66cf78fc292a4ab205eee6b373cd09a935d307c5e0a86423057f34daf46d004e", kill_on_drop: false }` [INFO] [stdout] 66cf78fc292a4ab205eee6b373cd09a935d307c5e0a86423057f34daf46d004e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c38b10c4b7270f6aa2ff9f79a437de8783af6338d837ccc5241770d6f8753a5f [INFO] running `Command { std: "docker" "start" "-a" "c38b10c4b7270f6aa2ff9f79a437de8783af6338d837ccc5241770d6f8753a5f", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.99 [INFO] [stderr] Compiling syn v1.0.74 [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Compiling typenum v1.13.0 [INFO] [stderr] Compiling standback v0.2.17 [INFO] [stderr] Compiling generic-array v0.14.4 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Checking bytes v1.0.1 [INFO] [stderr] Compiling openssl-sys v0.9.65 [INFO] [stderr] Compiling futures-core v0.3.16 [INFO] [stderr] Compiling tokio v1.10.0 [INFO] [stderr] Compiling proc-macro-hack v0.5.19 [INFO] [stderr] Compiling futures-task v0.3.16 [INFO] [stderr] Compiling serde_derive v1.0.127 [INFO] [stderr] Compiling indexmap v1.7.0 [INFO] [stderr] Compiling futures-util v0.3.16 [INFO] [stderr] Compiling openssl v0.10.35 [INFO] [stderr] Compiling const_fn v0.4.8 [INFO] [stderr] Compiling serde v1.0.127 [INFO] [stderr] Checking tracing-core v0.1.18 [INFO] [stderr] Compiling time v0.2.27 [INFO] [stderr] Checking bitflags v1.3.1 [INFO] [stderr] Compiling futures-channel v0.3.16 [INFO] [stderr] Checking futures-sink v0.3.16 [INFO] [stderr] Compiling httparse v1.4.1 [INFO] [stderr] Checking futures-io v0.3.16 [INFO] [stderr] Checking http v0.2.4 [INFO] [stderr] Compiling cookie v0.14.4 [INFO] [stderr] Compiling serde_json v1.0.66 [INFO] [stderr] Checking subtle v2.4.1 [INFO] [stderr] Compiling mime_guess v2.0.3 [INFO] [stderr] Checking tracing v0.1.26 [INFO] [stderr] Compiling native-tls v0.2.8 [INFO] [stderr] Checking opaque-debug v0.3.0 [INFO] [stderr] Checking httpdate v1.0.1 [INFO] [stderr] Checking publicsuffix v1.5.6 [INFO] [stderr] Checking base64ct v1.0.1 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking cpufeatures v0.1.5 [INFO] [stderr] Checking block-padding v0.2.1 [INFO] [stderr] Checking mio v0.7.13 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking socket2 v0.4.1 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking password-hash v0.2.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking cipher v0.3.0 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking crypto-mac v0.8.0 [INFO] [stderr] Checking blake2 v0.9.1 [INFO] [stderr] Checking clokwerk v0.3.5 [INFO] [stderr] Checking block-modes v0.8.1 [INFO] [stderr] Checking aes v0.7.4 [INFO] [stderr] Checking http-body v0.4.3 [INFO] [stderr] Checking argon2 v0.2.3 [INFO] [stderr] Compiling time-macros-impl v0.1.2 [INFO] [stderr] Checking time-macros v0.1.1 [INFO] [stderr] Checking tokio-util v0.6.7 [INFO] [stderr] Checking tokio-native-tls v0.3.0 [INFO] [stderr] Checking h2 v0.3.3 [INFO] [stderr] Checking hyper v0.14.11 [INFO] [stderr] Checking serde_urlencoded v0.7.0 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking cookie_store v0.12.0 [INFO] [stderr] Checking reqwest v0.11.4 [INFO] [stderr] Checking pfsense-auto-backup v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:33:11 [INFO] [stdout] | [INFO] [stdout] 26 | fn get_csrf_token(client: Arc, url: &str) -> String { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | let response = client.get(url).send().expect("Unable to load page."); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | let csrf_token_regex = Regex::new( [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | match csrf_token_regex.captures(&response.text().unwrap()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:54:11 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn login(client: Arc) -> Result { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let form = reqwest::blocking::multipart::Form::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | match client [INFO] [stdout] | ___________^ [INFO] [stdout] 55 | | .post(&format!( [INFO] [stdout] 56 | | "{}{}", [INFO] [stdout] 57 | | get_pfsense_domain(), [INFO] [stdout] ... | [INFO] [stdout] 60 | | .multipart(form) [INFO] [stdout] 61 | | .send() [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:169:5 [INFO] [stdout] | [INFO] [stdout] 106 | client: Arc, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | let form = reqwest::blocking::multipart::Form::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 131 | let mut response = client [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | let filename_regex = Regex::new(r"attachment; filename=(.+)").unwrap(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | let mut backup_file = [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 169 | / response [INFO] [stdout] 170 | | .copy_to(&mut backup_file) [INFO] [stdout] 171 | | .map(|_| "Config file backed up successfully.".to_string()) [INFO] [stdout] | |___________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:206:11 [INFO] [stdout] | [INFO] [stdout] 176 | client: Arc, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 185 | let form = reqwest::blocking::multipart::Form::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 198 | Ok(file) => file, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | Err(error) => return Err(error.to_string()), [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 206 | match client [INFO] [stdout] | ___________^ [INFO] [stdout] 207 | | .post(&format!( [INFO] [stdout] 208 | | "{}{}", [INFO] [stdout] 209 | | get_pfsense_domain(), [INFO] [stdout] ... | [INFO] [stdout] 212 | | .multipart(form) [INFO] [stdout] 213 | | .send() [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:33:11 [INFO] [stdout] | [INFO] [stdout] 26 | fn get_csrf_token(client: Arc, url: &str) -> String { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | let response = client.get(url).send().expect("Unable to load page."); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | let csrf_token_regex = Regex::new( [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | match csrf_token_regex.captures(&response.text().unwrap()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pfsense-auto-backup` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:54:11 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn login(client: Arc) -> Result { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let form = reqwest::blocking::multipart::Form::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | match client [INFO] [stdout] | ___________^ [INFO] [stdout] 55 | | .post(&format!( [INFO] [stdout] 56 | | "{}{}", [INFO] [stdout] 57 | | get_pfsense_domain(), [INFO] [stdout] ... | [INFO] [stdout] 60 | | .multipart(form) [INFO] [stdout] 61 | | .send() [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:169:5 [INFO] [stdout] | [INFO] [stdout] 106 | client: Arc, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | let form = reqwest::blocking::multipart::Form::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 131 | let mut response = client [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | let filename_regex = Regex::new(r"attachment; filename=(.+)").unwrap(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | let mut backup_file = [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 169 | / response [INFO] [stdout] 170 | | .copy_to(&mut backup_file) [INFO] [stdout] 171 | | .map(|_| "Config file backed up successfully.".to_string()) [INFO] [stdout] | |___________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:206:11 [INFO] [stdout] | [INFO] [stdout] 176 | client: Arc, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 185 | let form = reqwest::blocking::multipart::Form::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 198 | Ok(file) => file, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | Err(error) => return Err(error.to_string()), [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 206 | match client [INFO] [stdout] | ___________^ [INFO] [stdout] 207 | | .post(&format!( [INFO] [stdout] 208 | | "{}{}", [INFO] [stdout] 209 | | get_pfsense_domain(), [INFO] [stdout] ... | [INFO] [stdout] 212 | | .multipart(form) [INFO] [stdout] 213 | | .send() [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pfsense-auto-backup` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "c38b10c4b7270f6aa2ff9f79a437de8783af6338d837ccc5241770d6f8753a5f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c38b10c4b7270f6aa2ff9f79a437de8783af6338d837ccc5241770d6f8753a5f", kill_on_drop: false }` [INFO] [stdout] c38b10c4b7270f6aa2ff9f79a437de8783af6338d837ccc5241770d6f8753a5f