[INFO] cloning repository https://github.com/SKTT1Ryze/rust-piano [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/SKTT1Ryze/rust-piano" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSKTT1Ryze%2Frust-piano", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSKTT1Ryze%2Frust-piano'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 439d626dff9393bc177d62f784e67767b60093dd [INFO] checking SKTT1Ryze/rust-piano/439d626dff9393bc177d62f784e67767b60093dd against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSKTT1Ryze%2Frust-piano" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/SKTT1Ryze/rust-piano on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/SKTT1Ryze/rust-piano [INFO] finished tweaking git repo https://github.com/SKTT1Ryze/rust-piano [INFO] tweaked toml for git repo https://github.com/SKTT1Ryze/rust-piano written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/SKTT1Ryze/rust-piano already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2f9c01219382bae344a1cb30905d69d76ca109043792f30a396200f339b4b1e4 [INFO] running `Command { std: "docker" "start" "-a" "2f9c01219382bae344a1cb30905d69d76ca109043792f30a396200f339b4b1e4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2f9c01219382bae344a1cb30905d69d76ca109043792f30a396200f339b4b1e4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2f9c01219382bae344a1cb30905d69d76ca109043792f30a396200f339b4b1e4", kill_on_drop: false }` [INFO] [stdout] 2f9c01219382bae344a1cb30905d69d76ca109043792f30a396200f339b4b1e4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 131e669f20627a328bc61029081d00a69acbc4f54da308e94f274413a8cfbd2d [INFO] running `Command { std: "docker" "start" "-a" "131e669f20627a328bc61029081d00a69acbc4f54da308e94f274413a8cfbd2d", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.80 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling syn v1.0.50 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling pkg-config v0.3.19 [INFO] [stderr] Compiling nix v0.15.0 [INFO] [stderr] Compiling cc v1.0.65 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling getrandom v0.1.15 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Compiling cpal v0.13.1 [INFO] [stderr] Compiling unicode-segmentation v1.7.0 [INFO] [stderr] Checking tinyvec v0.3.4 [INFO] [stderr] Compiling alsa-sys v0.3.0 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Checking ogg v0.7.1 [INFO] [stderr] Compiling argh_shared v0.1.4 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Checking hound v3.4.0 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking lewton v0.10.1 [INFO] [stderr] Checking claxon v0.4.3 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking walkdir v2.3.1 [INFO] [stderr] Compiling minimp3-sys v0.3.2 [INFO] [stderr] Checking slice-deque v0.3.0 [INFO] [stderr] Checking termion v1.5.5 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking tui v0.13.0 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking minimp3 v0.5.0 [INFO] [stderr] Checking alsa v0.4.3 [INFO] [stderr] Compiling thiserror-impl v1.0.22 [INFO] [stderr] Compiling argh_derive v0.1.4 [INFO] [stderr] Checking thiserror v1.0.22 [INFO] [stderr] Checking mp3-duration v0.1.10 [INFO] [stderr] Checking argh v0.1.4 [INFO] [stderr] Checking rodio v0.13.0 [INFO] [stderr] Checking rust-piano v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `name`, `location`, `coords`, and `status` are never read [INFO] [stdout] --> src/piano/app.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 71 | pub struct Server<'a> { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 72 | pub name: &'a str, [INFO] [stdout] | ^^^^ [INFO] [stdout] 73 | pub location: &'a str, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 74 | pub coords: (f64, f64), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 75 | pub status: &'a str, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `servers` is never read [INFO] [stdout] --> src/piano/app.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 77 | pub struct App<'a> { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 86 | pub servers: Vec>, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piano/app.rs:177:25 [INFO] [stdout] | [INFO] [stdout] 105 | let mut music_list = Vec::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | let audio_player = AudioPlayer::new(20).unwrap(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | let tones = Tones::new("C", tone_path).unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | let mut opern_list = Vec::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | music_list: StatefulList::with_items(music_list), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piano/app.rs:182:21 [INFO] [stdout] | [INFO] [stdout] 105 | let mut music_list = Vec::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | let audio_player = AudioPlayer::new(20).unwrap(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | let tones = Tones::new("C", tone_path).unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | let mut opern_list = Vec::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 182 | operns: StatefulList::with_items(opern_list), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piano/music.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 29 | let file = File::open(path).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let duration = mp3_duration::from_file(&file).unwrap(); [INFO] [stdout] 31 | let data = BufReader::new(file); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | let source = rodio::Decoder::new(data).unwrap().buffered(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | / Self { [INFO] [stdout] 43 | | path: String::from(path), [INFO] [stdout] 44 | | name: music_name, [INFO] [stdout] 45 | | source, [INFO] [stdout] 46 | | duration, [INFO] [stdout] 47 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piano/player.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 32 | let music_src_list = Vec::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let piano_src_list = Vec::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let mut sink_list = Vec::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let (stream, stream_handle) = rodio::OutputStream::try_default().unwrap(); [INFO] [stdout] | ------ ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | / Self { [INFO] [stdout] 44 | | music_src_list, [INFO] [stdout] 45 | | piano_src_list, [INFO] [stdout] 46 | | sink_list, [INFO] [stdout] ... | [INFO] [stdout] 50 | | tone_sink, [INFO] [stdout] 51 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/piano/player.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 105 | drop(&self.sink_list[0]); [INFO] [stdout] | ^^^^^------------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&rodio::Sink` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 105 - drop(&self.sink_list[0]); [INFO] [stdout] 105 + let _ = &self.sink_list[0]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piano/tone.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 23 | let file = File::open(source_path).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | let source = BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | let source = rodio::Decoder::new(source).unwrap().buffered(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | / Self { [INFO] [stdout] 40 | | name: tone_name, [INFO] [stdout] 41 | | source, [INFO] [stdout] 42 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piano/tone.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 54 | let mut tone_list = Vec::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | / Self { [INFO] [stdout] 65 | | pitch, [INFO] [stdout] 66 | | tone_list, [INFO] [stdout] 67 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-piano` (bin "rust-piano" test) due to 7 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `name`, `location`, `coords`, and `status` are never read [INFO] [stdout] --> src/piano/app.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 71 | pub struct Server<'a> { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 72 | pub name: &'a str, [INFO] [stdout] | ^^^^ [INFO] [stdout] 73 | pub location: &'a str, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 74 | pub coords: (f64, f64), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 75 | pub status: &'a str, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `servers` is never read [INFO] [stdout] --> src/piano/app.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 77 | pub struct App<'a> { [INFO] [stdout] | --- field in this struct [INFO] [stdout] ... [INFO] [stdout] 86 | pub servers: Vec>, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piano/app.rs:177:25 [INFO] [stdout] | [INFO] [stdout] 105 | let mut music_list = Vec::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | let audio_player = AudioPlayer::new(20).unwrap(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | let tones = Tones::new("C", tone_path).unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | let mut opern_list = Vec::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | music_list: StatefulList::with_items(music_list), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piano/app.rs:182:21 [INFO] [stdout] | [INFO] [stdout] 105 | let mut music_list = Vec::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | let audio_player = AudioPlayer::new(20).unwrap(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | let tones = Tones::new("C", tone_path).unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | let mut opern_list = Vec::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 182 | operns: StatefulList::with_items(opern_list), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piano/music.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 29 | let file = File::open(path).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let duration = mp3_duration::from_file(&file).unwrap(); [INFO] [stdout] 31 | let data = BufReader::new(file); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | let source = rodio::Decoder::new(data).unwrap().buffered(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | / Self { [INFO] [stdout] 43 | | path: String::from(path), [INFO] [stdout] 44 | | name: music_name, [INFO] [stdout] 45 | | source, [INFO] [stdout] 46 | | duration, [INFO] [stdout] 47 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piano/player.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 32 | let music_src_list = Vec::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let piano_src_list = Vec::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let mut sink_list = Vec::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let (stream, stream_handle) = rodio::OutputStream::try_default().unwrap(); [INFO] [stdout] | ------ ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | / Self { [INFO] [stdout] 44 | | music_src_list, [INFO] [stdout] 45 | | piano_src_list, [INFO] [stdout] 46 | | sink_list, [INFO] [stdout] ... | [INFO] [stdout] 50 | | tone_sink, [INFO] [stdout] 51 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/piano/player.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 105 | drop(&self.sink_list[0]); [INFO] [stdout] | ^^^^^------------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&rodio::Sink` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 105 - drop(&self.sink_list[0]); [INFO] [stdout] 105 + let _ = &self.sink_list[0]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piano/tone.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 23 | let file = File::open(source_path).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | let source = BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | let source = rodio::Decoder::new(source).unwrap().buffered(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | / Self { [INFO] [stdout] 40 | | name: tone_name, [INFO] [stdout] 41 | | source, [INFO] [stdout] 42 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piano/tone.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 54 | let mut tone_list = Vec::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | / Self { [INFO] [stdout] 65 | | pitch, [INFO] [stdout] 66 | | tone_list, [INFO] [stdout] 67 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-piano` (bin "rust-piano") due to 7 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "131e669f20627a328bc61029081d00a69acbc4f54da308e94f274413a8cfbd2d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "131e669f20627a328bc61029081d00a69acbc4f54da308e94f274413a8cfbd2d", kill_on_drop: false }` [INFO] [stdout] 131e669f20627a328bc61029081d00a69acbc4f54da308e94f274413a8cfbd2d