[INFO] cloning repository https://github.com/S3r4f1n/logical_expr [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/S3r4f1n/logical_expr" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FS3r4f1n%2Flogical_expr", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FS3r4f1n%2Flogical_expr'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] cbe999fb0bd77a82c396c3e3fd694b499de4f438 [INFO] checking S3r4f1n/logical_expr/cbe999fb0bd77a82c396c3e3fd694b499de4f438 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FS3r4f1n%2Flogical_expr" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/S3r4f1n/logical_expr on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/S3r4f1n/logical_expr [INFO] finished tweaking git repo https://github.com/S3r4f1n/logical_expr [INFO] tweaked toml for git repo https://github.com/S3r4f1n/logical_expr written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/S3r4f1n/logical_expr already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e8394fd9d86fa98fded7172bacc32560be09635311f648a0b0658916680f3d09 [INFO] running `Command { std: "docker" "start" "-a" "e8394fd9d86fa98fded7172bacc32560be09635311f648a0b0658916680f3d09", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e8394fd9d86fa98fded7172bacc32560be09635311f648a0b0658916680f3d09", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e8394fd9d86fa98fded7172bacc32560be09635311f648a0b0658916680f3d09", kill_on_drop: false }` [INFO] [stdout] e8394fd9d86fa98fded7172bacc32560be09635311f648a0b0658916680f3d09 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 386cff4c857c7085c8f117e471926fbf8777c96bc21a1c30a611b07ae3f93331 [INFO] running `Command { std: "docker" "start" "-a" "386cff4c857c7085c8f117e471926fbf8777c96bc21a1c30a611b07ae3f93331", kill_on_drop: false }` [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking logical_expr v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/expression.rs:41:7 [INFO] [stdout] | [INFO] [stdout] 40 | UnaryOperator::Not => Ok(!rhs.evaluate()?), [INFO] [stdout] | ------------------ matches all the relevant values [INFO] [stdout] 41 | _ => Err(format!("Invalid unary operator for boolean: {:?}", op)) [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/expression.rs:41:7 [INFO] [stdout] | [INFO] [stdout] 40 | UnaryOperator::Not => Ok(!rhs.evaluate()?), [INFO] [stdout] | ------------------ matches all the relevant values [INFO] [stdout] 41 | _ => Err(format!("Invalid unary operator for boolean: {:?}", op)) [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression.rs:76:51 [INFO] [stdout] | [INFO] [stdout] 76 | |(op, _, value)| BooleanExpression::Unary(op, Box::new(value)) [INFO] [stdout] | -------------- ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression.rs:98:56 [INFO] [stdout] | [INFO] [stdout] 98 | |(lhs, _, op, _, rhs)| BooleanExpression::Binary(Box::new(lhs), op, Box::new(rhs)) [INFO] [stdout] | -------------------- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression.rs:98:75 [INFO] [stdout] | [INFO] [stdout] 98 | |(lhs, _, op, _, rhs)| BooleanExpression::Binary(Box::new(lhs), op, Box::new(rhs)) [INFO] [stdout] | -------------------- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression.rs:101:56 [INFO] [stdout] | [INFO] [stdout] 101 | |(lhs, _, op, _, rhs)| BooleanExpression::Binary(Box::new(lhs), op, Box::new(rhs)) [INFO] [stdout] | -------------------- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression.rs:101:75 [INFO] [stdout] | [INFO] [stdout] 101 | |(lhs, _, op, _, rhs)| BooleanExpression::Binary(Box::new(lhs), op, Box::new(rhs)) [INFO] [stdout] | -------------------- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression.rs:109:54 [INFO] [stdout] | [INFO] [stdout] 109 | |(lhs, _, op, _, rhs)| BooleanExpression::Binary(Box::new(lhs), op, Box::new(rhs)) [INFO] [stdout] | -------------------- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression.rs:109:73 [INFO] [stdout] | [INFO] [stdout] 109 | |(lhs, _, op, _, rhs)| BooleanExpression::Binary(Box::new(lhs), op, Box::new(rhs)) [INFO] [stdout] | -------------------- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression.rs:112:54 [INFO] [stdout] | [INFO] [stdout] 112 | |(lhs, _, op, _, rhs)| BooleanExpression::Binary(Box::new(lhs), op, Box::new(rhs)) [INFO] [stdout] | -------------------- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression.rs:112:73 [INFO] [stdout] | [INFO] [stdout] 112 | |(lhs, _, op, _, rhs)| BooleanExpression::Binary(Box::new(lhs), op, Box::new(rhs)) [INFO] [stdout] | -------------------- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression.rs:76:51 [INFO] [stdout] | [INFO] [stdout] 76 | |(op, _, value)| BooleanExpression::Unary(op, Box::new(value)) [INFO] [stdout] | -------------- ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression.rs:98:56 [INFO] [stdout] | [INFO] [stdout] 98 | |(lhs, _, op, _, rhs)| BooleanExpression::Binary(Box::new(lhs), op, Box::new(rhs)) [INFO] [stdout] | -------------------- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression.rs:98:75 [INFO] [stdout] | [INFO] [stdout] 98 | |(lhs, _, op, _, rhs)| BooleanExpression::Binary(Box::new(lhs), op, Box::new(rhs)) [INFO] [stdout] | -------------------- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression.rs:101:56 [INFO] [stdout] | [INFO] [stdout] 101 | |(lhs, _, op, _, rhs)| BooleanExpression::Binary(Box::new(lhs), op, Box::new(rhs)) [INFO] [stdout] | -------------------- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression.rs:101:75 [INFO] [stdout] | [INFO] [stdout] 101 | |(lhs, _, op, _, rhs)| BooleanExpression::Binary(Box::new(lhs), op, Box::new(rhs)) [INFO] [stdout] | -------------------- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression.rs:109:54 [INFO] [stdout] | [INFO] [stdout] 109 | |(lhs, _, op, _, rhs)| BooleanExpression::Binary(Box::new(lhs), op, Box::new(rhs)) [INFO] [stdout] | -------------------- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression.rs:109:73 [INFO] [stdout] | [INFO] [stdout] 109 | |(lhs, _, op, _, rhs)| BooleanExpression::Binary(Box::new(lhs), op, Box::new(rhs)) [INFO] [stdout] | -------------------- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression.rs:112:54 [INFO] [stdout] | [INFO] [stdout] 112 | |(lhs, _, op, _, rhs)| BooleanExpression::Binary(Box::new(lhs), op, Box::new(rhs)) [INFO] [stdout] | -------------------- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression.rs:112:73 [INFO] [stdout] | [INFO] [stdout] 112 | |(lhs, _, op, _, rhs)| BooleanExpression::Binary(Box::new(lhs), op, Box::new(rhs)) [INFO] [stdout] | -------------------- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `logical_expr` (lib) due to 10 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 9 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `logical_expr` (lib test) due to 10 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "386cff4c857c7085c8f117e471926fbf8777c96bc21a1c30a611b07ae3f93331", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "386cff4c857c7085c8f117e471926fbf8777c96bc21a1c30a611b07ae3f93331", kill_on_drop: false }` [INFO] [stdout] 386cff4c857c7085c8f117e471926fbf8777c96bc21a1c30a611b07ae3f93331