[INFO] cloning repository https://github.com/RustyYato/double-buffer [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/RustyYato/double-buffer" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRustyYato%2Fdouble-buffer", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRustyYato%2Fdouble-buffer'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0f931f9a779a3999d30eec75c70047e755f869af [INFO] checking RustyYato/double-buffer/0f931f9a779a3999d30eec75c70047e755f869af against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRustyYato%2Fdouble-buffer" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/RustyYato/double-buffer on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/RustyYato/double-buffer [INFO] finished tweaking git repo https://github.com/RustyYato/double-buffer [INFO] tweaked toml for git repo https://github.com/RustyYato/double-buffer written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/RustyYato/double-buffer already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bfe7780da04ba3d2d4a1da4b2e1c5cbfdedeecd2506f462fed7dfeae3bad7c33 [INFO] running `Command { std: "docker" "start" "-a" "bfe7780da04ba3d2d4a1da4b2e1c5cbfdedeecd2506f462fed7dfeae3bad7c33", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bfe7780da04ba3d2d4a1da4b2e1c5cbfdedeecd2506f462fed7dfeae3bad7c33", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bfe7780da04ba3d2d4a1da4b2e1c5cbfdedeecd2506f462fed7dfeae3bad7c33", kill_on_drop: false }` [INFO] [stdout] bfe7780da04ba3d2d4a1da4b2e1c5cbfdedeecd2506f462fed7dfeae3bad7c33 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b452caaaac67e59f8d37fabc8121c2d4142d5f5256864c7dbd940a61f11861c1 [INFO] running `Command { std: "docker" "start" "-a" "b452caaaac67e59f8d37fabc8121c2d4142d5f5256864c7dbd940a61f11861c1", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking rc-box v1.2.0 [INFO] [stderr] Checking triomphe v0.1.11 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking dbuf v0.1.0 (/opt/rustwide/workdir/dbuf) [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> dbuf/src/raw/reader.rs:192:13 [INFO] [stdout] | [INFO] [stdout] 192 | Err((_, err)) => match err {}, [INFO] [stdout] | ^^^^^^^^^^^^^ matches no values because `(reader::ReaderGuard<'_, T, P>, Infallible)` is uninhabited [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> dbuf/src/raw/reader.rs:221:13 [INFO] [stdout] | [INFO] [stdout] 221 | Err((_, err)) => match err {}, [INFO] [stdout] | ^^^^^^^^^^^^^ matches no values because `(reader::ReaderGuard<'_, T, P>, Infallible)` is uninhabited [INFO] [stdout] | [INFO] [stdout] = note: to learn more about uninhabited types, see https://doc.rust-lang.org/nomicon/exotic-sizes.html#empty-types [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> dbuf/src/ext/triomphe.rs:25:30 [INFO] [stdout] | [INFO] [stdout] 24 | fn into_writer(self) -> Self::Writer { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | Arc::into_raw_offset(self.shareable()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> dbuf/src/strategy/hazad_flash/hazard.rs:239:31 [INFO] [stdout] | [INFO] [stdout] 208 | pub fn get_or_insert_with(&self, f: impl FnMut() -> T) -> RawHazardGuard { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 239 | self.insert_with(&mut { f }) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> dbuf/src/delay.rs:92:30 [INFO] [stdout] | [INFO] [stdout] 91 | pub const fn from_writer(writer: raw::Writer

) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | Self { writer, swap: None } [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> dbuf/src/op.rs:32:27 [INFO] [stdout] | [INFO] [stdout] 31 | fn from(writer: raw::Writer

) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | Self::from_writer(writer.into()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> dbuf/src/op.rs:46:21 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn from_writer(writer: DelayWriter

) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | op_log: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> dbuf/src/op.rs:74:26 [INFO] [stdout] | [INFO] [stdout] 73 | pub fn push(&mut self, op: O) { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | self.op_log.push(SyncWrapper::new(op)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> dbuf/src/op.rs:94:28 [INFO] [stdout] | [INFO] [stdout] 93 | fn extend>(&mut self, iter: T) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | self.op_log.extend(iter.into_iter().map(SyncWrapper::new)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> dbuf/src/raw.rs:48:22 [INFO] [stdout] | [INFO] [stdout] 46 | pub const fn with_extras(back: T, front: T, strategy: S, extras: Extras) -> Self { [INFO] [stdout] | ------- -------- ----------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | Self { [INFO] [stdout] 48 | buffers: DoubleBufferCell { [INFO] [stdout] | ______________________^ [INFO] [stdout] 49 | | parts: [UnsafeCell::new(front), UnsafeCell::new(back)], [INFO] [stdout] 50 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> dbuf/src/raw/reader.rs:97:12 [INFO] [stdout] | [INFO] [stdout] 86 | let ptr = self.ptr.try_writer()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | let guard = unsafe { data.strategy.acquire_read_guard(&mut self.id) }; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | Ok(ReaderGuard { [INFO] [stdout] | ____________^ [INFO] [stdout] 98 | | ptr: RawReference { [INFO] [stdout] 99 | | // SAFETY: the pointer from ptr.buffers.get are always non-null [INFO] [stdout] 100 | | ptr: unsafe { NonNull::new_unchecked(reader.cast_mut()) }, [INFO] [stdout] ... | [INFO] [stdout] 112 | | }, [INFO] [stdout] 113 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> dbuf/src/raw/reader.rs:175:15 [INFO] [stdout] | [INFO] [stdout] 172 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | f: impl FnOnce(&T) -> Result<&U, E>, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | ) -> Result, (Self, E)> { [INFO] [stdout] 175 | match f(&self) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> dbuf/src/raw/reader.rs:190:15 [INFO] [stdout] | [INFO] [stdout] 189 | pub fn map(self, f: impl FnOnce(&T) -> &U) -> ReaderGuard<'a, U, P> { [INFO] [stdout] | ---- ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | match self.try_map::<_, core::convert::Infallible>(move |t| Ok(f(t))) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> dbuf/src/raw/reader.rs:201:15 [INFO] [stdout] | [INFO] [stdout] 198 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | f: impl for<'t> FnOnce(&'t T, &'t P::Extras) -> Result<&'t U, E>, [INFO] [stdout] | ---------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 200 | ) -> Result, (Self, E)> { [INFO] [stdout] 201 | match f(&self, self.extras()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> dbuf/src/raw/reader.rs:219:15 [INFO] [stdout] | [INFO] [stdout] 216 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | f: impl for<'t> FnOnce(&'t T, &'t P::Extras) -> &'t U, [INFO] [stdout] | ----------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | ) -> ReaderGuard<'a, U, P> { [INFO] [stdout] 219 | match self.try_map_with_extras::<_, core::convert::Infallible>(move |t, e| Ok(f(t, e))) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dbuf` (lib) due to 14 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "b452caaaac67e59f8d37fabc8121c2d4142d5f5256864c7dbd940a61f11861c1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b452caaaac67e59f8d37fabc8121c2d4142d5f5256864c7dbd940a61f11861c1", kill_on_drop: false }` [INFO] [stdout] b452caaaac67e59f8d37fabc8121c2d4142d5f5256864c7dbd940a61f11861c1