[INFO] cloning repository https://github.com/RustPanda/draw_triangle_without_error [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/RustPanda/draw_triangle_without_error" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRustPanda%2Fdraw_triangle_without_error", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRustPanda%2Fdraw_triangle_without_error'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b66208a4922895f1fd32338d207d0a5b4a3392a4 [INFO] checking RustPanda/draw_triangle_without_error/b66208a4922895f1fd32338d207d0a5b4a3392a4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRustPanda%2Fdraw_triangle_without_error" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/RustPanda/draw_triangle_without_error on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/RustPanda/draw_triangle_without_error [INFO] finished tweaking git repo https://github.com/RustPanda/draw_triangle_without_error [INFO] tweaked toml for git repo https://github.com/RustPanda/draw_triangle_without_error written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/RustPanda/draw_triangle_without_error already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1e5695a7399a4d65771b48fdacbf61ff8316646bd0e8105f2dff88107acb82e3 [INFO] running `Command { std: "docker" "start" "-a" "1e5695a7399a4d65771b48fdacbf61ff8316646bd0e8105f2dff88107acb82e3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1e5695a7399a4d65771b48fdacbf61ff8316646bd0e8105f2dff88107acb82e3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1e5695a7399a4d65771b48fdacbf61ff8316646bd0e8105f2dff88107acb82e3", kill_on_drop: false }` [INFO] [stdout] 1e5695a7399a4d65771b48fdacbf61ff8316646bd0e8105f2dff88107acb82e3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1dd7c29f9ca07007a512cb1721c661a3c84188251056b7c15a0d6b563aa9a836 [INFO] running `Command { std: "docker" "start" "-a" "1dd7c29f9ca07007a512cb1721c661a3c84188251056b7c15a0d6b563aa9a836", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.97 [INFO] [stderr] Compiling proc-macro2 v1.0.27 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling pkg-config v0.3.19 [INFO] [stderr] Checking libloading v0.7.0 [INFO] [stderr] Compiling xml-rs v0.8.3 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling memoffset v0.6.4 [INFO] [stderr] Compiling nom v6.2.1 [INFO] [stderr] Compiling crossbeam-epoch v0.9.5 [INFO] [stderr] Compiling syn v1.0.73 [INFO] [stderr] Checking downcast-rs v1.2.0 [INFO] [stderr] Checking ttf-parser v0.6.2 [INFO] [stderr] Compiling crossbeam-queue v0.3.2 [INFO] [stderr] Compiling nix v0.18.0 [INFO] [stderr] Checking dlib v0.5.0 [INFO] [stderr] Checking scoped-tls v1.0.0 [INFO] [stderr] Compiling cc v1.0.68 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.4 [INFO] [stderr] Checking instant v0.1.9 [INFO] [stderr] Checking libloading v0.6.7 [INFO] [stderr] Checking gimli v0.24.0 [INFO] [stderr] Checking xdg v2.2.0 [INFO] [stderr] Checking ash v0.32.1 [INFO] [stderr] Checking lock_api v0.4.4 [INFO] [stderr] Checking rustc-demangle v0.1.20 [INFO] [stderr] Compiling winit v0.25.0 (https://github.com/rust-windowing/winit.git#5a65347c) [INFO] [stderr] Checking dlib v0.4.2 [INFO] [stderr] Checking object v0.24.0 [INFO] [stderr] Compiling wayland-sys v0.28.6 [INFO] [stderr] Compiling x11-dl v2.18.5 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking crossbeam-deque v0.8.0 [INFO] [stderr] Compiling wayland-scanner v0.28.6 [INFO] [stderr] Checking crossbeam v0.8.1 [INFO] [stderr] Compiling backtrace v0.3.59 [INFO] [stderr] Checking owned_ttf_parser v0.6.0 [INFO] [stderr] Checking rusttype v0.9.2 [INFO] [stderr] Checking andrew v0.3.1 [INFO] [stderr] Checking nix v0.20.0 [INFO] [stderr] Checking mio v0.7.13 [INFO] [stderr] Checking parking_lot_core v0.8.3 [INFO] [stderr] Checking raw-window-handle v0.3.3 [INFO] [stderr] Checking memmap2 v0.1.0 [INFO] [stderr] Checking parking_lot v0.11.1 [INFO] [stderr] Checking mio-misc v1.2.1 [INFO] [stderr] Checking addr2line v0.15.2 [INFO] [stderr] Checking xcursor v0.3.3 [INFO] [stderr] Compiling wayland-client v0.28.6 [INFO] [stderr] Compiling wayland-protocols v0.28.6 [INFO] [stderr] Checking calloop v0.6.5 [INFO] [stderr] Checking wayland-commons v0.28.6 [INFO] [stderr] Compiling thiserror-impl v1.0.25 [INFO] [stderr] Checking thiserror v1.0.25 [INFO] [stderr] Checking wayland-cursor v0.28.6 [INFO] [stderr] Checking ash-window v0.6.0 [INFO] [stderr] Checking gpu-allocator v0.7.0 [INFO] [stderr] Checking smithay-client-toolkit v0.12.3 [INFO] [stderr] Checking winit-test v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `enable_layer_names` [INFO] [stdout] --> src/main.rs:185:13 [INFO] [stdout] | [INFO] [stdout] 185 | let enable_layer_names = vec![CString::new("VK_LAYER_KHRONOS_validation").unwrap()]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_enable_layer_names` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `enable_layer_names` [INFO] [stdout] --> src/main.rs:185:13 [INFO] [stdout] | [INFO] [stdout] 185 | let enable_layer_names = vec![CString::new("VK_LAYER_KHRONOS_validation").unwrap()]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_enable_layer_names` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/main.rs:55:17 [INFO] [stdout] | [INFO] [stdout] 55 | / &render [INFO] [stdout] 56 | | .device [INFO] [stdout] 57 | | .wait_for_fences(&wait_fences, true, std::u64::MAX) [INFO] [stdout] 58 | | .expect("Failed to wait for Fence!"); [INFO] [stdout] | |________________________________________________________^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 55 | let _ = &render [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/main.rs:55:17 [INFO] [stdout] | [INFO] [stdout] 55 | / &render [INFO] [stdout] 56 | | .device [INFO] [stdout] 57 | | .wait_for_fences(&wait_fences, true, std::u64::MAX) [INFO] [stdout] 58 | | .expect("Failed to wait for Fence!"); [INFO] [stdout] | |________________________________________________________^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 55 | let _ = &render [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/main.rs:135:13 [INFO] [stdout] | [INFO] [stdout] 135 | std::mem::drop(render); [INFO] [stdout] | ^^^^^^^^^^^^^^^------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&Render` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 135 - std::mem::drop(render); [INFO] [stdout] 135 + let _ = render; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/main.rs:135:13 [INFO] [stdout] | [INFO] [stdout] 135 | std::mem::drop(render); [INFO] [stdout] | ^^^^^^^^^^^^^^^------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&Render` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 135 - std::mem::drop(render); [INFO] [stdout] 135 + let _ = render; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:153:20 [INFO] [stdout] | [INFO] [stdout] 144 | let event_loop = event_loop::EventLoop::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | [INFO] [stdout] 146 | let window = window::WindowBuilder::new() [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 151 | let render = Render::new(&window).unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | [INFO] [stdout] 153 | event_loop.run(move |event, target, control_flow| { [INFO] [stdout] | ____________________^ [INFO] [stdout] 154 | | event_handler(event, target, control_flow, &window, &render) [INFO] [stdout] 155 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:153:20 [INFO] [stdout] | [INFO] [stdout] 144 | let event_loop = event_loop::EventLoop::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | [INFO] [stdout] 146 | let window = window::WindowBuilder::new() [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 151 | let render = Render::new(&window).unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | [INFO] [stdout] 153 | event_loop.run(move |event, target, control_flow| { [INFO] [stdout] | ____________________^ [INFO] [stdout] 154 | | event_handler(event, target, control_flow, &window, &render) [INFO] [stdout] 155 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:235:12 [INFO] [stdout] | [INFO] [stdout] 180 | let entry = unsafe { Entry::new() }?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 185 | let enable_layer_names = vec![CString::new("VK_LAYER_KHRONOS_validation").unwrap()]; [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 235 | Ok(Render { [INFO] [stdout] | ____________^ [INFO] [stdout] 236 | | _entry: entry, [INFO] [stdout] 237 | | instance, [INFO] [stdout] 238 | | debug_utils, [INFO] [stdout] ... | [INFO] [stdout] 252 | | current_frame: Cell::new(0), [INFO] [stdout] 253 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:235:12 [INFO] [stdout] | [INFO] [stdout] 180 | let entry = unsafe { Entry::new() }?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 185 | let enable_layer_names = vec![CString::new("VK_LAYER_KHRONOS_validation").unwrap()]; [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 235 | Ok(Render { [INFO] [stdout] | ____________^ [INFO] [stdout] 236 | | _entry: entry, [INFO] [stdout] 237 | | instance, [INFO] [stdout] 238 | | debug_utils, [INFO] [stdout] ... | [INFO] [stdout] 252 | | current_frame: Cell::new(0), [INFO] [stdout] 253 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `winit-test` (bin "winit-test") due to 3 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `winit-test` (bin "winit-test" test) due to 3 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "1dd7c29f9ca07007a512cb1721c661a3c84188251056b7c15a0d6b563aa9a836", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1dd7c29f9ca07007a512cb1721c661a3c84188251056b7c15a0d6b563aa9a836", kill_on_drop: false }` [INFO] [stdout] 1dd7c29f9ca07007a512cb1721c661a3c84188251056b7c15a0d6b563aa9a836