[INFO] cloning repository https://github.com/RusTit/tcp_router_first [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/RusTit/tcp_router_first" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRusTit%2Ftcp_router_first", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRusTit%2Ftcp_router_first'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d6cffd4911a31efb284d9544ce3a42d805634eeb [INFO] checking RusTit/tcp_router_first/d6cffd4911a31efb284d9544ce3a42d805634eeb against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRusTit%2Ftcp_router_first" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/RusTit/tcp_router_first on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/RusTit/tcp_router_first [INFO] finished tweaking git repo https://github.com/RusTit/tcp_router_first [INFO] tweaked toml for git repo https://github.com/RusTit/tcp_router_first written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/RusTit/tcp_router_first already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 13a29ad0889c68188b65e58f75c22f57f7cbdae31be5c5071f334d72a9060010 [INFO] running `Command { std: "docker" "start" "-a" "13a29ad0889c68188b65e58f75c22f57f7cbdae31be5c5071f334d72a9060010", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "13a29ad0889c68188b65e58f75c22f57f7cbdae31be5c5071f334d72a9060010", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "13a29ad0889c68188b65e58f75c22f57f7cbdae31be5c5071f334d72a9060010", kill_on_drop: false }` [INFO] [stdout] 13a29ad0889c68188b65e58f75c22f57f7cbdae31be5c5071f334d72a9060010 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 19ba67d5aa666d1e5dbfae68e198d65926a1e4d2336ca91d89abbd5771cced16 [INFO] running `Command { std: "docker" "start" "-a" "19ba67d5aa666d1e5dbfae68e198d65926a1e4d2336ca91d89abbd5771cced16", kill_on_drop: false }` [INFO] [stderr] Checking tcp_router_first v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:37:23 [INFO] [stdout] | [INFO] [stdout] 36 | fn create_tcp_server_thread(tx: mpsc::Sender) -> thread::JoinHandle<()> { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 38 | | let tcp_listner = TcpListener::bind("127.0.0.1:3000"); [INFO] [stdout] 39 | | match tcp_listner { [INFO] [stdout] 40 | | Ok(tcp_listner) => { [INFO] [stdout] ... | [INFO] [stdout] 56 | | } [INFO] [stdout] 57 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:100:23 [INFO] [stdout] | [INFO] [stdout] 99 | fn create_tcp_client_thread(tx: mpsc::Sender) -> thread::JoinHandle<()> { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 101 | | let socket = TcpStream::connect("127.0.0.1:8000"); [INFO] [stdout] 102 | | match socket { [INFO] [stdout] 103 | | Ok(mut socket) => App::process_client_socket(&mut socket, &tx), [INFO] [stdout] ... | [INFO] [stdout] 106 | | tx.send(AppEvent::TcpConnectionLost).unwrap(); [INFO] [stdout] 107 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:115:23 [INFO] [stdout] | [INFO] [stdout] 111 | tx_clients: mpsc::Sender, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | rx_clients: mpsc::Receiver, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 116 | | let mut sockets: Vec = Vec::new(); [INFO] [stdout] 117 | | loop { [INFO] [stdout] 118 | | let ev = rx_clients.recv().unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 143 | | } [INFO] [stdout] 144 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tcp_router_first` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:37:23 [INFO] [stdout] | [INFO] [stdout] 36 | fn create_tcp_server_thread(tx: mpsc::Sender) -> thread::JoinHandle<()> { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 38 | | let tcp_listner = TcpListener::bind("127.0.0.1:3000"); [INFO] [stdout] 39 | | match tcp_listner { [INFO] [stdout] 40 | | Ok(tcp_listner) => { [INFO] [stdout] ... | [INFO] [stdout] 56 | | } [INFO] [stdout] 57 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:100:23 [INFO] [stdout] | [INFO] [stdout] 99 | fn create_tcp_client_thread(tx: mpsc::Sender) -> thread::JoinHandle<()> { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 101 | | let socket = TcpStream::connect("127.0.0.1:8000"); [INFO] [stdout] 102 | | match socket { [INFO] [stdout] 103 | | Ok(mut socket) => App::process_client_socket(&mut socket, &tx), [INFO] [stdout] ... | [INFO] [stdout] 106 | | tx.send(AppEvent::TcpConnectionLost).unwrap(); [INFO] [stdout] 107 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:115:23 [INFO] [stdout] | [INFO] [stdout] 111 | tx_clients: mpsc::Sender, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | rx_clients: mpsc::Receiver, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 116 | | let mut sockets: Vec = Vec::new(); [INFO] [stdout] 117 | | loop { [INFO] [stdout] 118 | | let ev = rx_clients.recv().unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 143 | | } [INFO] [stdout] 144 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tcp_router_first` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "19ba67d5aa666d1e5dbfae68e198d65926a1e4d2336ca91d89abbd5771cced16", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "19ba67d5aa666d1e5dbfae68e198d65926a1e4d2336ca91d89abbd5771cced16", kill_on_drop: false }` [INFO] [stdout] 19ba67d5aa666d1e5dbfae68e198d65926a1e4d2336ca91d89abbd5771cced16