[INFO] cloning repository https://github.com/RuedigerLudwig/advent2023_rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/RuedigerLudwig/advent2023_rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRuedigerLudwig%2Fadvent2023_rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRuedigerLudwig%2Fadvent2023_rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a1f2fb2a14fd1dc2fd97f7192b8deba9c77f1547 [INFO] checking RuedigerLudwig/advent2023_rust/a1f2fb2a14fd1dc2fd97f7192b8deba9c77f1547 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRuedigerLudwig%2Fadvent2023_rust" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/RuedigerLudwig/advent2023_rust on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-4-tc2/source/rust-toolchain [INFO] started tweaking git repo https://github.com/RuedigerLudwig/advent2023_rust [INFO] finished tweaking git repo https://github.com/RuedigerLudwig/advent2023_rust [INFO] tweaked toml for git repo https://github.com/RuedigerLudwig/advent2023_rust written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/RuedigerLudwig/advent2023_rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: unused manifest key: dependencies.blas-src.featur0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e122638d231977247c97fcffaf878cba54ee35270a34303a4dee0e47085c3043 [INFO] running `Command { std: "docker" "start" "-a" "e122638d231977247c97fcffaf878cba54ee35270a34303a4dee0e47085c3043", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e122638d231977247c97fcffaf878cba54ee35270a34303a4dee0e47085c3043", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e122638d231977247c97fcffaf878cba54ee35270a34303a4dee0e47085c3043", kill_on_drop: false }` [INFO] [stdout] e122638d231977247c97fcffaf878cba54ee35270a34303a4dee0e47085c3043 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b96cc4efca949f91b2e9e3bc8e8c0c91245d83d64ae727c5eb5c5bfc7666a8b5 [INFO] running `Command { std: "docker" "start" "-a" "b96cc4efca949f91b2e9e3bc8e8c0c91245d83d64ae727c5eb5c5bfc7666a8b5", kill_on_drop: false }` [INFO] [stderr] warning: unused manifest key: dependencies.blas-src.featur0 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling cc v1.0.90 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Compiling bitflags v2.4.2 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling thiserror v1.0.58 [INFO] [stderr] Compiling tinyvec_macros v0.1.1 [INFO] [stderr] Compiling tinyvec v1.6.0 [INFO] [stderr] Compiling crc32fast v1.4.0 [INFO] [stderr] Compiling openssl v0.10.64 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Compiling foreign-types-shared v0.1.1 [INFO] [stderr] Compiling foreign-types v0.3.2 [INFO] [stderr] Compiling adler v1.0.2 [INFO] [stderr] Compiling base64 v0.21.7 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling unicode-normalization v0.1.23 [INFO] [stderr] Compiling rustls-pki-types v1.3.1 [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Compiling openssl-probe v0.1.5 [INFO] [stderr] Compiling openssl-sys v0.9.101 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling unicode-bidi v0.3.15 [INFO] [stderr] Compiling linux-raw-sys v0.4.13 [INFO] [stderr] Compiling percent-encoding v2.3.1 [INFO] [stderr] Compiling anyhow v1.0.81 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling form_urlencoded v1.2.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling rustls-pemfile v2.1.1 [INFO] [stderr] Compiling miniz_oxide v0.7.2 [INFO] [stderr] Compiling idna v0.5.0 [INFO] [stderr] Compiling log v0.4.21 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling rustls-native-certs v0.7.0 [INFO] [stderr] Compiling url v2.5.0 [INFO] [stderr] Compiling filetime v0.2.23 [INFO] [stderr] Compiling flate2 v1.0.28 [INFO] [stderr] Compiling cmake v0.1.50 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling same-file v1.0.6 [INFO] [stderr] Compiling walkdir v2.5.0 [INFO] [stderr] Compiling dirs-sys v0.3.7 [INFO] [stderr] Compiling matrixmultiply v0.3.8 [INFO] [stderr] Compiling netlib-src v0.8.0 [INFO] [stderr] Compiling dirs v3.0.2 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking approx v0.4.0 [INFO] [stderr] Checking lapack-sys v0.14.0 [INFO] [stderr] Checking cblas-sys v0.1.4 [INFO] [stderr] Checking either v1.10.0 [INFO] [stderr] Checking blas-src v0.10.0 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Compiling xattr v1.3.1 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling tar v0.4.40 [INFO] [stderr] Checking num-complex v0.4.5 [INFO] [stderr] Checking cauchy v0.4.0 [INFO] [stderr] Checking ndarray v0.15.6 [INFO] [stderr] Compiling katexit v0.1.4 [INFO] [stderr] Checking lax v0.16.0 [INFO] [stderr] Compiling ureq v2.9.6 [INFO] [stderr] Checking ndarray-linalg v0.16.0 [INFO] [stderr] Compiling openblas-build v0.10.9 [INFO] [stderr] Compiling openblas-src v0.10.9 [INFO] [stderr] Checking advent2023 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `common::matrix3::Matrix3` [INFO] [stdout] --> src/days/day24/mod.rs:165:9 [INFO] [stdout] | [INFO] [stdout] 165 | common::matrix3::Matrix3, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ndarray::prelude::*` [INFO] [stdout] --> src/days/day24/mod.rs:168:9 [INFO] [stdout] | [INFO] [stdout] 168 | use ndarray::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ndarray_linalg::Solve` [INFO] [stdout] --> src/days/day24/mod.rs:169:9 [INFO] [stdout] | [INFO] [stdout] 169 | use ndarray_linalg::Solve; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/days/day24/mod.rs:22:21 [INFO] [stdout] | [INFO] [stdout] 22 | fn part2(&self, input: &str) -> RResult { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/helper.rs:16:11 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn zip3(o1: Option, o2: Option, o3: Option) -> Option<(A, B, C)> { [INFO] [stdout] | ------------- ------------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | match (o1, o2, o3) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/helper.rs:28:11 [INFO] [stdout] | [INFO] [stdout] 23 | o1: Option, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | o2: Option, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | o3: Option, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | o4: Option, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | ) -> Option<(A, B, C, D)> { [INFO] [stdout] 28 | match (o1, o2, o3, o4) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/helper.rs:41:11 [INFO] [stdout] | [INFO] [stdout] 35 | o1: Option, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | o2: Option, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | o3: Option, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | o4: Option, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | o5: Option, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | ) -> Option<(A, B, C, D, E)> { [INFO] [stdout] 41 | match (o1, o2, o3, o4, o5) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/helper.rs:55:11 [INFO] [stdout] | [INFO] [stdout] 48 | o1: Option, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | o2: Option, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | o3: Option, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | o4: Option, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | o5: Option, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | o6: Option, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | ) -> Option<(A, B, C, D, E, F)> { [INFO] [stdout] 55 | match (o1, o2, o3, o4, o5, o6) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/helper.rs:70:11 [INFO] [stdout] | [INFO] [stdout] 62 | o1: Option, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | o2: Option, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | o3: Option, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | o4: Option, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | o5: Option, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | o6: Option, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | o7: Option, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | ) -> Option<(A, B, C, D, E, F, G)> { [INFO] [stdout] 70 | match (o1, o2, o3, o4, o5, o6, o7) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/pos2.rs:194:9 [INFO] [stdout] | [INFO] [stdout] 193 | pub fn abs(self) -> T { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | self.x.abs() + self.y.abs() [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/pos2.rs:194:24 [INFO] [stdout] | [INFO] [stdout] 193 | pub fn abs(self) -> T { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | self.x.abs() + self.y.abs() [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/pos2.rs:237:22 [INFO] [stdout] | [INFO] [stdout] 236 | pub fn new_x(x: T) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 237 | Self::new(x, T::zero()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/pos2.rs:242:19 [INFO] [stdout] | [INFO] [stdout] 241 | pub fn new_y(y: T) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 242 | Self::new(T::zero(), y) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/pos2.rs:394:55 [INFO] [stdout] | [INFO] [stdout] 392 | pub fn safe_matrix_set(&self, mat: &mut [Vec], new_value: A) { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 393 | mat.get_mut(self.y()) [INFO] [stdout] 394 | .and_then(|row| row.get_mut(self.x()).map(|val| *val = new_value)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/pos3.rs:194:9 [INFO] [stdout] | [INFO] [stdout] 193 | pub fn abs(self) -> T { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | self.x.abs() + self.y.abs() + self.z.abs() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/pos3.rs:194:39 [INFO] [stdout] | [INFO] [stdout] 193 | pub fn abs(self) -> T { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | self.x.abs() + self.y.abs() + self.z.abs() [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/days/day07/mod.rs:250:12 [INFO] [stdout] | [INFO] [stdout] 249 | let hands = s.lines().map(|line| line.parse()).try_collect()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 250 | Ok(Self { hands }) [INFO] [stdout] | ^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/days/day07/mod.rs:265:12 [INFO] [stdout] | [INFO] [stdout] 261 | let cards: Vec<_> = hand.chars().map(C::from_char).try_collect()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 265 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 266 | | cards, [INFO] [stdout] 267 | | value: value.parse()?, [INFO] [stdout] 268 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/days/day16/mod.rs:83:5 [INFO] [stdout] | [INFO] [stdout] 79 | fn first_item(tuples: impl IntoIterator) -> HashSet [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | tuples.into_iter().map(|(a, _)| a).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/days/mod.rs:66:37 [INFO] [stdout] | [INFO] [stdout] 66 | (1..=MAX_DAY).map(|day_num| get_day(day_num).expect("Must never happen")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `input` [INFO] [stdout] --> src/days/day24/mod.rs:22:21 [INFO] [stdout] | [INFO] [stdout] 22 | fn part2(&self, input: &str) -> RResult { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_input` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `advent2023` (bin "advent2023") due to 17 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `s1` [INFO] [stdout] --> src/days/day24/mod.rs:219:13 [INFO] [stdout] | [INFO] [stdout] 219 | let s1 = &storm.stones[0]; [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_s1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `s2` [INFO] [stdout] --> src/days/day24/mod.rs:220:13 [INFO] [stdout] | [INFO] [stdout] 220 | let s2 = &storm.stones[1]; [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_s2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `s3` [INFO] [stdout] --> src/days/day24/mod.rs:221:13 [INFO] [stdout] | [INFO] [stdout] 221 | let s3 = &storm.stones[2]; [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_s3` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/helper.rs:16:11 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn zip3(o1: Option, o2: Option, o3: Option) -> Option<(A, B, C)> { [INFO] [stdout] | ------------- ------------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | match (o1, o2, o3) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/helper.rs:28:11 [INFO] [stdout] | [INFO] [stdout] 23 | o1: Option, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | o2: Option, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | o3: Option, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | o4: Option, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | ) -> Option<(A, B, C, D)> { [INFO] [stdout] 28 | match (o1, o2, o3, o4) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/helper.rs:41:11 [INFO] [stdout] | [INFO] [stdout] 35 | o1: Option, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | o2: Option, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | o3: Option, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | o4: Option, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | o5: Option, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | ) -> Option<(A, B, C, D, E)> { [INFO] [stdout] 41 | match (o1, o2, o3, o4, o5) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/helper.rs:55:11 [INFO] [stdout] | [INFO] [stdout] 48 | o1: Option, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | o2: Option, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | o3: Option, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | o4: Option, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | o5: Option, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | o6: Option, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | ) -> Option<(A, B, C, D, E, F)> { [INFO] [stdout] 55 | match (o1, o2, o3, o4, o5, o6) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/helper.rs:70:11 [INFO] [stdout] | [INFO] [stdout] 62 | o1: Option, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | o2: Option, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | o3: Option, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | o4: Option, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | o5: Option, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | o6: Option, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | o7: Option, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | ) -> Option<(A, B, C, D, E, F, G)> { [INFO] [stdout] 70 | match (o1, o2, o3, o4, o5, o6, o7) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/pos2.rs:194:9 [INFO] [stdout] | [INFO] [stdout] 193 | pub fn abs(self) -> T { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | self.x.abs() + self.y.abs() [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/pos2.rs:194:24 [INFO] [stdout] | [INFO] [stdout] 193 | pub fn abs(self) -> T { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | self.x.abs() + self.y.abs() [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/pos2.rs:237:22 [INFO] [stdout] | [INFO] [stdout] 236 | pub fn new_x(x: T) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 237 | Self::new(x, T::zero()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/pos2.rs:242:19 [INFO] [stdout] | [INFO] [stdout] 241 | pub fn new_y(y: T) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 242 | Self::new(T::zero(), y) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/pos2.rs:394:55 [INFO] [stdout] | [INFO] [stdout] 392 | pub fn safe_matrix_set(&self, mat: &mut [Vec], new_value: A) { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 393 | mat.get_mut(self.y()) [INFO] [stdout] 394 | .and_then(|row| row.get_mut(self.x()).map(|val| *val = new_value)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/pos3.rs:194:9 [INFO] [stdout] | [INFO] [stdout] 193 | pub fn abs(self) -> T { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | self.x.abs() + self.y.abs() + self.z.abs() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/pos3.rs:194:39 [INFO] [stdout] | [INFO] [stdout] 193 | pub fn abs(self) -> T { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | self.x.abs() + self.y.abs() + self.z.abs() [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/days/day07/mod.rs:250:12 [INFO] [stdout] | [INFO] [stdout] 249 | let hands = s.lines().map(|line| line.parse()).try_collect()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 250 | Ok(Self { hands }) [INFO] [stdout] | ^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/days/day07/mod.rs:265:12 [INFO] [stdout] | [INFO] [stdout] 261 | let cards: Vec<_> = hand.chars().map(C::from_char).try_collect()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 265 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 266 | | cards, [INFO] [stdout] 267 | | value: value.parse()?, [INFO] [stdout] 268 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/days/day16/mod.rs:83:5 [INFO] [stdout] | [INFO] [stdout] 79 | fn first_item(tuples: impl IntoIterator) -> HashSet [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | tuples.into_iter().map(|(a, _)| a).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/days/mod.rs:66:37 [INFO] [stdout] | [INFO] [stdout] 66 | (1..=MAX_DAY).map(|day_num| get_day(day_num).expect("Must never happen")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `advent2023` (bin "advent2023" test) due to 17 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b96cc4efca949f91b2e9e3bc8e8c0c91245d83d64ae727c5eb5c5bfc7666a8b5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b96cc4efca949f91b2e9e3bc8e8c0c91245d83d64ae727c5eb5c5bfc7666a8b5", kill_on_drop: false }` [INFO] [stdout] b96cc4efca949f91b2e9e3bc8e8c0c91245d83d64ae727c5eb5c5bfc7666a8b5