[INFO] cloning repository https://github.com/RubyUmbra/gallery-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/RubyUmbra/gallery-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRubyUmbra%2Fgallery-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRubyUmbra%2Fgallery-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0e8428b75a0ce6b06bb08d73fbadb14571ad799d [INFO] checking RubyUmbra/gallery-rs/0e8428b75a0ce6b06bb08d73fbadb14571ad799d against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRubyUmbra%2Fgallery-rs" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/RubyUmbra/gallery-rs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/RubyUmbra/gallery-rs [INFO] finished tweaking git repo https://github.com/RubyUmbra/gallery-rs [INFO] tweaked toml for git repo https://github.com/RubyUmbra/gallery-rs written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/RubyUmbra/gallery-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0b8d3bc3f926cf197c91bd8d053654eec1b22d3bc12b9c1e9693bdbe14edeeed [INFO] running `Command { std: "docker" "start" "-a" "0b8d3bc3f926cf197c91bd8d053654eec1b22d3bc12b9c1e9693bdbe14edeeed", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0b8d3bc3f926cf197c91bd8d053654eec1b22d3bc12b9c1e9693bdbe14edeeed", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0b8d3bc3f926cf197c91bd8d053654eec1b22d3bc12b9c1e9693bdbe14edeeed", kill_on_drop: false }` [INFO] [stdout] 0b8d3bc3f926cf197c91bd8d053654eec1b22d3bc12b9c1e9693bdbe14edeeed [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ede247117ec4d8f078fcce44b0070a8ab5e8a07fca9b8b14eb3d05f78a4840c3 [INFO] running `Command { std: "docker" "start" "-a" "ede247117ec4d8f078fcce44b0070a8ab5e8a07fca9b8b14eb3d05f78a4840c3", kill_on_drop: false }` [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling libc v0.2.99 [INFO] [stderr] Compiling version-compare v0.0.10 [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Compiling cfg-if v0.1.10 [INFO] [stderr] Compiling syn v1.0.74 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Compiling cc v1.0.69 [INFO] [stderr] Checking gimli v0.25.0 [INFO] [stderr] Compiling sdl2-sys v0.34.5 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking object v0.26.0 [INFO] [stderr] Compiling error-chain v0.12.4 [INFO] [stderr] Compiling sdl2 v0.34.5 [INFO] [stderr] Checking rustc-demangle v0.1.20 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking textwrap v0.14.2 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking os_str_bytes v3.1.0 [INFO] [stderr] Checking imagesize v0.8.8 [INFO] [stderr] Compiling backtrace v0.3.61 [INFO] [stderr] Checking addr2line v0.16.0 [INFO] [stderr] Compiling clap_derive v3.0.0-beta.4 [INFO] [stderr] Checking clap v3.0.0-beta.4 [INFO] [stderr] Checking gallery-rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gui.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 18 | let sdl_context = sdl2::init()?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let video_subsystem = sdl_context.video()?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | let _image_context = sdl2::image::init(InitFlag::PNG | InitFlag::JPG)?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let display_bounds = video_subsystem.display_bounds(0)?; [INFO] [stdout] 27 | let window = video_subsystem [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | let canvas = window.into_canvas().software().build()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let texture_creator = canvas.texture_creator(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | [INFO] [stdout] 35 | Ok(GuiContext { [INFO] [stdout] | ____________^ [INFO] [stdout] 36 | | sdl_context, [INFO] [stdout] 37 | | display_bounds, [INFO] [stdout] 38 | | canvas, [INFO] [stdout] 39 | | texture_creator, [INFO] [stdout] 40 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/image_storage.rs:21:31 [INFO] [stdout] | [INFO] [stdout] 21 | .filter_map(|res| res.map(|entry| entry.path()).ok()) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gallery-rs` (lib test) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gui.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 18 | let sdl_context = sdl2::init()?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let video_subsystem = sdl_context.video()?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | let _image_context = sdl2::image::init(InitFlag::PNG | InitFlag::JPG)?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let display_bounds = video_subsystem.display_bounds(0)?; [INFO] [stdout] 27 | let window = video_subsystem [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | let canvas = window.into_canvas().software().build()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let texture_creator = canvas.texture_creator(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | [INFO] [stdout] 35 | Ok(GuiContext { [INFO] [stdout] | ____________^ [INFO] [stdout] 36 | | sdl_context, [INFO] [stdout] 37 | | display_bounds, [INFO] [stdout] 38 | | canvas, [INFO] [stdout] 39 | | texture_creator, [INFO] [stdout] 40 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/image_storage.rs:21:31 [INFO] [stdout] | [INFO] [stdout] 21 | .filter_map(|res| res.map(|entry| entry.path()).ok()) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gallery-rs` (lib) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "ede247117ec4d8f078fcce44b0070a8ab5e8a07fca9b8b14eb3d05f78a4840c3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ede247117ec4d8f078fcce44b0070a8ab5e8a07fca9b8b14eb3d05f78a4840c3", kill_on_drop: false }` [INFO] [stdout] ede247117ec4d8f078fcce44b0070a8ab5e8a07fca9b8b14eb3d05f78a4840c3