[INFO] cloning repository https://github.com/RuairidhWilliamson/todl [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/RuairidhWilliamson/todl" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRuairidhWilliamson%2Ftodl", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRuairidhWilliamson%2Ftodl'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 864f904b49302564cb69afdbc0ef3cdf51d4f9cf [INFO] checking RuairidhWilliamson/todl/864f904b49302564cb69afdbc0ef3cdf51d4f9cf against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRuairidhWilliamson%2Ftodl" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/RuairidhWilliamson/todl on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/RuairidhWilliamson/todl [INFO] finished tweaking git repo https://github.com/RuairidhWilliamson/todl [INFO] tweaked toml for git repo https://github.com/RuairidhWilliamson/todl written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/RuairidhWilliamson/todl already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1641cf8a008e857d9ddd1e949c463d85685de4df8b36b26e1d8fcc27fba95e0e [INFO] running `Command { std: "docker" "start" "-a" "1641cf8a008e857d9ddd1e949c463d85685de4df8b36b26e1d8fcc27fba95e0e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1641cf8a008e857d9ddd1e949c463d85685de4df8b36b26e1d8fcc27fba95e0e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1641cf8a008e857d9ddd1e949c463d85685de4df8b36b26e1d8fcc27fba95e0e", kill_on_drop: false }` [INFO] [stdout] 1641cf8a008e857d9ddd1e949c463d85685de4df8b36b26e1d8fcc27fba95e0e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c5fed2343d4aae074d2fd8f2227be0ded8a12f0565897b70bbb43efa63e3868a [INFO] running `Command { std: "docker" "start" "-a" "c5fed2343d4aae074d2fd8f2227be0ded8a12f0565897b70bbb43efa63e3868a", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling serde v1.0.183 [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Compiling rustix v0.38.8 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Checking linux-raw-sys v0.4.5 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Compiling serde_derive v1.0.183 [INFO] [stderr] Compiling num-traits v0.2.16 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Compiling serde_json v1.0.104 [INFO] [stderr] Checking aho-corasick v1.0.3 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking smallvec v1.11.0 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking regex-syntax v0.7.4 [INFO] [stderr] Checking lock_api v0.4.10 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Compiling rayon-core v1.11.0 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking walkdir v2.3.3 [INFO] [stderr] Checking plotters-backend v0.3.5 [INFO] [stderr] Checking ciborium-io v0.2.1 [INFO] [stderr] Checking os_str_bytes v6.5.1 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Checking iana-time-zone v0.1.57 [INFO] [stderr] Checking textwrap v0.16.0 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking parking_lot_core v0.9.8 [INFO] [stderr] Checking crossbeam-channel v0.5.8 [INFO] [stderr] Compiling jobserver v0.1.26 [INFO] [stderr] Compiling quote v1.0.32 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Compiling syn v2.0.28 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Checking plotters-svg v0.3.5 [INFO] [stderr] Checking ciborium-ll v0.2.1 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Compiling cc v1.0.82 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking crossterm v0.26.1 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking anstream v0.3.2 [INFO] [stderr] Checking clap_builder v4.3.21 [INFO] [stderr] Checking chrono v0.4.26 [INFO] [stderr] Checking plotters v0.3.5 [INFO] [stderr] Checking rayon v1.7.0 [INFO] [stderr] Checking regex-automata v0.3.6 [INFO] [stderr] Compiling openssl-sys v0.9.91 [INFO] [stderr] Compiling libz-sys v1.1.12 [INFO] [stderr] Compiling libssh2-sys v0.2.23 [INFO] [stderr] Compiling libgit2-sys v0.14.2+1.5.1 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking ciborium v0.2.1 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Compiling clap_derive v4.3.12 [INFO] [stderr] Checking regex v1.9.3 [INFO] [stderr] Checking criterion v0.4.0 [INFO] [stderr] Checking clap v4.3.21 [INFO] [stderr] Checking git2 v0.16.1 [INFO] [stderr] Checking todl v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:105:5 [INFO] [stdout] | [INFO] [stdout] 95 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | let repository = open_inside_repository(&path); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | let repository2 = open_inside_repository(&path); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | / WalkDir::new(path) [INFO] [stdout] 106 | | .into_iter() [INFO] [stdout] 107 | | .filter_map(|e| e.ok()) [INFO] [stdout] 108 | | .filter(|e| e.file_type().is_file()) [INFO] [stdout] ... | [INFO] [stdout] 125 | | }) [INFO] [stdout] 126 | | .flatten() [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:127:14 [INFO] [stdout] | [INFO] [stdout] 95 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | let repository = open_inside_repository(&path); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | let repository2 = open_inside_repository(&path); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | .map(move |mut tag| { [INFO] [stdout] | ______________^ [INFO] [stdout] 128 | | if git_blame { [INFO] [stdout] 129 | | if let Some(repo) = &repository2 { [INFO] [stdout] 130 | | tag.git_info = tag.get_blame_info(repo); [INFO] [stdout] ... | [INFO] [stdout] 133 | | tag [INFO] [stdout] 134 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:124:18 [INFO] [stdout] | [INFO] [stdout] 98 | let repository = open_inside_repository(&path); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | let Ok(file) = File::open(e.path()) else { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | Some(SourceFile::new(kind, e.path(), file)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source.rs:49:20 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn new(kind: SourceKind, path: &Path, reader: R) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | inner: BufReader::new(reader), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:105:5 [INFO] [stdout] | [INFO] [stdout] 95 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | let repository = open_inside_repository(&path); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | let repository2 = open_inside_repository(&path); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | / WalkDir::new(path) [INFO] [stdout] 106 | | .into_iter() [INFO] [stdout] 107 | | .filter_map(|e| e.ok()) [INFO] [stdout] 108 | | .filter(|e| e.file_type().is_file()) [INFO] [stdout] ... | [INFO] [stdout] 125 | | }) [INFO] [stdout] 126 | | .flatten() [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:127:14 [INFO] [stdout] | [INFO] [stdout] 95 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | let repository = open_inside_repository(&path); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | let repository2 = open_inside_repository(&path); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | .map(move |mut tag| { [INFO] [stdout] | ______________^ [INFO] [stdout] 128 | | if git_blame { [INFO] [stdout] 129 | | if let Some(repo) = &repository2 { [INFO] [stdout] 130 | | tag.git_info = tag.get_blame_info(repo); [INFO] [stdout] ... | [INFO] [stdout] 133 | | tag [INFO] [stdout] 134 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:124:18 [INFO] [stdout] | [INFO] [stdout] 98 | let repository = open_inside_repository(&path); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | let Ok(file) = File::open(e.path()) else { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | Some(SourceFile::new(kind, e.path(), file)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/source.rs:49:20 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn new(kind: SourceKind, path: &Path, reader: R) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | inner: BufReader::new(reader), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `todl` (lib test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `todl` (lib) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "c5fed2343d4aae074d2fd8f2227be0ded8a12f0565897b70bbb43efa63e3868a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c5fed2343d4aae074d2fd8f2227be0ded8a12f0565897b70bbb43efa63e3868a", kill_on_drop: false }` [INFO] [stdout] c5fed2343d4aae074d2fd8f2227be0ded8a12f0565897b70bbb43efa63e3868a