[INFO] cloning repository https://github.com/RomanHargrave/lyrebird [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/RomanHargrave/lyrebird" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRomanHargrave%2Flyrebird", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRomanHargrave%2Flyrebird'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 56ff516febdde9b6d0d05dcf6225f935db9b1163 [INFO] checking RomanHargrave/lyrebird/56ff516febdde9b6d0d05dcf6225f935db9b1163 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRomanHargrave%2Flyrebird" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/RomanHargrave/lyrebird on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/RomanHargrave/lyrebird [INFO] finished tweaking git repo https://github.com/RomanHargrave/lyrebird [INFO] tweaked toml for git repo https://github.com/RomanHargrave/lyrebird written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/RomanHargrave/lyrebird already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 99452b033b573aa6d94f64b0cc0d5b55ce66311304f846d2f04922e8dce15fc7 [INFO] running `Command { std: "docker" "start" "-a" "99452b033b573aa6d94f64b0cc0d5b55ce66311304f846d2f04922e8dce15fc7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "99452b033b573aa6d94f64b0cc0d5b55ce66311304f846d2f04922e8dce15fc7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "99452b033b573aa6d94f64b0cc0d5b55ce66311304f846d2f04922e8dce15fc7", kill_on_drop: false }` [INFO] [stdout] 99452b033b573aa6d94f64b0cc0d5b55ce66311304f846d2f04922e8dce15fc7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4c940a631b7cb54f3d51bb9c7f8bd480746e184219a22576ca365f72ce132453 [INFO] running `Command { std: "docker" "start" "-a" "4c940a631b7cb54f3d51bb9c7f8bd480746e184219a22576ca365f72ce132453", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.39 [INFO] [stderr] Compiling unicode-ident v1.0.1 [INFO] [stderr] Compiling syn v1.0.96 [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling serde_derive v1.0.137 [INFO] [stderr] Compiling serde v1.0.137 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling indexmap v1.9.0 [INFO] [stderr] Checking itoa v1.0.2 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Checking os_str_bytes v6.1.0 [INFO] [stderr] Compiling serde_json v1.0.81 [INFO] [stderr] Checking hashbrown v0.12.1 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking clap_lex v0.2.2 [INFO] [stderr] Checking ryu v1.0.10 [INFO] [stderr] Checking fastrand v1.7.0 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking num_threads v0.1.6 [INFO] [stderr] Checking once_cell v1.12.0 [INFO] [stderr] Checking random-string v1.0.0 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking time v0.3.9 [INFO] [stderr] Compiling clap_derive v3.2.5 [INFO] [stderr] Checking clap v3.2.5 [INFO] [stderr] Checking lyrebird v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:40:23 [INFO] [stdout] | [INFO] [stdout] 40 | .map(|f| Log::new(Box::new(f)))?; [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn record_action(&mut self, record_type: &str, data: D) -> Result<(), Box> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | / OffsetDateTime::now_utc() [INFO] [stdout] 51 | | .format(&Rfc3339) [INFO] [stdout] 52 | | .map_err(|e| e.into()) [INFO] [stdout] 53 | | // Create the record object [INFO] [stdout] ... | [INFO] [stdout] 65 | | .map_err(|e| e.into()) [INFO] [stdout] 66 | | ) [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | serde_json::to_writer(&mut self.writer, &entry) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | self.writer.write_all("\n".as_bytes()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/file.rs:32:3 [INFO] [stdout] | [INFO] [stdout] 27 | let f = File::options() [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | / f?.write_all(LB_FILE_CONTENT.as_bytes()) [INFO] [stdout] 33 | | .and_then(|()| canonicalize(path).map(|pb| pb.to_string_lossy().to_string())) [INFO] [stdout] 34 | | .map_err(|e| e.into()) [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/file.rs:33:20 [INFO] [stdout] | [INFO] [stdout] 33 | .and_then(|()| canonicalize(path).map(|pb| pb.to_string_lossy().to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/file.rs:46:3 [INFO] [stdout] | [INFO] [stdout] 41 | let f = File::options() [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | / f?.write_all(LB_FILE_CONTENT.as_bytes()) [INFO] [stdout] 47 | | .map_err(|e| e.into()) [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lyrebird` (bin "lyrebird" test) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:40:23 [INFO] [stdout] | [INFO] [stdout] 40 | .map(|f| Log::new(Box::new(f)))?; [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn record_action(&mut self, record_type: &str, data: D) -> Result<(), Box> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | / OffsetDateTime::now_utc() [INFO] [stdout] 51 | | .format(&Rfc3339) [INFO] [stdout] 52 | | .map_err(|e| e.into()) [INFO] [stdout] 53 | | // Create the record object [INFO] [stdout] ... | [INFO] [stdout] 65 | | .map_err(|e| e.into()) [INFO] [stdout] 66 | | ) [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | serde_json::to_writer(&mut self.writer, &entry) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/log.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | self.writer.write_all("\n".as_bytes()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/file.rs:32:3 [INFO] [stdout] | [INFO] [stdout] 27 | let f = File::options() [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | / f?.write_all(LB_FILE_CONTENT.as_bytes()) [INFO] [stdout] 33 | | .and_then(|()| canonicalize(path).map(|pb| pb.to_string_lossy().to_string())) [INFO] [stdout] 34 | | .map_err(|e| e.into()) [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/file.rs:33:20 [INFO] [stdout] | [INFO] [stdout] 33 | .and_then(|()| canonicalize(path).map(|pb| pb.to_string_lossy().to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/file.rs:46:3 [INFO] [stdout] | [INFO] [stdout] 41 | let f = File::options() [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | / f?.write_all(LB_FILE_CONTENT.as_bytes()) [INFO] [stdout] 47 | | .map_err(|e| e.into()) [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lyrebird` (bin "lyrebird") due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "4c940a631b7cb54f3d51bb9c7f8bd480746e184219a22576ca365f72ce132453", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4c940a631b7cb54f3d51bb9c7f8bd480746e184219a22576ca365f72ce132453", kill_on_drop: false }` [INFO] [stdout] 4c940a631b7cb54f3d51bb9c7f8bd480746e184219a22576ca365f72ce132453