[INFO] cloning repository https://github.com/RobbingDaHood/my_little_rpg [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/RobbingDaHood/my_little_rpg" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRobbingDaHood%2Fmy_little_rpg", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRobbingDaHood%2Fmy_little_rpg'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2c9bf28741fa64408f231d15191554acd649e450 [INFO] checking RobbingDaHood/my_little_rpg/2c9bf28741fa64408f231d15191554acd649e450 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRobbingDaHood%2Fmy_little_rpg" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/RobbingDaHood/my_little_rpg on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-2-tc2/source/rust-toolchain.toml [INFO] started tweaking git repo https://github.com/RobbingDaHood/my_little_rpg [INFO] finished tweaking git repo https://github.com/RobbingDaHood/my_little_rpg [INFO] tweaked toml for git repo https://github.com/RobbingDaHood/my_little_rpg written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/RobbingDaHood/my_little_rpg already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f7bde77b4187a80cb6b1bfdc7515e447909e2a4ccd7c26202c597fd4db692417 [INFO] running `Command { std: "docker" "start" "-a" "f7bde77b4187a80cb6b1bfdc7515e447909e2a4ccd7c26202c597fd4db692417", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f7bde77b4187a80cb6b1bfdc7515e447909e2a4ccd7c26202c597fd4db692417", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f7bde77b4187a80cb6b1bfdc7515e447909e2a4ccd7c26202c597fd4db692417", kill_on_drop: false }` [INFO] [stdout] f7bde77b4187a80cb6b1bfdc7515e447909e2a4ccd7c26202c597fd4db692417 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c1caab6d95df43bacdb3a7b68d3d64065f973a978338cb306ca40fd5053b0a72 [INFO] running `Command { std: "docker" "start" "-a" "c1caab6d95df43bacdb3a7b68d3d64065f973a978338cb306ca40fd5053b0a72", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Compiling libc v0.2.149 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling unicode-segmentation v1.10.1 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Compiling serde_json v1.0.107 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling syn v2.0.38 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling serde_derive v1.0.189 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Checking structopt v0.3.26 [INFO] [stderr] Checking serde v1.0.189 [INFO] [stderr] Checking rand_pcg v0.3.1 [INFO] [stderr] Checking my_little_rpg v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `rand::Rng` [INFO] [stdout] --> src/command/expand_min_element.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use rand::Rng; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `DamageType` [INFO] [stdout] --> src/command/expand_min_element.rs:10:52 [INFO] [stdout] | [INFO] [stdout] 10 | damage_types::{get_mut_random_attack_type, DamageType}, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `serde_json::json` [INFO] [stdout] --> src/my_little_rpg_errors.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use serde_json::json; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `BTreeMap` [INFO] [stdout] --> src/the_world/damage_types.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | BTreeMap, HashMap, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `rand::Rng` [INFO] [stdout] --> src/command/expand_min_element.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use rand::Rng; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `DamageType` [INFO] [stdout] --> src/command/expand_min_element.rs:10:52 [INFO] [stdout] | [INFO] [stdout] 10 | damage_types::{get_mut_random_attack_type, DamageType}, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `CraftingInfo`, `Game`, `Item`, `damage_types::DamageType`, `item_modifier::Modifier`, `modifier_cost::Cost`, and `modifier_gain::Gain` [INFO] [stdout] --> src/command/move/tests.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | Game, [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 8 | damage_types::DamageType, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 9 | item::{CraftingInfo, Item}, [INFO] [stdout] | ^^^^^^^^^^^^ ^^^^ [INFO] [stdout] 10 | item_modifier::Modifier, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 11 | item_resource::Type, [INFO] [stdout] 12 | modifier_cost::Cost, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 13 | modifier_gain::Gain, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `serde_json::json` [INFO] [stdout] --> src/my_little_rpg_errors.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use serde_json::json; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `BTreeMap` [INFO] [stdout] --> src/the_world/damage_types.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | BTreeMap, HashMap, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `IteratorRandom` [INFO] [stdout] --> src/the_world/damage_types.rs:10:21 [INFO] [stdout] | [INFO] [stdout] 10 | use rand::prelude::{IteratorRandom, SliceRandom}; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/command/craft_expand_modifier.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | let mut inventory_item = game.inventory[inventory_index].as_mut().expect( [INFO] [stdout] | ----^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/command/craft_reroll_modifier.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 105 | let mut inventory_item = game.inventory[inventory_index].as_mut().expect( [INFO] [stdout] | ----^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/command/expand_min_element.rs:56:15 [INFO] [stdout] | [INFO] [stdout] 56 | .map_err(|e| { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `IteratorRandom` [INFO] [stdout] --> src/the_world/damage_types.rs:10:21 [INFO] [stdout] | [INFO] [stdout] 10 | use rand::prelude::{IteratorRandom, SliceRandom}; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/command/craft_expand_modifier.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | let mut inventory_item = game.inventory[inventory_index].as_mut().expect( [INFO] [stdout] | ----^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/command/craft_reroll_modifier.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 105 | let mut inventory_item = game.inventory[inventory_index].as_mut().expect( [INFO] [stdout] | ----^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/command/expand_min_element.rs:56:15 [INFO] [stdout] | [INFO] [stdout] 56 | .map_err(|e| { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `damage_amount` [INFO] [stdout] --> src/the_world/damage_types.rs:64:29 [INFO] [stdout] | [INFO] [stdout] 64 | .map(|(damage_kind, damage_amount)| damage_kind) [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_damage_amount` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command/move.rs:179:9 [INFO] [stdout] | [INFO] [stdout] 69 | let mut item_report = Vec::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | Err(MyError::create_move_command_error( [INFO] [stdout] | _________^ [INFO] [stdout] 180 | | "You did not deal enough damage to overcome the challenges in this place.".to_string(), [INFO] [stdout] 181 | | json!(item_report).to_string(), [INFO] [stdout] 182 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command/move.rs:215:17 [INFO] [stdout] | [INFO] [stdout] 204 | item_report: Vec, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 215 | result: "You won and got a new item in the inventory.".into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command/presentation_game_state.rs:135:15 [INFO] [stdout] | [INFO] [stdout] 84 | let equipped_items: Vec = game [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | let inventory: Vec = game [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | seed: encode_hex(&game.seed), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command/save_load.rs:14:11 [INFO] [stdout] | [INFO] [stdout] 12 | save_path: Option>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | ) -> Value { [INFO] [stdout] 14 | match execute_save_command(game, save_name, save_path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command/save_load.rs:41:11 [INFO] [stdout] | [INFO] [stdout] 39 | save_path: Option>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | ) -> Value { [INFO] [stdout] 41 | match execute_load_command(save_name, save_path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command/save_load.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 52 | save_path: Option>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | / fs::read(file_path) [INFO] [stdout] 57 | | .map_err(|error| { [INFO] [stdout] 58 | | let error_message = format!("Failed loading the world! Reason: {}", error); [INFO] [stdout] 59 | | MyError::create_save_load_error(error_message) [INFO] [stdout] 60 | | }) [INFO] [stdout] 61 | | .map(|data| serde_json::from_slice::(data.as_slice())) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |____________________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command/save_load.rs:79:11 [INFO] [stdout] | [INFO] [stdout] 72 | save_path: Option>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | ) -> Result, MyError> { [INFO] [stdout] 74 | let save_path: Box = match save_path { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | Some(path) => path, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | match create_dir_all(save_path.as_ref()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/commands.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 79 | Ok(Equip(inventory_position, equipped_item_position)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/commands.rs:93:12 [INFO] [stdout] | [INFO] [stdout] 93 | Ok(SwapEquipment( [INFO] [stdout] | ____________^ [INFO] [stdout] 94 | | equipped_item_position_1, [INFO] [stdout] 95 | | equipped_item_position_2, [INFO] [stdout] 96 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/commands.rs:111:12 [INFO] [stdout] | [INFO] [stdout] 111 | Ok(RerollModifier( [INFO] [stdout] | ____________^ [INFO] [stdout] 112 | | inventory_index, [INFO] [stdout] 113 | | modifier_index, [INFO] [stdout] 114 | | parsed_sacrifice_item_indexes, [INFO] [stdout] 115 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/commands.rs:134:12 [INFO] [stdout] | [INFO] [stdout] 128 | let save_game_name = Box::from(command_parts[1]); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | let save_game_path = if command_parts.len() < 3 { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | Ok(SaveTheWorld(save_game_name, save_game_path)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/commands.rs:153:12 [INFO] [stdout] | [INFO] [stdout] 147 | let save_game_name = Box::from(command_parts[1]); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | let save_game_path = if command_parts.len() < 3 { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | Ok(LoadTheWorld(save_game_name, save_game_path)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/tcp_listener.rs:130:15 [INFO] [stdout] | [INFO] [stdout] 69 | let result = Self::read_command(stream).map(Command::try_from).and_then(|r| r).map(|command| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | Err(result) => format!("{} \n", json!(result)), [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | match stream.write(result_message.as_bytes()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/tcp_listener.rs:162:12 [INFO] [stdout] | [INFO] [stdout] 162 | Ok(command_as_string.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.deref()` on a double reference, which returns `&DamageType` instead of dereferencing the inner type [INFO] [stdout] --> src/the_world/damage_types.rs:72:12 [INFO] [stdout] | [INFO] [stdout] 72 | ))? [INFO] [stdout] | ____________^ [INFO] [stdout] 73 | | .deref() [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `damage_amount` [INFO] [stdout] --> src/the_world/damage_types.rs:64:29 [INFO] [stdout] | [INFO] [stdout] 64 | .map(|(damage_kind, damage_amount)| damage_kind) [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_damage_amount` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `my_little_rpg` (bin "my_little_rpg") due to 15 previous errors; 10 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command/move.rs:179:9 [INFO] [stdout] | [INFO] [stdout] 69 | let mut item_report = Vec::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | Err(MyError::create_move_command_error( [INFO] [stdout] | _________^ [INFO] [stdout] 180 | | "You did not deal enough damage to overcome the challenges in this place.".to_string(), [INFO] [stdout] 181 | | json!(item_report).to_string(), [INFO] [stdout] 182 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command/move.rs:215:17 [INFO] [stdout] | [INFO] [stdout] 204 | item_report: Vec, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 215 | result: "You won and got a new item in the inventory.".into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command/move/tests.rs:91:15 [INFO] [stdout] | [INFO] [stdout] 90 | fn unwrap_move_error(result: Result) -> MoveCommandErrorBody { [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | match result.unwrap_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command/presentation_game_state.rs:135:15 [INFO] [stdout] | [INFO] [stdout] 84 | let equipped_items: Vec = game [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | let inventory: Vec = game [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | seed: encode_hex(&game.seed), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command/save_load.rs:14:11 [INFO] [stdout] | [INFO] [stdout] 12 | save_path: Option>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | ) -> Value { [INFO] [stdout] 14 | match execute_save_command(game, save_name, save_path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command/save_load.rs:41:11 [INFO] [stdout] | [INFO] [stdout] 39 | save_path: Option>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | ) -> Value { [INFO] [stdout] 41 | match execute_load_command(save_name, save_path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command/save_load.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 52 | save_path: Option>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | / fs::read(file_path) [INFO] [stdout] 57 | | .map_err(|error| { [INFO] [stdout] 58 | | let error_message = format!("Failed loading the world! Reason: {}", error); [INFO] [stdout] 59 | | MyError::create_save_load_error(error_message) [INFO] [stdout] 60 | | }) [INFO] [stdout] 61 | | .map(|data| serde_json::from_slice::(data.as_slice())) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |____________________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command/save_load.rs:79:11 [INFO] [stdout] | [INFO] [stdout] 72 | save_path: Option>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | ) -> Result, MyError> { [INFO] [stdout] 74 | let save_path: Box = match save_path { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | Some(path) => path, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | match create_dir_all(save_path.as_ref()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/commands.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 79 | Ok(Equip(inventory_position, equipped_item_position)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/commands.rs:93:12 [INFO] [stdout] | [INFO] [stdout] 93 | Ok(SwapEquipment( [INFO] [stdout] | ____________^ [INFO] [stdout] 94 | | equipped_item_position_1, [INFO] [stdout] 95 | | equipped_item_position_2, [INFO] [stdout] 96 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/commands.rs:111:12 [INFO] [stdout] | [INFO] [stdout] 111 | Ok(RerollModifier( [INFO] [stdout] | ____________^ [INFO] [stdout] 112 | | inventory_index, [INFO] [stdout] 113 | | modifier_index, [INFO] [stdout] 114 | | parsed_sacrifice_item_indexes, [INFO] [stdout] 115 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/commands.rs:134:12 [INFO] [stdout] | [INFO] [stdout] 128 | let save_game_name = Box::from(command_parts[1]); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | let save_game_path = if command_parts.len() < 3 { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | Ok(SaveTheWorld(save_game_name, save_game_path)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/commands.rs:153:12 [INFO] [stdout] | [INFO] [stdout] 147 | let save_game_name = Box::from(command_parts[1]); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | let save_game_path = if command_parts.len() < 3 { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | Ok(LoadTheWorld(save_game_name, save_game_path)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/tcp_listener.rs:130:15 [INFO] [stdout] | [INFO] [stdout] 69 | let result = Self::read_command(stream).map(Command::try_from).and_then(|r| r).map(|command| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | Err(result) => format!("{} \n", json!(result)), [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | match stream.write(result_message.as_bytes()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/tcp_listener.rs:162:12 [INFO] [stdout] | [INFO] [stdout] 162 | Ok(command_as_string.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.deref()` on a double reference, which returns `&DamageType` instead of dereferencing the inner type [INFO] [stdout] --> src/the_world/damage_types.rs:72:12 [INFO] [stdout] | [INFO] [stdout] 72 | ))? [INFO] [stdout] | ____________^ [INFO] [stdout] 73 | | .deref() [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `my_little_rpg` (bin "my_little_rpg" test) due to 16 previous errors; 11 warnings emitted [INFO] running `Command { std: "docker" "inspect" "c1caab6d95df43bacdb3a7b68d3d64065f973a978338cb306ca40fd5053b0a72", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c1caab6d95df43bacdb3a7b68d3d64065f973a978338cb306ca40fd5053b0a72", kill_on_drop: false }` [INFO] [stdout] c1caab6d95df43bacdb3a7b68d3d64065f973a978338cb306ca40fd5053b0a72