[INFO] cloning repository https://github.com/Rgerritse/simple-restaurant-api [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Rgerritse/simple-restaurant-api" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRgerritse%2Fsimple-restaurant-api", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRgerritse%2Fsimple-restaurant-api'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 48261b9cade031e73ddaa5fd60a2e5c01e690b82 [INFO] checking Rgerritse/simple-restaurant-api/48261b9cade031e73ddaa5fd60a2e5c01e690b82 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRgerritse%2Fsimple-restaurant-api" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Rgerritse/simple-restaurant-api on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Rgerritse/simple-restaurant-api [INFO] finished tweaking git repo https://github.com/Rgerritse/simple-restaurant-api [INFO] tweaked toml for git repo https://github.com/Rgerritse/simple-restaurant-api written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Rgerritse/simple-restaurant-api already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 20b86746a9629f05dccc5e44e8b8a8535953d9e00fad554a15a1d08aba8ac02b [INFO] running `Command { std: "docker" "start" "-a" "20b86746a9629f05dccc5e44e8b8a8535953d9e00fad554a15a1d08aba8ac02b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "20b86746a9629f05dccc5e44e8b8a8535953d9e00fad554a15a1d08aba8ac02b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "20b86746a9629f05dccc5e44e8b8a8535953d9e00fad554a15a1d08aba8ac02b", kill_on_drop: false }` [INFO] [stdout] 20b86746a9629f05dccc5e44e8b8a8535953d9e00fad554a15a1d08aba8ac02b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] aca7fb1cc6966241e044eba9a3d76de8ac1bc2ea7e3bc452ca823a182111773d [INFO] running `Command { std: "docker" "start" "-a" "aca7fb1cc6966241e044eba9a3d76de8ac1bc2ea7e3bc452ca823a182111773d", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.125 [INFO] [stderr] Compiling proc-macro2 v1.0.38 [INFO] [stderr] Compiling unicode-xid v0.2.3 [INFO] [stderr] Compiling syn v1.0.94 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling parking_lot_core v0.9.3 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Compiling lock_api v0.4.7 [INFO] [stderr] Checking smallvec v1.8.0 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Checking slab v0.4.6 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Checking tracing-core v0.1.26 [INFO] [stderr] Compiling indexmap v1.8.1 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Compiling serde v1.0.137 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Compiling httparse v1.7.1 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Compiling serde_derive v1.0.137 [INFO] [stderr] Checking unicode-bidi v0.3.8 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking ryu v1.0.9 [INFO] [stderr] Checking http v0.2.7 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Checking mio v0.8.3 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking getrandom v0.2.6 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking parking_lot v0.12.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Checking http-body v0.4.4 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking serde_json v1.0.81 [INFO] [stderr] Compiling futures-macro v0.3.21 [INFO] [stderr] Compiling tracing-attributes v0.1.21 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Checking tokio v1.18.2 [INFO] [stderr] Checking tracing v0.1.34 [INFO] [stderr] Checking futures-executor v0.3.21 [INFO] [stderr] Checking futures v0.3.21 [INFO] [stderr] Checking tokio-util v0.7.1 [INFO] [stderr] Checking h2 v0.3.13 [INFO] [stderr] Checking hyper v0.14.18 [INFO] [stderr] Checking simple-restaurant-api v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/client_simulation.rs:118:5 [INFO] [stdout] | [INFO] [stdout] 118 | Ok(()) [INFO] [stdout] | ^^---- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/client_simulation.rs:59:48 [INFO] [stdout] | [INFO] [stdout] 52 | let req = Request::builder() [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let res = client.request(req.unwrap()).await?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | hyper::body::to_bytes(res.into_body()).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/client_simulation.rs:71:48 [INFO] [stdout] | [INFO] [stdout] 64 | let req = Request::builder() [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | let res =client.request(req.unwrap()).await?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | hyper::body::to_bytes(res.into_body()).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/client_simulation.rs:83:48 [INFO] [stdout] | [INFO] [stdout] 76 | let req = Request::builder() [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | let res =client.request(req.unwrap()).await?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | hyper::body::to_bytes(res.into_body()).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/client_simulation.rs:95:48 [INFO] [stdout] | [INFO] [stdout] 88 | let req = Request::builder() [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | let res = client.request(req.unwrap()).await?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | hyper::body::to_bytes(res.into_body()).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/client_simulation.rs:102:48 [INFO] [stdout] | [INFO] [stdout] 100 | let uri = format!("{}/items?table=1", base_url).parse(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | let res = client.get(uri.unwrap()).await?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | hyper::body::to_bytes(res.into_body()).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `simple-restaurant-api` (example "client_simulation") due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | if let Err(e) = graceful.await { [INFO] [stdout] | _____^ - [INFO] [stdout] | |____________________________________| [INFO] [stdout] 39 | || eprintln!("server error: {}", e); [INFO] [stdout] 40 | || } [INFO] [stdout] | ||_____^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:27:33 [INFO] [stdout] | [INFO] [stdout] 25 | let data = data.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | async move { [INFO] [stdout] 27 | Ok::<_, Infallible>(service_fn(move |req| { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 28 | | let data = data.clone(); [INFO] [stdout] 29 | | handle_request(req, data) [INFO] [stdout] 30 | | })) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | if let Err(e) = graceful.await { [INFO] [stdout] | _____^ - [INFO] [stdout] | |____________________________________| [INFO] [stdout] 39 | || eprintln!("server error: {}", e); [INFO] [stdout] 40 | || } [INFO] [stdout] | ||_____^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `simple-restaurant-api` (bin "simple-restaurant-api") due to 3 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:27:33 [INFO] [stdout] | [INFO] [stdout] 25 | let data = data.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | async move { [INFO] [stdout] 27 | Ok::<_, Infallible>(service_fn(move |req| { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 28 | | let data = data.clone(); [INFO] [stdout] 29 | | handle_request(req, data) [INFO] [stdout] 30 | | })) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `simple-restaurant-api` (bin "simple-restaurant-api" test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "aca7fb1cc6966241e044eba9a3d76de8ac1bc2ea7e3bc452ca823a182111773d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aca7fb1cc6966241e044eba9a3d76de8ac1bc2ea7e3bc452ca823a182111773d", kill_on_drop: false }` [INFO] [stdout] aca7fb1cc6966241e044eba9a3d76de8ac1bc2ea7e3bc452ca823a182111773d