[INFO] cloning repository https://github.com/RaphaelDarley/compactor [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/RaphaelDarley/compactor" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRaphaelDarley%2Fcompactor", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRaphaelDarley%2Fcompactor'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 449c50bd0b644c8cf73566a9af5c89e675ae493f [INFO] checking RaphaelDarley/compactor/449c50bd0b644c8cf73566a9af5c89e675ae493f against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FRaphaelDarley%2Fcompactor" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/RaphaelDarley/compactor on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/RaphaelDarley/compactor [INFO] finished tweaking git repo https://github.com/RaphaelDarley/compactor [INFO] tweaked toml for git repo https://github.com/RaphaelDarley/compactor written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/RaphaelDarley/compactor already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7f1e2c95f53789c2b6b315d3a5f65f558057b6ff8187cc9a277773da189ca77c [INFO] running `Command { std: "docker" "start" "-a" "7f1e2c95f53789c2b6b315d3a5f65f558057b6ff8187cc9a277773da189ca77c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7f1e2c95f53789c2b6b315d3a5f65f558057b6ff8187cc9a277773da189ca77c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7f1e2c95f53789c2b6b315d3a5f65f558057b6ff8187cc9a277773da189ca77c", kill_on_drop: false }` [INFO] [stdout] 7f1e2c95f53789c2b6b315d3a5f65f558057b6ff8187cc9a277773da189ca77c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 71cf349e11c31eb204fdbca04d8b87954d7b712e935ac759599d85c8ee7f5337 [INFO] running `Command { std: "docker" "start" "-a" "71cf349e11c31eb204fdbca04d8b87954d7b712e935ac759599d85c8ee7f5337", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.122 [INFO] [stderr] Checking itertools v0.10.3 [INFO] [stderr] Checking getrandom v0.2.6 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking compactor v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: module `BinararyStack` should have a snake case name [INFO] [stdout] --> src/lib.rs:1:9 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod BinararyStack; [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `binarary_stack` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/huffman.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn list_to_tree(mut nodes: Vec) -> HuffNodeFreq { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | nodes.pop().unwrap() [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `BinararyStack` should have a snake case name [INFO] [stdout] --> src/lib.rs:1:9 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod BinararyStack; [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to snake case: `binarary_stack` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/huffman.rs:94:10 [INFO] [stdout] | [INFO] [stdout] 85 | let mut out_acc = vec![]; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | Some(sort_desc_tokfreq(out_acc)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/huffman.rs:98:5 [INFO] [stdout] | [INFO] [stdout] 97 | fn sort_desc_tokfreq(to_sort: Vec) -> Vec { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | / to_sort [INFO] [stdout] 99 | | .into_iter() [INFO] [stdout] 100 | | .sorted_by(|a, b| b.freq.cmp(&a.freq)) [INFO] [stdout] | |______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/huffman.rs:138:20 [INFO] [stdout] | [INFO] [stdout] 135 | pub fn from_nodes(left: HuffNodeFreq, right: HuffNodeFreq) -> HuffNodeFreq { [INFO] [stdout] | ------------------ ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | value: HuffValue::Conns(HuffConns { [INFO] [stdout] | ____________________^ [INFO] [stdout] 139 | | left: Box::new(left), [INFO] [stdout] 140 | | right: Box::new(right), [INFO] [stdout] 141 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `compactor` (lib) due to 5 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/huffman.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn list_to_tree(mut nodes: Vec) -> HuffNodeFreq { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | nodes.pop().unwrap() [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/huffman.rs:94:10 [INFO] [stdout] | [INFO] [stdout] 85 | let mut out_acc = vec![]; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | Some(sort_desc_tokfreq(out_acc)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/huffman.rs:98:5 [INFO] [stdout] | [INFO] [stdout] 97 | fn sort_desc_tokfreq(to_sort: Vec) -> Vec { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | / to_sort [INFO] [stdout] 99 | | .into_iter() [INFO] [stdout] 100 | | .sorted_by(|a, b| b.freq.cmp(&a.freq)) [INFO] [stdout] | |______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/huffman.rs:138:20 [INFO] [stdout] | [INFO] [stdout] 135 | pub fn from_nodes(left: HuffNodeFreq, right: HuffNodeFreq) -> HuffNodeFreq { [INFO] [stdout] | ------------------ ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | value: HuffValue::Conns(HuffConns { [INFO] [stdout] | ____________________^ [INFO] [stdout] 139 | | left: Box::new(left), [INFO] [stdout] 140 | | right: Box::new(right), [INFO] [stdout] 141 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `compactor` (lib test) due to 5 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "71cf349e11c31eb204fdbca04d8b87954d7b712e935ac759599d85c8ee7f5337", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "71cf349e11c31eb204fdbca04d8b87954d7b712e935ac759599d85c8ee7f5337", kill_on_drop: false }` [INFO] [stdout] 71cf349e11c31eb204fdbca04d8b87954d7b712e935ac759599d85c8ee7f5337