[INFO] cloning repository https://github.com/Quinntyx/archive-shit [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Quinntyx/archive-shit" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FQuinntyx%2Farchive-shit", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FQuinntyx%2Farchive-shit'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 6b0ab3146d454838eaa34d1f11fe507ac5a1520d [INFO] checking Quinntyx/archive-shit/6b0ab3146d454838eaa34d1f11fe507ac5a1520d against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FQuinntyx%2Farchive-shit" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Quinntyx/archive-shit on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Quinntyx/archive-shit [INFO] finished tweaking git repo https://github.com/Quinntyx/archive-shit [INFO] tweaked toml for git repo https://github.com/Quinntyx/archive-shit written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Quinntyx/archive-shit already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4b072c641677fd1b8fc1cb72aeea8a0eb373af549b2eed56fee12bbaa746cfc7 [INFO] running `Command { std: "docker" "start" "-a" "4b072c641677fd1b8fc1cb72aeea8a0eb373af549b2eed56fee12bbaa746cfc7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4b072c641677fd1b8fc1cb72aeea8a0eb373af549b2eed56fee12bbaa746cfc7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4b072c641677fd1b8fc1cb72aeea8a0eb373af549b2eed56fee12bbaa746cfc7", kill_on_drop: false }` [INFO] [stdout] 4b072c641677fd1b8fc1cb72aeea8a0eb373af549b2eed56fee12bbaa746cfc7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 15a5e06940648ece63c685f23c10cce8d4e1fd8c9d8d4824cb66186295d43b76 [INFO] running `Command { std: "docker" "start" "-a" "15a5e06940648ece63c685f23c10cce8d4e1fd8c9d8d4824cb66186295d43b76", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Compiling cc v1.0.99 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Checking flate3 v1.1.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Compiling lzma-sys v0.1.20 [INFO] [stderr] Checking xz2 v0.1.7 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking libshit v0.1.0 (/opt/rustwide/workdir/libshit) [INFO] [stdout] warning: variant `flate3_DynamicBlockLarge` should have an upper camel case name [INFO] [stdout] --> libshit/src/schema.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | flate3_DynamicBlockLarge = 1, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `Flate3DynamicBlockLarge` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `flate3_DynamicBlockSmall` should have an upper camel case name [INFO] [stdout] --> libshit/src/schema.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | flate3_DynamicBlockSmall = 2, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `Flate3DynamicBlockSmall` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `flate3_StaticBlockLarge` should have an upper camel case name [INFO] [stdout] --> libshit/src/schema.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | flate3_StaticBlockLarge = 3, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `Flate3StaticBlockLarge` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `flate3_StaticBlockSmall` should have an upper camel case name [INFO] [stdout] --> libshit/src/schema.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | flate3_StaticBlockSmall = 4, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `Flate3StaticBlockSmall` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `lzma_xz_3` should have an upper camel case name [INFO] [stdout] --> libshit/src/schema.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | lzma_xz_3 = 33, [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper camel case: `LzmaXz3` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `lzma_xz_6` should have an upper camel case name [INFO] [stdout] --> libshit/src/schema.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | lzma_xz_6 = 34, [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper camel case: `LzmaXz6` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `flate3_DynamicBlockLarge` should have an upper camel case name [INFO] [stdout] --> libshit/src/schema.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | flate3_DynamicBlockLarge = 1, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `Flate3DynamicBlockLarge` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `flate3_DynamicBlockSmall` should have an upper camel case name [INFO] [stdout] --> libshit/src/schema.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | flate3_DynamicBlockSmall = 2, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `Flate3DynamicBlockSmall` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `flate3_StaticBlockLarge` should have an upper camel case name [INFO] [stdout] --> libshit/src/schema.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | flate3_StaticBlockLarge = 3, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `Flate3StaticBlockLarge` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `flate3_StaticBlockSmall` should have an upper camel case name [INFO] [stdout] --> libshit/src/schema.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | flate3_StaticBlockSmall = 4, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `Flate3StaticBlockSmall` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `lzma_xz_3` should have an upper camel case name [INFO] [stdout] --> libshit/src/schema.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | lzma_xz_3 = 33, [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper camel case: `LzmaXz3` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `lzma_xz_6` should have an upper camel case name [INFO] [stdout] --> libshit/src/schema.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | lzma_xz_6 = 34, [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper camel case: `LzmaXz6` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> libshit/src/lib.rs:83:17 [INFO] [stdout] | [INFO] [stdout] 83 | let mut times = FileTimes::new(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libshit/src/lib.rs:115:22 [INFO] [stdout] | [INFO] [stdout] 109 | let file = File::open(&file).expect("File should exist"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | let f = BufReader::new(file); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | content: f [INFO] [stdout] | ______________________^ [INFO] [stdout] 116 | | .bytes() [INFO] [stdout] 117 | | .map(|i| i.expect("Bytes should be valid")) [INFO] [stdout] | |___________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libshit/src/fs.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 8 | let Ok(entries) = read_dir(path.clone()) else { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 11 | / entries [INFO] [stdout] 12 | | .flatten() [INFO] [stdout] 13 | | .flat_map(|entry| { [INFO] [stdout] 14 | | let Ok(meta) = entry.metadata() else { [INFO] [stdout] ... | [INFO] [stdout] 23 | | vec![] [INFO] [stdout] 24 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> libshit/src/schema.rs:68:17 [INFO] [stdout] | [INFO] [stdout] 68 | XzEncoder::new(data, 3).read_to_end(&mut out); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 68 | let _ = XzEncoder::new(data, 3).read_to_end(&mut out); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> libshit/src/schema.rs:73:17 [INFO] [stdout] | [INFO] [stdout] 73 | XzEncoder::new(data, 6).read_to_end(&mut out); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 73 | let _ = XzEncoder::new(data, 6).read_to_end(&mut out); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> libshit/src/schema.rs:103:17 [INFO] [stdout] | [INFO] [stdout] 103 | XzDecoder::new(data).read_to_end(&mut out); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 103 | let _ = XzDecoder::new(data).read_to_end(&mut out); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libshit` (lib) due to 3 previous errors; 10 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> libshit/src/lib.rs:83:17 [INFO] [stdout] | [INFO] [stdout] 83 | let mut times = FileTimes::new(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libshit/src/lib.rs:115:22 [INFO] [stdout] | [INFO] [stdout] 109 | let file = File::open(&file).expect("File should exist"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | let f = BufReader::new(file); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | content: f [INFO] [stdout] | ______________________^ [INFO] [stdout] 116 | | .bytes() [INFO] [stdout] 117 | | .map(|i| i.expect("Bytes should be valid")) [INFO] [stdout] | |___________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> libshit/src/fs.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 8 | let Ok(entries) = read_dir(path.clone()) else { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 11 | / entries [INFO] [stdout] 12 | | .flatten() [INFO] [stdout] 13 | | .flat_map(|entry| { [INFO] [stdout] 14 | | let Ok(meta) = entry.metadata() else { [INFO] [stdout] ... | [INFO] [stdout] 23 | | vec![] [INFO] [stdout] 24 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> libshit/src/schema.rs:68:17 [INFO] [stdout] | [INFO] [stdout] 68 | XzEncoder::new(data, 3).read_to_end(&mut out); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 68 | let _ = XzEncoder::new(data, 3).read_to_end(&mut out); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> libshit/src/schema.rs:73:17 [INFO] [stdout] | [INFO] [stdout] 73 | XzEncoder::new(data, 6).read_to_end(&mut out); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 73 | let _ = XzEncoder::new(data, 6).read_to_end(&mut out); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> libshit/src/schema.rs:103:17 [INFO] [stdout] | [INFO] [stdout] 103 | XzDecoder::new(data).read_to_end(&mut out); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 103 | let _ = XzDecoder::new(data).read_to_end(&mut out); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libshit` (lib test) due to 3 previous errors; 10 warnings emitted [INFO] running `Command { std: "docker" "inspect" "15a5e06940648ece63c685f23c10cce8d4e1fd8c9d8d4824cb66186295d43b76", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "15a5e06940648ece63c685f23c10cce8d4e1fd8c9d8d4824cb66186295d43b76", kill_on_drop: false }` [INFO] [stdout] 15a5e06940648ece63c685f23c10cce8d4e1fd8c9d8d4824cb66186295d43b76