[INFO] cloning repository https://github.com/Pushyboy/chip8_emulator [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Pushyboy/chip8_emulator" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPushyboy%2Fchip8_emulator", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPushyboy%2Fchip8_emulator'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 41124a7c63b1f5b29ff5f82747db0da79ebb1026 [INFO] checking Pushyboy/chip8_emulator/41124a7c63b1f5b29ff5f82747db0da79ebb1026 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPushyboy%2Fchip8_emulator" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Pushyboy/chip8_emulator on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Pushyboy/chip8_emulator [INFO] finished tweaking git repo https://github.com/Pushyboy/chip8_emulator [INFO] tweaked toml for git repo https://github.com/Pushyboy/chip8_emulator written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Pushyboy/chip8_emulator already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3fe1711e9a7dd441bd1c428376a2dc2b165cc74d21d68d004dfee4ed4ad07d04 [INFO] running `Command { std: "docker" "start" "-a" "3fe1711e9a7dd441bd1c428376a2dc2b165cc74d21d68d004dfee4ed4ad07d04", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3fe1711e9a7dd441bd1c428376a2dc2b165cc74d21d68d004dfee4ed4ad07d04", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3fe1711e9a7dd441bd1c428376a2dc2b165cc74d21d68d004dfee4ed4ad07d04", kill_on_drop: false }` [INFO] [stdout] 3fe1711e9a7dd441bd1c428376a2dc2b165cc74d21d68d004dfee4ed4ad07d04 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 18bbe61ee3a1691d076436e7aa795a07a3203a9e0ffe76dcd51a61136fc70a11 [INFO] running `Command { std: "docker" "start" "-a" "18bbe61ee3a1691d076436e7aa795a07a3203a9e0ffe76dcd51a61136fc70a11", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.146 [INFO] [stderr] Compiling version-compare v0.1.1 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling sdl2 v0.35.2 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Compiling sdl2-sys v0.35.2 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking chip_8 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: type `Chip_8` should have an upper camel case name [INFO] [stdout] --> src/cpu.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 24 | pub struct Chip_8 { [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper camel case: `Chip8` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `match` scrutinee expression [INFO] [stdout] --> src/cpu.rs:306:15 [INFO] [stdout] | [INFO] [stdout] 306 | match (v[x] & 0x01) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 306 - match (v[x] & 0x01) { [INFO] [stdout] 306 + match v[x] & 0x01 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `State` [INFO] [stdout] --> src/main.rs:2:19 [INFO] [stdout] | [INFO] [stdout] 2 | use cpu::{Chip_8, State}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Duration` [INFO] [stdout] --> src/main.rs:5:17 [INFO] [stdout] | [INFO] [stdout] 5 | use std::time::{Duration, Instant}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `Chip_8` should have an upper camel case name [INFO] [stdout] --> src/cpu.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 24 | pub struct Chip_8 { [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper camel case: `Chip8` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `match` scrutinee expression [INFO] [stdout] --> src/cpu.rs:306:15 [INFO] [stdout] | [INFO] [stdout] 306 | match (v[x] & 0x01) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 306 - match (v[x] & 0x01) { [INFO] [stdout] 306 + match v[x] & 0x01 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `State` [INFO] [stdout] --> src/main.rs:2:19 [INFO] [stdout] | [INFO] [stdout] 2 | use cpu::{Chip_8, State}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Duration` [INFO] [stdout] --> src/main.rs:5:17 [INFO] [stdout] | [INFO] [stdout] 5 | use std::time::{Duration, Instant}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `INACTIVE` is never constructed [INFO] [stdout] --> src/cpu.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 19 | pub enum State { [INFO] [stdout] | ----- variant in this enum [INFO] [stdout] 20 | ACTIVE, [INFO] [stdout] 21 | INACTIVE, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `state` is never read [INFO] [stdout] --> src/cpu.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 24 | pub struct Chip_8 { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 35 | pub state: State [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `INACTIVE` is never constructed [INFO] [stdout] --> src/cpu.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 19 | pub enum State { [INFO] [stdout] | ----- variant in this enum [INFO] [stdout] 20 | ACTIVE, [INFO] [stdout] 21 | INACTIVE, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `state` is never read [INFO] [stdout] --> src/cpu.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 24 | pub struct Chip_8 { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 35 | pub state: State [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/cpu.rs:216:25 [INFO] [stdout] | [INFO] [stdout] 216 | self.display.draw_pixel(x as i32, y as i32, Color::BLACK); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 216 | let _ = self.display.draw_pixel(x as i32, y as i32, Color::BLACK); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/cpu.rs:220:25 [INFO] [stdout] | [INFO] [stdout] 220 | self.display.draw_pixel(x as i32, y as i32, Color::WHITE); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 220 | let _ = self.display.draw_pixel(x as i32, y as i32, Color::WHITE); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `store_BCD` should have a snake case name [INFO] [stdout] --> src/cpu.rs:395:8 [INFO] [stdout] | [INFO] [stdout] 395 | fn store_BCD(&mut self, x: usize) { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `store_bcd` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cpu/keyboard.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 13 | let event_pump = sdl_context.event_pump()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 17 | Ok(Keyboard { [INFO] [stdout] | ____________^ [INFO] [stdout] 18 | | event_pump, [INFO] [stdout] 19 | | awaiting_press, [INFO] [stdout] 20 | | key_press [INFO] [stdout] 21 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cpu/display.rs:39:12 [INFO] [stdout] | [INFO] [stdout] 17 | let video_subsystem = sdl_context.video()?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | [INFO] [stdout] 19 | let window= video_subsystem [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | let mut canvas = window [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | Ok(Display { canvas }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/cpu.rs:216:25 [INFO] [stdout] | [INFO] [stdout] 216 | self.display.draw_pixel(x as i32, y as i32, Color::BLACK); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 216 | let _ = self.display.draw_pixel(x as i32, y as i32, Color::BLACK); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/cpu.rs:220:25 [INFO] [stdout] | [INFO] [stdout] 220 | self.display.draw_pixel(x as i32, y as i32, Color::WHITE); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 220 | let _ = self.display.draw_pixel(x as i32, y as i32, Color::WHITE); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `store_BCD` should have a snake case name [INFO] [stdout] --> src/cpu.rs:395:8 [INFO] [stdout] | [INFO] [stdout] 395 | fn store_BCD(&mut self, x: usize) { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `store_bcd` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cpu/keyboard.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 13 | let event_pump = sdl_context.event_pump()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 17 | Ok(Keyboard { [INFO] [stdout] | ____________^ [INFO] [stdout] 18 | | event_pump, [INFO] [stdout] 19 | | awaiting_press, [INFO] [stdout] 20 | | key_press [INFO] [stdout] 21 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cpu/display.rs:39:12 [INFO] [stdout] | [INFO] [stdout] 17 | let video_subsystem = sdl_context.video()?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | [INFO] [stdout] 19 | let window= video_subsystem [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | let mut canvas = window [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | Ok(Display { canvas }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `chip_8` (bin "chip_8") due to 3 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `chip_8` (bin "chip_8" test) due to 3 previous errors; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "18bbe61ee3a1691d076436e7aa795a07a3203a9e0ffe76dcd51a61136fc70a11", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "18bbe61ee3a1691d076436e7aa795a07a3203a9e0ffe76dcd51a61136fc70a11", kill_on_drop: false }` [INFO] [stdout] 18bbe61ee3a1691d076436e7aa795a07a3203a9e0ffe76dcd51a61136fc70a11