[INFO] cloning repository https://github.com/PurpurTentakel97/rust-structs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/PurpurTentakel97/rust-structs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPurpurTentakel97%2Frust-structs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPurpurTentakel97%2Frust-structs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 29ab3bd0184b5ddc38aab2d72722c397dac95c8f [INFO] checking PurpurTentakel97/rust-structs/29ab3bd0184b5ddc38aab2d72722c397dac95c8f against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPurpurTentakel97%2Frust-structs" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/PurpurTentakel97/rust-structs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/PurpurTentakel97/rust-structs [INFO] finished tweaking git repo https://github.com/PurpurTentakel97/rust-structs [INFO] tweaked toml for git repo https://github.com/PurpurTentakel97/rust-structs written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/PurpurTentakel97/rust-structs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0e0a2390d0bbfca8780b488adb638e8429211d5a0896ecc3f4d605c79b7e7719 [INFO] running `Command { std: "docker" "start" "-a" "0e0a2390d0bbfca8780b488adb638e8429211d5a0896ecc3f4d605c79b7e7719", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0e0a2390d0bbfca8780b488adb638e8429211d5a0896ecc3f4d605c79b7e7719", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0e0a2390d0bbfca8780b488adb638e8429211d5a0896ecc3f4d605c79b7e7719", kill_on_drop: false }` [INFO] [stdout] 0e0a2390d0bbfca8780b488adb638e8429211d5a0896ecc3f4d605c79b7e7719 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f0397b35dce7f34f0ee873e07d09c784e62fa332b10a4b5faa6255636dcfcefd [INFO] running `Command { std: "docker" "start" "-a" "f0397b35dce7f34f0ee873e07d09c784e62fa332b10a4b5faa6255636dcfcefd", kill_on_drop: false }` [INFO] [stderr] Checking structs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `name` [INFO] [stdout] --> src/main.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | let name = get_name(s.as_str()); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_name` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `point` [INFO] [stdout] --> src/main.rs:56:13 [INFO] [stdout] | [INFO] [stdout] 56 | let mut point = point::Point::new("true".to_string(), "false".to_string()); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_point` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `point2` [INFO] [stdout] --> src/main.rs:57:13 [INFO] [stdout] | [INFO] [stdout] 57 | let mut point2 = point::Point::new(true, false); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_point2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | let mut point2 = point::Point::new(23, 15); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | let mut point = point::Point::new("true".to_string(), "false".to_string()); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | let mut point2 = point::Point::new(true, false); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Address` is never constructed [INFO] [stdout] --> src/main.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 8 | struct Address { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/main.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 14 | impl Address { [INFO] [stdout] | ------------ associated function in this implementation [INFO] [stdout] 15 | fn new(street: String, number: i32, city: String) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `point` is never used [INFO] [stdout] --> src/main.rs:44:4 [INFO] [stdout] | [INFO] [stdout] 44 | fn point() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `address` is never used [INFO] [stdout] --> src/main.rs:60:4 [INFO] [stdout] | [INFO] [stdout] 60 | fn address() { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `first_name` and `last_name` are never read [INFO] [stdout] --> src/time.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 1 | pub(crate) struct Name<'a> { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 2 | first_name: &'a str, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 3 | last_name: &'a str, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/point.rs:37:16 [INFO] [stdout] | [INFO] [stdout] 35 | fn add(self, rhs: Self) -> Self::Output { [INFO] [stdout] | ---- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | Self { [INFO] [stdout] 37 | x: self.x + rhs.x, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/point.rs:38:16 [INFO] [stdout] | [INFO] [stdout] 35 | fn add(self, rhs: Self) -> Self::Output { [INFO] [stdout] | ---- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | y: self.y + rhs.y, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `structs` (bin "structs" test) due to 3 previous errors; 11 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `name` [INFO] [stdout] --> src/main.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | let name = get_name(s.as_str()); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_name` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `point` [INFO] [stdout] --> src/main.rs:56:13 [INFO] [stdout] | [INFO] [stdout] 56 | let mut point = point::Point::new("true".to_string(), "false".to_string()); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_point` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `point2` [INFO] [stdout] --> src/main.rs:57:13 [INFO] [stdout] | [INFO] [stdout] 57 | let mut point2 = point::Point::new(true, false); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_point2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | let mut point2 = point::Point::new(23, 15); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | let mut point = point::Point::new("true".to_string(), "false".to_string()); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | let mut point2 = point::Point::new(true, false); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Address` is never constructed [INFO] [stdout] --> src/main.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 8 | struct Address { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/main.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 14 | impl Address { [INFO] [stdout] | ------------ associated function in this implementation [INFO] [stdout] 15 | fn new(street: String, number: i32, city: String) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `point` is never used [INFO] [stdout] --> src/main.rs:44:4 [INFO] [stdout] | [INFO] [stdout] 44 | fn point() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `address` is never used [INFO] [stdout] --> src/main.rs:60:4 [INFO] [stdout] | [INFO] [stdout] 60 | fn address() { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `first_name` and `last_name` are never read [INFO] [stdout] --> src/time.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 1 | pub(crate) struct Name<'a> { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 2 | first_name: &'a str, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 3 | last_name: &'a str, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/point.rs:37:16 [INFO] [stdout] | [INFO] [stdout] 35 | fn add(self, rhs: Self) -> Self::Output { [INFO] [stdout] | ---- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | Self { [INFO] [stdout] 37 | x: self.x + rhs.x, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/point.rs:38:16 [INFO] [stdout] | [INFO] [stdout] 35 | fn add(self, rhs: Self) -> Self::Output { [INFO] [stdout] | ---- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | y: self.y + rhs.y, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `structs` (bin "structs") due to 3 previous errors; 11 warnings emitted [INFO] running `Command { std: "docker" "inspect" "f0397b35dce7f34f0ee873e07d09c784e62fa332b10a4b5faa6255636dcfcefd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f0397b35dce7f34f0ee873e07d09c784e62fa332b10a4b5faa6255636dcfcefd", kill_on_drop: false }` [INFO] [stdout] f0397b35dce7f34f0ee873e07d09c784e62fa332b10a4b5faa6255636dcfcefd