[INFO] cloning repository https://github.com/PurpleBooth/git-moves-together [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/PurpleBooth/git-moves-together" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPurpleBooth%2Fgit-moves-together", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPurpleBooth%2Fgit-moves-together'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 81b96409050a75fa4a3d49c627f3372aed029ec9 [INFO] checking PurpleBooth/git-moves-together/81b96409050a75fa4a3d49c627f3372aed029ec9 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPurpleBooth%2Fgit-moves-together" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/PurpleBooth/git-moves-together on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/PurpleBooth/git-moves-together [INFO] finished tweaking git repo https://github.com/PurpleBooth/git-moves-together [INFO] tweaked toml for git repo https://github.com/PurpleBooth/git-moves-together written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/PurpleBooth/git-moves-together already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f7855aca4b7a64455bec8946e4c3df030c41a12c6925ef905bb7638a04d3b385 [INFO] running `Command { std: "docker" "start" "-a" "f7855aca4b7a64455bec8946e4c3df030c41a12c6925ef905bb7638a04d3b385", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f7855aca4b7a64455bec8946e4c3df030c41a12c6925ef905bb7638a04d3b385", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f7855aca4b7a64455bec8946e4c3df030c41a12c6925ef905bb7638a04d3b385", kill_on_drop: false }` [INFO] [stdout] f7855aca4b7a64455bec8946e4c3df030c41a12c6925ef905bb7638a04d3b385 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dacaa9686aa23dc3861b88843ed269ac21d90c7e8657e9aefa3bd75754319265 [INFO] running `Command { std: "docker" "start" "-a" "dacaa9686aa23dc3861b88843ed269ac21d90c7e8657e9aefa3bd75754319265", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking unicode-linebreak v0.1.5 [INFO] [stderr] Checking object v0.36.2 [INFO] [stderr] Checking smawk v0.3.2 [INFO] [stderr] Checking is_ci v1.2.0 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Checking supports-color v3.0.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking num-conv v0.1.0 [INFO] [stderr] Checking supports-hyperlinks v3.0.0 [INFO] [stderr] Checking supports-unicode v3.0.0 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking owo-colors v4.0.0 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking time-core v0.1.2 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v1.0.1 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Compiling cc v1.1.7 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Compiling libz-sys v1.1.18 [INFO] [stderr] Compiling libssh2-sys v0.3.0 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Compiling libgit2-sys v0.17.0+1.8.1 [INFO] [stderr] Compiling zerocopy-derive v0.6.6 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling miette-derive v7.2.0 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Checking backtrace-ext v0.2.1 [INFO] [stderr] Checking zerocopy v0.6.6 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking ppv-lite86 v0.2.18 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking comfy-table v7.1.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking miette v7.2.0 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking git2 v0.19.0 [INFO] [stderr] Checking git-moves-together v2.6.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:80:23 [INFO] [stdout] | [INFO] [stdout] 80 | .map(|commit| LibGit2::new(path.clone())?.compare_with_parent(commit)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repository/libgit2.rs:25:12 [INFO] [stdout] | [INFO] [stdout] 23 | let repo = git2::Repository::open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | [INFO] [stdout] 25 | Ok(Self { repo: repo.into() }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repository/libgit2.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 29 | let tree1 = parent [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | Ok(self [INFO] [stdout] | ____________^ [INFO] [stdout] 34 | | .repo [INFO] [stdout] 35 | | .clone() [INFO] [stdout] 36 | | .diff_tree_to_tree(Some(&tree1), tree.into(), None)? [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |________________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repository/libgit2.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 52 | let mut walker = self.repo.revwalk()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | / walker [INFO] [stdout] 57 | | .map(|oid| self.to_commit(oid?)) [INFO] [stdout] 58 | | .collect::, Error>>() [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |____________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repository/libgit2.rs:84:18 [INFO] [stdout] | [INFO] [stdout] 81 | acc: Result, Error>, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | item: Result, Error>, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | ) -> Result, Error> { [INFO] [stdout] 84 | acc.and_then(|acc| Ok([acc, item?].concat())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git-moves-together` (bin "git-moves-together") due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:80:23 [INFO] [stdout] | [INFO] [stdout] 80 | .map(|commit| LibGit2::new(path.clone())?.compare_with_parent(commit)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repository/libgit2.rs:25:12 [INFO] [stdout] | [INFO] [stdout] 23 | let repo = git2::Repository::open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | [INFO] [stdout] 25 | Ok(Self { repo: repo.into() }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repository/libgit2.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 29 | let tree1 = parent [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | Ok(self [INFO] [stdout] | ____________^ [INFO] [stdout] 34 | | .repo [INFO] [stdout] 35 | | .clone() [INFO] [stdout] 36 | | .diff_tree_to_tree(Some(&tree1), tree.into(), None)? [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |________________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repository/libgit2.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 52 | let mut walker = self.repo.revwalk()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | / walker [INFO] [stdout] 57 | | .map(|oid| self.to_commit(oid?)) [INFO] [stdout] 58 | | .collect::, Error>>() [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |____________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repository/libgit2.rs:84:18 [INFO] [stdout] | [INFO] [stdout] 81 | acc: Result, Error>, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | item: Result, Error>, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | ) -> Result, Error> { [INFO] [stdout] 84 | acc.and_then(|acc| Ok([acc, item?].concat())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git-moves-together` (bin "git-moves-together" test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "dacaa9686aa23dc3861b88843ed269ac21d90c7e8657e9aefa3bd75754319265", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dacaa9686aa23dc3861b88843ed269ac21d90c7e8657e9aefa3bd75754319265", kill_on_drop: false }` [INFO] [stdout] dacaa9686aa23dc3861b88843ed269ac21d90c7e8657e9aefa3bd75754319265