[INFO] cloning repository https://github.com/ProtonAOSP/android_external_rust_crates_quiche [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ProtonAOSP/android_external_rust_crates_quiche" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FProtonAOSP%2Fandroid_external_rust_crates_quiche", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FProtonAOSP%2Fandroid_external_rust_crates_quiche'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 902eb0d9ec1ba3f7b495426856b9d2b73c6d57d1 [INFO] checking ProtonAOSP/android_external_rust_crates_quiche/902eb0d9ec1ba3f7b495426856b9d2b73c6d57d1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FProtonAOSP%2Fandroid_external_rust_crates_quiche" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/ProtonAOSP/android_external_rust_crates_quiche on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/ProtonAOSP/android_external_rust_crates_quiche [INFO] finished tweaking git repo https://github.com/ProtonAOSP/android_external_rust_crates_quiche [INFO] tweaked toml for git repo https://github.com/ProtonAOSP/android_external_rust_crates_quiche written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/ProtonAOSP/android_external_rust_crates_quiche already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1d33f89b6c0ac3b3bc7fcf4d0257b4827b6d5b90c84a0061895f2c81278d61f3 [INFO] running `Command { std: "docker" "start" "-a" "1d33f89b6c0ac3b3bc7fcf4d0257b4827b6d5b90c84a0061895f2c81278d61f3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1d33f89b6c0ac3b3bc7fcf4d0257b4827b6d5b90c84a0061895f2c81278d61f3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1d33f89b6c0ac3b3bc7fcf4d0257b4827b6d5b90c84a0061895f2c81278d61f3", kill_on_drop: false }` [INFO] [stdout] 1d33f89b6c0ac3b3bc7fcf4d0257b4827b6d5b90c84a0061895f2c81278d61f3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 01367d0b96e489ad7465b381780a4c91fe8a7744c2241eca8f7c34973b6b96a7 [INFO] running `Command { std: "docker" "start" "-a" "01367d0b96e489ad7465b381780a4c91fe8a7744c2241eca8f7c34973b6b96a7", kill_on_drop: false }` [INFO] [stderr] Compiling cc v1.0.68 [INFO] [stderr] Compiling libc v0.2.95 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling libm v0.2.1 [INFO] [stderr] Checking once_cell v1.7.2 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Checking percent-encoding v1.0.1 [INFO] [stderr] Checking slab v0.4.3 [INFO] [stderr] Checking tinyvec v1.2.0 [INFO] [stderr] Compiling cmake v0.1.45 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking net2 v0.2.37 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Compiling quiche v0.9.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking idna v0.1.5 [INFO] [stderr] Checking url v1.7.2 [INFO] [stdout] warning: field `crypto_0rtt_seal` is never read [INFO] [stdout] --> src/packet.rs:830:9 [INFO] [stdout] | [INFO] [stdout] 813 | pub struct PktNumSpace { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 830 | pub crypto_0rtt_seal: Option, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `w_last_max` is never read [INFO] [stdout] --> src/recovery/cubic.rs:106:5 [INFO] [stdout] | [INFO] [stdout] 99 | struct PriorState { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 106 | w_last_max: f64, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PriorState` has derived impls for the traits `Default` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:574:12 [INFO] [stdout] | [INFO] [stdout] 572 | let tls_ctx = Mutex::new(tls::Context::new()?); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 573 | [INFO] [stdout] 574 | Ok(Config { [INFO] [stdout] | ____________^ [INFO] [stdout] 575 | | local_transport_params: TransportParams::default(), [INFO] [stdout] 576 | | version, [INFO] [stdout] 577 | | tls_ctx, [INFO] [stdout] ... | [INFO] [stdout] 586 | | max_send_udp_payload_size: MAX_SEND_UDP_PAYLOAD_SIZE, [INFO] [stdout] 587 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:5472:16 [INFO] [stdout] | [INFO] [stdout] 5462 | let mut config = Config::new(crate::PROTOCOL_VERSION)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 5472 | Ok(Pipe { [INFO] [stdout] | ________________^ [INFO] [stdout] 5473 | | client: connect( [INFO] [stdout] 5474 | | Some("quic.tech"), [INFO] [stdout] 5475 | | &client_scid, [INFO] [stdout] ... | [INFO] [stdout] 5479 | | server: accept(&server_scid, None, server_addr, &mut config)?, [INFO] [stdout] 5480 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:5502:16 [INFO] [stdout] | [INFO] [stdout] 5494 | let mut config = Config::new(crate::PROTOCOL_VERSION)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 5502 | Ok(Pipe { [INFO] [stdout] | ________________^ [INFO] [stdout] 5503 | | client: connect( [INFO] [stdout] 5504 | | Some("quic.tech"), [INFO] [stdout] 5505 | | &client_scid, [INFO] [stdout] ... | [INFO] [stdout] 5509 | | server: accept(&server_scid, None, server_addr, server_config)?, [INFO] [stdout] 5510 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/frame.rs:1182:8 [INFO] [stdout] | [INFO] [stdout] 1180 | let data = stream::RangeBuf::from(data.as_ref(), offset, fin); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1181 | [INFO] [stdout] 1182 | Ok(Frame::Stream { stream_id, data }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/h3/mod.rs:2141:16 [INFO] [stdout] | [INFO] [stdout] 2138 | let pipe = testing::Pipe::with_config(config)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2141 | Ok(Session { [INFO] [stdout] | ________________^ [INFO] [stdout] 2142 | | pipe, [INFO] [stdout] 2143 | | client: Connection::new(&h3_config, false, client_dgram)?, [INFO] [stdout] 2144 | | server: Connection::new(&h3_config, true, server_dgram)?, [INFO] [stdout] 2145 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `quiche` (lib) due to 6 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `crypto_0rtt_seal` is never read [INFO] [stdout] --> src/packet.rs:830:9 [INFO] [stdout] | [INFO] [stdout] 813 | pub struct PktNumSpace { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 830 | pub crypto_0rtt_seal: Option, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `w_last_max` is never read [INFO] [stdout] --> src/recovery/cubic.rs:106:5 [INFO] [stdout] | [INFO] [stdout] 99 | struct PriorState { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 106 | w_last_max: f64, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PriorState` has derived impls for the traits `Default` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:574:12 [INFO] [stdout] | [INFO] [stdout] 572 | let tls_ctx = Mutex::new(tls::Context::new()?); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 573 | [INFO] [stdout] 574 | Ok(Config { [INFO] [stdout] | ____________^ [INFO] [stdout] 575 | | local_transport_params: TransportParams::default(), [INFO] [stdout] 576 | | version, [INFO] [stdout] 577 | | tls_ctx, [INFO] [stdout] ... | [INFO] [stdout] 586 | | max_send_udp_payload_size: MAX_SEND_UDP_PAYLOAD_SIZE, [INFO] [stdout] 587 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:5472:16 [INFO] [stdout] | [INFO] [stdout] 5462 | let mut config = Config::new(crate::PROTOCOL_VERSION)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 5472 | Ok(Pipe { [INFO] [stdout] | ________________^ [INFO] [stdout] 5473 | | client: connect( [INFO] [stdout] 5474 | | Some("quic.tech"), [INFO] [stdout] 5475 | | &client_scid, [INFO] [stdout] ... | [INFO] [stdout] 5479 | | server: accept(&server_scid, None, server_addr, &mut config)?, [INFO] [stdout] 5480 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:5502:16 [INFO] [stdout] | [INFO] [stdout] 5494 | let mut config = Config::new(crate::PROTOCOL_VERSION)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 5502 | Ok(Pipe { [INFO] [stdout] | ________________^ [INFO] [stdout] 5503 | | client: connect( [INFO] [stdout] 5504 | | Some("quic.tech"), [INFO] [stdout] 5505 | | &client_scid, [INFO] [stdout] ... | [INFO] [stdout] 5509 | | server: accept(&server_scid, None, server_addr, server_config)?, [INFO] [stdout] 5510 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/frame.rs:1182:8 [INFO] [stdout] | [INFO] [stdout] 1180 | let data = stream::RangeBuf::from(data.as_ref(), offset, fin); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1181 | [INFO] [stdout] 1182 | Ok(Frame::Stream { stream_id, data }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/h3/mod.rs:2141:16 [INFO] [stdout] | [INFO] [stdout] 2138 | let pipe = testing::Pipe::with_config(config)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2141 | Ok(Session { [INFO] [stdout] | ________________^ [INFO] [stdout] 2142 | | pipe, [INFO] [stdout] 2143 | | client: Connection::new(&h3_config, false, client_dgram)?, [INFO] [stdout] 2144 | | server: Connection::new(&h3_config, true, server_dgram)?, [INFO] [stdout] 2145 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `quiche` (lib test) due to 6 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "01367d0b96e489ad7465b381780a4c91fe8a7744c2241eca8f7c34973b6b96a7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "01367d0b96e489ad7465b381780a4c91fe8a7744c2241eca8f7c34973b6b96a7", kill_on_drop: false }` [INFO] [stdout] 01367d0b96e489ad7465b381780a4c91fe8a7744c2241eca8f7c34973b6b96a7