[INFO] updating cached repository https://github.com/ProgrammingRust/fingertips [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "-c" "remote.origin.fetch=refs/heads/*:refs/heads/*" "fetch" "origin" "--force" "--prune", kill_on_drop: false }` [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1bd7691d4721c44293d6451c393a39ea38a71ac9 [INFO] checking ProgrammingRust/fingertips/1bd7691d4721c44293d6451c393a39ea38a71ac9 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FProgrammingRust%2Ffingertips" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/ProgrammingRust/fingertips on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/ProgrammingRust/fingertips [INFO] finished tweaking git repo https://github.com/ProgrammingRust/fingertips [INFO] tweaked toml for git repo https://github.com/ProgrammingRust/fingertips written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/ProgrammingRust/fingertips already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e43efe3e684917ece24e971f1a8e8972aaa4a526984f4411dbf396fb29285f90 [INFO] running `Command { std: "docker" "start" "-a" "e43efe3e684917ece24e971f1a8e8972aaa4a526984f4411dbf396fb29285f90", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e43efe3e684917ece24e971f1a8e8972aaa4a526984f4411dbf396fb29285f90", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e43efe3e684917ece24e971f1a8e8972aaa4a526984f4411dbf396fb29285f90", kill_on_drop: false }` [INFO] [stdout] e43efe3e684917ece24e971f1a8e8972aaa4a526984f4411dbf396fb29285f90 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0ee2267732a86b43cbe4f4812bb279295c7c358c91db28701aa05295908cd38a [INFO] running `Command { std: "docker" "start" "-a" "0ee2267732a86b43cbe4f4812bb279295c7c358c91db28701aa05295908cd38a", kill_on_drop: false }` [INFO] [stderr] Checking argparse v0.2.1 [INFO] [stderr] Checking byteorder v0.5.3 [INFO] [stderr] Checking fingertips v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `offset` is never read [INFO] [stdout] --> src/read.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 41 | pub struct Entry { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 51 | pub offset: u64, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:86:12 [INFO] [stdout] | [INFO] [stdout] 65 | pub fn open_and_delete>(filename: P) -> io::Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | let filename = filename.as_ref(); [INFO] [stdout] 67 | let mut main_raw = File::open(filename)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | let mut contents_raw = File::open(filename)?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | contents_raw.seek(SeekFrom::Start(contents_offset))?; [INFO] [stdout] 78 | let main = BufReader::new(main_raw); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | let mut contents = BufReader::new(contents_raw); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | Ok(IndexFileReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 87 | | main: main, [INFO] [stdout] 88 | | contents: contents, [INFO] [stdout] 89 | | next: first [INFO] [stdout] 90 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn new(mut f: BufWriter) -> io::Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | Ok(IndexFileWriter { [INFO] [stdout] | ____________^ [INFO] [stdout] 34 | | offset: HEADER_SIZE, [INFO] [stdout] 35 | | writer: f, [INFO] [stdout] 36 | | contents_buf: vec![] [INFO] [stdout] 37 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fingertips` (bin "fingertips" test) due to 3 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `offset` is never read [INFO] [stdout] --> src/read.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 41 | pub struct Entry { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 51 | pub offset: u64, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:86:12 [INFO] [stdout] | [INFO] [stdout] 65 | pub fn open_and_delete>(filename: P) -> io::Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | let filename = filename.as_ref(); [INFO] [stdout] 67 | let mut main_raw = File::open(filename)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | let mut contents_raw = File::open(filename)?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | contents_raw.seek(SeekFrom::Start(contents_offset))?; [INFO] [stdout] 78 | let main = BufReader::new(main_raw); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | let mut contents = BufReader::new(contents_raw); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | Ok(IndexFileReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 87 | | main: main, [INFO] [stdout] 88 | | contents: contents, [INFO] [stdout] 89 | | next: first [INFO] [stdout] 90 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/write.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn new(mut f: BufWriter) -> io::Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | Ok(IndexFileWriter { [INFO] [stdout] | ____________^ [INFO] [stdout] 34 | | offset: HEADER_SIZE, [INFO] [stdout] 35 | | writer: f, [INFO] [stdout] 36 | | contents_buf: vec![] [INFO] [stdout] 37 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fingertips` (bin "fingertips") due to 3 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "0ee2267732a86b43cbe4f4812bb279295c7c358c91db28701aa05295908cd38a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0ee2267732a86b43cbe4f4812bb279295c7c358c91db28701aa05295908cd38a", kill_on_drop: false }` [INFO] [stdout] 0ee2267732a86b43cbe4f4812bb279295c7c358c91db28701aa05295908cd38a