[INFO] cloning repository https://github.com/Plasticcaz/mayim_old [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Plasticcaz/mayim_old" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPlasticcaz%2Fmayim_old", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPlasticcaz%2Fmayim_old'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c98c5ac9d7a59a9e9c4c91bce1eb0a5919df029f [INFO] checking Plasticcaz/mayim_old/c98c5ac9d7a59a9e9c4c91bce1eb0a5919df029f against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPlasticcaz%2Fmayim_old" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Plasticcaz/mayim_old on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Plasticcaz/mayim_old [INFO] finished tweaking git repo https://github.com/Plasticcaz/mayim_old [INFO] tweaked toml for git repo https://github.com/Plasticcaz/mayim_old written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Plasticcaz/mayim_old already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0ec02b019d8792422f164ac72374ae7a9fae718bfe5f04ff2e4e140e1e9393bb [INFO] running `Command { std: "docker" "start" "-a" "0ec02b019d8792422f164ac72374ae7a9fae718bfe5f04ff2e4e140e1e9393bb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0ec02b019d8792422f164ac72374ae7a9fae718bfe5f04ff2e4e140e1e9393bb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0ec02b019d8792422f164ac72374ae7a9fae718bfe5f04ff2e4e140e1e9393bb", kill_on_drop: false }` [INFO] [stdout] 0ec02b019d8792422f164ac72374ae7a9fae718bfe5f04ff2e4e140e1e9393bb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0608a55fe7f4deb729a41186cc9d433e2f60bbc2fbc9d2dde8508539e32aaffe [INFO] running `Command { std: "docker" "start" "-a" "0608a55fe7f4deb729a41186cc9d433e2f60bbc2fbc9d2dde8508539e32aaffe", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.104 [INFO] [stderr] Checking siphasher v0.3.1 [INFO] [stderr] Checking new_debug_unreachable v1.0.4 [INFO] [stderr] Checking precomputed-hash v0.1.1 [INFO] [stderr] Checking phf_shared v0.8.0 [INFO] [stderr] Checking string_cache v0.8.0 [INFO] [stderr] Checking syntax v0.1.0 (/opt/rustwide/workdir/syntax) [INFO] [stdout] warning: unused import: `Atom` [INFO] [stdout] --> syntax/src/expression.rs:1:13 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::{Atom, AtomToken, Location}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `fmt` [INFO] [stdout] --> syntax/src/parser.rs:3:11 [INFO] [stdout] | [INFO] [stdout] 3 | use std::{fmt, vec::IntoIter}; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Atom` [INFO] [stdout] --> syntax/src/expression.rs:1:13 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::{Atom, AtomToken, Location}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `fmt` [INFO] [stdout] --> syntax/src/parser.rs:3:11 [INFO] [stdout] | [INFO] [stdout] 3 | use std::{fmt, vec::IntoIter}; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `location` is never used [INFO] [stdout] --> syntax/src/expression.rs:18:8 [INFO] [stdout] | [INFO] [stdout] 17 | impl Expression { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] 18 | fn location(&self) -> Location { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> syntax/src/parser.rs:14:19 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn new(iterator: IntoIter) -> Tokens { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 14 | next: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> syntax/src/parser.rs:104:36 [INFO] [stdout] | [INFO] [stdout] 83 | let_location: Location, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | ) -> Expression { [INFO] [stdout] 85 | let identifier = match tokens.next() { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | Token::Identifier(identifier) => identifier, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | unexpected => return unexpected_token(unexpected), [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | let assign_operator = match tokens.next() { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | Token::Assign(assignment_location) => assignment_location, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | unexpected => return unexpected_token(unexpected), [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | let initialized_to = parse_expression(tokens); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | [INFO] [stdout] 97 | let declaration = BindingDeclaration { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | Expression::BindingDeclaration(Box::new(declaration)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> syntax/src/parser.rs:111:11 [INFO] [stdout] | [INFO] [stdout] 109 | identifier: AtomToken, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | ) -> Expression { [INFO] [stdout] 111 | match tokens.next() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `location` is never used [INFO] [stdout] --> syntax/src/expression.rs:18:8 [INFO] [stdout] | [INFO] [stdout] 17 | impl Expression { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] 18 | fn location(&self) -> Location { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> syntax/src/parser.rs:14:19 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn new(iterator: IntoIter) -> Tokens { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 14 | next: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> syntax/src/parser.rs:121:23 [INFO] [stdout] | [INFO] [stdout] 120 | fn unexpected_token(token: Token) -> Expression { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | Expression::Error(Error::new( [INFO] [stdout] | _______________________^ [INFO] [stdout] 122 | | token.location().clone(), [INFO] [stdout] 123 | | format!("Unexpected token: {}", token.description()), [INFO] [stdout] 124 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> syntax/src/parser.rs:104:36 [INFO] [stdout] | [INFO] [stdout] 83 | let_location: Location, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | ) -> Expression { [INFO] [stdout] 85 | let identifier = match tokens.next() { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | Token::Identifier(identifier) => identifier, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | unexpected => return unexpected_token(unexpected), [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | let assign_operator = match tokens.next() { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | Token::Assign(assignment_location) => assignment_location, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | unexpected => return unexpected_token(unexpected), [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | let initialized_to = parse_expression(tokens); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | [INFO] [stdout] 97 | let declaration = BindingDeclaration { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | Expression::BindingDeclaration(Box::new(declaration)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> syntax/src/parser.rs:111:11 [INFO] [stdout] | [INFO] [stdout] 109 | identifier: AtomToken, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | ) -> Expression { [INFO] [stdout] 111 | match tokens.next() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> syntax/src/parser.rs:121:23 [INFO] [stdout] | [INFO] [stdout] 120 | fn unexpected_token(token: Token) -> Expression { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | Expression::Error(Error::new( [INFO] [stdout] | _______________________^ [INFO] [stdout] 122 | | token.location().clone(), [INFO] [stdout] 123 | | format!("Unexpected token: {}", token.description()), [INFO] [stdout] 124 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> syntax/src/tests.rs:65:17 [INFO] [stdout] | [INFO] [stdout] 62 | |binding_declaration: Box| { [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | Some(binding_declaration.initialized_to), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `syntax` (lib) due to 5 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `syntax` (lib test) due to 6 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "0608a55fe7f4deb729a41186cc9d433e2f60bbc2fbc9d2dde8508539e32aaffe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0608a55fe7f4deb729a41186cc9d433e2f60bbc2fbc9d2dde8508539e32aaffe", kill_on_drop: false }` [INFO] [stdout] 0608a55fe7f4deb729a41186cc9d433e2f60bbc2fbc9d2dde8508539e32aaffe