[INFO] cloning repository https://github.com/Phantom217/rust-tcp [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Phantom217/rust-tcp" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPhantom217%2Frust-tcp", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPhantom217%2Frust-tcp'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3e2af4c37dab21640ba4feb266b129b433d380f6 [INFO] checking Phantom217/rust-tcp/3e2af4c37dab21640ba4feb266b129b433d380f6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPhantom217%2Frust-tcp" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Phantom217/rust-tcp on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Phantom217/rust-tcp [INFO] finished tweaking git repo https://github.com/Phantom217/rust-tcp [INFO] tweaked toml for git repo https://github.com/Phantom217/rust-tcp written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Phantom217/rust-tcp already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1347772fba80e752fd3bd37ff5690c123a11417b3b1ed2a70cd59f1ad4889566 [INFO] running `Command { std: "docker" "start" "-a" "1347772fba80e752fd3bd37ff5690c123a11417b3b1ed2a70cd59f1ad4889566", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1347772fba80e752fd3bd37ff5690c123a11417b3b1ed2a70cd59f1ad4889566", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1347772fba80e752fd3bd37ff5690c123a11417b3b1ed2a70cd59f1ad4889566", kill_on_drop: false }` [INFO] [stdout] 1347772fba80e752fd3bd37ff5690c123a11417b3b1ed2a70cd59f1ad4889566 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2f2ed988ac07b63db1960ed9e3c45ad3de49c43a03d76c97fc4b92ed549610ee [INFO] running `Command { std: "docker" "start" "-a" "2f2ed988ac07b63db1960ed9e3c45ad3de49c43a03d76c97fc4b92ed549610ee", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling libc v0.2.70 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Checking futures v0.1.29 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Compiling cc v1.0.54 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking scoped-tls v0.1.2 [INFO] [stderr] Compiling nix v0.13.1 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Checking smallvec v0.6.13 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling memoffset v0.5.4 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking etherparse v0.9.0 [INFO] [stderr] Compiling parking_lot_core v0.6.2 [INFO] [stderr] Compiling parking_lot v0.9.0 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking net2 v0.2.34 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Compiling tun-tap v0.1.2 [INFO] [stderr] Checking mio v0.6.22 [INFO] [stderr] Checking crossbeam-queue v0.2.1 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Checking tokio-executor v0.1.10 [INFO] [stderr] Checking tokio-io v0.1.13 [INFO] [stderr] Checking tokio-sync v0.1.8 [INFO] [stderr] Checking tokio-threadpool v0.1.18 [INFO] [stderr] Checking tokio-current-thread v0.1.7 [INFO] [stderr] Checking tokio-timer v0.2.13 [INFO] [stderr] Checking mio-uds v0.6.8 [INFO] [stderr] Checking tokio-reactor v0.1.12 [INFO] [stderr] Checking tokio-codec v0.1.2 [INFO] [stderr] Checking tokio-fs v0.1.7 [INFO] [stderr] Checking tokio-uds v0.2.6 [INFO] [stderr] Checking tokio-udp v0.1.6 [INFO] [stderr] Checking tokio-tcp v0.1.4 [INFO] [stderr] Checking tokio v0.1.22 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking trust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `buf` [INFO] [stdout] --> src/tcp.rs:137:13 [INFO] [stdout] | [INFO] [stdout] 137 | let buf = [0u8; 1500]; [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_buf` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> src/tcp.rs:135:9 [INFO] [stdout] | [INFO] [stdout] 135 | data: &'a [u8], [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `iph` [INFO] [stdout] --> src/tcp.rs:380:9 [INFO] [stdout] | [INFO] [stdout] 380 | iph: etherparse::Ipv4HeaderSlice<'a>, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_iph` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/tcp.rs:474:25 [INFO] [stdout] | [INFO] [stdout] 474 | let mut srtt = &mut self.timers.srtt; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/lib.rs:154:17 [INFO] [stdout] | [INFO] [stdout] 154 | Err(e) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `quad` [INFO] [stdout] --> src/lib.rs:214:13 [INFO] [stdout] | [INFO] [stdout] 214 | for quad in pending { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_quad` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cm` [INFO] [stdout] --> src/lib.rs:250:13 [INFO] [stdout] | [INFO] [stdout] 250 | let cm = self.h.manager.lock().unwrap(); [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_cm` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `how` [INFO] [stdout] --> src/lib.rs:336:28 [INFO] [stdout] | [INFO] [stdout] 336 | pub fn shutdown(&self, how: std::net::Shutdown) -> io::Result<()> { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_how` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `is_synchronized` is never used [INFO] [stdout] --> src/tcp.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 23 | impl State { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] 24 | fn is_synchronized(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `up`, `wl1`, and `wl2` are never read [INFO] [stdout] --> src/tcp.rs:96:5 [INFO] [stdout] | [INFO] [stdout] 88 | struct SendSequenceSpace { [INFO] [stdout] | ----------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 96 | up: bool, [INFO] [stdout] | ^^ [INFO] [stdout] 97 | /// segment sequence number used for last window update [INFO] [stdout] 98 | wl1: usize, [INFO] [stdout] | ^^^ [INFO] [stdout] 99 | /// segment acknowledgment number used for last window update [INFO] [stdout] 100 | wl2: usize, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `up` is never read [INFO] [stdout] --> src/tcp.rs:125:5 [INFO] [stdout] | [INFO] [stdout] 119 | struct RecvSequenceSpace { [INFO] [stdout] | ----------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 125 | up: bool, [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `send_rst` is never used [INFO] [stdout] --> src/tcp.rs:293:8 [INFO] [stdout] | [INFO] [stdout] 130 | impl Connection { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 293 | fn send_rst(&mut self, nic: &mut tun_tap::Iface) -> io::Result<()> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `buf` [INFO] [stdout] --> src/tcp.rs:137:13 [INFO] [stdout] | [INFO] [stdout] 137 | let buf = [0u8; 1500]; [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_buf` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> src/tcp.rs:135:9 [INFO] [stdout] | [INFO] [stdout] 135 | data: &'a [u8], [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:172:12 [INFO] [stdout] | [INFO] [stdout] 163 | let nic = tun_tap::Iface::without_packet_info("tun0", tun_tap::Mode::Tun)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 164 | [INFO] [stdout] 165 | let ih: InterfaceHandle = Arc::default(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | [INFO] [stdout] 167 | let jh = { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | let ih = ih.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 173 | | ih: Some(ih), [INFO] [stdout] 174 | | jh: Some(jh), [INFO] [stdout] 175 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:193:12 [INFO] [stdout] | [INFO] [stdout] 180 | let mut cm = self.ih.as_mut().unwrap().manager.lock().unwrap(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 193 | Ok(TcpListener { [INFO] [stdout] | ____________^ [INFO] [stdout] 194 | | port, [INFO] [stdout] 195 | | h: self.ih.as_mut().unwrap().clone(), [INFO] [stdout] 196 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/tcp.rs:234:9 [INFO] [stdout] | [INFO] [stdout] 234 | / self.ip [INFO] [stdout] 235 | | .set_payload_len(size - self.ip.header_len() as usize); [INFO] [stdout] | |__________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 234 | let _ = self.ip [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `iph` [INFO] [stdout] --> src/tcp.rs:380:9 [INFO] [stdout] | [INFO] [stdout] 380 | iph: etherparse::Ipv4HeaderSlice<'a>, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_iph` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/tcp.rs:241:9 [INFO] [stdout] | [INFO] [stdout] 241 | self.ip.write(&mut unwritten); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 241 | let _ = self.ip.write(&mut unwritten); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/tcp.rs:273:9 [INFO] [stdout] | [INFO] [stdout] 273 | self.tcp.write(&mut tcp_header_buf); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 273 | let _ = self.tcp.write(&mut tcp_header_buf); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 15 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/tcp.rs:474:25 [INFO] [stdout] | [INFO] [stdout] 474 | let mut srtt = &mut self.timers.srtt; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/lib.rs:154:17 [INFO] [stdout] | [INFO] [stdout] 154 | Err(e) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `trust` (lib) due to 3 previous errors; 15 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `quad` [INFO] [stdout] --> src/lib.rs:214:13 [INFO] [stdout] | [INFO] [stdout] 214 | for quad in pending { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_quad` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cm` [INFO] [stdout] --> src/lib.rs:250:13 [INFO] [stdout] | [INFO] [stdout] 250 | let cm = self.h.manager.lock().unwrap(); [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_cm` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `how` [INFO] [stdout] --> src/lib.rs:336:28 [INFO] [stdout] | [INFO] [stdout] 336 | pub fn shutdown(&self, how: std::net::Shutdown) -> io::Result<()> { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_how` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `is_synchronized` is never used [INFO] [stdout] --> src/tcp.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 23 | impl State { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] 24 | fn is_synchronized(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `up`, `wl1`, and `wl2` are never read [INFO] [stdout] --> src/tcp.rs:96:5 [INFO] [stdout] | [INFO] [stdout] 88 | struct SendSequenceSpace { [INFO] [stdout] | ----------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 96 | up: bool, [INFO] [stdout] | ^^ [INFO] [stdout] 97 | /// segment sequence number used for last window update [INFO] [stdout] 98 | wl1: usize, [INFO] [stdout] | ^^^ [INFO] [stdout] 99 | /// segment acknowledgment number used for last window update [INFO] [stdout] 100 | wl2: usize, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `up` is never read [INFO] [stdout] --> src/tcp.rs:125:5 [INFO] [stdout] | [INFO] [stdout] 119 | struct RecvSequenceSpace { [INFO] [stdout] | ----------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 125 | up: bool, [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `send_rst` is never used [INFO] [stdout] --> src/tcp.rs:293:8 [INFO] [stdout] | [INFO] [stdout] 130 | impl Connection { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 293 | fn send_rst(&mut self, nic: &mut tun_tap::Iface) -> io::Result<()> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:172:12 [INFO] [stdout] | [INFO] [stdout] 163 | let nic = tun_tap::Iface::without_packet_info("tun0", tun_tap::Mode::Tun)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 164 | [INFO] [stdout] 165 | let ih: InterfaceHandle = Arc::default(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | [INFO] [stdout] 167 | let jh = { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | let ih = ih.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 173 | | ih: Some(ih), [INFO] [stdout] 174 | | jh: Some(jh), [INFO] [stdout] 175 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:193:12 [INFO] [stdout] | [INFO] [stdout] 180 | let mut cm = self.ih.as_mut().unwrap().manager.lock().unwrap(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 193 | Ok(TcpListener { [INFO] [stdout] | ____________^ [INFO] [stdout] 194 | | port, [INFO] [stdout] 195 | | h: self.ih.as_mut().unwrap().clone(), [INFO] [stdout] 196 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/tcp.rs:234:9 [INFO] [stdout] | [INFO] [stdout] 234 | / self.ip [INFO] [stdout] 235 | | .set_payload_len(size - self.ip.header_len() as usize); [INFO] [stdout] | |__________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 234 | let _ = self.ip [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/tcp.rs:241:9 [INFO] [stdout] | [INFO] [stdout] 241 | self.ip.write(&mut unwritten); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 241 | let _ = self.ip.write(&mut unwritten); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/tcp.rs:273:9 [INFO] [stdout] | [INFO] [stdout] 273 | self.tcp.write(&mut tcp_header_buf); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 273 | let _ = self.tcp.write(&mut tcp_header_buf); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 15 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `trust` (lib test) due to 3 previous errors; 15 warnings emitted [INFO] running `Command { std: "docker" "inspect" "2f2ed988ac07b63db1960ed9e3c45ad3de49c43a03d76c97fc4b92ed549610ee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2f2ed988ac07b63db1960ed9e3c45ad3de49c43a03d76c97fc4b92ed549610ee", kill_on_drop: false }` [INFO] [stdout] 2f2ed988ac07b63db1960ed9e3c45ad3de49c43a03d76c97fc4b92ed549610ee