[INFO] cloning repository https://github.com/PetrichorIT/sh-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/PetrichorIT/sh-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPetrichorIT%2Fsh-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPetrichorIT%2Fsh-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 509cc665dac856f9d8872c913d58ec3a4ff38cb8 [INFO] checking PetrichorIT/sh-rust/509cc665dac856f9d8872c913d58ec3a4ff38cb8 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPetrichorIT%2Fsh-rust" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/PetrichorIT/sh-rust on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/PetrichorIT/sh-rust [INFO] finished tweaking git repo https://github.com/PetrichorIT/sh-rust [INFO] tweaked toml for git repo https://github.com/PetrichorIT/sh-rust written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/PetrichorIT/sh-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bb3a698f62042ba03c1194f03268cc9fdb7c75c968606fe935b0a4c72fbf94ce [INFO] running `Command { std: "docker" "start" "-a" "bb3a698f62042ba03c1194f03268cc9fdb7c75c968606fe935b0a4c72fbf94ce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bb3a698f62042ba03c1194f03268cc9fdb7c75c968606fe935b0a4c72fbf94ce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bb3a698f62042ba03c1194f03268cc9fdb7c75c968606fe935b0a4c72fbf94ce", kill_on_drop: false }` [INFO] [stdout] bb3a698f62042ba03c1194f03268cc9fdb7c75c968606fe935b0a4c72fbf94ce [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2bc2bde1420da9a09c6e88e6084f3bad5e0069665c03c4c4dafaf68b63d6db82 [INFO] running `Command { std: "docker" "start" "-a" "2bc2bde1420da9a09c6e88e6084f3bad5e0069665c03c4c4dafaf68b63d6db82", kill_on_drop: false }` [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Compiling httparse v1.9.4 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling syn v2.0.74 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling thiserror v1.0.60 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking tower-layer v0.3.3 [INFO] [stderr] Checking tower-service v0.3.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling serde_json v1.0.125 [INFO] [stderr] Checking data-encoding v2.6.0 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking http-range-header v0.4.1 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Compiling axum-core v0.4.3 [INFO] [stderr] Compiling axum v0.7.5 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking headers-core v0.3.0 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking headers v0.4.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling serde_derive v1.0.208 [INFO] [stderr] Compiling thiserror-impl v1.0.60 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking tokio v1.39.2 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tungstenite v0.21.0 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking serde v1.0.208 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-tungstenite v0.21.0 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tower-http v0.5.2 [INFO] [stderr] Checking serde_path_to_error v0.1.16 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking hyper-util v0.1.7 [INFO] [stderr] Checking axum-extra v0.9.3 [INFO] [stderr] Checking secret-hitler v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/lib.rs:190:21 [INFO] [stdout] | [INFO] [stdout] 190 | _ => todo!(), [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/lib.rs:190:21 [INFO] [stdout] | [INFO] [stdout] 128 | IncomingMessage::Authenticate(auth) => { [INFO] [stdout] | ----------------------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 170 | IncomingMessage::GetState => { [INFO] [stdout] | ------------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 183 | IncomingMessage::Task(task_response) => { [INFO] [stdout] | ------------------------------------ matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 190 | _ => todo!(), [INFO] [stdout] | ^ collectively making this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `close_frame` [INFO] [stdout] --> src/lib.rs:193:28 [INFO] [stdout] | [INFO] [stdout] 193 | Message::Close(close_frame) => { [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_close_frame` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/lib.rs:190:21 [INFO] [stdout] | [INFO] [stdout] 190 | _ => todo!(), [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/lib.rs:190:21 [INFO] [stdout] | [INFO] [stdout] 128 | IncomingMessage::Authenticate(auth) => { [INFO] [stdout] | ----------------------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 170 | IncomingMessage::GetState => { [INFO] [stdout] | ------------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 183 | IncomingMessage::Task(task_response) => { [INFO] [stdout] | ------------------------------------ matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 190 | _ => todo!(), [INFO] [stdout] | ^ collectively making this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `close_frame` [INFO] [stdout] --> src/lib.rs:193:28 [INFO] [stdout] | [INFO] [stdout] 193 | Message::Close(close_frame) => { [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_close_frame` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `of` [INFO] [stdout] --> src/core/view.rs:87:24 [INFO] [stdout] | [INFO] [stdout] 87 | pub fn view(&self, of: &Player) -> StateView { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_of` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `of` [INFO] [stdout] --> src/core/view.rs:87:24 [INFO] [stdout] | [INFO] [stdout] 87 | pub fn view(&self, of: &Player) -> StateView { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_of` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/core/mod.rs:199:13 [INFO] [stdout] | [INFO] [stdout] 199 | for i in 0..N { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/core/mod.rs:199:13 [INFO] [stdout] | [INFO] [stdout] 199 | for i in 0..N { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:62:15 [INFO] [stdout] | [INFO] [stdout] 52 | State(game_state): State>>, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | ws.on_upgrade(move |socket| async move { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | match handle_ws(socket, addr, game_state).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `secret-hitler` (lib test) due to 2 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:62:15 [INFO] [stdout] | [INFO] [stdout] 52 | State(game_state): State>>, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | ws.on_upgrade(move |socket| async move { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | match handle_ws(socket, addr, game_state).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `secret-hitler` (lib) due to 2 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "2bc2bde1420da9a09c6e88e6084f3bad5e0069665c03c4c4dafaf68b63d6db82", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2bc2bde1420da9a09c6e88e6084f3bad5e0069665c03c4c4dafaf68b63d6db82", kill_on_drop: false }` [INFO] [stdout] 2bc2bde1420da9a09c6e88e6084f3bad5e0069665c03c4c4dafaf68b63d6db82