[INFO] cloning repository https://github.com/PeterMaltby/advent-of-code [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/PeterMaltby/advent-of-code" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPeterMaltby%2Fadvent-of-code", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPeterMaltby%2Fadvent-of-code'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a8e44fb431e50d655f2ac2f9b7be5e53363cd387 [INFO] checking PeterMaltby/advent-of-code/a8e44fb431e50d655f2ac2f9b7be5e53363cd387 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPeterMaltby%2Fadvent-of-code" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/PeterMaltby/advent-of-code on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/PeterMaltby/advent-of-code [INFO] finished tweaking git repo https://github.com/PeterMaltby/advent-of-code [INFO] tweaked toml for git repo https://github.com/PeterMaltby/advent-of-code written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/PeterMaltby/advent-of-code already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 409890a247331257e7384e77b3f280e848dd94bd0b741c7da88335a305ac72a9 [INFO] running `Command { std: "docker" "start" "-a" "409890a247331257e7384e77b3f280e848dd94bd0b741c7da88335a305ac72a9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "409890a247331257e7384e77b3f280e848dd94bd0b741c7da88335a305ac72a9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "409890a247331257e7384e77b3f280e848dd94bd0b741c7da88335a305ac72a9", kill_on_drop: false }` [INFO] [stdout] 409890a247331257e7384e77b3f280e848dd94bd0b741c7da88335a305ac72a9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3a5ce2fcf2e7dd41b210e109c6814815e2663d5f9e1ab7a93b2586ee993b106e [INFO] running `Command { std: "docker" "start" "-a" "3a5ce2fcf2e7dd41b210e109c6814815e2663d5f9e1ab7a93b2586ee993b106e", kill_on_drop: false }` [INFO] [stderr] Checking advent-of-code v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::iter::zip` [INFO] [stdout] --> src/bin/2023_day3.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::iter::zip; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/bin/2023_day3.rs:188:20 [INFO] [stdout] | [INFO] [stdout] 188 | if (item.1 == item_to_check.1 && item.0 != item_to_check.0) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 188 - if (item.1 == item_to_check.1 && item.0 != item_to_check.0) { [INFO] [stdout] 188 + if item.1 == item_to_check.1 && item.0 != item_to_check.0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/bin/2023_day3.rs:190:26 [INFO] [stdout] | [INFO] [stdout] 190 | n += (item.0 * item_to_check.0); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 190 - n += (item.0 * item_to_check.0); [INFO] [stdout] 190 + n += item.0 * item_to_check.0; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `HashMap` [INFO] [stdout] --> src/bin/2022_day15.rs:1:24 [INFO] [stdout] | [INFO] [stdout] 1 | use std::collections::{HashMap, HashSet}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt::write` [INFO] [stdout] --> src/bin/2022_day14.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::fmt::write; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/bin/2022_day14.rs:74:40 [INFO] [stdout] | [INFO] [stdout] 74 | fn add_wall(&mut self, walls: &Vec<(Coords)>) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 74 - fn add_wall(&mut self, walls: &Vec<(Coords)>) { [INFO] [stdout] 74 + fn add_wall(&mut self, walls: &Vec) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/bin/2022_day14.rs:75:26 [INFO] [stdout] | [INFO] [stdout] 75 | let walls: Vec<(&(Coords), &(Coords))> = walls.iter().zip(walls.iter().skip(1)).collect(); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 75 - let walls: Vec<(&(Coords), &(Coords))> = walls.iter().zip(walls.iter().skip(1)).collect(); [INFO] [stdout] 75 + let walls: Vec<(&Coords, &(Coords))> = walls.iter().zip(walls.iter().skip(1)).collect(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/bin/2022_day14.rs:75:37 [INFO] [stdout] | [INFO] [stdout] 75 | let walls: Vec<(&(Coords), &(Coords))> = walls.iter().zip(walls.iter().skip(1)).collect(); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 75 - let walls: Vec<(&(Coords), &(Coords))> = walls.iter().zip(walls.iter().skip(1)).collect(); [INFO] [stdout] 75 + let walls: Vec<(&(Coords), &Coords)> = walls.iter().zip(walls.iter().skip(1)).collect(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/bin/2022_day14.rs:176:31 [INFO] [stdout] | [INFO] [stdout] 176 | let mut wall: Vec<(Coords)> = Vec::new(); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 176 - let mut wall: Vec<(Coords)> = Vec::new(); [INFO] [stdout] 176 + let mut wall: Vec = Vec::new(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/bin/2022_day14.rs:207:31 [INFO] [stdout] | [INFO] [stdout] 207 | let mut wall: Vec<(Coords)> = Vec::new(); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 207 - let mut wall: Vec<(Coords)> = Vec::new(); [INFO] [stdout] 207 + let mut wall: Vec = Vec::new(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/bin/2022_day14.rs:222:23 [INFO] [stdout] | [INFO] [stdout] 222 | let mut wall: Vec<(Coords)> = Vec::new(); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 222 - let mut wall: Vec<(Coords)> = Vec::new(); [INFO] [stdout] 222 + let mut wall: Vec = Vec::new(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable statement [INFO] [stdout] --> src/bin/2022_day3.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 41 | panic!("shouldnt reach here"); [INFO] [stdout] | ----------------------------- any code following this expression is unreachable [INFO] [stdout] 42 | return 0; [INFO] [stdout] | ^^^^^^^^^ unreachable statement [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable statement [INFO] [stdout] --> src/bin/2022_day3.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 71 | panic!("shouldnt get here!"); [INFO] [stdout] | ---------------------------- any code following this expression is unreachable [INFO] [stdout] 72 | return 0; [INFO] [stdout] | ^^^^^^^^^ unreachable statement [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Write` [INFO] [stdout] --> src/bin/2023_day3.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::io::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/2023_day3.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | for mut x in 0..self.map.len() { [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `game_id` is assigned to, but never used [INFO] [stdout] --> src/bin/2023_day2.rs:73:17 [INFO] [stdout] | [INFO] [stdout] 73 | let mut game_id = 0; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_game_id` instead [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/utils/mod.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn read_lines

(filename: P) -> io::Result>> [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 7 | where P: AsRef, { [INFO] [stdout] 8 | let file = File::open(filename)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | Ok(io::BufReader::new(file).lines()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/utils/mod.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn read_lines

(filename: P) -> io::Result>> [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 7 | where P: AsRef, { [INFO] [stdout] 8 | let file = File::open(filename)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | Ok(io::BufReader::new(file).lines()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/2023_day3.rs:115:13 [INFO] [stdout] | [INFO] [stdout] 115 | for mut x in 0..self.map.len() { [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `advent-of-code` (bin "2023_day2") due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/utils/mod.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn read_lines

(filename: P) -> io::Result>> [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 7 | where P: AsRef, { [INFO] [stdout] 8 | let file = File::open(filename)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | Ok(io::BufReader::new(file).lines()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `makeGame` should have a snake case name [INFO] [stdout] --> src/bin/2022_day2.rs:32:4 [INFO] [stdout] | [INFO] [stdout] 32 | fn makeGame(input: &str) -> (RPS, RPS) { [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `make_game` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `makeGame2` should have a snake case name [INFO] [stdout] --> src/bin/2022_day2.rs:51:4 [INFO] [stdout] | [INFO] [stdout] 51 | fn makeGame2(input: &str) -> (RPS, RPS) { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `make_game2` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `advent-of-code` (bin "2022_day3") due to 2 previous errors; 2 warnings emitted [INFO] [stdout] warning: fields `min_x_y` and `max_x_y` are never read [INFO] [stdout] --> src/bin/2022_day15.rs:142:5 [INFO] [stdout] | [INFO] [stdout] 140 | struct Map { [INFO] [stdout] | --- fields in this struct [INFO] [stdout] 141 | beacons: Vec, [INFO] [stdout] 142 | min_x_y: Coords, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 143 | max_x_y: Coords, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/utils/mod.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn read_lines

(filename: P) -> io::Result>> [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 7 | where P: AsRef, { [INFO] [stdout] 8 | let file = File::open(filename)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | Ok(io::BufReader::new(file).lines()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/bin/2023_day3.rs:204:17 [INFO] [stdout] | [INFO] [stdout] 204 | write!(f, "{}", c); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] = note: this warning originates in the macro `write` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/bin/2023_day3.rs:206:13 [INFO] [stdout] | [INFO] [stdout] 206 | write!(f, "\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: this warning originates in the macro `write` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/utils/mod.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn read_lines

(filename: P) -> io::Result>> [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 7 | where P: AsRef, { [INFO] [stdout] 8 | let file = File::open(filename)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | Ok(io::BufReader::new(file).lines()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/bin/2023_day14.rs:175:9 [INFO] [stdout] | [INFO] [stdout] 175 | for i in 0..1000 { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/utils/mod.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn read_lines

(filename: P) -> io::Result>> [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 7 | where P: AsRef, { [INFO] [stdout] 8 | let file = File::open(filename)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | Ok(io::BufReader::new(file).lines()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `advent-of-code` (bin "2022_day15" test) due to 2 previous errors; 2 warnings emitted [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/utils/mod.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn read_lines

(filename: P) -> io::Result>> [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 7 | where P: AsRef, { [INFO] [stdout] 8 | let file = File::open(filename)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | Ok(io::BufReader::new(file).lines()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `advent-of-code` (bin "2022_day2" test) due to 2 previous errors; 2 warnings emitted [INFO] [stderr] error: could not compile `advent-of-code` (bin "2023_day3" test) due to 2 previous errors; 8 warnings emitted [INFO] [stderr] error: could not compile `advent-of-code` (bin "2023_day13") due to 2 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/utils/mod.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn read_lines

(filename: P) -> io::Result>> [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 7 | where P: AsRef, { [INFO] [stdout] 8 | let file = File::open(filename)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | Ok(io::BufReader::new(file).lines()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `advent-of-code` (bin "2023_day14" test) due to 2 previous errors; 1 warning emitted [INFO] [stdout] error: aborting due to 1 previous error; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `advent-of-code` (bin "2022_day14" test) due to 2 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "3a5ce2fcf2e7dd41b210e109c6814815e2663d5f9e1ab7a93b2586ee993b106e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3a5ce2fcf2e7dd41b210e109c6814815e2663d5f9e1ab7a93b2586ee993b106e", kill_on_drop: false }` [INFO] [stdout] 3a5ce2fcf2e7dd41b210e109c6814815e2663d5f9e1ab7a93b2586ee993b106e