[INFO] cloning repository https://github.com/Peltoche/lsd [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Peltoche/lsd" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPeltoche%2Flsd", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPeltoche%2Flsd'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5b104dcf3ad7861517deb221e23248d51a814968 [INFO] checking Peltoche/lsd/5b104dcf3ad7861517deb221e23248d51a814968 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPeltoche%2Flsd" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Peltoche/lsd on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Peltoche/lsd [INFO] finished tweaking git repo https://github.com/Peltoche/lsd [INFO] tweaked toml for git repo https://github.com/Peltoche/lsd written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Peltoche/lsd already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0e285db4fa00263f7ed6da1bcb1eb5722c7097897757127d107e1fe07064c33d [INFO] running `Command { std: "docker" "start" "-a" "0e285db4fa00263f7ed6da1bcb1eb5722c7097897757127d107e1fe07064c33d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0e285db4fa00263f7ed6da1bcb1eb5722c7097897757127d107e1fe07064c33d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0e285db4fa00263f7ed6da1bcb1eb5722c7097897757127d107e1fe07064c33d", kill_on_drop: false }` [INFO] [stdout] 0e285db4fa00263f7ed6da1bcb1eb5722c7097897757127d107e1fe07064c33d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 02302a4f6cac1b12c9495516029fa9d7e8f8f643826546cadbc2acda6275c9d1 [INFO] running `Command { std: "docker" "start" "-a" "02302a4f6cac1b12c9495516029fa9d7e8f8f643826546cadbc2acda6275c9d1", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling utf8parse v0.2.1 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Compiling rustix v0.38.32 [INFO] [stderr] Compiling anstyle v1.0.6 [INFO] [stderr] Compiling anstyle-parse v0.2.3 [INFO] [stderr] Compiling colorchoice v1.0.0 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling anstyle-query v1.0.2 [INFO] [stderr] Compiling clap_lex v0.5.1 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling rustix v0.37.27 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking linux-raw-sys v0.3.8 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling jobserver v0.1.28 [INFO] [stderr] Compiling is-terminal v0.4.12 [INFO] [stderr] Compiling syn v2.0.57 [INFO] [stderr] Compiling anstream v0.3.2 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking predicates-core v1.0.6 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Compiling cc v1.0.90 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling clap_builder v4.3.24 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking pure-rust-locales v0.8.1 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Compiling thiserror v1.0.58 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking predicates-tree v1.0.9 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking fastrand v2.0.2 [INFO] [stderr] Checking nu-ansi-term v0.49.0 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Compiling assert_cmd v2.0.14 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking lscolors v0.16.0 [INFO] [stderr] Checking term_grid v0.1.7 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Checking uzers v0.11.3 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking xdg v2.5.2 [INFO] [stderr] Checking vsort v0.2.0 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking wild v2.2.1 [INFO] [stderr] Checking human-sort v0.2.2 [INFO] [stderr] Checking sys-locale v0.3.1 [INFO] [stderr] Compiling libz-sys v1.1.16 [INFO] [stderr] Compiling libgit2-sys v0.16.2+1.7.2 [INFO] [stderr] Checking terminal_size v0.2.6 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking bstr v1.9.1 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking predicates v3.1.0 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling clap_derive v4.3.12 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Compiling serial_test_derive v2.0.0 [INFO] [stderr] Checking serial_test v2.0.0 [INFO] [stderr] Checking ignore v0.4.22 [INFO] [stderr] Checking chrono v0.4.37 [INFO] [stderr] Checking chrono-humanize v0.2.3 [INFO] [stderr] Compiling clap v4.3.24 [INFO] [stderr] Compiling clap_complete v4.5.1 [INFO] [stderr] Compiling lsd v1.1.5 (/opt/rustwide/workdir) [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking globwalk v0.9.1 [INFO] [stderr] Checking git2 v0.18.3 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking xattr v1.3.1 [INFO] [stderr] Checking assert_fs v1.1.1 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config_file.rs:138:15 [INFO] [stdout] | [INFO] [stdout] 136 | pub fn from_file>(file: P) -> Option { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | let file = file.as_ref(); [INFO] [stdout] 138 | match fs::read(file) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:57:60 [INFO] [stdout] | [INFO] [stdout] 57 | if let Some(workdir) = repo.workdir().and_then(|x| std::fs::canonicalize(x).ok()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/theme.rs:76:15 [INFO] [stdout] | [INFO] [stdout] 76 | match fs::read_to_string(valid) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/main.rs:75:25 [INFO] [stdout] | [INFO] [stdout] 75 | let mut handle = stderr.lock(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | let res = handle.write_all(std::format!("lsd: {}\n\n", [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/theme/icon.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 10 | deserializer: D, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | HashMap::<_, _>::deserialize(deserializer) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/theme/icon.rs:21:22 [INFO] [stdout] | [INFO] [stdout] 21 | .map(|input| default.into_iter().chain(input).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lsd` (bin "lsd") due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config_file.rs:138:15 [INFO] [stdout] | [INFO] [stdout] 136 | pub fn from_file>(file: P) -> Option { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | let file = file.as_ref(); [INFO] [stdout] 138 | match fs::read(file) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:57:60 [INFO] [stdout] | [INFO] [stdout] 57 | if let Some(workdir) = repo.workdir().and_then(|x| std::fs::canonicalize(x).ok()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/theme.rs:76:15 [INFO] [stdout] | [INFO] [stdout] 76 | match fs::read_to_string(valid) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/main.rs:75:25 [INFO] [stdout] | [INFO] [stdout] 75 | let mut handle = stderr.lock(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | let res = handle.write_all(std::format!("lsd: {}\n\n", [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/theme/icon.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 10 | deserializer: D, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | HashMap::<_, _>::deserialize(deserializer) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/theme/icon.rs:21:22 [INFO] [stdout] | [INFO] [stdout] 21 | .map(|input| default.into_iter().chain(input).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lsd` (bin "lsd" test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "02302a4f6cac1b12c9495516029fa9d7e8f8f643826546cadbc2acda6275c9d1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "02302a4f6cac1b12c9495516029fa9d7e8f8f643826546cadbc2acda6275c9d1", kill_on_drop: false }` [INFO] [stdout] 02302a4f6cac1b12c9495516029fa9d7e8f8f643826546cadbc2acda6275c9d1