[INFO] cloning repository https://github.com/Parth/redis_utils [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Parth/redis_utils" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FParth%2Fredis_utils", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FParth%2Fredis_utils'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e8684134dbd8cff3acc15340e4bbe51b37b9494e [INFO] checking Parth/redis_utils/e8684134dbd8cff3acc15340e4bbe51b37b9494e against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FParth%2Fredis_utils" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Parth/redis_utils on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Parth/redis_utils [INFO] finished tweaking git repo https://github.com/Parth/redis_utils [INFO] tweaked toml for git repo https://github.com/Parth/redis_utils written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Parth/redis_utils already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fd83fc73c71f8cf2bcef123f17b81998890258fb9109a8db01e22c1a15716ff6 [INFO] running `Command { std: "docker" "start" "-a" "fd83fc73c71f8cf2bcef123f17b81998890258fb9109a8db01e22c1a15716ff6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fd83fc73c71f8cf2bcef123f17b81998890258fb9109a8db01e22c1a15716ff6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fd83fc73c71f8cf2bcef123f17b81998890258fb9109a8db01e22c1a15716ff6", kill_on_drop: false }` [INFO] [stdout] fd83fc73c71f8cf2bcef123f17b81998890258fb9109a8db01e22c1a15716ff6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b689a05136a4603081fb8e39e45e7490836d48ab29bc9b990574070ded670c99 [INFO] running `Command { std: "docker" "start" "-a" "b689a05136a4603081fb8e39e45e7490836d48ab29bc9b990574070ded670c99", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling libc v0.2.112 [INFO] [stderr] Compiling syn v1.0.84 [INFO] [stderr] Compiling futures-core v0.3.19 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Checking pin-project-lite v0.2.8 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Compiling serde_derive v1.0.133 [INFO] [stderr] Compiling futures-task v0.3.19 [INFO] [stderr] Checking futures-sink v0.3.19 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Compiling serde v1.0.133 [INFO] [stderr] Compiling futures-util v0.3.19 [INFO] [stderr] Compiling async-trait v0.1.52 [INFO] [stderr] Checking unicode-bidi v0.3.7 [INFO] [stderr] Checking tinyvec v1.5.1 [INFO] [stderr] Compiling serde_json v1.0.74 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking ryu v1.0.9 [INFO] [stderr] Checking dtoa v0.4.8 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Compiling quote v1.0.14 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Checking mio v0.7.14 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking tokio v1.15.0 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking tokio-util v0.6.9 [INFO] [stderr] Checking combine v4.6.2 [INFO] [stderr] Checking redis v0.21.4 [INFO] [stderr] Checking redis_utils v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> src/converters.rs:174:5 [INFO] [stdout] | [INFO] [stdout] 174 | async fn watch_json_mget( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: FromRedisValue` will fail [INFO] [stdout] --> src/converters.rs:178:39 [INFO] [stdout] | [INFO] [stdout] 178 | redis::cmd("WATCH").arg(&key).query_async(self).await?; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(dependency_on_unit_never_type_fallback)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> src/converters.rs:174:5 [INFO] [stdout] | [INFO] [stdout] 174 | async fn watch_json_mget( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: FromRedisValue` will fail [INFO] [stdout] --> src/converters.rs:178:39 [INFO] [stdout] | [INFO] [stdout] 178 | redis::cmd("WATCH").arg(&key).query_async(self).await?; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(dependency_on_unit_never_type_fallback)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/converters.rs:65:35 [INFO] [stdout] | [INFO] [stdout] 63 | key: Key, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | val: Val, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | ) -> Result<(), JsonSetError> { [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 66 | | Ok(self.set(key, serde_json::to_string(&val)?).await?) [INFO] [stdout] 67 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/converters.rs:139:36 [INFO] [stdout] | [INFO] [stdout] 138 | key: Key, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | ) -> Result { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 140 | | let val: String = self.get(key).await?; [INFO] [stdout] 141 | | Ok(serde_json::from_str(&val)?) [INFO] [stdout] 142 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/converters.rs:148:44 [INFO] [stdout] | [INFO] [stdout] 147 | key: Key, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | ) -> Result, JsonGetError> { [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 149 | | let val: Option = self.get(key).await?; [INFO] [stdout] 150 | | match val { [INFO] [stdout] 151 | | Some(string) => Ok(Some(serde_json::from_str(&string)?)), [INFO] [stdout] 152 | | None => Ok(None), [INFO] [stdout] 153 | | } [INFO] [stdout] 154 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/converters.rs:160:41 [INFO] [stdout] | [INFO] [stdout] 159 | keys: Key, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | ) -> Result, JsonGetError> { [INFO] [stdout] | _________________________________________^ [INFO] [stdout] 161 | | if keys.is_single_arg() { [INFO] [stdout] 162 | | Ok(self.maybe_json_get(keys).await?.into_iter().collect()) [INFO] [stdout] 163 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 170 | | } [INFO] [stdout] 171 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/converters.rs:177:41 [INFO] [stdout] | [INFO] [stdout] 176 | key: Key, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | ) -> Result, JsonGetError> { [INFO] [stdout] | _________________________________________^ [INFO] [stdout] 178 | | redis::cmd("WATCH").arg(&key).query_async(self).await?; [INFO] [stdout] 179 | | Ok(self.json_mget(key).await?) [INFO] [stdout] 180 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/converters.rs:65:35 [INFO] [stdout] | [INFO] [stdout] 63 | key: Key, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | val: Val, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | ) -> Result<(), JsonSetError> { [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 66 | | Ok(self.set(key, serde_json::to_string(&val)?).await?) [INFO] [stdout] 67 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/converters.rs:139:36 [INFO] [stdout] | [INFO] [stdout] 138 | key: Key, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | ) -> Result { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 140 | | let val: String = self.get(key).await?; [INFO] [stdout] 141 | | Ok(serde_json::from_str(&val)?) [INFO] [stdout] 142 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/converters.rs:148:44 [INFO] [stdout] | [INFO] [stdout] 147 | key: Key, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | ) -> Result, JsonGetError> { [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 149 | | let val: Option = self.get(key).await?; [INFO] [stdout] 150 | | match val { [INFO] [stdout] 151 | | Some(string) => Ok(Some(serde_json::from_str(&string)?)), [INFO] [stdout] 152 | | None => Ok(None), [INFO] [stdout] 153 | | } [INFO] [stdout] 154 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/converters.rs:160:41 [INFO] [stdout] | [INFO] [stdout] 159 | keys: Key, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | ) -> Result, JsonGetError> { [INFO] [stdout] | _________________________________________^ [INFO] [stdout] 161 | | if keys.is_single_arg() { [INFO] [stdout] 162 | | Ok(self.maybe_json_get(keys).await?.into_iter().collect()) [INFO] [stdout] 163 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 170 | | } [INFO] [stdout] 171 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/converters.rs:177:41 [INFO] [stdout] | [INFO] [stdout] 176 | key: Key, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | ) -> Result, JsonGetError> { [INFO] [stdout] | _________________________________________^ [INFO] [stdout] 178 | | redis::cmd("WATCH").arg(&key).query_async(self).await?; [INFO] [stdout] 179 | | Ok(self.json_mget(key).await?) [INFO] [stdout] 180 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `redis_utils` (lib) due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `redis_utils` (lib test) due to 6 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "b689a05136a4603081fb8e39e45e7490836d48ab29bc9b990574070ded670c99", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b689a05136a4603081fb8e39e45e7490836d48ab29bc9b990574070ded670c99", kill_on_drop: false }` [INFO] [stdout] b689a05136a4603081fb8e39e45e7490836d48ab29bc9b990574070ded670c99