[INFO] cloning repository https://github.com/Pantonshire/small_robots_archive [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Pantonshire/small_robots_archive" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPantonshire%2Fsmall_robots_archive", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPantonshire%2Fsmall_robots_archive'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e2fe384e7ad1ce6f9e0f70d609dce2e325b40ee2 [INFO] checking Pantonshire/small_robots_archive/e2fe384e7ad1ce6f9e0f70d609dce2e325b40ee2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPantonshire%2Fsmall_robots_archive" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Pantonshire/small_robots_archive on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Pantonshire/small_robots_archive [INFO] finished tweaking git repo https://github.com/Pantonshire/small_robots_archive [INFO] tweaked toml for git repo https://github.com/Pantonshire/small_robots_archive written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Pantonshire/small_robots_archive already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e5e242e68ddaa7df74e6d9d13231388baf592086c9f89a7c3e9db7dc81d6a7a3 [INFO] running `Command { std: "docker" "start" "-a" "e5e242e68ddaa7df74e6d9d13231388baf592086c9f89a7c3e9db7dc81d6a7a3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e5e242e68ddaa7df74e6d9d13231388baf592086c9f89a7c3e9db7dc81d6a7a3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e5e242e68ddaa7df74e6d9d13231388baf592086c9f89a7c3e9db7dc81d6a7a3", kill_on_drop: false }` [INFO] [stdout] e5e242e68ddaa7df74e6d9d13231388baf592086c9f89a7c3e9db7dc81d6a7a3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 202e0346330752c13557b6401811118aa645946070808ef005f81b1aa758d878 [INFO] running `Command { std: "docker" "start" "-a" "202e0346330752c13557b6401811118aa645946070808ef005f81b1aa758d878", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.103 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling proc-macro2 v1.0.29 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.80 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling futures-core v0.3.17 [INFO] [stderr] Compiling parking_lot_core v0.8.5 [INFO] [stderr] Compiling typenum v1.14.0 [INFO] [stderr] Checking once_cell v1.8.0 [INFO] [stderr] Checking pin-project-lite v0.2.7 [INFO] [stderr] Checking smallvec v1.7.0 [INFO] [stderr] Checking instant v0.1.11 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling serde_derive v1.0.130 [INFO] [stderr] Compiling serde v1.0.130 [INFO] [stderr] Checking lock_api v0.4.5 [INFO] [stderr] Compiling futures-task v0.3.17 [INFO] [stderr] Checking futures-sink v0.3.17 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling generic-array v0.14.4 [INFO] [stderr] Compiling ahash v0.7.4 [INFO] [stderr] Compiling tokio v1.12.0 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling futures-util v0.3.17 [INFO] [stderr] Compiling indexmap v1.7.0 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Compiling standback v0.2.17 [INFO] [stderr] Compiling spin v0.5.2 [INFO] [stderr] Compiling untrusted v0.7.1 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling nom v7.0.0 [INFO] [stderr] Compiling serde_json v1.0.68 [INFO] [stderr] Compiling proc-macro-hack v0.5.19 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Checking tinyvec v1.5.0 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Checking opaque-debug v0.3.0 [INFO] [stderr] Compiling unicase v2.6.0 [INFO] [stderr] Checking local-waker v0.1.1 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Checking unicode-bidi v0.3.6 [INFO] [stderr] Compiling jobserver v0.1.24 [INFO] [stderr] Compiling getrandom v0.2.3 [INFO] [stderr] Compiling mio v0.7.13 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Compiling cc v1.0.70 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking cpufeatures v0.2.1 [INFO] [stderr] Compiling const_fn v0.4.8 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Compiling futures-channel v0.3.17 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Compiling crossbeam-queue v0.3.2 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Compiling whoami v1.1.5 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking http v0.2.5 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Compiling time v0.2.27 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Compiling crc32fast v1.2.1 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Compiling zstd-sys v1.5.0+zstd.1.4.9 [INFO] [stderr] Compiling brotli-sys v0.3.2 [INFO] [stderr] Compiling paste v1.0.5 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Compiling zstd-safe v3.1.0+zstd.1.4.9 [INFO] [stderr] Checking sha-1 v0.9.8 [INFO] [stderr] Checking actix-service v2.0.0 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking actix-utils v3.0.0 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking tracing-core v0.1.21 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling encoding_rs v0.8.28 [INFO] [stderr] Compiling minimal-lexical v0.1.4 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking slab v0.4.4 [INFO] [stderr] Compiling httparse v1.5.1 [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Compiling subtle v2.4.1 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Compiling crypto-mac v0.11.1 [INFO] [stderr] Compiling itertools v0.10.1 [INFO] [stderr] Checking tracing v0.1.29 [INFO] [stderr] Compiling time v0.1.43 [INFO] [stderr] Compiling dirs-sys v0.3.6 [INFO] [stderr] Compiling bytestring v1.0.0 [INFO] [stderr] Compiling cookie v0.15.1 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling pin-utils v0.1.0 [INFO] [stderr] Compiling crc-catalog v1.1.1 [INFO] [stderr] Compiling unicode_categories v0.1.1 [INFO] [stderr] Checking mime v0.3.16 [INFO] [stderr] Compiling firestorm v0.4.6 [INFO] [stderr] Compiling chrono v0.4.19 [INFO] [stderr] Compiling crc v2.0.0 [INFO] [stderr] Compiling dirs v3.0.2 [INFO] [stderr] Compiling mime_guess v2.0.3 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking flate2 v1.0.22 [INFO] [stderr] Checking tokio-util v0.6.8 [INFO] [stderr] Checking webpki v0.21.4 [INFO] [stderr] Compiling sct v0.6.1 [INFO] [stderr] Checking local-channel v0.1.2 [INFO] [stderr] Compiling hmac v0.11.0 [INFO] [stderr] Checking actix-codec v0.4.0 [INFO] [stderr] Checking rustls v0.19.1 [INFO] [stderr] Checking h2 v0.3.6 [INFO] [stderr] Compiling webpki-roots v0.21.1 [INFO] [stderr] Compiling sqlformat v0.1.8 [INFO] [stderr] Compiling sha2 v0.9.8 [INFO] [stderr] Compiling hashlink v0.7.0 [INFO] [stderr] Compiling stringprep v0.1.2 [INFO] [stderr] Compiling crossbeam-channel v0.5.1 [INFO] [stderr] Compiling atoi v0.4.0 [INFO] [stderr] Compiling md-5 v0.9.1 [INFO] [stderr] Compiling futures-intrusive v0.4.0 [INFO] [stderr] Compiling tokio-stream v0.1.7 [INFO] [stderr] Checking language-tags v0.3.2 [INFO] [stderr] Compiling byteorder v1.4.3 [INFO] [stderr] Compiling unicode-segmentation v1.8.0 [INFO] [stderr] Compiling hex v0.4.3 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking tokio-rustls v0.22.0 [INFO] [stderr] Checking socket2 v0.4.2 [INFO] [stderr] Compiling dotenv v0.15.0 [INFO] [stderr] Compiling maud_htmlescape v0.17.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking http-range v0.1.4 [INFO] [stderr] Checking askama_escape v0.10.1 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking unidecode v0.3.0 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Compiling actix-macros v0.2.1 [INFO] [stderr] Compiling time-macros-impl v0.1.2 [INFO] [stderr] Compiling thiserror-impl v1.0.29 [INFO] [stderr] Compiling derive_more v0.99.16 [INFO] [stderr] Checking actix-rt v2.2.0 [INFO] [stderr] Compiling pin-project-internal v1.0.8 [INFO] [stderr] Checking time-macros v0.1.1 [INFO] [stderr] Compiling sqlx-rt v0.5.9 [INFO] [stderr] Checking actix-server v2.0.0-beta.5 [INFO] [stderr] Compiling maud_macros v0.22.3 [INFO] [stderr] Compiling thiserror v1.0.29 [INFO] [stderr] Checking brotli2 v0.3.2 [INFO] [stderr] Checking pin-project v1.0.8 [INFO] [stderr] Checking maud v0.22.3 [INFO] [stderr] Checking actix-tls v3.0.0-beta.5 [INFO] [stderr] Checking actix-router v0.5.0-beta.2 [INFO] [stderr] Checking serde_urlencoded v0.7.0 [INFO] [stderr] Compiling actix-web-codegen v0.5.0-beta.4 [INFO] [stderr] Checking sqlx-core v0.5.9 [INFO] [stderr] Compiling sqlx-macros v0.5.9 [INFO] [stderr] Checking sqlx v0.5.9 [INFO] [stderr] Checking zstd v0.7.0+zstd.1.4.9 [INFO] [stderr] Checking actix-http v3.0.0-beta.10 [INFO] [stderr] Checking actix-web v4.0.0-beta.9 [INFO] [stderr] Checking actix-files v0.6.0-beta.7 [INFO] [stderr] Checking sbb_archive v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `id` and `content_warning` are never read [INFO] [stdout] --> src/robots.rs:101:16 [INFO] [stdout] | [INFO] [stdout] 100 | pub(crate) struct RobotTextLink { [INFO] [stdout] | ------------- fields in this struct [INFO] [stdout] 101 | pub(crate) id: i32, [INFO] [stdout] | ^^ [INFO] [stdout] ... [INFO] [stdout] 107 | pub(crate) content_warning: Option, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RobotTextLink` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `content_warning` is never read [INFO] [stdout] --> src/robots.rs:137:16 [INFO] [stdout] | [INFO] [stdout] 130 | pub(crate) struct RobotPreview { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 137 | pub(crate) content_warning: Option, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RobotPreview` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `id` is never read [INFO] [stdout] --> src/robots.rs:174:16 [INFO] [stdout] | [INFO] [stdout] 173 | pub(crate) struct RobotFull { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 174 | pub(crate) id: i32, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `RobotFull` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:63:23 [INFO] [stdout] | [INFO] [stdout] 62 | fn from(err: sqlx::Error) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | Self::DbError(Box::new(err)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:69:23 [INFO] [stdout] | [INFO] [stdout] 68 | fn from(err: io::Error) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | Self::IoError(Box::new(err)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:281:24 [INFO] [stdout] | [INFO] [stdout] 281 | .ok_or_else(|| SiteError::BadRequest.report(format!("invalid page number {}", page)))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:414:35 [INFO] [stdout] | [INFO] [stdout] 414 | .and_then(|robot| robot.ok_or(SiteError::NotFound)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:660:9 [INFO] [stdout] | [INFO] [stdout] 649 | let instance_meta = { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 654 | let pool = { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 660 | / App::new() [INFO] [stdout] 661 | | .app_data(instance_meta.clone()) [INFO] [stdout] 662 | | .app_data(CloneData::new(pool.clone())) [INFO] [stdout] 663 | | .service(fs::Files::new("/static", "./static")) [INFO] [stdout] ... | [INFO] [stdout] 673 | | .service(random_robot) [INFO] [stdout] 674 | | .service(about_page) [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:675:30 [INFO] [stdout] | [INFO] [stdout] 649 | let instance_meta = { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 654 | let pool = { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 675 | .default_service(web::route().to(not_found)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:100:29 [INFO] [stdout] | [INFO] [stdout] 99 | fn from(err: sqlx::Error) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | Self::DatabaseError(Box::new(err)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:110:9 [INFO] [stdout] | [INFO] [stdout] 109 | fn into_report(self, message: S) -> SiteReportError where S: Into> { [INFO] [stdout] | ---- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | self.into().report(message) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `id` and `content_warning` are never read [INFO] [stdout] --> src/robots.rs:101:16 [INFO] [stdout] | [INFO] [stdout] 100 | pub(crate) struct RobotTextLink { [INFO] [stdout] | ------------- fields in this struct [INFO] [stdout] 101 | pub(crate) id: i32, [INFO] [stdout] | ^^ [INFO] [stdout] ... [INFO] [stdout] 107 | pub(crate) content_warning: Option, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RobotTextLink` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `content_warning` is never read [INFO] [stdout] --> src/robots.rs:137:16 [INFO] [stdout] | [INFO] [stdout] 130 | pub(crate) struct RobotPreview { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 137 | pub(crate) content_warning: Option, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RobotPreview` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `id` is never read [INFO] [stdout] --> src/robots.rs:174:16 [INFO] [stdout] | [INFO] [stdout] 173 | pub(crate) struct RobotFull { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 174 | pub(crate) id: i32, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `RobotFull` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:63:23 [INFO] [stdout] | [INFO] [stdout] 62 | fn from(err: sqlx::Error) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | Self::DbError(Box::new(err)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:69:23 [INFO] [stdout] | [INFO] [stdout] 68 | fn from(err: io::Error) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | Self::IoError(Box::new(err)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:281:24 [INFO] [stdout] | [INFO] [stdout] 281 | .ok_or_else(|| SiteError::BadRequest.report(format!("invalid page number {}", page)))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:414:35 [INFO] [stdout] | [INFO] [stdout] 414 | .and_then(|robot| robot.ok_or(SiteError::NotFound)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:660:9 [INFO] [stdout] | [INFO] [stdout] 649 | let instance_meta = { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 654 | let pool = { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 660 | / App::new() [INFO] [stdout] 661 | | .app_data(instance_meta.clone()) [INFO] [stdout] 662 | | .app_data(CloneData::new(pool.clone())) [INFO] [stdout] 663 | | .service(fs::Files::new("/static", "./static")) [INFO] [stdout] ... | [INFO] [stdout] 673 | | .service(random_robot) [INFO] [stdout] 674 | | .service(about_page) [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:675:30 [INFO] [stdout] | [INFO] [stdout] 649 | let instance_meta = { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 654 | let pool = { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 675 | .default_service(web::route().to(not_found)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:100:29 [INFO] [stdout] | [INFO] [stdout] 99 | fn from(err: sqlx::Error) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | Self::DatabaseError(Box::new(err)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:110:9 [INFO] [stdout] | [INFO] [stdout] 109 | fn into_report(self, message: S) -> SiteReportError where S: Into> { [INFO] [stdout] | ---- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | self.into().report(message) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sbb_archive` (bin "sbb_archive") due to 9 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 8 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sbb_archive` (bin "sbb_archive" test) due to 9 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "202e0346330752c13557b6401811118aa645946070808ef005f81b1aa758d878", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "202e0346330752c13557b6401811118aa645946070808ef005f81b1aa758d878", kill_on_drop: false }` [INFO] [stdout] 202e0346330752c13557b6401811118aa645946070808ef005f81b1aa758d878