[INFO] cloning repository https://github.com/PBertinJohannet/exprToSop [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/PBertinJohannet/exprToSop" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPBertinJohannet%2FexprToSop", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPBertinJohannet%2FexprToSop'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5b7c37113c878ff00c4e207c2e5969ac403a381d [INFO] checking PBertinJohannet/exprToSop/5b7c37113c878ff00c4e207c2e5969ac403a381d against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FPBertinJohannet%2FexprToSop" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/PBertinJohannet/exprToSop on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/PBertinJohannet/exprToSop [INFO] finished tweaking git repo https://github.com/PBertinJohannet/exprToSop [INFO] tweaked toml for git repo https://github.com/PBertinJohannet/exprToSop written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/PBertinJohannet/exprToSop already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f501ad71d1afbc78d8691e0392fba0255378d2f64e4cc8edbc5cc74d08b1d376 [INFO] running `Command { std: "docker" "start" "-a" "f501ad71d1afbc78d8691e0392fba0255378d2f64e4cc8edbc5cc74d08b1d376", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f501ad71d1afbc78d8691e0392fba0255378d2f64e4cc8edbc5cc74d08b1d376", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f501ad71d1afbc78d8691e0392fba0255378d2f64e4cc8edbc5cc74d08b1d376", kill_on_drop: false }` [INFO] [stdout] f501ad71d1afbc78d8691e0392fba0255378d2f64e4cc8edbc5cc74d08b1d376 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3adeeef516fd373c1908c9e914836ce63c811ce5b514237ff083ecf5703ecd4e [INFO] running `Command { std: "docker" "start" "-a" "3adeeef516fd373c1908c9e914836ce63c811ce5b514237ff083ecf5703ecd4e", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking libc v0.2.42 [INFO] [stderr] Checking rand_core v0.2.1 [INFO] [stderr] Checking rand v0.5.4 [INFO] [stderr] Checking booleansimplify v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/lexer.rs:74:16 [INFO] [stdout] | [INFO] [stdout] 74 | '2'...'9' => self.identifier(), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/lexer.rs:75:16 [INFO] [stdout] | [INFO] [stdout] 75 | 'a'...'z' => self.identifier(), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/lexer.rs:76:16 [INFO] [stdout] | [INFO] [stdout] 76 | 'A'...'Z' => self.identifier(), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::env` [INFO] [stdout] --> src/main.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::env; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Sum` [INFO] [stdout] --> src/mccluskey.rs:3:26 [INFO] [stdout] | [INFO] [stdout] 3 | use equation::{Equation, Sum, Prod, Not}; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Not`, `Prod`, and `Sum` [INFO] [stdout] --> src/equation.rs:434:30 [INFO] [stdout] | [INFO] [stdout] 434 | use equation::{Equation, Not, Prod, Sum}; [INFO] [stdout] | ^^^ ^^^^ ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `lexer::EqLexer` [INFO] [stdout] --> src/equation.rs:435:9 [INFO] [stdout] | [INFO] [stdout] 435 | use lexer::EqLexer; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/equation.rs:489:9 [INFO] [stdout] | [INFO] [stdout] 489 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Not`, `Prod`, and `Sum` [INFO] [stdout] --> src/equation.rs:490:30 [INFO] [stdout] | [INFO] [stdout] 490 | use equation::{Equation, Not, Prod, Sum}; [INFO] [stdout] | ^^^ ^^^^ ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `lexer::EqLexer` [INFO] [stdout] --> src/equation.rs:491:9 [INFO] [stdout] | [INFO] [stdout] 491 | use lexer::EqLexer; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/equation.rs:511:9 [INFO] [stdout] | [INFO] [stdout] 511 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Not`, `Prod`, and `Sum` [INFO] [stdout] --> src/equation.rs:512:30 [INFO] [stdout] | [INFO] [stdout] 512 | use equation::{Equation, Not, Prod, Sum}; [INFO] [stdout] | ^^^ ^^^^ ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `lexer::EqLexer` [INFO] [stdout] --> src/equation.rs:513:9 [INFO] [stdout] | [INFO] [stdout] 513 | use lexer::EqLexer; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/equation.rs:529:9 [INFO] [stdout] | [INFO] [stdout] 529 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Not`, `Prod`, and `Sum` [INFO] [stdout] --> src/equation.rs:530:30 [INFO] [stdout] | [INFO] [stdout] 530 | use equation::{Equation, Not, Prod, Sum}; [INFO] [stdout] | ^^^ ^^^^ ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `lexer::EqLexer` [INFO] [stdout] --> src/equation.rs:531:9 [INFO] [stdout] | [INFO] [stdout] 531 | use lexer::EqLexer; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/lexer.rs:74:16 [INFO] [stdout] | [INFO] [stdout] 74 | '2'...'9' => self.identifier(), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/lexer.rs:75:16 [INFO] [stdout] | [INFO] [stdout] 75 | 'a'...'z' => self.identifier(), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/lexer.rs:76:16 [INFO] [stdout] | [INFO] [stdout] 76 | 'A'...'Z' => self.identifier(), [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::env` [INFO] [stdout] --> src/main.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::env; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Sum` [INFO] [stdout] --> src/mccluskey.rs:3:26 [INFO] [stdout] | [INFO] [stdout] 3 | use equation::{Equation, Sum, Prod, Not}; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Not` and `Prod` [INFO] [stdout] --> src/mccluskey.rs:194:30 [INFO] [stdout] | [INFO] [stdout] 194 | use equation::{Equation, Not, Prod, Sum}; [INFO] [stdout] | ^^^ ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Not`, `Prod`, and `Sum` [INFO] [stdout] --> src/mccluskey.rs:241:30 [INFO] [stdout] | [INFO] [stdout] 241 | use equation::{Equation, Not, Prod, Sum}; [INFO] [stdout] | ^^^ ^^^^ ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Not`, `Prod`, and `Sum` [INFO] [stdout] --> src/mccluskey.rs:281:30 [INFO] [stdout] | [INFO] [stdout] 281 | use equation::{Equation, Not, Prod, Sum}; [INFO] [stdout] | ^^^ ^^^^ ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Not`, `Prod`, and `Sum` [INFO] [stdout] --> src/mccluskey.rs:299:30 [INFO] [stdout] | [INFO] [stdout] 299 | use equation::{Equation, Not, Prod, Sum}; [INFO] [stdout] | ^^^ ^^^^ ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `new_sum` [INFO] [stdout] --> src/equation.rs:68:13 [INFO] [stdout] | [INFO] [stdout] 68 | let new_sum = match self { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_new_sum` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `v` [INFO] [stdout] --> src/equation.rs:82:13 [INFO] [stdout] | [INFO] [stdout] 82 | v => vec![self], [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_v` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ancient_nb_var` [INFO] [stdout] --> src/equation.rs:106:13 [INFO] [stdout] | [INFO] [stdout] 106 | let ancient_nb_var = self.get_vars().len(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_ancient_nb_var` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `s` [INFO] [stdout] --> src/mccluskey.rs:24:32 [INFO] [stdout] | [INFO] [stdout] 24 | &Equation::Sum(ref s) => panic!("do not give a sum to from_eq"), [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_s` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `new_sum` [INFO] [stdout] --> src/equation.rs:68:13 [INFO] [stdout] | [INFO] [stdout] 68 | let new_sum = match self { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_new_sum` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `v` [INFO] [stdout] --> src/equation.rs:82:13 [INFO] [stdout] | [INFO] [stdout] 82 | v => vec![self], [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_v` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ancient_nb_var` [INFO] [stdout] --> src/equation.rs:106:13 [INFO] [stdout] | [INFO] [stdout] 106 | let ancient_nb_var = self.get_vars().len(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_ancient_nb_var` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/mccluskey.rs:134:25 [INFO] [stdout] | [INFO] [stdout] 134 | pub fn mccluskey((vars, mut impls) : (Vec, Vec)) -> Vec{ [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/mccluskey.rs:165:24 [INFO] [stdout] | [INFO] [stdout] 165 | while let Some(mut curr) = now.pop(){ [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/mccluskey.rs:176:25 [INFO] [stdout] | [INFO] [stdout] 176 | pub fn mccluskey_primes(mut impls : Vec)-> Vec{ [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/mccluskey.rs:180:13 [INFO] [stdout] | [INFO] [stdout] 180 | let mut to_add = mccluskey_pass_two(sort_prime_implicants(mccluskey_pass_one(sorted_primes))); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `len_removed`, `eval`, `inners`, `compare_random_values`, `is_product`, and `get_owned_vars` are never used [INFO] [stdout] --> src/equation.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 19 | impl Equation { [INFO] [stdout] | ------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 50 | pub fn len_removed(&mut self) -> usize{ [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 57 | pub fn eval(&self, vars: &HashMap) -> bool { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 77 | pub fn inners(&self) -> Vec<&Equation> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 87 | pub fn compare_random_values(&self, other : &Equation, tests : usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 120 | pub fn is_product(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 175 | pub fn get_owned_vars(&self) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_owned_vars` is never used [INFO] [stdout] --> src/equation.rs:250:12 [INFO] [stdout] | [INFO] [stdout] 236 | impl Sum { [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 250 | pub fn get_owned_vars(&self) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/equation.rs:63:42 [INFO] [stdout] | [INFO] [stdout] 63 | .unwrap_or_else(||panic!(format!("var not found : {}", e))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 63 - .unwrap_or_else(||panic!(format!("var not found : {}", e))), [INFO] [stdout] 63 + .unwrap_or_else(||panic!("var not found : {}", e)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/equation.rs:344:9 [INFO] [stdout] | [INFO] [stdout] 336 | pub fn factorise_for(mut self, i: usize) -> Equation { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 337 | let removed = self.inner.remove(i); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 338 | let mut new_sum_of_products = vec![]; [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 344 | Equation::Sum(Box::new(Sum::new(new_sum_of_products))).complete_simplify() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/equation.rs:417:44 [INFO] [stdout] | [INFO] [stdout] 417 | .map(|i| Equation::Not(Box::new(Not::new(i)))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/equation.rs:423:44 [INFO] [stdout] | [INFO] [stdout] 423 | .map(|i| Equation::Not(Box::new(Not::new(i)))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:51:23 [INFO] [stdout] | [INFO] [stdout] 46 | let mut sm = vec![self.prod()]; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | Equation::Sum(Box::new(Sum::new(sm))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:60:24 [INFO] [stdout] | [INFO] [stdout] 55 | let mut sm = vec![self.not()]; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | Equation::Prod(Box::new(Prod::new(sm))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/parser.rs:84:29 [INFO] [stdout] | [INFO] [stdout] 84 | u => panic!(format!( [INFO] [stdout] | _____________________________^ [INFO] [stdout] 85 | | "error, expected variable or rparen, found {:?} at : {}", [INFO] [stdout] 86 | | u, pos [INFO] [stdout] 87 | | )), [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 84 ~ u => panic!( [INFO] [stdout] 85 | "error, expected variable or rparen, found {:?} at : {}", [INFO] [stdout] 86 | u, pos [INFO] [stdout] 87 ~ ), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mccluskey.rs:32:51 [INFO] [stdout] | [INFO] [stdout] 32 | let list = vars.iter().map( | &var| match p.removed_doublons().iter() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 17 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/equation.rs:536:13 [INFO] [stdout] | [INFO] [stdout] 536 | let mut new_eq = eq.complete_simplify(); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `booleansimplify` (bin "booleansimplify") due to 7 previous errors; 17 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `s` [INFO] [stdout] --> src/mccluskey.rs:24:32 [INFO] [stdout] | [INFO] [stdout] 24 | &Equation::Sum(ref s) => panic!("do not give a sum to from_eq"), [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_s` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/mccluskey.rs:134:25 [INFO] [stdout] | [INFO] [stdout] 134 | pub fn mccluskey((vars, mut impls) : (Vec, Vec)) -> Vec{ [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/mccluskey.rs:165:24 [INFO] [stdout] | [INFO] [stdout] 165 | while let Some(mut curr) = now.pop(){ [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/mccluskey.rs:176:25 [INFO] [stdout] | [INFO] [stdout] 176 | pub fn mccluskey_primes(mut impls : Vec)-> Vec{ [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/mccluskey.rs:180:13 [INFO] [stdout] | [INFO] [stdout] 180 | let mut to_add = mccluskey_pass_two(sort_prime_implicants(mccluskey_pass_one(sorted_primes))); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `len_removed`, `inners`, `is_product`, and `get_owned_vars` are never used [INFO] [stdout] --> src/equation.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 19 | impl Equation { [INFO] [stdout] | ------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 50 | pub fn len_removed(&mut self) -> usize{ [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 77 | pub fn inners(&self) -> Vec<&Equation> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 120 | pub fn is_product(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 175 | pub fn get_owned_vars(&self) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_owned_vars` is never used [INFO] [stdout] --> src/equation.rs:250:12 [INFO] [stdout] | [INFO] [stdout] 236 | impl Sum { [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 250 | pub fn get_owned_vars(&self) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/equation.rs:63:42 [INFO] [stdout] | [INFO] [stdout] 63 | .unwrap_or_else(||panic!(format!("var not found : {}", e))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 63 - .unwrap_or_else(||panic!(format!("var not found : {}", e))), [INFO] [stdout] 63 + .unwrap_or_else(||panic!("var not found : {}", e)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/equation.rs:344:9 [INFO] [stdout] | [INFO] [stdout] 336 | pub fn factorise_for(mut self, i: usize) -> Equation { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 337 | let removed = self.inner.remove(i); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 338 | let mut new_sum_of_products = vec![]; [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 344 | Equation::Sum(Box::new(Sum::new(new_sum_of_products))).complete_simplify() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/equation.rs:417:44 [INFO] [stdout] | [INFO] [stdout] 417 | .map(|i| Equation::Not(Box::new(Not::new(i)))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/equation.rs:423:44 [INFO] [stdout] | [INFO] [stdout] 423 | .map(|i| Equation::Not(Box::new(Not::new(i)))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:51:23 [INFO] [stdout] | [INFO] [stdout] 46 | let mut sm = vec![self.prod()]; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | Equation::Sum(Box::new(Sum::new(sm))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:60:24 [INFO] [stdout] | [INFO] [stdout] 55 | let mut sm = vec![self.not()]; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | Equation::Prod(Box::new(Prod::new(sm))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/parser.rs:84:29 [INFO] [stdout] | [INFO] [stdout] 84 | u => panic!(format!( [INFO] [stdout] | _____________________________^ [INFO] [stdout] 85 | | "error, expected variable or rparen, found {:?} at : {}", [INFO] [stdout] 86 | | u, pos [INFO] [stdout] 87 | | )), [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 84 ~ u => panic!( [INFO] [stdout] 85 | "error, expected variable or rparen, found {:?} at : {}", [INFO] [stdout] 86 | u, pos [INFO] [stdout] 87 ~ ), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mccluskey.rs:32:51 [INFO] [stdout] | [INFO] [stdout] 32 | let list = vars.iter().map( | &var| match p.removed_doublons().iter() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 33 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `booleansimplify` (bin "booleansimplify" test) due to 7 previous errors; 33 warnings emitted [INFO] running `Command { std: "docker" "inspect" "3adeeef516fd373c1908c9e914836ce63c811ce5b514237ff083ecf5703ecd4e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3adeeef516fd373c1908c9e914836ce63c811ce5b514237ff083ecf5703ecd4e", kill_on_drop: false }` [INFO] [stdout] 3adeeef516fd373c1908c9e914836ce63c811ce5b514237ff083ecf5703ecd4e