[INFO] cloning repository https://github.com/Outspending/minecraft-protocol [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Outspending/minecraft-protocol" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FOutspending%2Fminecraft-protocol", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FOutspending%2Fminecraft-protocol'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c50f01e8bf481defdfe26c8d5ad667af088da73a [INFO] checking Outspending/minecraft-protocol/c50f01e8bf481defdfe26c8d5ad667af088da73a against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FOutspending%2Fminecraft-protocol" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Outspending/minecraft-protocol on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Outspending/minecraft-protocol [INFO] finished tweaking git repo https://github.com/Outspending/minecraft-protocol [INFO] tweaked toml for git repo https://github.com/Outspending/minecraft-protocol written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Outspending/minecraft-protocol already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a87b91fbf3c46d4a9ae4a9328fcb1fc25d5dcb8226b476b2c1e333005b9f4c54 [INFO] running `Command { std: "docker" "start" "-a" "a87b91fbf3c46d4a9ae4a9328fcb1fc25d5dcb8226b476b2c1e333005b9f4c54", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a87b91fbf3c46d4a9ae4a9328fcb1fc25d5dcb8226b476b2c1e333005b9f4c54", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a87b91fbf3c46d4a9ae4a9328fcb1fc25d5dcb8226b476b2c1e333005b9f4c54", kill_on_drop: false }` [INFO] [stdout] a87b91fbf3c46d4a9ae4a9328fcb1fc25d5dcb8226b476b2c1e333005b9f4c54 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bbb376fac9c02945c978ed8c37880854483bd4ec01d886dbc74e99b3455bb02b [INFO] running `Command { std: "docker" "start" "-a" "bbb376fac9c02945c978ed8c37880854483bd4ec01d886dbc74e99b3455bb02b", kill_on_drop: false }` [INFO] [stderr] Compiling thiserror v1.0.62 [INFO] [stderr] Checking bytes v1.6.1 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Compiling syn v2.0.71 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking proc-macro2 v1.0.86 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Checking quote v1.0.36 [INFO] [stderr] Checking protocol-macros v0.1.0 (/opt/rustwide/workdir/crates/protocol-macros) [INFO] [stderr] Compiling thiserror-impl v1.0.62 [INFO] [stderr] Compiling tokio-macros v2.3.0 [INFO] [stderr] Checking tokio v1.38.0 [INFO] [stderr] Checking protocol-buf v0.1.0 (/opt/rustwide/workdir/crates/protocol-buf) [INFO] [stdout] warning: unused import: `thiserror::Error` [INFO] [stdout] --> crates/protocol-buf/src/compression.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use thiserror::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `thiserror::Error` [INFO] [stdout] --> crates/protocol-buf/src/compression.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use thiserror::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> crates/protocol-buf/src/compression.rs:200:36 [INFO] [stdout] | [INFO] [stdout] 200 | fn decompress(buffer: Vec, data: &CompressionData) -> PacketBuffer { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `buffer` [INFO] [stdout] --> crates/protocol-buf/src/compression.rs:268:19 [INFO] [stdout] | [INFO] [stdout] 268 | fn decompress(buffer: Vec, data: &CompressionData) -> PacketBuffer { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_buffer` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> crates/protocol-buf/src/compression.rs:268:36 [INFO] [stdout] | [INFO] [stdout] 268 | fn decompress(buffer: Vec, data: &CompressionData) -> PacketBuffer { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bounds on generic parameters in type aliases are not enforced [INFO] [stdout] --> crates/protocol-buf/src/compression.rs:27:31 [INFO] [stdout] | [INFO] [stdout] 27 | pub type CompressionResult = BufferResult; [INFO] [stdout] | --^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | will not be checked at usage sites of the type alias [INFO] [stdout] | help: remove this bound [INFO] [stdout] | [INFO] [stdout] = note: this is a known limitation of the type checker that may be lifted in a future edition. [INFO] [stdout] see issue #112792 for more information [INFO] [stdout] = help: add `#![feature(lazy_type_alias)]` to the crate attributes to enable the desired semantics [INFO] [stdout] = note: `#[warn(type_alias_bounds)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> crates/protocol-buf/src/compression.rs:200:36 [INFO] [stdout] | [INFO] [stdout] 200 | fn decompress(buffer: Vec, data: &CompressionData) -> PacketBuffer { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `buffer` [INFO] [stdout] --> crates/protocol-buf/src/compression.rs:268:19 [INFO] [stdout] | [INFO] [stdout] 268 | fn decompress(buffer: Vec, data: &CompressionData) -> PacketBuffer { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_buffer` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> crates/protocol-buf/src/compression.rs:268:36 [INFO] [stdout] | [INFO] [stdout] 268 | fn decompress(buffer: Vec, data: &CompressionData) -> PacketBuffer { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bounds on generic parameters in type aliases are not enforced [INFO] [stdout] --> crates/protocol-buf/src/compression.rs:27:31 [INFO] [stdout] | [INFO] [stdout] 27 | pub type CompressionResult = BufferResult; [INFO] [stdout] | --^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | will not be checked at usage sites of the type alias [INFO] [stdout] | help: remove this bound [INFO] [stdout] | [INFO] [stdout] = note: this is a known limitation of the type checker that may be lifted in a future edition. [INFO] [stdout] see issue #112792 for more information [INFO] [stdout] = help: add `#![feature(lazy_type_alias)]` to the crate attributes to enable the desired semantics [INFO] [stdout] = note: `#[warn(type_alias_bounds)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking protocol-packets v0.1.0 (/opt/rustwide/workdir/crates/protocol-packets) [INFO] [stderr] Checking protocol-core v0.1.0 (/opt/rustwide/workdir/crates/protocol-core) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/protocol-core/src/client.rs:40:25 [INFO] [stdout] | [INFO] [stdout] 38 | pub const fn new(listener: TcpStream, compression: CompressionData) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | Self { [INFO] [stdout] 40 | connection: ClientConnection { listener }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/protocol-core/src/server.rs:201:82 [INFO] [stdout] | [INFO] [stdout] 201 | .accept_connections(|mut connection| async move { connection.start().await }) [INFO] [stdout] | ---------- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `protocol-core` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/protocol-core/src/client.rs:40:25 [INFO] [stdout] | [INFO] [stdout] 38 | pub const fn new(listener: TcpStream, compression: CompressionData) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | Self { [INFO] [stdout] 40 | connection: ClientConnection { listener }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/protocol-core/src/server.rs:201:82 [INFO] [stdout] | [INFO] [stdout] 201 | .accept_connections(|mut connection| async move { connection.start().await }) [INFO] [stdout] | ---------- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `protocol-core` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "bbb376fac9c02945c978ed8c37880854483bd4ec01d886dbc74e99b3455bb02b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bbb376fac9c02945c978ed8c37880854483bd4ec01d886dbc74e99b3455bb02b", kill_on_drop: false }` [INFO] [stdout] bbb376fac9c02945c978ed8c37880854483bd4ec01d886dbc74e99b3455bb02b