[INFO] cloning repository https://github.com/OptiVorbis/OptiVorbis [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/OptiVorbis/OptiVorbis" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FOptiVorbis%2FOptiVorbis", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FOptiVorbis%2FOptiVorbis'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d57fe5f4d886406dd2b877aafe1289ad888ce44e [INFO] checking OptiVorbis/OptiVorbis/d57fe5f4d886406dd2b877aafe1289ad888ce44e against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FOptiVorbis%2FOptiVorbis" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/OptiVorbis/OptiVorbis on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-1-tc2/source/.cargo/config.toml [INFO] started tweaking git repo https://github.com/OptiVorbis/OptiVorbis [INFO] finished tweaking git repo https://github.com/OptiVorbis/OptiVorbis [INFO] tweaked toml for git repo https://github.com/OptiVorbis/OptiVorbis written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/OptiVorbis/OptiVorbis already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9498938624d84a0db3cfbf886bc5696128d9daa01e75079e70924c365df94da3 [INFO] running `Command { std: "docker" "start" "-a" "9498938624d84a0db3cfbf886bc5696128d9daa01e75079e70924c365df94da3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9498938624d84a0db3cfbf886bc5696128d9daa01e75079e70924c365df94da3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9498938624d84a0db3cfbf886bc5696128d9daa01e75079e70924c365df94da3", kill_on_drop: false }` [INFO] [stdout] 9498938624d84a0db3cfbf886bc5696128d9daa01e75079e70924c365df94da3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a7fbaac3a09ff3114586f03889b0a13069e9058f29b1440d2b688bab1030be1b [INFO] running `Command { std: "docker" "start" "-a" "a7fbaac3a09ff3114586f03889b0a13069e9058f29b1440d2b688bab1030be1b", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling proc-macro2-diagnostics v0.10.1 [INFO] [stderr] Compiling either v1.12.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling yansi v1.0.1 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling optivorbis v0.2.0 (/opt/rustwide/workdir/packages/optivorbis) [INFO] [stderr] Checking aliasable v0.1.3 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Compiling itertools v0.12.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking ogg v0.9.1 [INFO] [stderr] Checking rand_xoshiro v0.6.0 [INFO] [stderr] Checking slice-group-by v0.3.1 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking bumpalo v3.16.0 [INFO] [stderr] Checking vorbis_bitpack v0.1.1 (/opt/rustwide/workdir/packages/vorbis_bitpack) [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling home v0.5.9 [INFO] [stderr] Compiling afl v0.15.10 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.67 [INFO] [stderr] Checking indexmap v2.4.0 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking smallvec v0.6.14 [INFO] [stderr] Checking rustc_version v0.4.0 [INFO] [stderr] Checking ogg v0.7.1 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking lewton v0.9.4 [INFO] [stderr] Checking stderrlog v0.6.0 [INFO] [stderr] Checking oggvorbismeta v0.1.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling ouroboros_macro v0.18.4 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking pretty_env_logger v0.5.0 [INFO] [stderr] Checking ouroboros v0.18.4 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> packages/optivorbis/src/remuxer/ogg_to_ogg/mod.rs:195:22 [INFO] [stdout] | [INFO] [stdout] 193 | fn new(remuxer_settings: Settings, optimizer_settings: VorbisOptimizerSettings) -> Self { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | Self { [INFO] [stdout] 195 | remuxer_settings: RefCell::new(remuxer_settings), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> packages/optivorbis/src/vorbis/optimizer.rs:559:6 [INFO] [stdout] | [INFO] [stdout] 472 | identification_header: B [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 559 | Ok(VorbisOptimizer { [INFO] [stdout] | ____________^ [INFO] [stdout] 560 | | settings, [INFO] [stdout] 561 | | identification_data: VorbisIdentificationHeaderData { [INFO] [stdout] 562 | | channels, [INFO] [stdout] ... | [INFO] [stdout] 569 | | state: CommentHeaderParse.into() [INFO] [stdout] 570 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> packages/optivorbis/src/vorbis/optimizer/audio_packet_analyze.rs:65:6 [INFO] [stdout] | [INFO] [stdout] 65 | Ok((decode_blocksize, None)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: packages/optivorbis/src/vorbis/optimizer.rs:70:33 [INFO] [stdout] | [INFO] [stdout] 70 | Err(VorbisOptimizerError::Io(err)) [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | Err(err) => Err(err) [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> packages/optivorbis/src/vorbis/optimizer/audio_packet_common.rs:73:3 [INFO] [stdout] | [INFO] [stdout] 42 | mut bitpack_read_callback: F, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | codebook_entry_decode_callback: G, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | mut shared_callback_data: T [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | / process_audio_packet_second_part( [INFO] [stdout] 74 | | identification_data, [INFO] [stdout] 75 | | codec_setup, [INFO] [stdout] 76 | | packet_length, [INFO] [stdout] ... | [INFO] [stdout] 83 | | ) [INFO] [stdout] 84 | | .map(|_| (true, Some(decode_blocksize))), [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] ::: packages/optivorbis/src/vorbis/optimizer.rs:70:33 [INFO] [stdout] | [INFO] [stdout] 70 | Err(VorbisOptimizerError::Io(err)) [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | Err(err) => Err(err) [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> packages/optivorbis/src/vorbis/optimizer/audio_packet_rewrite.rs:94:6 [INFO] [stdout] | [INFO] [stdout] 55 | let mut new_packet_bitpacker = BitpackWriter::new(&mut new_packet); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 95 | | keep_packet.then(|| (new_packet.into(), decode_blocksize)), [INFO] [stdout] 96 | | None [INFO] [stdout] 97 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> packages/optivorbis/src/vorbis/optimizer/comment_header_parse.rs:37:24 [INFO] [stdout] | [INFO] [stdout] 36 | fn from(into_err: T) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | Self::OptimizerError(into_err.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> packages/optivorbis/src/vorbis/optimizer/setup_header_parse.rs:186:6 [INFO] [stdout] | [INFO] [stdout] 142 | let (codebook_configurations, mut bitpacker, header_length) = [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 186 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 187 | | None, [INFO] [stdout] 188 | | Some(AudioPacketAnalyze { [INFO] [stdout] 189 | | comment_data: mem::take(&mut self.comment_data), [INFO] [stdout] ... | [INFO] [stdout] 197 | | }) [INFO] [stdout] 198 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> packages/optivorbis/src/vorbis/optimizer/setup_header_parse.rs:436:5 [INFO] [stdout] | [INFO] [stdout] 248 | let mut codebook_configurations = Vec::with_capacity(codebook_count as usize); [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 436 | Ok((codebook_configurations, bitpacker, header_length)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> packages/optivorbis/src/vorbis/optimizer/setup_header_rewrite.rs:72:6 [INFO] [stdout] | [INFO] [stdout] 38 | let mut codec_setup = self.codec_setup.take().unwrap(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let mut bitpacker = optimize_and_write_codebooks(&mut codec_setup, packet_data)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 73 | | Some((packet, None)), [INFO] [stdout] 74 | | Some(AudioPacketRewrite::new(codec_setup)) [INFO] [stdout] 75 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> packages/optivorbis/src/vorbis/codebook/mod.rs:84:6 [INFO] [stdout] | [INFO] [stdout] 82 | codeword_lengths: T [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | ) -> Result { [INFO] [stdout] 84 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 85 | | codebook_number, [INFO] [stdout] 86 | | entry_decode_frequencies_or_lengths: Cell::new(vec![ [INFO] [stdout] 87 | | 0; [INFO] [stdout] ... | [INFO] [stdout] 96 | | recording_decode_frequencies: true [INFO] [stdout] 97 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> packages/optivorbis/src/vorbis/codebook/huffman_tree.rs:91:3 [INFO] [stdout] | [INFO] [stdout] 60 | codeword_lengths: T [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | / VorbisHuffmanTreeTryBuilder { [INFO] [stdout] 92 | | arena: Bump::new(), [INFO] [stdout] 93 | | root_builder: |arena| { [INFO] [stdout] 94 | | let mut root = VorbisHuffmanTreeNode::default(); [INFO] [stdout] ... | [INFO] [stdout] 113 | | } [INFO] [stdout] 114 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> packages/optivorbis/src/vorbis/codebook/huffman_tree.rs:162:18 [INFO] [stdout] | [INFO] [stdout] 160 | f: impl FnOnce(VorbisHuffmanTreeWalker<'_, '_, VorbisHuffmanTreeEntry>) -> R [INFO] [stdout] | ---------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | ) -> R { [INFO] [stdout] 162 | self.with_root(|root| f(VorbisHuffmanTreeWalker { current_node: root })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> packages/optivorbis/src/vorbis/codebook/huffman_tree.rs:263:39 [INFO] [stdout] | [INFO] [stdout] 263 | .get_or_insert_with(|| arena.alloc(Default::default())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> packages/optivorbis/src/vorbis/codebook/huffman_tree.rs:267:41 [INFO] [stdout] | [INFO] [stdout] 267 | .get_or_insert_with(|| arena.alloc(Default::default())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> packages/optivorbis/src/remuxer/ogg_to_ogg/mod.rs:195:22 [INFO] [stdout] | [INFO] [stdout] 193 | fn new(remuxer_settings: Settings, optimizer_settings: VorbisOptimizerSettings) -> Self { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | Self { [INFO] [stdout] 195 | remuxer_settings: RefCell::new(remuxer_settings), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> packages/optivorbis/src/vorbis/optimizer.rs:559:6 [INFO] [stdout] | [INFO] [stdout] 472 | identification_header: B [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 559 | Ok(VorbisOptimizer { [INFO] [stdout] | ____________^ [INFO] [stdout] 560 | | settings, [INFO] [stdout] 561 | | identification_data: VorbisIdentificationHeaderData { [INFO] [stdout] 562 | | channels, [INFO] [stdout] ... | [INFO] [stdout] 569 | | state: CommentHeaderParse.into() [INFO] [stdout] 570 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> packages/optivorbis/src/vorbis/optimizer/audio_packet_analyze.rs:65:6 [INFO] [stdout] | [INFO] [stdout] 65 | Ok((decode_blocksize, None)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: packages/optivorbis/src/vorbis/optimizer.rs:70:33 [INFO] [stdout] | [INFO] [stdout] 70 | Err(VorbisOptimizerError::Io(err)) [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | Err(err) => Err(err) [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> packages/optivorbis/src/vorbis/optimizer/audio_packet_common.rs:73:3 [INFO] [stdout] | [INFO] [stdout] 42 | mut bitpack_read_callback: F, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | codebook_entry_decode_callback: G, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | mut shared_callback_data: T [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | / process_audio_packet_second_part( [INFO] [stdout] 74 | | identification_data, [INFO] [stdout] 75 | | codec_setup, [INFO] [stdout] 76 | | packet_length, [INFO] [stdout] ... | [INFO] [stdout] 83 | | ) [INFO] [stdout] 84 | | .map(|_| (true, Some(decode_blocksize))), [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] ::: packages/optivorbis/src/vorbis/optimizer.rs:70:33 [INFO] [stdout] | [INFO] [stdout] 70 | Err(VorbisOptimizerError::Io(err)) [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | Err(err) => Err(err) [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> packages/optivorbis/src/vorbis/optimizer/audio_packet_rewrite.rs:94:6 [INFO] [stdout] | [INFO] [stdout] 55 | let mut new_packet_bitpacker = BitpackWriter::new(&mut new_packet); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 95 | | keep_packet.then(|| (new_packet.into(), decode_blocksize)), [INFO] [stdout] 96 | | None [INFO] [stdout] 97 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> packages/optivorbis/src/vorbis/optimizer/comment_header_parse.rs:37:24 [INFO] [stdout] | [INFO] [stdout] 36 | fn from(into_err: T) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | Self::OptimizerError(into_err.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> packages/optivorbis/src/vorbis/optimizer/setup_header_parse.rs:186:6 [INFO] [stdout] | [INFO] [stdout] 142 | let (codebook_configurations, mut bitpacker, header_length) = [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 186 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 187 | | None, [INFO] [stdout] 188 | | Some(AudioPacketAnalyze { [INFO] [stdout] 189 | | comment_data: mem::take(&mut self.comment_data), [INFO] [stdout] ... | [INFO] [stdout] 197 | | }) [INFO] [stdout] 198 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> packages/optivorbis/src/vorbis/optimizer/setup_header_parse.rs:436:5 [INFO] [stdout] | [INFO] [stdout] 248 | let mut codebook_configurations = Vec::with_capacity(codebook_count as usize); [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 436 | Ok((codebook_configurations, bitpacker, header_length)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> packages/optivorbis/src/vorbis/optimizer/setup_header_rewrite.rs:72:6 [INFO] [stdout] | [INFO] [stdout] 38 | let mut codec_setup = self.codec_setup.take().unwrap(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let mut bitpacker = optimize_and_write_codebooks(&mut codec_setup, packet_data)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 73 | | Some((packet, None)), [INFO] [stdout] 74 | | Some(AudioPacketRewrite::new(codec_setup)) [INFO] [stdout] 75 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `optivorbis` (lib) due to 15 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> packages/optivorbis/src/vorbis/codebook/mod.rs:84:6 [INFO] [stdout] | [INFO] [stdout] 82 | codeword_lengths: T [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | ) -> Result { [INFO] [stdout] 84 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 85 | | codebook_number, [INFO] [stdout] 86 | | entry_decode_frequencies_or_lengths: Cell::new(vec![ [INFO] [stdout] 87 | | 0; [INFO] [stdout] ... | [INFO] [stdout] 96 | | recording_decode_frequencies: true [INFO] [stdout] 97 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> packages/optivorbis/src/vorbis/codebook/huffman_tree.rs:91:3 [INFO] [stdout] | [INFO] [stdout] 60 | codeword_lengths: T [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | / VorbisHuffmanTreeTryBuilder { [INFO] [stdout] 92 | | arena: Bump::new(), [INFO] [stdout] 93 | | root_builder: |arena| { [INFO] [stdout] 94 | | let mut root = VorbisHuffmanTreeNode::default(); [INFO] [stdout] ... | [INFO] [stdout] 113 | | } [INFO] [stdout] 114 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> packages/optivorbis/src/vorbis/codebook/huffman_tree.rs:162:18 [INFO] [stdout] | [INFO] [stdout] 160 | f: impl FnOnce(VorbisHuffmanTreeWalker<'_, '_, VorbisHuffmanTreeEntry>) -> R [INFO] [stdout] | ---------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | ) -> R { [INFO] [stdout] 162 | self.with_root(|root| f(VorbisHuffmanTreeWalker { current_node: root })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> packages/optivorbis/src/vorbis/codebook/huffman_tree.rs:263:39 [INFO] [stdout] | [INFO] [stdout] 263 | .get_or_insert_with(|| arena.alloc(Default::default())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> packages/optivorbis/src/vorbis/codebook/huffman_tree.rs:267:41 [INFO] [stdout] | [INFO] [stdout] 267 | .get_or_insert_with(|| arena.alloc(Default::default())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `optivorbis` (lib test) due to 15 previous errors [INFO] running `Command { std: "docker" "inspect" "a7fbaac3a09ff3114586f03889b0a13069e9058f29b1440d2b688bab1030be1b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a7fbaac3a09ff3114586f03889b0a13069e9058f29b1440d2b688bab1030be1b", kill_on_drop: false }` [INFO] [stdout] a7fbaac3a09ff3114586f03889b0a13069e9058f29b1440d2b688bab1030be1b