[INFO] cloning repository https://github.com/OmarAlraisi/tcp [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/OmarAlraisi/tcp" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FOmarAlraisi%2Ftcp", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FOmarAlraisi%2Ftcp'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] be2304782bcc45f0596f9dcabd32b9b7c8b7e4fa [INFO] checking OmarAlraisi/tcp/be2304782bcc45f0596f9dcabd32b9b7c8b7e4fa against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FOmarAlraisi%2Ftcp" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/OmarAlraisi/tcp on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/OmarAlraisi/tcp [INFO] finished tweaking git repo https://github.com/OmarAlraisi/tcp [INFO] tweaked toml for git repo https://github.com/OmarAlraisi/tcp written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/OmarAlraisi/tcp already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c3268eca1742820664c4d7d2beef62f93b642c1766e4d07cfc0ad6e39fab79a7 [INFO] running `Command { std: "docker" "start" "-a" "c3268eca1742820664c4d7d2beef62f93b642c1766e4d07cfc0ad6e39fab79a7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c3268eca1742820664c4d7d2beef62f93b642c1766e4d07cfc0ad6e39fab79a7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c3268eca1742820664c4d7d2beef62f93b642c1766e4d07cfc0ad6e39fab79a7", kill_on_drop: false }` [INFO] [stdout] c3268eca1742820664c4d7d2beef62f93b642c1766e4d07cfc0ad6e39fab79a7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9e95f6872d5fd64e8ff61f6ae8f70cc36a169969d6a4fc9a399ab35a0c415fa4 [INFO] running `Command { std: "docker" "start" "-a" "9e95f6872d5fd64e8ff61f6ae8f70cc36a169969d6a4fc9a399ab35a0c415fa4", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Checking futures v0.1.31 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Compiling cc v1.0.99 [INFO] [stderr] Compiling cfg_aliases v0.2.1 [INFO] [stderr] Checking scoped-tls v0.1.2 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling memoffset v0.5.6 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Checking etherparse v0.15.0 [INFO] [stderr] Checking smallvec v0.6.14 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling parking_lot_core v0.6.3 [INFO] [stderr] Compiling parking_lot v0.9.0 [INFO] [stderr] Compiling tun-tap v0.1.4 [INFO] [stderr] Checking crossbeam-queue v0.2.3 [INFO] [stderr] Checking crossbeam-deque v0.7.4 [INFO] [stderr] Checking tokio-executor v0.1.10 [INFO] [stderr] Checking tokio-sync v0.1.8 [INFO] [stderr] Checking tokio-timer v0.2.13 [INFO] [stderr] Checking tokio-current-thread v0.1.7 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking net2 v0.2.39 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Checking tokio-threadpool v0.1.18 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking tokio-io v0.1.13 [INFO] [stderr] Checking tokio-codec v0.1.2 [INFO] [stderr] Checking tokio-fs v0.1.7 [INFO] [stderr] Checking tokio-reactor v0.1.12 [INFO] [stderr] Checking mio-uds v0.6.8 [INFO] [stderr] Checking tokio-udp v0.1.6 [INFO] [stderr] Checking tokio-uds v0.2.7 [INFO] [stderr] Checking tokio-tcp v0.1.4 [INFO] [stderr] Checking tokio v0.1.22 [INFO] [stderr] Checking tokio-core v0.1.18 [INFO] [stderr] Checking rust_tcp v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `quad` [INFO] [stdout] --> src/lib.rs:275:13 [INFO] [stdout] | [INFO] [stdout] 275 | for quad in pending { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_quad` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `how` [INFO] [stdout] --> src/lib.rs:396:28 [INFO] [stdout] | [INFO] [stdout] 396 | pub fn shutdown(&self, how: std::net::Shutdown) -> io::Result<()> { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_how` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `FinWait1` and `Closing` are never constructed [INFO] [stdout] --> src/tcp.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 20 | pub enum State { [INFO] [stdout] | ----- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 24 | FinWait1, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 27 | Closing, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `State` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `up` is never read [INFO] [stdout] --> src/tcp.rs:113:5 [INFO] [stdout] | [INFO] [stdout] 105 | struct SendSequenceSpace { [INFO] [stdout] | ----------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 113 | up: bool, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `SendSequenceSpace` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `up` is never read [INFO] [stdout] --> src/tcp.rs:144:5 [INFO] [stdout] | [INFO] [stdout] 138 | struct RecvSequenceSpace { [INFO] [stdout] | ----------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 144 | up: bool, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `RecvSequenceSpace` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:189:12 [INFO] [stdout] | [INFO] [stdout] 184 | let conn_handler: ConnectionHandler = Arc::default(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | let join_handler = { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | let cm = conn_handler.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 189 | Ok(Tcp { [INFO] [stdout] | ____________^ [INFO] [stdout] 190 | | conn_handler: Some(conn_handler), [INFO] [stdout] 191 | | join_handler: Some(join_handler), [INFO] [stdout] 192 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:218:12 [INFO] [stdout] | [INFO] [stdout] 197 | let mut cm = self [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | Ok(TcpListener { [INFO] [stdout] | ____________^ [INFO] [stdout] 219 | | port, [INFO] [stdout] 220 | | conn_handler: self.conn_handler.as_mut().unwrap().clone(), [INFO] [stdout] 221 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust_tcp` (lib) due to 3 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `quad` [INFO] [stdout] --> src/lib.rs:275:13 [INFO] [stdout] | [INFO] [stdout] 275 | for quad in pending { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_quad` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `how` [INFO] [stdout] --> src/lib.rs:396:28 [INFO] [stdout] | [INFO] [stdout] 396 | pub fn shutdown(&self, how: std::net::Shutdown) -> io::Result<()> { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_how` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `FinWait1` and `Closing` are never constructed [INFO] [stdout] --> src/tcp.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 20 | pub enum State { [INFO] [stdout] | ----- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 24 | FinWait1, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 27 | Closing, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `State` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `up` is never read [INFO] [stdout] --> src/tcp.rs:113:5 [INFO] [stdout] | [INFO] [stdout] 105 | struct SendSequenceSpace { [INFO] [stdout] | ----------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 113 | up: bool, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `SendSequenceSpace` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `up` is never read [INFO] [stdout] --> src/tcp.rs:144:5 [INFO] [stdout] | [INFO] [stdout] 138 | struct RecvSequenceSpace { [INFO] [stdout] | ----------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 144 | up: bool, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `RecvSequenceSpace` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:189:12 [INFO] [stdout] | [INFO] [stdout] 184 | let conn_handler: ConnectionHandler = Arc::default(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | let join_handler = { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | let cm = conn_handler.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 189 | Ok(Tcp { [INFO] [stdout] | ____________^ [INFO] [stdout] 190 | | conn_handler: Some(conn_handler), [INFO] [stdout] 191 | | join_handler: Some(join_handler), [INFO] [stdout] 192 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:218:12 [INFO] [stdout] | [INFO] [stdout] 197 | let mut cm = self [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | Ok(TcpListener { [INFO] [stdout] | ____________^ [INFO] [stdout] 219 | | port, [INFO] [stdout] 220 | | conn_handler: self.conn_handler.as_mut().unwrap().clone(), [INFO] [stdout] 221 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust_tcp` (lib test) due to 3 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "9e95f6872d5fd64e8ff61f6ae8f70cc36a169969d6a4fc9a399ab35a0c415fa4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9e95f6872d5fd64e8ff61f6ae8f70cc36a169969d6a4fc9a399ab35a0c415fa4", kill_on_drop: false }` [INFO] [stdout] 9e95f6872d5fd64e8ff61f6ae8f70cc36a169969d6a4fc9a399ab35a0c415fa4