[INFO] cloning repository https://github.com/OlivierLemoine/myshell [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/OlivierLemoine/myshell" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FOlivierLemoine%2Fmyshell", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FOlivierLemoine%2Fmyshell'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] bcf5a2f9e4f51e95f7e9ef559370aff2c9abec8d [INFO] checking OlivierLemoine/myshell/bcf5a2f9e4f51e95f7e9ef559370aff2c9abec8d against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FOlivierLemoine%2Fmyshell" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/OlivierLemoine/myshell on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/OlivierLemoine/myshell [INFO] finished tweaking git repo https://github.com/OlivierLemoine/myshell [INFO] tweaked toml for git repo https://github.com/OlivierLemoine/myshell written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/OlivierLemoine/myshell already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a923d99956d0eb44f7337395aa451c63255cc3e27473a9dbaca4b618521b7669 [INFO] running `Command { std: "docker" "start" "-a" "a923d99956d0eb44f7337395aa451c63255cc3e27473a9dbaca4b618521b7669", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a923d99956d0eb44f7337395aa451c63255cc3e27473a9dbaca4b618521b7669", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a923d99956d0eb44f7337395aa451c63255cc3e27473a9dbaca4b618521b7669", kill_on_drop: false }` [INFO] [stdout] a923d99956d0eb44f7337395aa451c63255cc3e27473a9dbaca4b618521b7669 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 58829cbcabe82388deb70b7ad7eb99ed1bdd6e68a1537eb7e5c093160fc0e6ac [INFO] running `Command { std: "docker" "start" "-a" "58829cbcabe82388deb70b7ad7eb99ed1bdd6e68a1537eb7e5c093160fc0e6ac", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.119 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Compiling pkg-config v0.3.24 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Compiling signal-hook v0.3.13 [INFO] [stderr] Compiling parking_lot_core v0.9.1 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling tree-sitter v0.19.5 [INFO] [stderr] Checking smallvec v1.8.0 [INFO] [stderr] Checking lock_api v0.4.6 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Compiling tree-sitter-lua v0.0.9 [INFO] [stderr] Checking ryu v1.0.9 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Compiling rlua v0.19.1 [INFO] [stderr] Checking encode_unicode v0.3.6 [INFO] [stderr] Compiling rlua-lua54-sys v0.1.1 [INFO] [stderr] Checking is_executable v1.0.1 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking dirs v1.0.5 [INFO] [stderr] Checking mio v0.7.14 [INFO] [stderr] Checking term v0.5.2 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking parking_lot v0.12.0 [INFO] [stderr] Checking signal-hook-mio v0.2.1 [INFO] [stderr] Checking crossterm v0.23.0 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Checking prettytable-rs v0.8.0 [INFO] [stderr] Checking myshell v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Lua` [INFO] [stdout] --> src/builtin.rs:4:12 [INFO] [stdout] | [INFO] [stdout] 4 | use rlua::{Lua, MetaMethod, ToLua, UserData}; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Lua` [INFO] [stdout] --> src/builtin.rs:4:12 [INFO] [stdout] | [INFO] [stdout] 4 | use rlua::{Lua, MetaMethod, ToLua, UserData}; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:386:58 [INFO] [stdout] | [INFO] [stdout] 386 | if let Some(init_code) = init_code_path.and_then(|p| fs::read_to_string(p).ok()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:386:58 [INFO] [stdout] | [INFO] [stdout] 386 | if let Some(init_code) = init_code_path.and_then(|p| fs::read_to_string(p).ok()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:451:74 [INFO] [stdout] | [INFO] [stdout] 451 | ... .filter_map(|(key, value)| match (key, value) { [INFO] [stdout] | ------------ ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:451:74 [INFO] [stdout] | [INFO] [stdout] 451 | ... .filter_map(|(key, value)| match (key, value) { [INFO] [stdout] | ------------ ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:462:63 [INFO] [stdout] | [INFO] [stdout] 462 | ... .and_then(|k| s.to_str().map(|v| (k, v))) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builtin.rs:54:40 [INFO] [stdout] | [INFO] [stdout] 54 | .unwrap_or_else(|| lua_ctx.create_table().and_then(|v| v.to_lua(lua_ctx))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:462:63 [INFO] [stdout] | [INFO] [stdout] 462 | ... .and_then(|k| s.to_str().map(|v| (k, v))) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builtin.rs:74:44 [INFO] [stdout] | [INFO] [stdout] 74 | .unwrap_or_else(|| lua_ctx.create_table().and_then(|v| v.to_lua(lua_ctx))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builtin.rs:92:29 [INFO] [stdout] | [INFO] [stdout] 92 | .filter_map(|entry| entry.metadata().ok().map(|metadata| (entry, metadata))) [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builtin.rs:92:55 [INFO] [stdout] | [INFO] [stdout] 92 | .filter_map(|entry| entry.metadata().ok().map(|metadata| (entry, metadata))) [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builtin.rs:121:37 [INFO] [stdout] | [INFO] [stdout] 121 | home::home_dir().or_else(|| env::current_dir().ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builtin.rs:54:40 [INFO] [stdout] | [INFO] [stdout] 54 | .unwrap_or_else(|| lua_ctx.create_table().and_then(|v| v.to_lua(lua_ctx))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builtin.rs:74:44 [INFO] [stdout] | [INFO] [stdout] 74 | .unwrap_or_else(|| lua_ctx.create_table().and_then(|v| v.to_lua(lua_ctx))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builtin.rs:92:29 [INFO] [stdout] | [INFO] [stdout] 92 | .filter_map(|entry| entry.metadata().ok().map(|metadata| (entry, metadata))) [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builtin.rs:92:55 [INFO] [stdout] | [INFO] [stdout] 92 | .filter_map(|entry| entry.metadata().ok().map(|metadata| (entry, metadata))) [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builtin.rs:121:37 [INFO] [stdout] | [INFO] [stdout] 121 | home::home_dir().or_else(|| env::current_dir().ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `myshell` (bin "myshell" test) due to 9 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `myshell` (bin "myshell") due to 9 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "58829cbcabe82388deb70b7ad7eb99ed1bdd6e68a1537eb7e5c093160fc0e6ac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "58829cbcabe82388deb70b7ad7eb99ed1bdd6e68a1537eb7e5c093160fc0e6ac", kill_on_drop: false }` [INFO] [stdout] 58829cbcabe82388deb70b7ad7eb99ed1bdd6e68a1537eb7e5c093160fc0e6ac