[INFO] cloning repository https://github.com/Noratrieb/fakessh [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Noratrieb/fakessh" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNoratrieb%2Ffakessh", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNoratrieb%2Ffakessh'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e36f416c54f93678c83cd38bfc6b96ba32122f0a [INFO] checking Noratrieb/fakessh/e36f416c54f93678c83cd38bfc6b96ba32122f0a against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNoratrieb%2Ffakessh" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Noratrieb/fakessh on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Noratrieb/fakessh [INFO] finished tweaking git repo https://github.com/Noratrieb/fakessh [INFO] tweaked toml for git repo https://github.com/Noratrieb/fakessh written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Noratrieb/fakessh already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 53a821c5841e1f253c507b485bb100436b1bfe5cae23525548428996616ce3b8 [INFO] running `Command { std: "docker" "start" "-a" "53a821c5841e1f253c507b485bb100436b1bfe5cae23525548428996616ce3b8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "53a821c5841e1f253c507b485bb100436b1bfe5cae23525548428996616ce3b8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "53a821c5841e1f253c507b485bb100436b1bfe5cae23525548428996616ce3b8", kill_on_drop: false }` [INFO] [stdout] 53a821c5841e1f253c507b485bb100436b1bfe5cae23525548428996616ce3b8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ea4c4c0e87f2ac72b64d16e9d98f9b6166c3c5e62cf321009508f3ee12dfffdd [INFO] running `Command { std: "docker" "start" "-a" "ea4c4c0e87f2ac72b64d16e9d98f9b6166c3c5e62cf321009508f3ee12dfffdd", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking base16ct v0.2.0 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking opaque-debug v0.3.1 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling eyre v0.6.12 [INFO] [stderr] Checking pem-rfc7468 v0.7.0 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Compiling serde_json v1.0.125 [INFO] [stderr] Checking pem v3.0.4 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking rtoolbox v0.0.2 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling heapless v0.7.17 [INFO] [stderr] Checking rpassword v7.3.1 [INFO] [stderr] Checking users v0.11.0 [INFO] [stderr] Checking hash32 v0.2.1 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking ff v0.13.0 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Checking cobs v0.2.3 [INFO] [stderr] Checking hex-literal v0.4.1 [INFO] [stderr] Checking seccompiler v0.4.0 [INFO] [stderr] Checking shlex v1.3.0 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Checking indexmap v2.4.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking der v0.7.9 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking crypto-bigint v0.5.5 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking blowfish v0.9.1 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking hkdf v0.12.4 [INFO] [stderr] Checking rfc6979 v0.4.0 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking sec1 v0.7.3 [INFO] [stderr] Checking bcrypt-pbkdf v0.10.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Checking ed25519-dalek v2.1.1 [INFO] [stderr] Checking x25519-dalek v2.0.1 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking elliptic-curve v0.13.8 [INFO] [stderr] Checking cluelessh-format v0.1.0 (/opt/rustwide/workdir/lib/cluelessh-format) [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking primeorder v0.13.6 [INFO] [stderr] Checking ecdsa v0.16.9 [INFO] [stderr] Checking p256 v0.13.2 [INFO] [stderr] Checking cluelessh-keys v0.1.0 (/opt/rustwide/workdir/lib/cluelessh-keys) [INFO] [stderr] Checking secrecy v0.8.0 [INFO] [stderr] Checking tracing-serde v0.1.3 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking cluelessh-transport v0.1.0 (/opt/rustwide/workdir/lib/cluelessh-transport) [INFO] [stderr] Checking cluelessh-key v0.1.0 (/opt/rustwide/workdir/bin/cluelessh-key) [INFO] [stderr] Checking postcard v1.0.10 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/cluelessh-transport/src/client.rs:69:20 [INFO] [stdout] | [INFO] [stdout] 62 | pub fn new(rng: impl SshRng + Send + Sync + 'static) -> Self { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | let mut packet_transport = PacketTransport::new(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | state: ClientState::ProtoExchange { [INFO] [stdout] | ____________________^ [INFO] [stdout] 70 | | ident_parser: ProtocolIdentParser::new(), [INFO] [stdout] 71 | | client_ident, [INFO] [stdout] 72 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/cluelessh-transport/src/client.rs:74:18 [INFO] [stdout] | [INFO] [stdout] 62 | pub fn new(rng: impl SshRng + Send + Sync + 'static) -> Self { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | let mut packet_transport = PacketTransport::new(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | rng: Box::new(rng), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/cluelessh-transport/src/crypto.rs:71:23 [INFO] [stdout] | [INFO] [stdout] 66 | let secret = x25519_dalek::EphemeralSecret::random_from_rng(crate::SshRngRandAdapter(rng)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | exchange: Box::new(move |peer_public_key| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 72 | | let Ok(peer_public_key) = <[u8; 32]>::try_from(peer_public_key) else { [INFO] [stdout] 73 | | return Err(crate::peer_error!( [INFO] [stdout] 74 | | "invalid x25519 public key length, should be 32, was: {}", [INFO] [stdout] ... | [INFO] [stdout] 83 | | ))) [INFO] [stdout] 84 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/cluelessh-transport/src/crypto.rs:81:20 [INFO] [stdout] | [INFO] [stdout] 66 | let secret = x25519_dalek::EphemeralSecret::random_from_rng(crate::SshRngRandAdapter(rng)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | let shared_secret = secret.diffie_hellman(&peer_public_key); // K [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | [INFO] [stdout] 81 | Ok(secrecy::Secret::new(SharedSecretInner( [INFO] [stdout] | ____________________^ [INFO] [stdout] 82 | | shared_secret.as_bytes().to_vec(), [INFO] [stdout] 83 | | ))) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/cluelessh-transport/src/crypto.rs:97:23 [INFO] [stdout] | [INFO] [stdout] 92 | let secret = p256::ecdh::EphemeralSecret::random(&mut crate::SshRngRandAdapter(rng)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | exchange: Box::new(move |peer_public_key| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 98 | | let peer_public_key = [INFO] [stdout] 99 | | p256::PublicKey::from_sec1_bytes(peer_public_key).map_err(|_| { [INFO] [stdout] 100 | | crate::peer_error!( [INFO] [stdout] ... | [INFO] [stdout] 110 | | ))) [INFO] [stdout] 111 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/cluelessh-transport/src/crypto.rs:108:20 [INFO] [stdout] | [INFO] [stdout] 92 | let secret = p256::ecdh::EphemeralSecret::random(&mut crate::SshRngRandAdapter(rng)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | let shared_secret = secret.diffie_hellman(&peer_public_key); // K [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | [INFO] [stdout] 108 | Ok(secrecy::Secret::new(SharedSecretInner( [INFO] [stdout] | ____________________^ [INFO] [stdout] 109 | | shared_secret.raw_secret_bytes().to_vec(), [INFO] [stdout] 110 | | ))) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/cluelessh-transport/src/server.rs:98:20 [INFO] [stdout] | [INFO] [stdout] 96 | pub fn new(rng: impl SshRng + Send + Sync + 'static, config: ServerConfig) -> Self { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | Self { [INFO] [stdout] 98 | state: ServerState::ProtoExchange { [INFO] [stdout] | ____________________^ [INFO] [stdout] 99 | | ident_parser: ProtocolIdentParser::new(), [INFO] [stdout] 100 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/cluelessh-transport/src/server.rs:101:31 [INFO] [stdout] | [INFO] [stdout] 96 | pub fn new(rng: impl SshRng + Send + Sync + 'static, config: ServerConfig) -> Self { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | packet_transport: PacketTransport::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/cluelessh-transport/src/server.rs:102:18 [INFO] [stdout] | [INFO] [stdout] 96 | pub fn new(rng: impl SshRng + Send + Sync + 'static, config: ServerConfig) -> Self { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | rng: Box::new(rng), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/cluelessh-transport/src/server.rs:485:8 [INFO] [stdout] | [INFO] [stdout] 469 | let server_secret = (msg.kex_algorithm.generate_secret)(rng); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 470 | let server_ephemeral_public_key = server_secret.pubkey; [INFO] [stdout] 471 | let shared_secret = (server_secret.exchange)(&msg.eph_client_public_key)?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 485 | Ok(KeyExchangeResponse { [INFO] [stdout] | ________^ [INFO] [stdout] 486 | | hash: SessionId(hash), [INFO] [stdout] 487 | | server_ephemeral_public_key, [INFO] [stdout] 488 | | shared_secret, [INFO] [stdout] 489 | | signature: private.private_key.sign(&hash), [INFO] [stdout] 490 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cluelessh-transport` (lib) due to 11 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/cluelessh-transport/src/client.rs:69:20 [INFO] [stdout] | [INFO] [stdout] 62 | pub fn new(rng: impl SshRng + Send + Sync + 'static) -> Self { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | let mut packet_transport = PacketTransport::new(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | state: ClientState::ProtoExchange { [INFO] [stdout] | ____________________^ [INFO] [stdout] 70 | | ident_parser: ProtocolIdentParser::new(), [INFO] [stdout] 71 | | client_ident, [INFO] [stdout] 72 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/cluelessh-transport/src/client.rs:74:18 [INFO] [stdout] | [INFO] [stdout] 62 | pub fn new(rng: impl SshRng + Send + Sync + 'static) -> Self { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | let mut packet_transport = PacketTransport::new(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | rng: Box::new(rng), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/cluelessh-transport/src/crypto.rs:71:23 [INFO] [stdout] | [INFO] [stdout] 66 | let secret = x25519_dalek::EphemeralSecret::random_from_rng(crate::SshRngRandAdapter(rng)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | exchange: Box::new(move |peer_public_key| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 72 | | let Ok(peer_public_key) = <[u8; 32]>::try_from(peer_public_key) else { [INFO] [stdout] 73 | | return Err(crate::peer_error!( [INFO] [stdout] 74 | | "invalid x25519 public key length, should be 32, was: {}", [INFO] [stdout] ... | [INFO] [stdout] 83 | | ))) [INFO] [stdout] 84 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/cluelessh-transport/src/crypto.rs:81:20 [INFO] [stdout] | [INFO] [stdout] 66 | let secret = x25519_dalek::EphemeralSecret::random_from_rng(crate::SshRngRandAdapter(rng)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | let shared_secret = secret.diffie_hellman(&peer_public_key); // K [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | [INFO] [stdout] 81 | Ok(secrecy::Secret::new(SharedSecretInner( [INFO] [stdout] | ____________________^ [INFO] [stdout] 82 | | shared_secret.as_bytes().to_vec(), [INFO] [stdout] 83 | | ))) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/cluelessh-transport/src/crypto.rs:97:23 [INFO] [stdout] | [INFO] [stdout] 92 | let secret = p256::ecdh::EphemeralSecret::random(&mut crate::SshRngRandAdapter(rng)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | exchange: Box::new(move |peer_public_key| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 98 | | let peer_public_key = [INFO] [stdout] 99 | | p256::PublicKey::from_sec1_bytes(peer_public_key).map_err(|_| { [INFO] [stdout] 100 | | crate::peer_error!( [INFO] [stdout] ... | [INFO] [stdout] 110 | | ))) [INFO] [stdout] 111 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/cluelessh-transport/src/crypto.rs:108:20 [INFO] [stdout] | [INFO] [stdout] 92 | let secret = p256::ecdh::EphemeralSecret::random(&mut crate::SshRngRandAdapter(rng)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | let shared_secret = secret.diffie_hellman(&peer_public_key); // K [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | [INFO] [stdout] 108 | Ok(secrecy::Secret::new(SharedSecretInner( [INFO] [stdout] | ____________________^ [INFO] [stdout] 109 | | shared_secret.raw_secret_bytes().to_vec(), [INFO] [stdout] 110 | | ))) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/cluelessh-transport/src/server.rs:98:20 [INFO] [stdout] | [INFO] [stdout] 96 | pub fn new(rng: impl SshRng + Send + Sync + 'static, config: ServerConfig) -> Self { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | Self { [INFO] [stdout] 98 | state: ServerState::ProtoExchange { [INFO] [stdout] | ____________________^ [INFO] [stdout] 99 | | ident_parser: ProtocolIdentParser::new(), [INFO] [stdout] 100 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/cluelessh-transport/src/server.rs:101:31 [INFO] [stdout] | [INFO] [stdout] 96 | pub fn new(rng: impl SshRng + Send + Sync + 'static, config: ServerConfig) -> Self { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | packet_transport: PacketTransport::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/cluelessh-transport/src/server.rs:102:18 [INFO] [stdout] | [INFO] [stdout] 96 | pub fn new(rng: impl SshRng + Send + Sync + 'static, config: ServerConfig) -> Self { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | rng: Box::new(rng), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/cluelessh-transport/src/server.rs:485:8 [INFO] [stdout] | [INFO] [stdout] 469 | let server_secret = (msg.kex_algorithm.generate_secret)(rng); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 470 | let server_ephemeral_public_key = server_secret.pubkey; [INFO] [stdout] 471 | let shared_secret = (server_secret.exchange)(&msg.eph_client_public_key)?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 485 | Ok(KeyExchangeResponse { [INFO] [stdout] | ________^ [INFO] [stdout] 486 | | hash: SessionId(hash), [INFO] [stdout] 487 | | server_ephemeral_public_key, [INFO] [stdout] 488 | | shared_secret, [INFO] [stdout] 489 | | signature: private.private_key.sign(&hash), [INFO] [stdout] 490 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cluelessh-transport` (lib test) due to 11 previous errors [INFO] running `Command { std: "docker" "inspect" "ea4c4c0e87f2ac72b64d16e9d98f9b6166c3c5e62cf321009508f3ee12dfffdd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ea4c4c0e87f2ac72b64d16e9d98f9b6166c3c5e62cf321009508f3ee12dfffdd", kill_on_drop: false }` [INFO] [stdout] ea4c4c0e87f2ac72b64d16e9d98f9b6166c3c5e62cf321009508f3ee12dfffdd