[INFO] cloning repository https://github.com/NoahLavelle/hecto [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/NoahLavelle/hecto" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNoahLavelle%2Fhecto", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNoahLavelle%2Fhecto'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 03366d94ad20a19ff4405a781a915088d38a523c [INFO] checking NoahLavelle/hecto/03366d94ad20a19ff4405a781a915088d38a523c against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNoahLavelle%2Fhecto" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/NoahLavelle/hecto on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/NoahLavelle/hecto [INFO] finished tweaking git repo https://github.com/NoahLavelle/hecto [INFO] tweaked toml for git repo https://github.com/NoahLavelle/hecto written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/NoahLavelle/hecto already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b06f93b6b38dc97d1d2e4a7d986a9b579731fbbb32a256b8786859a6362bd6d8 [INFO] running `Command { std: "docker" "start" "-a" "b06f93b6b38dc97d1d2e4a7d986a9b579731fbbb32a256b8786859a6362bd6d8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b06f93b6b38dc97d1d2e4a7d986a9b579731fbbb32a256b8786859a6362bd6d8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b06f93b6b38dc97d1d2e4a7d986a9b579731fbbb32a256b8786859a6362bd6d8", kill_on_drop: false }` [INFO] [stdout] b06f93b6b38dc97d1d2e4a7d986a9b579731fbbb32a256b8786859a6362bd6d8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8bd2ad14a21496b336ac6e99e89e48ed56933783da66d1cda89b4a3a2c04c487 [INFO] running `Command { std: "docker" "start" "-a" "8bd2ad14a21496b336ac6e99e89e48ed56933783da66d1cda89b4a3a2c04c487", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.105 [INFO] [stderr] Checking numtoa v0.1.0 [INFO] [stderr] Checking unicode-segmentation v1.8.0 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking termion v1.5.6 [INFO] [stderr] Checking lecturn v0.1.8 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/editor.rs:236:13 [INFO] [stdout] | [INFO] [stdout] 236 | let mut offset = &mut self.offset; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/commands.rs:28:28 [INFO] [stdout] | [INFO] [stdout] 28 | function: |mut editor, _params, forced| { [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/editor.rs:94:23 [INFO] [stdout] | [INFO] [stdout] 77 | let doc = Document::open(file_name); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | terminal: Terminal::default().expect("Failed to initialize terminal"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/editor.rs:101:30 [INFO] [stdout] | [INFO] [stdout] 77 | let doc = Document::open(file_name); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | command_handler: Commands::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/terminal.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 24 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 25 | | size: Size { [INFO] [stdout] 26 | | width: size.0, [INFO] [stdout] 27 | | height: size.1.saturating_sub(2), [INFO] [stdout] 28 | | }, [INFO] [stdout] 29 | | _stdout: stdout().into_raw_mode()?, [INFO] [stdout] 30 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/editor.rs:236:13 [INFO] [stdout] | [INFO] [stdout] 236 | let mut offset = &mut self.offset; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lecturn` (bin "lecturn") due to 4 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/commands.rs:28:28 [INFO] [stdout] | [INFO] [stdout] 28 | function: |mut editor, _params, forced| { [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/editor.rs:94:23 [INFO] [stdout] | [INFO] [stdout] 77 | let doc = Document::open(file_name); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | terminal: Terminal::default().expect("Failed to initialize terminal"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/editor.rs:101:30 [INFO] [stdout] | [INFO] [stdout] 77 | let doc = Document::open(file_name); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | command_handler: Commands::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/terminal.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 24 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 25 | | size: Size { [INFO] [stdout] 26 | | width: size.0, [INFO] [stdout] 27 | | height: size.1.saturating_sub(2), [INFO] [stdout] 28 | | }, [INFO] [stdout] 29 | | _stdout: stdout().into_raw_mode()?, [INFO] [stdout] 30 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lecturn` (bin "lecturn" test) due to 4 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "8bd2ad14a21496b336ac6e99e89e48ed56933783da66d1cda89b4a3a2c04c487", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8bd2ad14a21496b336ac6e99e89e48ed56933783da66d1cda89b4a3a2c04c487", kill_on_drop: false }` [INFO] [stdout] 8bd2ad14a21496b336ac6e99e89e48ed56933783da66d1cda89b4a3a2c04c487