[INFO] cloning repository https://github.com/NinoMaj/rust-web-api [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/NinoMaj/rust-web-api" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNinoMaj%2Frust-web-api", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNinoMaj%2Frust-web-api'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 08edaeba82f5c4847f760caabf5075b2fe718e86 [INFO] checking NinoMaj/rust-web-api/08edaeba82f5c4847f760caabf5075b2fe718e86 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNinoMaj%2Frust-web-api" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/NinoMaj/rust-web-api on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/NinoMaj/rust-web-api [INFO] finished tweaking git repo https://github.com/NinoMaj/rust-web-api [INFO] tweaked toml for git repo https://github.com/NinoMaj/rust-web-api written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/NinoMaj/rust-web-api already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 93450eeaa82120f48dc6b8e60eb5896ca95c7f071f6eb3f3cc928ed55176bdb1 [INFO] running `Command { std: "docker" "start" "-a" "93450eeaa82120f48dc6b8e60eb5896ca95c7f071f6eb3f3cc928ed55176bdb1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "93450eeaa82120f48dc6b8e60eb5896ca95c7f071f6eb3f3cc928ed55176bdb1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "93450eeaa82120f48dc6b8e60eb5896ca95c7f071f6eb3f3cc928ed55176bdb1", kill_on_drop: false }` [INFO] [stdout] 93450eeaa82120f48dc6b8e60eb5896ca95c7f071f6eb3f3cc928ed55176bdb1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ed10c53e54fd12f3aefc2431ace941591d53b944b5f8890740a4069bd77ee28c [INFO] running `Command { std: "docker" "start" "-a" "ed10c53e54fd12f3aefc2431ace941591d53b944b5f8890740a4069bd77ee28c", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.86 [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Compiling version_check v0.1.5 [INFO] [stderr] Compiling rand_core v0.4.2 [INFO] [stderr] Compiling siphasher v0.2.3 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Checking tinyvec v1.1.1 [INFO] [stderr] Compiling syn v1.0.60 [INFO] [stderr] Compiling rand_core v0.3.1 [INFO] [stderr] Compiling rand_jitter v0.1.4 [INFO] [stderr] Compiling rand_isaac v0.1.1 [INFO] [stderr] Compiling unicase v1.4.2 [INFO] [stderr] Compiling rand_hc v0.1.0 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Compiling rand_xorshift v0.1.1 [INFO] [stderr] Compiling phf_shared v0.7.24 [INFO] [stderr] Checking matches v0.1.8 [INFO] [stderr] Checking traitobject v0.1.0 [INFO] [stderr] Compiling phf v0.7.24 [INFO] [stderr] Checking unicode-bidi v0.3.4 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Compiling httparse v1.3.5 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Compiling serde_derive v1.0.123 [INFO] [stderr] Checking unicode-normalization v0.1.17 [INFO] [stderr] Compiling rand_os v0.1.3 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking mime v0.2.6 [INFO] [stderr] Checking unsafe-any v0.4.2 [INFO] [stderr] Checking byteorder v1.4.2 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling serde v1.0.123 [INFO] [stderr] Checking percent-encoding v1.0.1 [INFO] [stderr] Checking safemem v0.3.3 [INFO] [stderr] Checking typemap v0.3.3 [INFO] [stderr] Checking base64 v0.9.3 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Checking language-tags v0.2.2 [INFO] [stderr] Checking typeable v0.1.2 [INFO] [stderr] Checking plugin v0.2.6 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Checking modifier v0.1.0 [INFO] [stderr] Checking once_cell v1.7.0 [INFO] [stderr] Checking aho-corasick v0.7.15 [INFO] [stderr] Checking thread_local v1.1.3 [INFO] [stderr] Checking idna v0.1.5 [INFO] [stderr] Compiling serde_json v1.0.63 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking regex-syntax v0.6.22 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Compiling phf_generator v0.7.24 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking route-recognizer v0.1.13 [INFO] [stderr] Compiling phf_codegen v0.7.24 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Compiling mime_guess v1.8.8 [INFO] [stderr] Checking url v1.7.2 [INFO] [stderr] Checking hyper v0.10.16 [INFO] [stderr] Checking regex v1.4.3 [INFO] [stderr] Checking iron v0.6.1 [INFO] [stderr] Checking router v0.6.0 [INFO] [stderr] Checking logger v0.4.0 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking uuid v0.7.4 [INFO] [stderr] Checking rust-web-api v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/database.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | &self.posts.push(post); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 14 | let _ = &self.posts.push(post); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/database.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | &self.posts.push(post); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 14 | let _ = &self.posts.push(post); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers.rs:54:18 [INFO] [stdout] | [INFO] [stdout] 52 | let database = Arc::new(Mutex::new(db)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | Handlers { [INFO] [stdout] 54 | post_feed: PostFeedHandler::new(database.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers.rs:55:18 [INFO] [stdout] | [INFO] [stdout] 52 | let database = Arc::new(Mutex::new(db)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | post_post: PostPostHandler::new(database.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers.rs:56:13 [INFO] [stdout] | [INFO] [stdout] 52 | let database = Arc::new(Mutex::new(db)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | post: PostHandler::new(database.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers.rs:74:8 [INFO] [stdout] | [INFO] [stdout] 15 | Err(e) => return Ok(Response::with((status::InternalServerError, e.to_string()))), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | Ok(Response::with((status::Ok, payload))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers.rs:96:8 [INFO] [stdout] | [INFO] [stdout] 21 | Err(e) => return Ok(Response::with(($error, e.to_string()))), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | Ok(Response::with((status::Created, payload))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers.rs:54:18 [INFO] [stdout] | [INFO] [stdout] 52 | let database = Arc::new(Mutex::new(db)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | Handlers { [INFO] [stdout] 54 | post_feed: PostFeedHandler::new(database.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers.rs:55:18 [INFO] [stdout] | [INFO] [stdout] 52 | let database = Arc::new(Mutex::new(db)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | post_post: PostPostHandler::new(database.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers.rs:56:13 [INFO] [stdout] | [INFO] [stdout] 52 | let database = Arc::new(Mutex::new(db)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | post: PostHandler::new(database.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers.rs:74:8 [INFO] [stdout] | [INFO] [stdout] 15 | Err(e) => return Ok(Response::with((status::InternalServerError, e.to_string()))), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | Ok(Response::with((status::Ok, payload))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers.rs:96:8 [INFO] [stdout] | [INFO] [stdout] 21 | Err(e) => return Ok(Response::with(($error, e.to_string()))), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | Ok(Response::with((status::Created, payload))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-web-api` (bin "rust-web-api" test) due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `rust-web-api` (bin "rust-web-api") due to 6 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "ed10c53e54fd12f3aefc2431ace941591d53b944b5f8890740a4069bd77ee28c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ed10c53e54fd12f3aefc2431ace941591d53b944b5f8890740a4069bd77ee28c", kill_on_drop: false }` [INFO] [stdout] ed10c53e54fd12f3aefc2431ace941591d53b944b5f8890740a4069bd77ee28c