[INFO] cloning repository https://github.com/Nilstrieb/tls [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Nilstrieb/tls" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNilstrieb%2Ftls", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNilstrieb%2Ftls'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ad3a4d21a5fcf12b4bee407145f42a87c743b9aa [INFO] checking Nilstrieb/tls/ad3a4d21a5fcf12b4bee407145f42a87c743b9aa against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNilstrieb%2Ftls" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Nilstrieb/tls on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Nilstrieb/tls [INFO] finished tweaking git repo https://github.com/Nilstrieb/tls [INFO] tweaked toml for git repo https://github.com/Nilstrieb/tls written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Nilstrieb/tls already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] babbe55d2f1818bd4896a2244e3704c19c8d68990afa47b2f05f7f87b1e20dbe [INFO] running `Command { std: "docker" "start" "-a" "babbe55d2f1818bd4896a2244e3704c19c8d68990afa47b2f05f7f87b1e20dbe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "babbe55d2f1818bd4896a2244e3704c19c8d68990afa47b2f05f7f87b1e20dbe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "babbe55d2f1818bd4896a2244e3704c19c8d68990afa47b2f05f7f87b1e20dbe", kill_on_drop: false }` [INFO] [stdout] babbe55d2f1818bd4896a2244e3704c19c8d68990afa47b2f05f7f87b1e20dbe [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1024cf7e8230acf8aa5b3f0839c1cf8e6d4390cbe2f04ab7bb5438b3e8516252 [INFO] running `Command { std: "docker" "start" "-a" "1024cf7e8230acf8aa5b3f0839c1cf8e6d4390cbe2f04ab7bb5438b3e8516252", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Compiling platforms v3.4.0 [INFO] [stderr] Checking opaque-debug v0.3.1 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Compiling curve25519-dalek v4.1.2 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Checking hkdf v0.12.4 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking x25519-dalek v2.0.1 [INFO] [stderr] Checking tls v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `inner` [INFO] [stdout] --> src/lib.rs:344:25 [INFO] [stdout] | [INFO] [stdout] 344 | let inner = crypto::aead::decrypt_ciphertext( [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_inner` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `inner` [INFO] [stdout] --> src/lib.rs:344:25 [INFO] [stdout] | [INFO] [stdout] 344 | let inner = crypto::aead::decrypt_ciphertext( [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_inner` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `expand` is never used [INFO] [stdout] --> src/crypto/mod.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 9 | trait TlsHasher: OutputSizeUser { [INFO] [stdout] | --------- associated function in this trait [INFO] [stdout] 10 | const ZEROED: &'static [u8]; [INFO] [stdout] 11 | fn expand(ikm: &[u8], label: &[u8], okm: &mut [u8]) -> Result<(), hkdf::InvalidLength>; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `hkdf_extract` is never read [INFO] [stdout] --> src/crypto/mod.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 36 | pub struct CryptoProvider { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 37 | zeroed_of_hash_size: &'static [u8], [INFO] [stdout] 38 | hkdf_extract: fn(salt: &[u8], ikm: &[u8]) -> Vec, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `provider` and `client_handshake_traffic_secret` are never read [INFO] [stdout] --> src/crypto/keys.rs:128:5 [INFO] [stdout] | [INFO] [stdout] 127 | pub struct KeysAfterServerHello { [INFO] [stdout] | -------------------- fields in this struct [INFO] [stdout] 128 | provider: CryptoProvider, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 129 | pub client_handshake_traffic_secret: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `expand` is never used [INFO] [stdout] --> src/crypto/mod.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 9 | trait TlsHasher: OutputSizeUser { [INFO] [stdout] | --------- associated function in this trait [INFO] [stdout] 10 | const ZEROED: &'static [u8]; [INFO] [stdout] 11 | fn expand(ikm: &[u8], label: &[u8], okm: &mut [u8]) -> Result<(), hkdf::InvalidLength>; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `hkdf_extract` is never read [INFO] [stdout] --> src/crypto/mod.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 36 | pub struct CryptoProvider { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 37 | zeroed_of_hash_size: &'static [u8], [INFO] [stdout] 38 | hkdf_extract: fn(salt: &[u8], ikm: &[u8]) -> Vec, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `provider` and `client_handshake_traffic_secret` are never read [INFO] [stdout] --> src/crypto/keys.rs:128:5 [INFO] [stdout] | [INFO] [stdout] 127 | pub struct KeysAfterServerHello { [INFO] [stdout] | -------------------- fields in this struct [INFO] [stdout] 128 | provider: CryptoProvider, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 129 | pub client_handshake_traffic_secret: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proto/ser_de.rs:283:12 [INFO] [stdout] | [INFO] [stdout] 277 | let mut v = Vec::new(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 283 | Ok(Self(v, PhantomData)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proto/ser_de.rs:308:12 [INFO] [stdout] | [INFO] [stdout] 303 | let mut values = Vec::with_capacity(N); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 308 | Ok(values.try_into().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proto/ser_de.rs:283:12 [INFO] [stdout] | [INFO] [stdout] 277 | let mut v = Vec::new(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 283 | Ok(Self(v, PhantomData)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proto/ser_de.rs:308:12 [INFO] [stdout] | [INFO] [stdout] 303 | let mut values = Vec::with_capacity(N); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 308 | Ok(values.try_into().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tls` (lib) due to 3 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `tls` (lib test) due to 3 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "1024cf7e8230acf8aa5b3f0839c1cf8e6d4390cbe2f04ab7bb5438b3e8516252", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1024cf7e8230acf8aa5b3f0839c1cf8e6d4390cbe2f04ab7bb5438b3e8516252", kill_on_drop: false }` [INFO] [stdout] 1024cf7e8230acf8aa5b3f0839c1cf8e6d4390cbe2f04ab7bb5438b3e8516252