[INFO] cloning repository https://github.com/Nilstrieb/fix-und-fertig [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Nilstrieb/fix-und-fertig" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNilstrieb%2Ffix-und-fertig", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNilstrieb%2Ffix-und-fertig'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d28d923d430b94cd38ed0da70e94e81ae3bf8ef1 [INFO] checking Nilstrieb/fix-und-fertig/d28d923d430b94cd38ed0da70e94e81ae3bf8ef1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNilstrieb%2Ffix-und-fertig" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Nilstrieb/fix-und-fertig on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Nilstrieb/fix-und-fertig [INFO] finished tweaking git repo https://github.com/Nilstrieb/fix-und-fertig [INFO] tweaked toml for git repo https://github.com/Nilstrieb/fix-und-fertig written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Nilstrieb/fix-und-fertig already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ef1bf6f3ff5276223c5e722bb25baa206f250b995ef633f0fc6b2e485bac5540 [INFO] running `Command { std: "docker" "start" "-a" "ef1bf6f3ff5276223c5e722bb25baa206f250b995ef633f0fc6b2e485bac5540", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ef1bf6f3ff5276223c5e722bb25baa206f250b995ef633f0fc6b2e485bac5540", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ef1bf6f3ff5276223c5e722bb25baa206f250b995ef633f0fc6b2e485bac5540", kill_on_drop: false }` [INFO] [stdout] ef1bf6f3ff5276223c5e722bb25baa206f250b995ef633f0fc6b2e485bac5540 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 167381c42a38d8008baefc1804b74d5bb86dd11b2e7e141059ba7f190fcbf716 [INFO] running `Command { std: "docker" "start" "-a" "167381c42a38d8008baefc1804b74d5bb86dd11b2e7e141059ba7f190fcbf716", kill_on_drop: false }` [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling rustix v0.38.30 [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling io-lifetimes v2.0.3 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking thread_local v1.1.7 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling io-extras v0.18.1 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Compiling eyre v0.6.12 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking anstyle v1.0.5 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking gimli v0.28.1 [INFO] [stderr] Compiling cap-primitives v3.0.0 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking anstream v0.6.11 [INFO] [stderr] Checking object v0.32.2 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking tracing-error v0.2.0 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Checking owo-colors v3.5.0 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Compiling cap-std v3.0.0 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Checking ipnet v2.9.0 [INFO] [stderr] Checking ambient-authority v0.0.2 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Checking maybe-owned v0.3.4 [INFO] [stderr] Checking clap_builder v4.4.18 [INFO] [stderr] Checking color-spantrace v0.2.1 [INFO] [stderr] Compiling backtrace v0.3.69 [INFO] [stderr] Compiling blake3 v1.5.0 [INFO] [stderr] Checking constant_time_eq v0.3.0 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking arrayref v0.3.7 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stderr] Checking fs-set-times v0.20.1 [INFO] [stderr] Checking tempfile v3.9.0 [INFO] [stderr] Checking color-eyre v0.6.2 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Checking clap v4.4.18 [INFO] [stderr] Checking fix-und-fertig v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli/utils.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 20 | let dir = File::open(path).wrap_err_with(|| format!("opening directory {}", path.display()))?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | Ok(Dir::from_std_file(dir)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 45 | let db = dir [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let objects = db [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | Ok(Self { objects }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 92 | let prefix_dir = self.open_prefix_dir(address).wrap_err("opening prefix dir for reading file")?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | prefix_dir.read(address.0.to_hex().as_str()).wrap_err("reading file") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workspace.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 27 | bail!("you are not in a fix-und-fertig workspace, indicated by a .fuf directory"); [INFO] [stdout] | --------------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | Self::open_root(&root).wrap_err_with(|| format!("opening workspace {}", root.display())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workspace.rs:37:12 [INFO] [stdout] | [INFO] [stdout] 34 | let dir = File::open(root).wrap_err("opening workspace directory")?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let dir = Dir::from_std_file(dir); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let db = Db::open(&dir).wrap_err("opening .fuf database")?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | Ok(Self { _root: dir, db }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli/utils.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 20 | let dir = File::open(path).wrap_err_with(|| format!("opening directory {}", path.display()))?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | Ok(Dir::from_std_file(dir)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 45 | let db = dir [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let objects = db [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | Ok(Self { objects }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 92 | let prefix_dir = self.open_prefix_dir(address).wrap_err("opening prefix dir for reading file")?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | prefix_dir.read(address.0.to_hex().as_str()).wrap_err("reading file") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workspace.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 27 | bail!("you are not in a fix-und-fertig workspace, indicated by a .fuf directory"); [INFO] [stdout] | --------------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | Self::open_root(&root).wrap_err_with(|| format!("opening workspace {}", root.display())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workspace.rs:37:12 [INFO] [stdout] | [INFO] [stdout] 34 | let dir = File::open(root).wrap_err("opening workspace directory")?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let dir = Dir::from_std_file(dir); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let db = Db::open(&dir).wrap_err("opening .fuf database")?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | Ok(Self { _root: dir, db }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fix-und-fertig` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `fix-und-fertig` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "167381c42a38d8008baefc1804b74d5bb86dd11b2e7e141059ba7f190fcbf716", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "167381c42a38d8008baefc1804b74d5bb86dd11b2e7e141059ba7f190fcbf716", kill_on_drop: false }` [INFO] [stdout] 167381c42a38d8008baefc1804b74d5bb86dd11b2e7e141059ba7f190fcbf716