[INFO] cloning repository https://github.com/NicholasLYang/tlox [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/NicholasLYang/tlox" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNicholasLYang%2Ftlox", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNicholasLYang%2Ftlox'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ed4ae161571042e4fc234349177d1ae3a0681cf3 [INFO] checking NicholasLYang/tlox/ed4ae161571042e4fc234349177d1ae3a0681cf3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNicholasLYang%2Ftlox" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/NicholasLYang/tlox on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/NicholasLYang/tlox [INFO] finished tweaking git repo https://github.com/NicholasLYang/tlox [INFO] tweaked toml for git repo https://github.com/NicholasLYang/tlox written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/NicholasLYang/tlox already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] de7142045de341cf95eaedd3c2f81b254ac5929671ff199e3ddaf19c23209739 [INFO] running `Command { std: "docker" "start" "-a" "de7142045de341cf95eaedd3c2f81b254ac5929671ff199e3ddaf19c23209739", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "de7142045de341cf95eaedd3c2f81b254ac5929671ff199e3ddaf19c23209739", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "de7142045de341cf95eaedd3c2f81b254ac5929671ff199e3ddaf19c23209739", kill_on_drop: false }` [INFO] [stdout] de7142045de341cf95eaedd3c2f81b254ac5929671ff199e3ddaf19c23209739 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] feab18eea8351ce5aa12ed6249284da6d354877af2a5dfcdae4baccc9857abb9 [INFO] running `Command { std: "docker" "start" "-a" "feab18eea8351ce5aa12ed6249284da6d354877af2a5dfcdae4baccc9857abb9", kill_on_drop: false }` [INFO] [stderr] Compiling anyhow v1.0.58 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Compiling tree-sitter v0.20.8 [INFO] [stderr] Compiling tlox v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Compiling syn v1.0.98 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Compiling thiserror-impl v1.0.31 [INFO] [stderr] Checking thiserror v1.0.31 [INFO] [stdout] warning: unused import: `Node` [INFO] [stdout] --> src/main.rs:2:29 [INFO] [stdout] | [INFO] [stdout] 2 | use tree_sitter::{Language, Node, Parser, TreeCursor}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Node` [INFO] [stdout] --> src/main.rs:2:29 [INFO] [stdout] | [INFO] [stdout] 2 | use tree_sitter::{Language, Node, Parser, TreeCursor}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cursor` [INFO] [stdout] --> src/main.rs:182:16 [INFO] [stdout] | [INFO] [stdout] 182 | fn parse_block(cursor: &mut TreeCursor) -> Result, anyhow::Error> { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_cursor` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cursor` [INFO] [stdout] --> src/main.rs:186:21 [INFO] [stdout] | [INFO] [stdout] 186 | fn parse_parameters(cursor: &mut TreeCursor) -> Result, anyhow::Error> { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_cursor` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Add`, `Subtract`, `Multiply`, and `Divide` are never constructed [INFO] [stdout] --> src/main.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 15 | enum Operator { [INFO] [stdout] | -------- variants in this enum [INFO] [stdout] 16 | Add, [INFO] [stdout] | ^^^ [INFO] [stdout] 17 | Subtract, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 18 | Multiply, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 19 | Divide, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Operator` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Number`, `String`, and `Bool` are never constructed [INFO] [stdout] --> src/main.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 23 | enum Value { [INFO] [stdout] | ----- variants in this enum [INFO] [stdout] 24 | Number(f64), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 25 | String(String), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 26 | Bool(bool), [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Value` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Binary`, `Literal`, and `Unary` are never constructed [INFO] [stdout] --> src/main.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 30 | enum Expr { [INFO] [stdout] | ---- variants in this enum [INFO] [stdout] 31 | Binary { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 36 | Literal { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 39 | Unary { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Expr` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/main.rs:46:16 [INFO] [stdout] | [INFO] [stdout] 46 | struct Program(Vec); [INFO] [stdout] | ------- ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `Program` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name`, `body`, and `params` are never read [INFO] [stdout] --> src/main.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 56 | Function { [INFO] [stdout] | -------- fields in this variant [INFO] [stdout] 57 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 58 | body: Vec, [INFO] [stdout] | ^^^^ [INFO] [stdout] 59 | params: Vec, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Stmt` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name`, `super_class`, and `methods` are never read [INFO] [stdout] --> src/main.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 61 | Class { [INFO] [stdout] | ----- fields in this variant [INFO] [stdout] 62 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 63 | super_class: Option, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 64 | methods: Vec, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Stmt` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Var`, `Expression`, and `Print` are never constructed [INFO] [stdout] --> src/main.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 49 | enum Stmt { [INFO] [stdout] | ---- variants in this enum [INFO] [stdout] 50 | Var { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 54 | Expression(Expr), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 55 | Print(Expr), [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Stmt` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:175:8 [INFO] [stdout] | [INFO] [stdout] 155 | let mut body = None; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | Ok(Stmt::Function { [INFO] [stdout] | ________^ [INFO] [stdout] 176 | | name: name.ok_or_else(|| anyhow!("Function does not have name"))?, [INFO] [stdout] 177 | | body: body.ok_or_else(|| anyhow!("Function does not have body"))?, [INFO] [stdout] 178 | | params: params.unwrap_or_default(), [INFO] [stdout] 179 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cursor` [INFO] [stdout] --> src/main.rs:182:16 [INFO] [stdout] | [INFO] [stdout] 182 | fn parse_block(cursor: &mut TreeCursor) -> Result, anyhow::Error> { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_cursor` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cursor` [INFO] [stdout] --> src/main.rs:186:21 [INFO] [stdout] | [INFO] [stdout] 186 | fn parse_parameters(cursor: &mut TreeCursor) -> Result, anyhow::Error> { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_cursor` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tlox` (bin "tlox") due to 2 previous errors; 10 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variants `Add`, `Subtract`, `Multiply`, and `Divide` are never constructed [INFO] [stdout] --> src/main.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 15 | enum Operator { [INFO] [stdout] | -------- variants in this enum [INFO] [stdout] 16 | Add, [INFO] [stdout] | ^^^ [INFO] [stdout] 17 | Subtract, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 18 | Multiply, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 19 | Divide, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Operator` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tlox` (bin "tlox" test) due to 2 previous errors; 10 warnings emitted [INFO] [stdout] warning: variants `Number`, `String`, and `Bool` are never constructed [INFO] [stdout] --> src/main.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 23 | enum Value { [INFO] [stdout] | ----- variants in this enum [INFO] [stdout] 24 | Number(f64), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 25 | String(String), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 26 | Bool(bool), [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Value` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Binary`, `Literal`, and `Unary` are never constructed [INFO] [stdout] --> src/main.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 30 | enum Expr { [INFO] [stdout] | ---- variants in this enum [INFO] [stdout] 31 | Binary { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 36 | Literal { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 39 | Unary { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Expr` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/main.rs:46:16 [INFO] [stdout] | [INFO] [stdout] 46 | struct Program(Vec); [INFO] [stdout] | ------- ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `Program` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name`, `body`, and `params` are never read [INFO] [stdout] --> src/main.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 56 | Function { [INFO] [stdout] | -------- fields in this variant [INFO] [stdout] 57 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 58 | body: Vec, [INFO] [stdout] | ^^^^ [INFO] [stdout] 59 | params: Vec, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Stmt` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name`, `super_class`, and `methods` are never read [INFO] [stdout] --> src/main.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 61 | Class { [INFO] [stdout] | ----- fields in this variant [INFO] [stdout] 62 | name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 63 | super_class: Option, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 64 | methods: Vec, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Stmt` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Var`, `Expression`, and `Print` are never constructed [INFO] [stdout] --> src/main.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 49 | enum Stmt { [INFO] [stdout] | ---- variants in this enum [INFO] [stdout] 50 | Var { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 54 | Expression(Expr), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 55 | Print(Expr), [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Stmt` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:175:8 [INFO] [stdout] | [INFO] [stdout] 155 | let mut body = None; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | Ok(Stmt::Function { [INFO] [stdout] | ________^ [INFO] [stdout] 176 | | name: name.ok_or_else(|| anyhow!("Function does not have name"))?, [INFO] [stdout] 177 | | body: body.ok_or_else(|| anyhow!("Function does not have body"))?, [INFO] [stdout] 178 | | params: params.unwrap_or_default(), [INFO] [stdout] 179 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "feab18eea8351ce5aa12ed6249284da6d354877af2a5dfcdae4baccc9857abb9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "feab18eea8351ce5aa12ed6249284da6d354877af2a5dfcdae4baccc9857abb9", kill_on_drop: false }` [INFO] [stdout] feab18eea8351ce5aa12ed6249284da6d354877af2a5dfcdae4baccc9857abb9