[INFO] cloning repository https://github.com/NakadaTokumei/NakadaDB [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/NakadaTokumei/NakadaDB" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNakadaTokumei%2FNakadaDB", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNakadaTokumei%2FNakadaDB'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 77bfb11f095442e8e9456d6de3712aa669b15455 [INFO] checking NakadaTokumei/NakadaDB/77bfb11f095442e8e9456d6de3712aa669b15455 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNakadaTokumei%2FNakadaDB" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/NakadaTokumei/NakadaDB on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/NakadaTokumei/NakadaDB [INFO] finished tweaking git repo https://github.com/NakadaTokumei/NakadaDB [INFO] tweaked toml for git repo https://github.com/NakadaTokumei/NakadaDB written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/NakadaTokumei/NakadaDB already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f4294da21802d0bd8b9c69ab2dab3e502d38cd3b3ef4db55b943c1cfca59e3fa [INFO] running `Command { std: "docker" "start" "-a" "f4294da21802d0bd8b9c69ab2dab3e502d38cd3b3ef4db55b943c1cfca59e3fa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f4294da21802d0bd8b9c69ab2dab3e502d38cd3b3ef4db55b943c1cfca59e3fa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f4294da21802d0bd8b9c69ab2dab3e502d38cd3b3ef4db55b943c1cfca59e3fa", kill_on_drop: false }` [INFO] [stdout] f4294da21802d0bd8b9c69ab2dab3e502d38cd3b3ef4db55b943c1cfca59e3fa [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 930ba58a4298323d68f1648557ff8b3fe554e05969bb116e93d995336d20339e [INFO] running `Command { std: "docker" "start" "-a" "930ba58a4298323d68f1648557ff8b3fe554e05969bb116e93d995336d20339e", kill_on_drop: false }` [INFO] [stderr] Checking NakadaDB v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::thread` [INFO] [stdout] --> src/nakada/server/DBServer.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::thread; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/nakada/server/DBServer.rs:23:13 [INFO] [stdout] | [INFO] [stdout] 23 | let mut iter = self.server_thread.into_iter(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `server` [INFO] [stdout] --> src/main.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | let server = match Server::bind("127.0.0.1:5994") { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_server` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `create_thread`, `start_all`, and `stop_all` are never used [INFO] [stdout] --> src/nakada/server/Thread.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 4 | pub trait NakadaThread [INFO] [stdout] | ------------ methods in this trait [INFO] [stdout] 5 | { [INFO] [stdout] 6 | fn create_thread(&mut self, func : fn()) -> Result<(), Box>; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 7 | fn start_all(self) -> thread::Result<()>; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 8 | fn stop_all(&mut self) -> Result<(), Box>; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `tcp_listener` and `server_thread` are never read [INFO] [stdout] --> src/nakada/server/DBServer.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 36 | pub struct Server [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 37 | { [INFO] [stdout] 38 | tcp_listener : TcpListener, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 39 | server_thread : ServerThread [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `Thread` should have a snake case name [INFO] [stdout] --> src/nakada/server/mod.rs:1:9 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod Thread; [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `thread` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `DBServer` should have a snake case name [INFO] [stdout] --> src/nakada/server/mod.rs:2:9 [INFO] [stdout] | [INFO] [stdout] 2 | pub mod DBServer; [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `dbserver` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nakada/server/DBServer.rs:55:12 [INFO] [stdout] | [INFO] [stdout] 50 | let listener = TcpListener::bind(ip_port)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | let thread = ServerThread { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | Ok(Server [INFO] [stdout] | ____________^ [INFO] [stdout] 56 | | { [INFO] [stdout] 57 | | tcp_listener: listener, [INFO] [stdout] 58 | | server_thread : thread [INFO] [stdout] 59 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `NakadaDB` (bin "NakadaDB") due to 2 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused import: `std::thread` [INFO] [stdout] --> src/nakada/server/DBServer.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::thread; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/nakada/server/DBServer.rs:23:13 [INFO] [stdout] | [INFO] [stdout] 23 | let mut iter = self.server_thread.into_iter(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `server` [INFO] [stdout] --> src/main.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | let server = match Server::bind("127.0.0.1:5994") { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_server` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `create_thread`, `start_all`, and `stop_all` are never used [INFO] [stdout] --> src/nakada/server/Thread.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 4 | pub trait NakadaThread [INFO] [stdout] | ------------ methods in this trait [INFO] [stdout] 5 | { [INFO] [stdout] 6 | fn create_thread(&mut self, func : fn()) -> Result<(), Box>; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 7 | fn start_all(self) -> thread::Result<()>; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 8 | fn stop_all(&mut self) -> Result<(), Box>; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `tcp_listener` and `server_thread` are never read [INFO] [stdout] --> src/nakada/server/DBServer.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 36 | pub struct Server [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 37 | { [INFO] [stdout] 38 | tcp_listener : TcpListener, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 39 | server_thread : ServerThread [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `Thread` should have a snake case name [INFO] [stdout] --> src/nakada/server/mod.rs:1:9 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod Thread; [INFO] [stdout] | ^^^^^^ help: convert the identifier to snake case: `thread` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `DBServer` should have a snake case name [INFO] [stdout] --> src/nakada/server/mod.rs:2:9 [INFO] [stdout] | [INFO] [stdout] 2 | pub mod DBServer; [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `dbserver` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nakada/server/DBServer.rs:55:12 [INFO] [stdout] | [INFO] [stdout] 50 | let listener = TcpListener::bind(ip_port)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | let thread = ServerThread { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | Ok(Server [INFO] [stdout] | ____________^ [INFO] [stdout] 56 | | { [INFO] [stdout] 57 | | tcp_listener: listener, [INFO] [stdout] 58 | | server_thread : thread [INFO] [stdout] 59 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `NakadaDB` (bin "NakadaDB" test) due to 2 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "930ba58a4298323d68f1648557ff8b3fe554e05969bb116e93d995336d20339e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "930ba58a4298323d68f1648557ff8b3fe554e05969bb116e93d995336d20339e", kill_on_drop: false }` [INFO] [stdout] 930ba58a4298323d68f1648557ff8b3fe554e05969bb116e93d995336d20339e