[INFO] cloning repository https://github.com/Nahuel-M/mathematics [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Nahuel-M/mathematics" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNahuel-M%2Fmathematics", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNahuel-M%2Fmathematics'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d15180e5b91b37fc9f7168c7f90edb00d2f978b9 [INFO] checking Nahuel-M/mathematics/d15180e5b91b37fc9f7168c7f90edb00d2f978b9 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNahuel-M%2Fmathematics" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Nahuel-M/mathematics on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Nahuel-M/mathematics [INFO] finished tweaking git repo https://github.com/Nahuel-M/mathematics [INFO] tweaked toml for git repo https://github.com/Nahuel-M/mathematics written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Nahuel-M/mathematics already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2ce988bd4a5e9381eae8fc6f2036241b92845670fe5cb782e195458e1b4a5092 [INFO] running `Command { std: "docker" "start" "-a" "2ce988bd4a5e9381eae8fc6f2036241b92845670fe5cb782e195458e1b4a5092", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2ce988bd4a5e9381eae8fc6f2036241b92845670fe5cb782e195458e1b4a5092", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2ce988bd4a5e9381eae8fc6f2036241b92845670fe5cb782e195458e1b4a5092", kill_on_drop: false }` [INFO] [stdout] 2ce988bd4a5e9381eae8fc6f2036241b92845670fe5cb782e195458e1b4a5092 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 56a7d3cc66a41aba2a5fb6b3786f6021cf2e6f9adcdd6eb36df3aa247e730874 [INFO] running `Command { std: "docker" "start" "-a" "56a7d3cc66a41aba2a5fb6b3786f6021cf2e6f9adcdd6eb36df3aa247e730874", kill_on_drop: false }` [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking itertools v0.12.0 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking math_toolkit v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `non_containing` [INFO] [stdout] --> src/expression/isolate_variable.rs:13:34 [INFO] [stdout] | [INFO] [stdout] 13 | let (containing, non_containing): (Vec<_>, Vec<_>) = add.0.iter() [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_non_containing` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `isolations` [INFO] [stdout] --> src/expression/isolate_variable.rs:30:21 [INFO] [stdout] | [INFO] [stdout] 30 | let isolations: Vec<_> = children [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_isolations` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `left` [INFO] [stdout] --> src/equation/isolate_variable.rs:5:13 [INFO] [stdout] | [INFO] [stdout] 5 | let left = self.left.contains_variable(variable); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_left` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `right` [INFO] [stdout] --> src/equation/isolate_variable.rs:6:13 [INFO] [stdout] | [INFO] [stdout] 6 | let right = self.right.contains_variable(variable); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_right` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `operand_count` is never used [INFO] [stdout] --> src/expression/mod.rs:26:8 [INFO] [stdout] | [INFO] [stdout] 24 | trait Operand: Display + Clone + PartialEq{ [INFO] [stdout] | ------- method in this trait [INFO] [stdout] 25 | fn solve(&self, variables: Option<&HashMap>) -> Result; [INFO] [stdout] 26 | fn operand_count(&self) -> usize; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression/from_str.rs:87:8 [INFO] [stdout] | [INFO] [stdout] 67 | let (mut remaining_input, mut expression) = singleton(input)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | Ok((remaining_input, expression)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression/from_str.rs:109:8 [INFO] [stdout] | [INFO] [stdout] 91 | let (mut remaining_input, mut expression) = singleton(input)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | Ok((remaining_input, expression)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression/from_str.rs:121:8 [INFO] [stdout] | [INFO] [stdout] 113 | let (mut remaining_input, mut expression) = singleton(input)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | Ok((remaining_input, expression)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression/from_str.rs:133:98 [INFO] [stdout] | [INFO] [stdout] 133 | take_while(|c: char| c.is_alphanumeric() || c == '_')(input).map(|(input, variable)| (input, Variable(variable.to_string()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression/macros.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | $crate::expression::Expression::Number($crate::expression::number::Number($expression as f64)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/expression/from_str.rs:137:49 [INFO] [stdout] | [INFO] [stdout] 137 | double(input).map(|(input, number)| (input, num!(number))) [INFO] [stdout] | ------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `num` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression/add.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 34 | let mut new_children: Vec = Vec::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | use Expression::*; [INFO] [stdout] 36 | let children: Vec = self.0.iter() [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | let mut additions: FxHashMap = FxHashMap::default(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | Add(Self(new_children)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression/multiply.rs:76:18 [INFO] [stdout] | [INFO] [stdout] 28 | let mut new_children: Vec = Vec::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | use Expression::*; [INFO] [stdout] 30 | let children: Vec = self.0.iter() [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | let mut multiplications: FxHashMap = FxHashMap::default(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | Multiply(Self(new_children)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression/macros.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | Expression::Invert(($crate::expression::Invert(Box::new($expression)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/expression/invert.rs:36:73 [INFO] [stdout] | [INFO] [stdout] 36 | Multiply(multiply::Multiply(children.iter().map(|child| inv!(child.clone()).simplify()).collect())) [INFO] [stdout] | ------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `inv` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression/operations.rs:10:15 [INFO] [stdout] | [INFO] [stdout] 8 | fn add(self, rhs: Self) -> Self::Output { [INFO] [stdout] | ---- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | use Expression::*; [INFO] [stdout] 10 | match (self, rhs){ [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression/operations.rs:24:15 [INFO] [stdout] | [INFO] [stdout] 22 | fn mul(self, rhs: Self) -> Self::Output { [INFO] [stdout] | ---- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | use Expression::*; [INFO] [stdout] 24 | match (self, rhs){ [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression/operations.rs:38:15 [INFO] [stdout] | [INFO] [stdout] 36 | fn div(self, rhs: Self) -> Self::Output { [INFO] [stdout] | ---- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | use Expression::*; [INFO] [stdout] 38 | match (self, rhs){ [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression/operations.rs:50:15 [INFO] [stdout] | [INFO] [stdout] 48 | fn sub(self, rhs: Expression) -> Self::Output { [INFO] [stdout] | ---- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | use Expression::*; [INFO] [stdout] 50 | match (self, rhs){ [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression/macros.rs:46:28 [INFO] [stdout] | [INFO] [stdout] 46 | Expression::Negate($crate::expression::Negate(Box::new($expression))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/expression/operations.rs:51:99 [INFO] [stdout] | [INFO] [stdout] 51 | (Add(add), Add(add2)) => Add(add::Add(add.0.into_iter().chain(add2.0.into_iter().map(|child| neg!(child))).collect())), [INFO] [stdout] | ----- ----------- in this macro invocation [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `neg` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression/macros.rs:46:28 [INFO] [stdout] | [INFO] [stdout] 46 | Expression::Negate($crate::expression::Negate(Box::new($expression))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/expression/operations.rs:62:12 [INFO] [stdout] | [INFO] [stdout] 62 | fn neg(self) -> Self::Output { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | neg!(self) [INFO] [stdout] | ---------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `neg` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `math_toolkit` (bin "math_toolkit") due to 15 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `non_containing` [INFO] [stdout] --> src/expression/isolate_variable.rs:13:34 [INFO] [stdout] | [INFO] [stdout] 13 | let (containing, non_containing): (Vec<_>, Vec<_>) = add.0.iter() [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_non_containing` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `isolations` [INFO] [stdout] --> src/expression/isolate_variable.rs:30:21 [INFO] [stdout] | [INFO] [stdout] 30 | let isolations: Vec<_> = children [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_isolations` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `left` [INFO] [stdout] --> src/equation/isolate_variable.rs:5:13 [INFO] [stdout] | [INFO] [stdout] 5 | let left = self.left.contains_variable(variable); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_left` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `right` [INFO] [stdout] --> src/equation/isolate_variable.rs:6:13 [INFO] [stdout] | [INFO] [stdout] 6 | let right = self.right.contains_variable(variable); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_right` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `equation` [INFO] [stdout] --> src/equation/mod.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | let equation = Equation::from_str("P = O + V * t").unwrap(); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_equation` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `operand_count` is never used [INFO] [stdout] --> src/expression/mod.rs:26:8 [INFO] [stdout] | [INFO] [stdout] 24 | trait Operand: Display + Clone + PartialEq{ [INFO] [stdout] | ------- method in this trait [INFO] [stdout] 25 | fn solve(&self, variables: Option<&HashMap>) -> Result; [INFO] [stdout] 26 | fn operand_count(&self) -> usize; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression/from_str.rs:87:8 [INFO] [stdout] | [INFO] [stdout] 67 | let (mut remaining_input, mut expression) = singleton(input)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | Ok((remaining_input, expression)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression/from_str.rs:109:8 [INFO] [stdout] | [INFO] [stdout] 91 | let (mut remaining_input, mut expression) = singleton(input)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | Ok((remaining_input, expression)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression/from_str.rs:121:8 [INFO] [stdout] | [INFO] [stdout] 113 | let (mut remaining_input, mut expression) = singleton(input)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | Ok((remaining_input, expression)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression/from_str.rs:133:98 [INFO] [stdout] | [INFO] [stdout] 133 | take_while(|c: char| c.is_alphanumeric() || c == '_')(input).map(|(input, variable)| (input, Variable(variable.to_string()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression/macros.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | $crate::expression::Expression::Number($crate::expression::number::Number($expression as f64)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/expression/from_str.rs:137:49 [INFO] [stdout] | [INFO] [stdout] 137 | double(input).map(|(input, number)| (input, num!(number))) [INFO] [stdout] | ------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `num` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression/add.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 34 | let mut new_children: Vec = Vec::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | use Expression::*; [INFO] [stdout] 36 | let children: Vec = self.0.iter() [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | let mut additions: FxHashMap = FxHashMap::default(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | Add(Self(new_children)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression/multiply.rs:76:18 [INFO] [stdout] | [INFO] [stdout] 28 | let mut new_children: Vec = Vec::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | use Expression::*; [INFO] [stdout] 30 | let children: Vec = self.0.iter() [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | let mut multiplications: FxHashMap = FxHashMap::default(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | Multiply(Self(new_children)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression/macros.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | Expression::Invert(($crate::expression::Invert(Box::new($expression)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/expression/invert.rs:36:73 [INFO] [stdout] | [INFO] [stdout] 36 | Multiply(multiply::Multiply(children.iter().map(|child| inv!(child.clone()).simplify()).collect())) [INFO] [stdout] | ------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `inv` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression/invert.rs:52:20 [INFO] [stdout] | [INFO] [stdout] 51 | let expression = inv!(num!(2.0) * inv!(var!("a"))); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | assert_eq!(expression.simplify(), var!("a") * num!(0.5)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression/invert.rs:52:43 [INFO] [stdout] | [INFO] [stdout] 51 | let expression = inv!(num!(2.0) * inv!(var!("a"))); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | assert_eq!(expression.simplify(), var!("a") * num!(0.5)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression/operations.rs:10:15 [INFO] [stdout] | [INFO] [stdout] 8 | fn add(self, rhs: Self) -> Self::Output { [INFO] [stdout] | ---- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | use Expression::*; [INFO] [stdout] 10 | match (self, rhs){ [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression/operations.rs:24:15 [INFO] [stdout] | [INFO] [stdout] 22 | fn mul(self, rhs: Self) -> Self::Output { [INFO] [stdout] | ---- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | use Expression::*; [INFO] [stdout] 24 | match (self, rhs){ [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression/operations.rs:38:15 [INFO] [stdout] | [INFO] [stdout] 36 | fn div(self, rhs: Self) -> Self::Output { [INFO] [stdout] | ---- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | use Expression::*; [INFO] [stdout] 38 | match (self, rhs){ [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression/operations.rs:50:15 [INFO] [stdout] | [INFO] [stdout] 48 | fn sub(self, rhs: Expression) -> Self::Output { [INFO] [stdout] | ---- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | use Expression::*; [INFO] [stdout] 50 | match (self, rhs){ [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression/macros.rs:46:28 [INFO] [stdout] | [INFO] [stdout] 46 | Expression::Negate($crate::expression::Negate(Box::new($expression))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/expression/operations.rs:51:99 [INFO] [stdout] | [INFO] [stdout] 51 | (Add(add), Add(add2)) => Add(add::Add(add.0.into_iter().chain(add2.0.into_iter().map(|child| neg!(child))).collect())), [INFO] [stdout] | ----- ----------- in this macro invocation [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `neg` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expression/macros.rs:46:28 [INFO] [stdout] | [INFO] [stdout] 46 | Expression::Negate($crate::expression::Negate(Box::new($expression))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/expression/operations.rs:62:12 [INFO] [stdout] | [INFO] [stdout] 62 | fn neg(self) -> Self::Output { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | neg!(self) [INFO] [stdout] | ---------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `neg` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `math_toolkit` (bin "math_toolkit" test) due to 17 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "56a7d3cc66a41aba2a5fb6b3786f6021cf2e6f9adcdd6eb36df3aa247e730874", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "56a7d3cc66a41aba2a5fb6b3786f6021cf2e6f9adcdd6eb36df3aa247e730874", kill_on_drop: false }` [INFO] [stdout] 56a7d3cc66a41aba2a5fb6b3786f6021cf2e6f9adcdd6eb36df3aa247e730874