[INFO] cloning repository https://github.com/Nadybot/ao-chat-client [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Nadybot/ao-chat-client" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNadybot%2Fao-chat-client", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNadybot%2Fao-chat-client'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9543e59b0a7a0edde903a26f5ebe5ff7c192fbc7 [INFO] checking Nadybot/ao-chat-client/9543e59b0a7a0edde903a26f5ebe5ff7c192fbc7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FNadybot%2Fao-chat-client" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Nadybot/ao-chat-client on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Nadybot/ao-chat-client [INFO] finished tweaking git repo https://github.com/Nadybot/ao-chat-client [INFO] tweaked toml for git repo https://github.com/Nadybot/ao-chat-client written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Nadybot/ao-chat-client already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 192ea8fe6be8da634abb2be27f245bcf7a5cb4f3f20625b4866349e32e501359 [INFO] running `Command { std: "docker" "start" "-a" "192ea8fe6be8da634abb2be27f245bcf7a5cb4f3f20625b4866349e32e501359", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "192ea8fe6be8da634abb2be27f245bcf7a5cb4f3f20625b4866349e32e501359", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "192ea8fe6be8da634abb2be27f245bcf7a5cb4f3f20625b4866349e32e501359", kill_on_drop: false }` [INFO] [stdout] 192ea8fe6be8da634abb2be27f245bcf7a5cb4f3f20625b4866349e32e501359 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7e19a69eb8773256cf18aac81660870feb646ec7e6dba4a9666d16618dc63136 [INFO] running `Command { std: "docker" "start" "-a" "7e19a69eb8773256cf18aac81660870feb646ec7e6dba4a9666d16618dc63136", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.103 [INFO] [stderr] Compiling proc-macro2 v1.0.29 [INFO] [stderr] Compiling syn v1.0.78 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling parking_lot_core v0.8.5 [INFO] [stderr] Compiling signal-hook v0.3.10 [INFO] [stderr] Compiling futures-core v0.3.17 [INFO] [stderr] Compiling tokio v1.12.0 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Checking pin-project-lite v0.2.7 [INFO] [stderr] Checking smallvec v1.7.0 [INFO] [stderr] Checking instant v0.1.11 [INFO] [stderr] Checking lock_api v0.4.5 [INFO] [stderr] Compiling num-bigint v0.4.2 [INFO] [stderr] Compiling futures-task v0.3.17 [INFO] [stderr] Compiling futures-util v0.3.17 [INFO] [stderr] Checking unicode-segmentation v1.8.0 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking bimap v0.6.1 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking mio v0.7.13 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking dirs-sys v0.3.6 [INFO] [stderr] Checking directories v4.0.1 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking signal-hook-mio v0.2.1 [INFO] [stderr] Checking crossterm v0.20.0 [INFO] [stderr] Checking tui v0.16.0 [INFO] [stderr] Compiling tokio-macros v1.4.1 [INFO] [stderr] Checking leaky-bucket-lite v0.3.2 [INFO] [stderr] Checking nadylib v0.1.0 (https://github.com/Nadybot/nadylib.git?branch=unstable#6ae443ea) [INFO] [stderr] Checking ao-chat-client v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variants `Invite`, `Kick`, and `Leave` are never constructed [INFO] [stdout] --> src/chat.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 51 | pub enum UiUpdate { [INFO] [stdout] | -------- variants in this enum [INFO] [stdout] 52 | Message(ResolvedMessage), [INFO] [stdout] 53 | Invite(ResolvedChannel), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 54 | Kick(ResolvedChannel), [INFO] [stdout] | ^^^^ [INFO] [stdout] 55 | Leave(String, ResolvedChannel), [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:345:5 [INFO] [stdout] | [INFO] [stdout] 345 | Ok(()) [INFO] [stdout] | ^^---- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chat.rs:205:30 [INFO] [stdout] | [INFO] [stdout] 199 | pub fn new(sender: SocketSendHandle, ui_update_sender: UnboundedSender) -> Self { [INFO] [stdout] | ------------------------ ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 205 | pending_lookups: RwLock::new(HashMap::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chat.rs:466:84 [INFO] [stdout] | [INFO] [stdout] 465 | ... let chat_state = chat_state.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 466 | ... tokio::spawn(async move { chat_state.invite(user_name).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chat.rs:470:82 [INFO] [stdout] | [INFO] [stdout] 469 | ... let chat_state = chat_state.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 470 | ... tokio::spawn(async move { chat_state.kick(user_name).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chat.rs:474:83 [INFO] [stdout] | [INFO] [stdout] 473 | ... let chat_state = chat_state.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 474 | ... tokio::spawn(async move { chat_state.leave(user_name).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chat.rs:478:93 [INFO] [stdout] | [INFO] [stdout] 477 | ... let chat_state = chat_state.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 478 | ... tokio::spawn(async move { chat_state.send_tell(user_name, text).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chat.rs:482:94 [INFO] [stdout] | [INFO] [stdout] 481 | ... let chat_state = chat_state.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 482 | ... tokio::spawn(async move { chat_state.send_message(channel, text).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/term.rs:25:8 [INFO] [stdout] | [INFO] [stdout] 15 | let term = Terminal::new(backend)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | [INFO] [stdout] 17 | let cleanup = OnShutdown::new(|| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | Ok((term, cleanup)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ao-chat-client` (bin "ao-chat-client" test) due to 9 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variants `Invite`, `Kick`, and `Leave` are never constructed [INFO] [stdout] --> src/chat.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 51 | pub enum UiUpdate { [INFO] [stdout] | -------- variants in this enum [INFO] [stdout] 52 | Message(ResolvedMessage), [INFO] [stdout] 53 | Invite(ResolvedChannel), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 54 | Kick(ResolvedChannel), [INFO] [stdout] | ^^^^ [INFO] [stdout] 55 | Leave(String, ResolvedChannel), [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:345:5 [INFO] [stdout] | [INFO] [stdout] 345 | Ok(()) [INFO] [stdout] | ^^---- [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chat.rs:205:30 [INFO] [stdout] | [INFO] [stdout] 199 | pub fn new(sender: SocketSendHandle, ui_update_sender: UnboundedSender) -> Self { [INFO] [stdout] | ------------------------ ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 205 | pending_lookups: RwLock::new(HashMap::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chat.rs:466:84 [INFO] [stdout] | [INFO] [stdout] 465 | ... let chat_state = chat_state.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 466 | ... tokio::spawn(async move { chat_state.invite(user_name).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chat.rs:470:82 [INFO] [stdout] | [INFO] [stdout] 469 | ... let chat_state = chat_state.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 470 | ... tokio::spawn(async move { chat_state.kick(user_name).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chat.rs:474:83 [INFO] [stdout] | [INFO] [stdout] 473 | ... let chat_state = chat_state.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 474 | ... tokio::spawn(async move { chat_state.leave(user_name).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chat.rs:478:93 [INFO] [stdout] | [INFO] [stdout] 477 | ... let chat_state = chat_state.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 478 | ... tokio::spawn(async move { chat_state.send_tell(user_name, text).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chat.rs:482:94 [INFO] [stdout] | [INFO] [stdout] 481 | ... let chat_state = chat_state.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 482 | ... tokio::spawn(async move { chat_state.send_message(channel, text).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/term.rs:25:8 [INFO] [stdout] | [INFO] [stdout] 15 | let term = Terminal::new(backend)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | [INFO] [stdout] 17 | let cleanup = OnShutdown::new(|| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | Ok((term, cleanup)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ao-chat-client` (bin "ao-chat-client") due to 9 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "7e19a69eb8773256cf18aac81660870feb646ec7e6dba4a9666d16618dc63136", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7e19a69eb8773256cf18aac81660870feb646ec7e6dba4a9666d16618dc63136", kill_on_drop: false }` [INFO] [stdout] 7e19a69eb8773256cf18aac81660870feb646ec7e6dba4a9666d16618dc63136