[INFO] cloning repository https://github.com/MrWint/factorio-replay-tools [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/MrWint/factorio-replay-tools" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMrWint%2Ffactorio-replay-tools", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMrWint%2Ffactorio-replay-tools'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1058407c520221d8bb94de8ed7041cb8661913e5 [INFO] checking MrWint/factorio-replay-tools/1058407c520221d8bb94de8ed7041cb8661913e5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMrWint%2Ffactorio-replay-tools" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/MrWint/factorio-replay-tools on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/MrWint/factorio-replay-tools [INFO] finished tweaking git repo https://github.com/MrWint/factorio-replay-tools [INFO] tweaked toml for git repo https://github.com/MrWint/factorio-replay-tools written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/MrWint/factorio-replay-tools already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6f95e11e2130e5da9e001fc3a6f6d2b887aa6ca67ddd7c9f90b2bdb7e3e1ce08 [INFO] running `Command { std: "docker" "start" "-a" "6f95e11e2130e5da9e001fc3a6f6d2b887aa6ca67ddd7c9f90b2bdb7e3e1ce08", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6f95e11e2130e5da9e001fc3a6f6d2b887aa6ca67ddd7c9f90b2bdb7e3e1ce08", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6f95e11e2130e5da9e001fc3a6f6d2b887aa6ca67ddd7c9f90b2bdb7e3e1ce08", kill_on_drop: false }` [INFO] [stdout] 6f95e11e2130e5da9e001fc3a6f6d2b887aa6ca67ddd7c9f90b2bdb7e3e1ce08 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 19b0ce464e97e7e8a335020819b0dc3eb2e7af1d42c4db1b1cd9b12ae130b805 [INFO] running `Command { std: "docker" "start" "-a" "19b0ce464e97e7e8a335020819b0dc3eb2e7af1d42c4db1b1cd9b12ae130b805", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling pkg-config v0.3.27 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling strsim v0.11.1 [INFO] [stderr] Compiling zstd-safe v5.0.2+zstd.1.5.2 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Checking generic-array v0.14.7 [INFO] [stderr] Compiling num-traits v0.2.16 [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking deranged v0.3.8 [INFO] [stderr] Checking time-core v0.1.1 [INFO] [stderr] Compiling serde_json v1.0.109 [INFO] [stderr] Checking constant_time_eq v0.1.5 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking heck v0.4.1 [INFO] [stderr] Checking password-hash v0.4.2 [INFO] [stderr] Checking flate2 v1.0.27 [INFO] [stderr] Compiling jobserver v0.1.26 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling syn v2.0.31 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking aes v0.8.3 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha2 v0.10.7 [INFO] [stderr] Checking sha1 v0.10.5 [INFO] [stderr] Checking time v0.3.28 [INFO] [stderr] Checking pbkdf2 v0.11.0 [INFO] [stderr] Compiling zstd-sys v2.0.8+zstd.1.5.5 [INFO] [stderr] Compiling bzip2-sys v0.1.11+1.0.8 [INFO] [stderr] Checking bzip2 v0.4.4 [INFO] [stderr] Compiling enum-primitive-derive v0.2.2 [INFO] [stderr] Compiling darling_core v0.20.9 [INFO] [stderr] Compiling serde_derive v1.0.188 [INFO] [stderr] Compiling factorio-serialize-derive v0.1.0 (/opt/rustwide/workdir/factorio-serialize/factorio-serialize-derive) [INFO] [stderr] Compiling darling_macro v0.20.9 [INFO] [stderr] Compiling darling v0.20.9 [INFO] [stderr] Checking zstd v0.11.2+zstd.1.5.2 [INFO] [stderr] Compiling serde_with_macros v3.8.1 [INFO] [stderr] Checking zip v0.6.6 [INFO] [stderr] Checking factorio-serialize v0.1.0 (/opt/rustwide/workdir/factorio-serialize) [INFO] [stdout] warning: this function depends on never type fallback being `()` [INFO] [stdout] --> factorio-serialize/src/map.rs:1593:3 [INFO] [stdout] | [INFO] [stdout] 1593 | fn map_write(&self, input: &mut MapSerialiser) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #123748 [INFO] [stdout] = help: specify the types explicitly [INFO] [stdout] note: in edition 2024, the requirement `!: FromIterator<()>` will fail [INFO] [stdout] --> factorio-serialize/src/map.rs:1598:66 [INFO] [stdout] | [INFO] [stdout] 1598 | self.chunks.iter().map(|c| c.initial_write(input)).collect::>()?; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] = note: `#[warn(dependency_on_unit_never_type_fallback)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> factorio-serialize/src/error.rs:14:19 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn from_io(error: std::io::Error, position: u64) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | Error { kind: ErrorKind::Io(error), position, } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> factorio-serialize/src/map.rs:80:8 [INFO] [stdout] | [INFO] [stdout] 76 | pub fn new(map_data: R) -> Result> { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | let mut stream = Reader::new(map_data); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | Ok(MapDeserialiser { [INFO] [stdout] | ________^ [INFO] [stdout] 81 | | stream, [INFO] [stdout] 82 | | map_version, [INFO] [stdout] ... | [INFO] [stdout] 85 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> factorio-serialize/src/map.rs:231:8 [INFO] [stdout] | [INFO] [stdout] 228 | let a = A::map_read(r)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 229 | let b = B::map_read(r)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 230 | [INFO] [stdout] 231 | Ok((a, b)) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> factorio-serialize/src/map.rs:885:8 [INFO] [stdout] | [INFO] [stdout] 872 | let len = V::map_read(r)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 873 | let mut mappings = Vec::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 885 | Ok(ActiveMigrations { mappings }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> factorio-serialize/src/map.rs:1030:8 [INFO] [stdout] | [INFO] [stdout] 1030 | Ok(CustomPrototypesOption { [INFO] [stdout] | ________^ [INFO] [stdout] 1031 | | option: if id == 0 { None } else { Some((id, T::map_read(input)?)) } [INFO] [stdout] 1032 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> factorio-serialize/src/replay.rs:79:8 [INFO] [stdout] | [INFO] [stdout] 76 | pub fn new(replay_data: R) -> Result> { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | let stream = Reader::new(replay_data); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | [INFO] [stdout] 79 | Ok(ReplayDeserialiser { [INFO] [stdout] | ________^ [INFO] [stdout] 80 | | stream, [INFO] [stdout] 81 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> factorio-serialize/src/replay.rs:206:8 [INFO] [stdout] | [INFO] [stdout] 203 | let a = A::replay_read(r)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | let b = B::replay_read(r)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 205 | [INFO] [stdout] 206 | Ok((a, b)) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> factorio-serialize/src/writer.rs:123:5 [INFO] [stdout] | [INFO] [stdout] 122 | pub fn write_array<'a, I: IntoIterator>(&mut self, array: I) -> Result<()> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | array.into_iter().map(|v| self.write_u32(*v)).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking serde_with v3.8.1 [INFO] [stdout] error: aborting due to 8 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `factorio-serialize` (lib) due to 9 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "19b0ce464e97e7e8a335020819b0dc3eb2e7af1d42c4db1b1cd9b12ae130b805", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "19b0ce464e97e7e8a335020819b0dc3eb2e7af1d42c4db1b1cd9b12ae130b805", kill_on_drop: false }` [INFO] [stdout] 19b0ce464e97e7e8a335020819b0dc3eb2e7af1d42c4db1b1cd9b12ae130b805