[INFO] cloning repository https://github.com/MrPicklePinosaur/flowdown [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/MrPicklePinosaur/flowdown" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMrPicklePinosaur%2Fflowdown", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMrPicklePinosaur%2Fflowdown'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ab502a83bb245d28835379abdae68dda75bb9aff [INFO] checking MrPicklePinosaur/flowdown/ab502a83bb245d28835379abdae68dda75bb9aff against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMrPicklePinosaur%2Fflowdown" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/MrPicklePinosaur/flowdown on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/MrPicklePinosaur/flowdown [INFO] finished tweaking git repo https://github.com/MrPicklePinosaur/flowdown [INFO] tweaked toml for git repo https://github.com/MrPicklePinosaur/flowdown written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/MrPicklePinosaur/flowdown already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ea041c0f51140dee4477d7235561e88cb63aed6fa76951838f845570fc1d57af [INFO] running `Command { std: "docker" "start" "-a" "ea041c0f51140dee4477d7235561e88cb63aed6fa76951838f845570fc1d57af", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ea041c0f51140dee4477d7235561e88cb63aed6fa76951838f845570fc1d57af", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ea041c0f51140dee4477d7235561e88cb63aed6fa76951838f845570fc1d57af", kill_on_drop: false }` [INFO] [stdout] ea041c0f51140dee4477d7235561e88cb63aed6fa76951838f845570fc1d57af [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8c8f4cd5e82e3ea8657f0c206afebf1f37c622540fbba063c09d8953345d4774 [INFO] running `Command { std: "docker" "start" "-a" "8c8f4cd5e82e3ea8657f0c206afebf1f37c622540fbba063c09d8953345d4774", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.40 [INFO] [stderr] Compiling unicode-ident v1.0.2 [INFO] [stderr] Compiling quote v1.0.20 [INFO] [stderr] Compiling syn v1.0.98 [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling ucd-trie v0.1.4 [INFO] [stderr] Compiling serde_derive v1.0.140 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling maplit v1.0.2 [INFO] [stderr] Compiling serde v1.0.140 [INFO] [stderr] Compiling serde_json v1.0.82 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Checking ryu v1.0.10 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking argparse v0.1.0 (https://github.com/MrPicklePinosaur/pino.rs?rev=69b4452c66172adfe16af9e956fc614a9804108a#69b4452c) [INFO] [stderr] Compiling pest v2.1.3 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking getrandom v0.2.7 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling pest_meta v2.1.3 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Compiling pest_generator v2.1.3 [INFO] [stderr] Compiling thiserror-impl v1.0.31 [INFO] [stderr] Compiling pest_derive v2.1.0 [INFO] [stderr] Checking thiserror v1.0.31 [INFO] [stderr] Checking flowdown v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `serde::Serialize` [INFO] [stdout] --> src/generator/voiceflow.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use serde::Serialize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `hash::Hash` [INFO] [stdout] --> src/generator/voiceflow.rs:6:33 [INFO] [stdout] | [INFO] [stdout] 6 | use std::{collections::HashMap, hash::Hash}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Rng` [INFO] [stdout] --> src/generator/voiceflow.rs:665:46 [INFO] [stdout] | [INFO] [stdout] 665 | use rand::{seq::SliceRandom, thread_rng, Rng}; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `log::debug` [INFO] [stdout] --> src/parser.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use log::debug; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Pairs` [INFO] [stdout] --> src/parser.rs:4:23 [INFO] [stdout] | [INFO] [stdout] 4 | iterators::{Pair, Pairs}, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `serde::ser::Error` [INFO] [stdout] --> src/parser.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use serde::ser::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `fs` [INFO] [stdout] --> src/parser.rs:9:33 [INFO] [stdout] | [INFO] [stdout] 9 | use std::{collections::HashMap, fs}; [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `info` [INFO] [stdout] --> src/main.rs:14:18 [INFO] [stdout] | [INFO] [stdout] 14 | use log::{debug, info}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `serde::Serialize` [INFO] [stdout] --> src/generator/voiceflow.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use serde::Serialize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `hash::Hash` [INFO] [stdout] --> src/generator/voiceflow.rs:6:33 [INFO] [stdout] | [INFO] [stdout] 6 | use std::{collections::HashMap, hash::Hash}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Rng` [INFO] [stdout] --> src/generator/voiceflow.rs:665:46 [INFO] [stdout] | [INFO] [stdout] 665 | use rand::{seq::SliceRandom, thread_rng, Rng}; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `log::debug` [INFO] [stdout] --> src/parser.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use log::debug; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Pairs` [INFO] [stdout] --> src/parser.rs:4:23 [INFO] [stdout] | [INFO] [stdout] 4 | iterators::{Pair, Pairs}, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `serde::ser::Error` [INFO] [stdout] --> src/parser.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use serde::ser::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `fs` [INFO] [stdout] --> src/parser.rs:9:33 [INFO] [stdout] | [INFO] [stdout] 9 | use std::{collections::HashMap, fs}; [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `info` [INFO] [stdout] --> src/main.rs:14:18 [INFO] [stdout] | [INFO] [stdout] 14 | use log::{debug, info}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/generator/voiceflow.rs:122:13 [INFO] [stdout] | [INFO] [stdout] 122 | let mut vf_file = json!({ [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/generator/voiceflow.rs:122:13 [INFO] [stdout] | [INFO] [stdout] 122 | let mut vf_file = json!({ [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `cur_dialog` is never used [INFO] [stdout] --> src/parser.rs:366:8 [INFO] [stdout] | [INFO] [stdout] 106 | impl ConversationBuilder { [INFO] [stdout] | ------------------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 366 | fn cur_dialog(&self) -> &DialogBuilder { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 55 | fn build(mut self) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | Ok(Dialog { [INFO] [stdout] | ____________^ [INFO] [stdout] 64 | | bookmark_table, [INFO] [stdout] 65 | | blocks: self.blocks, [INFO] [stdout] 66 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:171:12 [INFO] [stdout] | [INFO] [stdout] 170 | let block = self.parse_inline_stmt(it.next().unwrap())?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 171 | Ok(Block::Choice { [INFO] [stdout] | ____________^ [INFO] [stdout] 172 | | cond, [INFO] [stdout] 173 | | block: Box::new(block), [INFO] [stdout] 174 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:386:12 [INFO] [stdout] | [INFO] [stdout] 378 | pub fn build(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 379 | // build all dialogs [INFO] [stdout] 380 | let mut dialog_table = HashMap::::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 386 | Ok(Conversation { [INFO] [stdout] | ____________^ [INFO] [stdout] 387 | | dialog_table, [INFO] [stdout] 388 | | variables: self.variables, [INFO] [stdout] 389 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `flowdown` (bin "fdc" test) due to 4 previous errors; 10 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `cur_dialog` is never used [INFO] [stdout] --> src/parser.rs:366:8 [INFO] [stdout] | [INFO] [stdout] 106 | impl ConversationBuilder { [INFO] [stdout] | ------------------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 366 | fn cur_dialog(&self) -> &DialogBuilder { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 55 | fn build(mut self) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | Ok(Dialog { [INFO] [stdout] | ____________^ [INFO] [stdout] 64 | | bookmark_table, [INFO] [stdout] 65 | | blocks: self.blocks, [INFO] [stdout] 66 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:171:12 [INFO] [stdout] | [INFO] [stdout] 170 | let block = self.parse_inline_stmt(it.next().unwrap())?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 171 | Ok(Block::Choice { [INFO] [stdout] | ____________^ [INFO] [stdout] 172 | | cond, [INFO] [stdout] 173 | | block: Box::new(block), [INFO] [stdout] 174 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:386:12 [INFO] [stdout] | [INFO] [stdout] 378 | pub fn build(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 379 | // build all dialogs [INFO] [stdout] 380 | let mut dialog_table = HashMap::::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 386 | Ok(Conversation { [INFO] [stdout] | ____________^ [INFO] [stdout] 387 | | dialog_table, [INFO] [stdout] 388 | | variables: self.variables, [INFO] [stdout] 389 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `flowdown` (bin "fdc") due to 4 previous errors; 10 warnings emitted [INFO] running `Command { std: "docker" "inspect" "8c8f4cd5e82e3ea8657f0c206afebf1f37c622540fbba063c09d8953345d4774", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8c8f4cd5e82e3ea8657f0c206afebf1f37c622540fbba063c09d8953345d4774", kill_on_drop: false }` [INFO] [stdout] 8c8f4cd5e82e3ea8657f0c206afebf1f37c622540fbba063c09d8953345d4774