[INFO] cloning repository https://github.com/MrE-Fog/boringtun [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/MrE-Fog/boringtun" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMrE-Fog%2Fboringtun", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMrE-Fog%2Fboringtun'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ac3718c6684b9b618126aa0b3e1f8d6250b45e69 [INFO] checking MrE-Fog/boringtun/ac3718c6684b9b618126aa0b3e1f8d6250b45e69 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMrE-Fog%2Fboringtun" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/MrE-Fog/boringtun on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-6-tc2/source/.cargo/config [INFO] started tweaking git repo https://github.com/MrE-Fog/boringtun [INFO] finished tweaking git repo https://github.com/MrE-Fog/boringtun [INFO] tweaked toml for git repo https://github.com/MrE-Fog/boringtun written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/MrE-Fog/boringtun already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b87149fddb1997cfbfb77257e7fe627c3172fdaa35a32985c92f0037f912703e [INFO] running `Command { std: "docker" "start" "-a" "b87149fddb1997cfbfb77257e7fe627c3172fdaa35a32985c92f0037f912703e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b87149fddb1997cfbfb77257e7fe627c3172fdaa35a32985c92f0037f912703e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b87149fddb1997cfbfb77257e7fe627c3172fdaa35a32985c92f0037f912703e", kill_on_drop: false }` [INFO] [stdout] b87149fddb1997cfbfb77257e7fe627c3172fdaa35a32985c92f0037f912703e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e6849df3bf86fa5a7bcb881c01d02f359d79619db7ae2b6caf25e43bdcddd65d [INFO] running `Command { std: "docker" "start" "-a" "e6849df3bf86fa5a7bcb881c01d02f359d79619db7ae2b6caf25e43bdcddd65d", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Compiling libc v0.2.117 [INFO] [stderr] Compiling syn v1.0.86 [INFO] [stderr] Checking once_cell v1.9.0 [INFO] [stderr] Compiling cc v1.0.72 [INFO] [stderr] Compiling parking_lot_core v0.9.1 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking ip_network_table-deps-treebitmap v0.5.0 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Checking tracing-core v0.1.22 [INFO] [stderr] Checking lock_api v0.4.6 [INFO] [stderr] Checking sharded-slab v0.1.4 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Checking ip_network v0.4.1 [INFO] [stderr] Compiling quote v1.0.15 [INFO] [stderr] Compiling crossbeam-utils v0.8.7 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Checking num_threads v0.1.3 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking boxfnonce v0.1.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking thread_local v1.1.4 [INFO] [stderr] Checking ip_network_table v0.2.0 [INFO] [stderr] Checking tracing-log v0.1.2 [INFO] [stderr] Checking crossbeam-channel v0.5.2 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking tracing-subscriber v0.3.9 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking time v0.3.7 [INFO] [stderr] Checking daemonize v0.4.1 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking parking_lot v0.12.0 [INFO] [stderr] Checking tracing-appender v0.2.1 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Compiling tracing-attributes v0.1.19 [INFO] [stderr] Compiling zeroize_derive v1.3.1 [INFO] [stderr] Checking zeroize v1.5.2 [INFO] [stderr] Checking tracing v0.1.31 [INFO] [stderr] Checking boringtun v0.4.0 (/opt/rustwide/workdir/boringtun) [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> boringtun/src/crypto/chacha20poly1305/poly1305.rs:99:12 [INFO] [stdout] | [INFO] [stdout] 99 | #[cfg_attr(feature = "cargo-clippy", allow(clippy::suspicious_arithmetic_impl))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> boringtun/src/crypto/chacha20poly1305/poly1305.rs:120:12 [INFO] [stdout] | [INFO] [stdout] 120 | #[cfg_attr(feature = "cargo-clippy", allow(clippy::suspicious_arithmetic_impl))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> boringtun/src/crypto/x25519/mod.rs:141:12 [INFO] [stdout] | [INFO] [stdout] 141 | #[cfg_attr(feature = "cargo-clippy", allow(clippy::suspicious_arithmetic_impl))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> boringtun/src/crypto/x25519/mod.rs:178:12 [INFO] [stdout] | [INFO] [stdout] 178 | #[cfg_attr(feature = "cargo-clippy", allow(clippy::suspicious_arithmetic_impl))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> boringtun/src/crypto/x25519/mod.rs:231:12 [INFO] [stdout] | [INFO] [stdout] 231 | #[cfg_attr(feature = "cargo-clippy", allow(clippy::suspicious_arithmetic_impl))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> boringtun/src/crypto/chacha20poly1305/poly1305.rs:99:12 [INFO] [stdout] | [INFO] [stdout] 99 | #[cfg_attr(feature = "cargo-clippy", allow(clippy::suspicious_arithmetic_impl))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> boringtun/src/crypto/chacha20poly1305/poly1305.rs:120:12 [INFO] [stdout] | [INFO] [stdout] 120 | #[cfg_attr(feature = "cargo-clippy", allow(clippy::suspicious_arithmetic_impl))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> boringtun/src/crypto/x25519/mod.rs:141:12 [INFO] [stdout] | [INFO] [stdout] 141 | #[cfg_attr(feature = "cargo-clippy", allow(clippy::suspicious_arithmetic_impl))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> boringtun/src/crypto/x25519/mod.rs:178:12 [INFO] [stdout] | [INFO] [stdout] 178 | #[cfg_attr(feature = "cargo-clippy", allow(clippy::suspicious_arithmetic_impl))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> boringtun/src/crypto/x25519/mod.rs:231:12 [INFO] [stdout] | [INFO] [stdout] 231 | #[cfg_attr(feature = "cargo-clippy", allow(clippy::suspicious_arithmetic_impl))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> boringtun/src/device/mod.rs:173:12 [INFO] [stdout] | [INFO] [stdout] 159 | let mut wg_interface = Device::new(name, config)?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | let interface_lock = Arc::new(Lock::new(wg_interface)); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 163 | [INFO] [stdout] 164 | let mut threads = vec![]; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 173 | Ok(DeviceHandle { [INFO] [stdout] | ____________^ [INFO] [stdout] 174 | | device: interface_lock, [INFO] [stdout] 175 | | threads, [INFO] [stdout] 176 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> boringtun/src/device/dev_lock.rs:21:20 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(user_data: T) -> Lock { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | inner: RwLock::new(user_data), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> boringtun/src/device/dev_lock.rs:38:20 [INFO] [stdout] | [INFO] [stdout] 30 | let mut wants_write = lock.lock(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | inner: self.inner.read(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> boringtun/src/device/peer.rs:65:23 [INFO] [stdout] | [INFO] [stdout] 56 | tunnel: Box, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | endpoint: RwLock::new(Endpoint { [INFO] [stdout] | _______________________^ [INFO] [stdout] 66 | | addr: endpoint, [INFO] [stdout] 67 | | conn: None, [INFO] [stdout] 68 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> boringtun/src/device/peer.rs:69:26 [INFO] [stdout] | [INFO] [stdout] 56 | tunnel: Box, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | allowed_ips: allowed_ips.iter().map(|ip| (ip, ())).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> boringtun/src/ffi/mod.rs:236:5 [INFO] [stdout] | [INFO] [stdout] 236 | Box::from_raw(tunnel); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 236 | let _ = Box::from_raw(tunnel); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> boringtun/src/noise/mod.rs:158:12 [INFO] [stdout] | [INFO] [stdout] 125 | static_private: Arc, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | peer_static_public: Arc, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | rate_limiter: Option>, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | ) -> Result, &'static str> { [INFO] [stdout] 132 | let static_public = Arc::new(static_private.public_key()); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | [INFO] [stdout] 134 | let tunn = Tunn { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | Ok(Box::new(tunn)) [INFO] [stdout] | ^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> boringtun/src/noise/handshake.rs:237:12 [INFO] [stdout] | [INFO] [stdout] 228 | static_private: Arc, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 229 | static_public: Arc, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 230 | peer_static_public: Arc, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 237 | Ok(NoiseParams { [INFO] [stdout] | ____________^ [INFO] [stdout] 238 | | static_public, [INFO] [stdout] 239 | | static_private, [INFO] [stdout] 240 | | peer_static_public, [INFO] [stdout] ... | [INFO] [stdout] 243 | | preshared_key, [INFO] [stdout] 244 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> boringtun/src/noise/handshake.rs:280:12 [INFO] [stdout] | [INFO] [stdout] 267 | static_private: Arc, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 268 | static_public: Arc, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 269 | peer_static_public: Arc, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 273 | let params = NoiseParams::new( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 280 | Ok(Handshake { [INFO] [stdout] | ____________^ [INFO] [stdout] 281 | | params, [INFO] [stdout] 282 | | next_index: global_idx, [INFO] [stdout] 283 | | previous: HandshakeState::None, [INFO] [stdout] ... | [INFO] [stdout] 288 | | last_rtt: None, [INFO] [stdout] 289 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `boringtun` (lib) due to 9 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> boringtun/src/device/mod.rs:173:12 [INFO] [stdout] | [INFO] [stdout] 159 | let mut wg_interface = Device::new(name, config)?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | let interface_lock = Arc::new(Lock::new(wg_interface)); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 163 | [INFO] [stdout] 164 | let mut threads = vec![]; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 173 | Ok(DeviceHandle { [INFO] [stdout] | ____________^ [INFO] [stdout] 174 | | device: interface_lock, [INFO] [stdout] 175 | | threads, [INFO] [stdout] 176 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> boringtun/src/device/dev_lock.rs:21:20 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(user_data: T) -> Lock { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | inner: RwLock::new(user_data), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> boringtun/src/device/dev_lock.rs:38:20 [INFO] [stdout] | [INFO] [stdout] 30 | let mut wants_write = lock.lock(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | inner: self.inner.read(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> boringtun/src/device/peer.rs:65:23 [INFO] [stdout] | [INFO] [stdout] 56 | tunnel: Box, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | endpoint: RwLock::new(Endpoint { [INFO] [stdout] | _______________________^ [INFO] [stdout] 66 | | addr: endpoint, [INFO] [stdout] 67 | | conn: None, [INFO] [stdout] 68 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> boringtun/src/device/peer.rs:69:26 [INFO] [stdout] | [INFO] [stdout] 56 | tunnel: Box, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | allowed_ips: allowed_ips.iter().map(|ip| (ip, ())).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> boringtun/src/ffi/mod.rs:236:5 [INFO] [stdout] | [INFO] [stdout] 236 | Box::from_raw(tunnel); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 236 | let _ = Box::from_raw(tunnel); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> boringtun/src/noise/mod.rs:158:12 [INFO] [stdout] | [INFO] [stdout] 125 | static_private: Arc, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | peer_static_public: Arc, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | rate_limiter: Option>, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | ) -> Result, &'static str> { [INFO] [stdout] 132 | let static_public = Arc::new(static_private.public_key()); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | [INFO] [stdout] 134 | let tunn = Tunn { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | Ok(Box::new(tunn)) [INFO] [stdout] | ^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> boringtun/src/noise/handshake.rs:237:12 [INFO] [stdout] | [INFO] [stdout] 228 | static_private: Arc, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 229 | static_public: Arc, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 230 | peer_static_public: Arc, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 237 | Ok(NoiseParams { [INFO] [stdout] | ____________^ [INFO] [stdout] 238 | | static_public, [INFO] [stdout] 239 | | static_private, [INFO] [stdout] 240 | | peer_static_public, [INFO] [stdout] ... | [INFO] [stdout] 243 | | preshared_key, [INFO] [stdout] 244 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> boringtun/src/noise/handshake.rs:280:12 [INFO] [stdout] | [INFO] [stdout] 267 | static_private: Arc, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 268 | static_public: Arc, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 269 | peer_static_public: Arc, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 273 | let params = NoiseParams::new( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 280 | Ok(Handshake { [INFO] [stdout] | ____________^ [INFO] [stdout] 281 | | params, [INFO] [stdout] 282 | | next_index: global_idx, [INFO] [stdout] 283 | | previous: HandshakeState::None, [INFO] [stdout] ... | [INFO] [stdout] 288 | | last_rtt: None, [INFO] [stdout] 289 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `boringtun` (lib test) due to 9 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "e6849df3bf86fa5a7bcb881c01d02f359d79619db7ae2b6caf25e43bdcddd65d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e6849df3bf86fa5a7bcb881c01d02f359d79619db7ae2b6caf25e43bdcddd65d", kill_on_drop: false }` [INFO] [stdout] e6849df3bf86fa5a7bcb881c01d02f359d79619db7ae2b6caf25e43bdcddd65d