[INFO] updating cached repository https://github.com/MostlyMax/disk-ringbuffer [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "-c" "remote.origin.fetch=refs/heads/*:refs/heads/*" "fetch" "origin" "--force" "--prune", kill_on_drop: false }` [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 343a65b017b5597e03cbb12e2ac82a07e38e8deb [INFO] checking MostlyMax/disk-ringbuffer/343a65b017b5597e03cbb12e2ac82a07e38e8deb against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMostlyMax%2Fdisk-ringbuffer" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/MostlyMax/disk-ringbuffer on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/MostlyMax/disk-ringbuffer [INFO] finished tweaking git repo https://github.com/MostlyMax/disk-ringbuffer [INFO] tweaked toml for git repo https://github.com/MostlyMax/disk-ringbuffer written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/MostlyMax/disk-ringbuffer already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 543ee93d12cd0ca4829df083ce87841287823599586426b9828cd4f6c790d036 [INFO] running `Command { std: "docker" "start" "-a" "543ee93d12cd0ca4829df083ce87841287823599586426b9828cd4f6c790d036", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "543ee93d12cd0ca4829df083ce87841287823599586426b9828cd4f6c790d036", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "543ee93d12cd0ca4829df083ce87841287823599586426b9828cd4f6c790d036", kill_on_drop: false }` [INFO] [stdout] 543ee93d12cd0ca4829df083ce87841287823599586426b9828cd4f6c790d036 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 087a36bb6660fd9f20051aaf6046a5ac3b3b65339f3debaad44b670d34ef86f1 [INFO] running `Command { std: "docker" "start" "-a" "087a36bb6660fd9f20051aaf6046a5ac3b3b65339f3debaad44b670d34ef86f1", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Compiling prettyplease v0.2.20 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling linux-raw-sys v0.4.14 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling minimal-lexical v0.2.1 [INFO] [stderr] Compiling bitflags v2.6.0 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling home v0.5.9 [INFO] [stderr] Compiling bindgen v0.69.4 [INFO] [stderr] Compiling lazycell v1.3.0 [INFO] [stderr] Compiling libloading v0.8.4 [INFO] [stderr] Compiling lazy_static v1.5.0 [INFO] [stderr] Compiling log v0.4.22 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Compiling rustc-hash v1.1.0 [INFO] [stderr] Compiling cc v1.0.90 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Checking cty v0.2.2 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Compiling itertools v0.12.1 [INFO] [stderr] Compiling clang-sys v1.8.1 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.68 [INFO] [stderr] Checking fslock v0.2.1 [INFO] [stderr] Checking memmap2 v0.9.4 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Compiling cexpr v0.6.0 [INFO] [stderr] Compiling which v4.4.2 [INFO] [stderr] Compiling regex v1.10.5 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling disk-ringbuffer v0.5.0 (/opt/rustwide/workdir) [INFO] [stderr] warning: disk-ringbuffer@0.5.0: Compiler version doesn't include clang or GCC: "cc" "--version" [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ringbuf.rs:104:8 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn new>(path: P, max_pages: usize) -> Result<(Writer, Reader), RingbufError> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | let mut file = fslock::LockFile::open(&path.join("rb.lock"))?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | let _lock = Arc::new(file); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | let wp_count = Arc::new(RwLock::new(latest_file_no)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | let page = Page::new( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | Ok(( [INFO] [stdout] | ________^ [INFO] [stdout] 105 | | Writer { [INFO] [stdout] 106 | | path: path.clone(), [INFO] [stdout] 107 | | write_page_count: wp_count.clone(), [INFO] [stdout] ... | [INFO] [stdout] 121 | | }, [INFO] [stdout] 122 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] The following warnings were emitted during compilation: [INFO] [stderr] [INFO] [stderr] warning: disk-ringbuffer@0.5.0: Compiler version doesn't include clang or GCC: "cc" "--version" [INFO] [stderr] [INFO] [stderr] error: could not compile `disk-ringbuffer` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ringbuf.rs:104:8 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn new>(path: P, max_pages: usize) -> Result<(Writer, Reader), RingbufError> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | let mut file = fslock::LockFile::open(&path.join("rb.lock"))?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | let _lock = Arc::new(file); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | let wp_count = Arc::new(RwLock::new(latest_file_no)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | let page = Page::new( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | Ok(( [INFO] [stdout] | ________^ [INFO] [stdout] 105 | | Writer { [INFO] [stdout] 106 | | path: path.clone(), [INFO] [stdout] 107 | | write_page_count: wp_count.clone(), [INFO] [stdout] ... | [INFO] [stdout] 121 | | }, [INFO] [stdout] 122 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] The following warnings were emitted during compilation: [INFO] [stderr] [INFO] [stderr] warning: disk-ringbuffer@0.5.0: Compiler version doesn't include clang or GCC: "cc" "--version" [INFO] [stderr] [INFO] [stderr] error: could not compile `disk-ringbuffer` (lib test) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "087a36bb6660fd9f20051aaf6046a5ac3b3b65339f3debaad44b670d34ef86f1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "087a36bb6660fd9f20051aaf6046a5ac3b3b65339f3debaad44b670d34ef86f1", kill_on_drop: false }` [INFO] [stdout] 087a36bb6660fd9f20051aaf6046a5ac3b3b65339f3debaad44b670d34ef86f1