[INFO] cloning repository https://github.com/MordragT/megadvc [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/MordragT/megadvc" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMordragT%2Fmegadvc", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMordragT%2Fmegadvc'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 909b5c8d95384119a6abcdcdffa0e8747dbf7238 [INFO] checking MordragT/megadvc/909b5c8d95384119a6abcdcdffa0e8747dbf7238 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FMordragT%2Fmegadvc" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/MordragT/megadvc on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/MordragT/megadvc [INFO] finished tweaking git repo https://github.com/MordragT/megadvc [INFO] tweaked toml for git repo https://github.com/MordragT/megadvc written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/MordragT/megadvc already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: unused manifest key: package.about [INFO] [stderr] warning: unused manifest key: package.author [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7444d8368cbe536628223430d2975759cfab1b2d3e602464595f210a87eaac24 [INFO] running `Command { std: "docker" "start" "-a" "7444d8368cbe536628223430d2975759cfab1b2d3e602464595f210a87eaac24", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7444d8368cbe536628223430d2975759cfab1b2d3e602464595f210a87eaac24", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7444d8368cbe536628223430d2975759cfab1b2d3e602464595f210a87eaac24", kill_on_drop: false }` [INFO] [stdout] 7444d8368cbe536628223430d2975759cfab1b2d3e602464595f210a87eaac24 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] adb33367d7443f0c6fbe037aa490c317ede1762ae2b015a2811c2371c67c26b4 [INFO] running `Command { std: "docker" "start" "-a" "adb33367d7443f0c6fbe037aa490c317ede1762ae2b015a2811c2371c67c26b4", kill_on_drop: false }` [INFO] [stderr] warning: unused manifest key: package.about [INFO] [stderr] warning: unused manifest key: package.author [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Compiling unicode-ident v1.0.3 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Compiling typenum v1.15.0 [INFO] [stderr] Compiling libc v0.2.132 [INFO] [stderr] Compiling generic-array v0.14.6 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling serde v1.0.144 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling serde_derive v1.0.144 [INFO] [stderr] Compiling indexmap v1.9.1 [INFO] [stderr] Compiling blake3 v1.3.1 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking subtle v2.4.1 [INFO] [stderr] Checking once_cell v1.14.0 [INFO] [stderr] Checking os_str_bytes v6.3.0 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Checking arrayref v0.3.6 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking constant_time_eq v0.1.5 [INFO] [stderr] Checking arrayvec v0.7.2 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking terminal_size v0.1.17 [INFO] [stderr] Checking console v0.15.1 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.2 [INFO] [stderr] Checking digest v0.10.3 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Checking toml v0.5.9 [INFO] [stderr] Compiling clap_derive v3.2.18 [INFO] [stderr] Compiling thiserror-impl v1.0.33 [INFO] [stderr] Checking thiserror v1.0.33 [INFO] [stderr] Checking clap v3.2.20 [INFO] [stderr] Checking megadvc v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Hash` [INFO] [stdout] --> src/status.rs:2:12 [INFO] [stdout] | [INFO] [stdout] 2 | lock::{Hash, LocalLock, Lock, LockError}, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `HashMap` [INFO] [stdout] --> src/status.rs:8:19 [INFO] [stdout] | [INFO] [stdout] 8 | collections::{HashMap, HashSet}, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/status.rs:31:20 [INFO] [stdout] | [INFO] [stdout] 31 | files: HashSet<(&'a Path)>, [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 31 - files: HashSet<(&'a Path)>, [INFO] [stdout] 31 + files: HashSet<&'a Path>, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/status.rs:32:21 [INFO] [stdout] | [INFO] [stdout] 32 | staged: HashSet<(&'a PathBuf)>, [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 32 - staged: HashSet<(&'a PathBuf)>, [INFO] [stdout] 32 + staged: HashSet<&'a PathBuf>, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/status.rs:33:24 [INFO] [stdout] | [INFO] [stdout] 33 | to_remove: HashSet<(&'a PathBuf)>, [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 33 - to_remove: HashSet<(&'a PathBuf)>, [INFO] [stdout] 33 + to_remove: HashSet<&'a PathBuf>, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/status.rs:35:20 [INFO] [stdout] | [INFO] [stdout] 35 | added: HashSet<(&'a Path)>, [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 35 - added: HashSet<(&'a Path)>, [INFO] [stdout] 35 + added: HashSet<&'a Path>, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/status.rs:36:22 [INFO] [stdout] | [INFO] [stdout] 36 | deleted: HashSet<(&'a Path)>, [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 36 - deleted: HashSet<(&'a Path)>, [INFO] [stdout] 36 + deleted: HashSet<&'a Path>, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `push::*` [INFO] [stdout] --> src/lib.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | pub use push::*; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Hash` [INFO] [stdout] --> src/status.rs:2:12 [INFO] [stdout] | [INFO] [stdout] 2 | lock::{Hash, LocalLock, Lock, LockError}, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `HashMap` [INFO] [stdout] --> src/status.rs:8:19 [INFO] [stdout] | [INFO] [stdout] 8 | collections::{HashMap, HashSet}, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/status.rs:31:20 [INFO] [stdout] | [INFO] [stdout] 31 | files: HashSet<(&'a Path)>, [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 31 - files: HashSet<(&'a Path)>, [INFO] [stdout] 31 + files: HashSet<&'a Path>, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/status.rs:32:21 [INFO] [stdout] | [INFO] [stdout] 32 | staged: HashSet<(&'a PathBuf)>, [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 32 - staged: HashSet<(&'a PathBuf)>, [INFO] [stdout] 32 + staged: HashSet<&'a PathBuf>, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/status.rs:33:24 [INFO] [stdout] | [INFO] [stdout] 33 | to_remove: HashSet<(&'a PathBuf)>, [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 33 - to_remove: HashSet<(&'a PathBuf)>, [INFO] [stdout] 33 + to_remove: HashSet<&'a PathBuf>, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/status.rs:35:20 [INFO] [stdout] | [INFO] [stdout] 35 | added: HashSet<(&'a Path)>, [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 35 - added: HashSet<(&'a Path)>, [INFO] [stdout] 35 + added: HashSet<&'a Path>, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/status.rs:36:22 [INFO] [stdout] | [INFO] [stdout] 36 | deleted: HashSet<(&'a Path)>, [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 36 - deleted: HashSet<(&'a Path)>, [INFO] [stdout] 36 + deleted: HashSet<&'a Path>, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `push::*` [INFO] [stdout] --> src/lib.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | pub use push::*; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Write` [INFO] [stdout] --> src/megacmd.rs:2:22 [INFO] [stdout] | [INFO] [stdout] 2 | io::{self, Read, Write}, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Write` [INFO] [stdout] --> src/megacmd.rs:2:22 [INFO] [stdout] | [INFO] [stdout] 2 | io::{self, Read, Write}, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `rm` and `mv` are never used [INFO] [stdout] --> src/megacmd.rs:65:8 [INFO] [stdout] | [INFO] [stdout] 23 | impl MegaCmd { [INFO] [stdout] | ------------ associated functions in this implementation [INFO] [stdout] ... [INFO] [stdout] 65 | fn rm>(remote_path: P) -> MegaResult<()> { [INFO] [stdout] | ^^ [INFO] [stdout] ... [INFO] [stdout] 99 | fn mv, D: AsRef>(remote_src: S, remote_dest: D) -> MegaResult<()> { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `files` is never read [INFO] [stdout] --> src/status.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 30 | pub struct LockStatus<'a> { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] 31 | files: HashSet<(&'a Path)>, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `LockStatus` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lock.rs:124:12 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn from_path>(path: P) -> LockResult { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 125 | | path, [INFO] [stdout] 126 | | files, [INFO] [stdout] 127 | | generation: 0, [INFO] [stdout] 128 | | add: HashSet::new(), [INFO] [stdout] 129 | | remove: HashSet::new(), [INFO] [stdout] 130 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `rm` and `mv` are never used [INFO] [stdout] --> src/megacmd.rs:65:8 [INFO] [stdout] | [INFO] [stdout] 23 | impl MegaCmd { [INFO] [stdout] | ------------ associated functions in this implementation [INFO] [stdout] ... [INFO] [stdout] 65 | fn rm>(remote_path: P) -> MegaResult<()> { [INFO] [stdout] | ^^ [INFO] [stdout] ... [INFO] [stdout] 99 | fn mv, D: AsRef>(remote_src: S, remote_dest: D) -> MegaResult<()> { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `files` is never read [INFO] [stdout] --> src/status.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 30 | pub struct LockStatus<'a> { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] 31 | files: HashSet<(&'a Path)>, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `LockStatus` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lock.rs:124:12 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn from_path>(path: P) -> LockResult { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 125 | | path, [INFO] [stdout] 126 | | files, [INFO] [stdout] 127 | | generation: 0, [INFO] [stdout] 128 | | add: HashSet::new(), [INFO] [stdout] 129 | | remove: HashSet::new(), [INFO] [stdout] 130 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `megadvc` (lib) due to 2 previous errors; 11 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `megadvc` (lib test) due to 2 previous errors; 11 warnings emitted [INFO] running `Command { std: "docker" "inspect" "adb33367d7443f0c6fbe037aa490c317ede1762ae2b015a2811c2371c67c26b4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "adb33367d7443f0c6fbe037aa490c317ede1762ae2b015a2811c2371c67c26b4", kill_on_drop: false }` [INFO] [stdout] adb33367d7443f0c6fbe037aa490c317ede1762ae2b015a2811c2371c67c26b4